Refactored BookingShould.cs #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Description: Extracted CreateBooking() helper method to remove redundant object instantiation. Allowed passing custom start and end dates for more flexible test cases. Improved maintainability by centralizing booking creation logic. Enhanced test readability by reducing boilerplate setup in each test. Closes CodelyTV#63
Mykyta-Panchenko added a commit to Mykyta-Panchenko/refactoring-code_smells-design_patterns that referenced this pull request Feb 7, 2025
Refactored Booking Class for Better Encapsulation & Method Design Exposed private fields as read-only properties. Marked IsBetween() as static since it does not depend on instance state. Added null-checks in the constructor to ensure valid input. Closes CodelyTV#62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description:
Extracted CreateBooking() helper method to remove redundant object instantiation. Allowed passing custom start and end dates for more flexible test cases.
Improved maintainability by centralizing booking creation logic.
Enhanced test readability by reducing boilerplate setup in each test.
Closes #61