Skip to content

Feature/test1 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Feature/test1 #51

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
12ef51b
build: create Dockerfile and script bash
mbarreche Nov 6, 2022
d616b11
refactor: rename variables
mbarreche Nov 6, 2022
14af2ec
refactor: move if sentence
mbarreche Nov 6, 2022
129ca84
Merge remote-tracking branch 'origin/main' into feature/test1
mbarreche Nov 6, 2022
ba33b62
refactor: evaluate if $csv is empty when we have its content
mbarreche Nov 6, 2022
132b9e0
refactor: create function duration and points
mbarreche Nov 6, 2022
418a468
refactor: create a loop to get all the steps
mbarreche Nov 6, 2022
bc0dc2f
refactor: generate result string
mbarreche Nov 6, 2022
356d781
refactor: create two functions
mbarreche Nov 6, 2022
e60702d
refactor: simplify the function get in CourseStepsGetController
mbarreche Nov 6, 2022
216b95d
refactor: create constants
mbarreche Nov 6, 2022
ffb76f4
refactor: rename functions
mbarreche Nov 6, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: rename functions
  • Loading branch information
@mbarreche
mbarreche committed Nov 6, 2022
commit ffb76f41de2328c573ceec44adb7c0112bee43ee
8 changes: 4 additions & 4 deletions examples/php/php-divergent_change-01_base/src/Controller/CourseStepsGetController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ public function __construct(Platform $platform)
public function get(string $courseId): string
{
$csv = $this->platform->findCourseSteps($courseId);
$steps = $this->createSteps($csv);
return $this->serialize($steps);
$steps = $this->parseSteps($csv);
return $this->serializeSteps($steps);
}

private function serialize(array $steps): string
private function serializeSteps(array $steps): string
{
$results = [];
foreach ($steps as $step) {
Expand All @@ -38,7 +38,7 @@ private function serialize(array $steps): string
return '[' . implode(',', $results) . ']';
}

private function createSteps(string $csv): array
private function parseSteps(string $csv): array
{
$csvLines = explode(PHP_EOL, $csv);
$steps = [];
Expand Down