- Notifications
You must be signed in to change notification settings - Fork 40
Upgrade Java to 17 LTS version #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
87fa801
to 252cfa8
Compare implementation 'org.apache.logging.log4j:log4j-core:2.17.0' | ||
implementation 'com.vlkan.log4j2:log4j2-logstash-layout:1.0.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove log4j libraries from the skeleton. Is there any reason to keep them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup!
I would vote for maintaining it 😬👼
Reasons why:
- Used in the bast majority of Java projects, so highly probable to be needed just after cloning the skeleton
- Useful for Java ecosystem newcomers in order to do not miss logs from libraries you can be actually using which, because of not having a main logger, would not have a visible output for you
- Consistency with the rest of skeletons where yo have an easy way to log things out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! ❤️
Those are good reasons for maintaining log4j, so let's keep them 🙃
I thought it might be some dependencies that we forgot to remove 😅
sourceCompatibility = 17 | ||
targetCompatibility = 17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it these variables are something that Gradle needs. If they are not needed, I'd remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on Gradle docs:
sourceCompatibility
: Java version compatibility to use when compiling Java source. Default value: version of the current JVM in use.
?
targetCompatibility
: Java version to generate classes for. Default value:sourceCompatibility
.
So, my votes would go for:
- Maintain
sourceCompatibility
as it explicitly states the Java version to use while compiling instead of delegating it implicitly. Why: We would like to throw an error otherwise making it worth it to mention that the actual environment does not match the expected one. - Maintain
targetCompatibility
because it acquiring thesourceCompatibility
value by default does not seems like an easy assumption (at least in my case). However, I do not have any other reason apart from personal opinions here, so feel free to delete it if you prefer 😊
README.md Outdated
1. Install Java 17: `brew cask install corretto` or download it [here](https://docs.aws.amazon.com/corretto/latest/corretto-11-ug/downloads-list.html) | ||
2. Set it as your default JVM: `export JAVA_HOME='/Library/Java/JavaVirtualMachines/amazon-corretto-17.jdk/Contents/Home'` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future improvement: Linux, Windows and Docker setup.
(I don't want to put effort on this right now 😬)
252cfa8
to 2d0d09d
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor improvements 😊
Decide what you prefer and go ahead merging it 🙌🚀
Co-authored-by: Javier Ferrer <javier.mailserio@gmail.com>
Upgrade skeleton to Java 17 LTS version