This repository was archived by the owner on Sep 18, 2024. It is now read-only.
Fixed permLevel: "Server Owner" not working in threads #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Any screenshots or something to corroborate this working? |
| check: (message) => { | ||
| const serverOwner = message.author ?? message.user; | ||
| return message.channel.type === "GUILD_TEXT" ? (message.guild.ownerId === serverOwner.id ? true : false) : false; | ||
| return (message.channel.type === "GUILD_TEXT" || message.channel.isThread()) ? (message.guild.ownerId === serverOwner.id ? true : false) : false; |
Contributor
There was a problem hiding this comment.
This won't work in news channels and is frankly over-engineered. Try this:
Suggested change
| return (message.channel.type === "GUILD_TEXT" || message.channel.isThread()) ? (message.guild.ownerId === serverOwner.id ? true : false) : false; | |
| return message.guild?.ownerId === serverOwner.id; |
YorkAARGH added a commit that referenced this pull request Sep 13, 2021
This resolves #153, instead of over-engineering the issue it was successfully reduced to this thanks to @WilsontheWolf
Member
| This was fixed in the most recent commit thanks to a simplistic suggestion from @WilsontheWolf |
YorkAARGH added a commit that referenced this pull request Sep 25, 2021
* Slash Command Permissions. Due to the current limitations of the permission system for slash commands we essentially extend the functionality of our permission checking system to the slash commands. * Fixed a mistake. Forgot to revert testing parameters. Updated the comments in the deploy command. * Fixed Help Fixed the help command, it will now respond if you supply an invalid command name, or alias. It will now display the help message if an alias is supplied. Updated the `messageCreate` event to output the error into the console. Updated the example config to take advantage of the Nullish coalescing operator * Guild Owner fix This resolves #153, instead of over-engineering the issue it was successfully reduced to this thanks to @WilsontheWolf * Correcting a mistake. If the command executioner can, or can't execute the command with the nature of the permission system we **must** respond otherwise it will error out and inform the user that it failed, giving them the illusion that they can use the command.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged, as well as any and all proof of successful tests:
Semantic versioning classification: