This repository was archived by the owner on Sep 18, 2024. It is now read-only.
Fixed Issues in Commands #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
YorkAARGH added a commit that referenced this pull request Sep 12, 2021
* 2.0.0 Removed the installer and all required packages. Removed the `loadCommand` and `unloadCommand` functions. Removed the `wait` function, was no longer used. Removed the `owners` functionality as the concept was too advanced for an example bot. Required the `logger` file where it was needed instead of binding it to `client`. Required the `settings` database and `config` file where needed. Moved the `clean` function into the `eval` command. Updated all of the code to reflect these changes. Moved the discord bot token into an `.env` file for better security. Added `owner` to the `.env` file. To-do; Change `levelCache` into a function to pull it off the `client` property. * Missed one whoops, missed one. * Fixed events Removed `client` from `getSettings()` as it expects one variable, not two. * Clean up Removed an unused prototype pollutant, fixed a padding mistake and cleaned up the client object. * Further clean up Found some stray `client.awaitReply` functions, updated the reload command to work with aliases. * Final draft of simplification. Significantly reduced the `client` pollution by including a single `container` to the client and attaching every thing else, such as the `commands`, `aliases`, etc collections to that instead. Updated the code to reflect these changes. * Dependency update Replaced the dead `moment`, and `moment-duration-format` dependencies with `@sapphire/time-utilities`. Replaced `chalk` with `colorette`. * Formatting consistency. Updated the timestamp for the logger to be consistent with previous versions. * Whoopsy I forgot to revert a testing change. * Removed default params Both `stat` commands included redundant parameters, they have been removed. * Fixing error logging * Fixed Issues in Commands (#150) * removed token lines from config.js (#151) * removed token lines from config.js * Update .gitignore I'm making an executive decision to merge this without full testing from multiple sources; It works for me and two other individuals.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged, as well as any and all proof of successful tests:
client.unloadCommand is not a functionsettings[key]withserverSettings[key],client.settingswithsettingsSemantic versioning classification: