Skip to content
This repository was archived by the owner on Sep 18, 2024. It is now read-only.

Conversation

@YorkAARGH
Copy link
Member

@YorkAARGH YorkAARGH commented Aug 22, 2021

Please describe the changes this PR makes and why it should be merged, as well as any and all proof of successful tests:

Semantic versioning classification:

  • This PR changes the framework's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to README, etc.

Removed the installer and all required packages.
Removed the loadCommand and unloadCommand functions.
Removed the wait function, was no longer used.
Removed the owners functionality as the concept was too advanced for an example bot.
Moved the discord bot token into an .env file for better security.
Added owner to the .env file.
Required the logger file where it was needed instead of binding it to client.
Required the settings database and config file where needed.
Created a container property to attach commands, aliases, slashcmds and levelCache to.
Moved the clean function into the eval command.
Replaced chalk with colorette.
Replaced moment and moment-duration-format with @sapphire/time-utilities

Updated all of the code to reflect these changes.

Removed the installer and all required packages. Removed the `loadCommand` and `unloadCommand` functions. Removed the `wait` function, was no longer used. Removed the `owners` functionality as the concept was too advanced for an example bot. Required the `logger` file where it was needed instead of binding it to `client`. Required the `settings` database and `config` file where needed. Moved the `clean` function into the `eval` command. Updated all of the code to reflect these changes. Moved the discord bot token into an `.env` file for better security. Added `owner` to the `.env` file. To-do; Change `levelCache` into a function to pull it off the `client` property.
@YorkAARGH YorkAARGH added enhancement guidebot The original version of guidebot. labels Aug 22, 2021
whoops, missed one.
Removed `client` from `getSettings()` as it expects one variable, not two.
Removed an unused prototype pollutant, fixed a padding mistake and cleaned up the client object.
Found some stray `client.awaitReply` functions, updated the reload command to work with aliases.
@jaspermayone
Copy link

@YorkAARGH When is this going to be merged?

@jaspermayone
Copy link

(not to sound impatient) 😄

@YorkAARGH
Copy link
Member Author

@YorkAARGH When is this going to be merged?

When it's finished, there's a few things that remain to be done, then I'll need people to test it to eliminate the whole "It works on my machine" situation.

Significantly reduced the `client` pollution by including a single `container` to the client and attaching every thing else, such as the `commands`, `aliases`, etc collections to that instead. Updated the code to reflect these changes.
@YorkAARGH YorkAARGH marked this pull request as ready for review September 6, 2021 11:14
Replaced the dead `moment`, and `moment-duration-format` dependencies with `@sapphire/time-utilities`. Replaced `chalk` with `colorette`.
@YorkAARGH YorkAARGH requested review from a user, eslachance and kyranet September 6, 2021 11:35
Updated the timestamp for the logger to be consistent with previous versions.
I forgot to revert a testing change.
Both `stat` commands included redundant parameters, they have been removed.
@jaspermayone
Copy link

Hey @YorkAARGH, I think we should keep the owner only function. Personally, I think that is something that people can learn from and dissect.

@YorkAARGH
Copy link
Member Author

Hey @YorkAARGH, I think we should keep the owner only function. Personally, I think that is something that people can learn from and dissect.

I was initially in the same boat, but we don't cover teams at all in the guide and it wasn't really explained well, if at all in the code.

The team functionality (to me at least) would imply using this example code in a large production based project, which we absolutely do not want to encourage as it lacks significant features that would be able to handle such a scale, which is why it was removed in the first place.

@YorkAARGH YorkAARGH mentioned this pull request Sep 9, 2021
3 tasks
* removed token lines from config.js * Update .gitignore
@YorkAARGH YorkAARGH merged commit 90d78e1 into master Sep 12, 2021
@YorkAARGH YorkAARGH deleted the simplification branch September 12, 2021 14:17
@jaspermayone
Copy link

Yay! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement guidebot The original version of guidebot.

5 participants