chore: Improve DOM-less type exports #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Usage of HeadersInit requires either a node-fetch dependency or to include DOM in tsconfig libs for consumer projects. It is not exported as a global type in @types/node v18 or v20. RequestInit is: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/aaf94a0a6431f52c46dab26182f1156d79720d29/types/node/v18/globals.d.ts#L341 Define headers in interface HTTPResolverOptions<> via RequestInit['headers'] which will make it possible to depend on this project without node-fetch.
Pull Request Test Coverage Report for Build 9352827824Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
| 🎉 This PR is included in version 11.6.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Usage of
HeadersInitrequires either a node-fetch dependency or to include DOM in tsconfig libs for consumer projects. It is not exported as a global type in @types/node v18 or v20.RequestInitis:https://github.com/DefinitelyTyped/DefinitelyTyped/blob/aaf94a0a6431f52c46dab26182f1156d79720d29/types/node/v18/globals.d.ts#L341
Define headers in interface
HTTPResolverOptions<>viaRequestInit['headers']which will make it possible to depend on this project without node-fetch.