chore: inherit encoding type from Plugin for text parsing option #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
7 tasks
Pull Request Test Coverage Report for Build 8537520040Details
💛 - Coveralls |
| @jonluca will a force-release be necessary here? the CI action claims that nothing of note has changed (which I guess is true) but the built |
| Yeah need to make a commit with a |
| 🎉 This PR is included in version 11.5.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When compiled, there is a type error that makes builds fail on a package that I would like to use this as a dependency. It's related to
Plugin.parse.textwhich appears to have some overriding typing for theencodingoption. This just removes that override and instead inherits theBufferEncodingtype fromPlugin.