external refs: keep track of original paths during resolve #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Right now the library is “loosing” the original value information from the `$ref` entry in case of we are resolving relative file paths. It can be a useful information to keep the original path taken from the JSON Schema document while crawling the references tree. Thus this PR is trying to keep a `Set` containing all original paths when resolving external $ref pointers.
paulRbr force-pushed the track-original-paths branch from d9c9847 to 53312ef Compare 
| I'm closing stale PRs - happy to merge in a new PR if it's rebased |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Right now the library is “loosing” the original value
information from the
$refentry in case of we are resolving relativefile paths.
However, it can be a useful information to keep. This PR is thus trying
to keep a
Setcontaining all original paths when resolving external$ref pointers.