Handle execution under root more correctly

[P0lip]

Right now, the file url starts with triple slashes (///). This PR fixes it.

[coveralls]

Pull Request Test Coverage Report for Build 388

• 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.06%) to 93.908%

---

Totals
Change from base Build 381:	0.06%
Covered Lines:	679
Relevant Lines:	712

---

💛 - Coveralls

[JamesMessinger]

Thanks for the PR @P0lip !

Can you provide an example of the problem that you're fixing? What does the URL/path that your getting look like currently, and what do you think it should look like?

[JamesMessinger]

To match the other test suites, there need to be tests for the parse(), resolve(), dereference(), and bundle() methods, each with absolute paths, relative paths, and URLs. I recommend copying the contents of "test/specs/external" into this directory and using that as your starting point

[P0lip]

relative paths

This is not going to work since I spoof process.cwd. I'd need to spoof fs calls as well.
Are you okay with that?

[P0lip]

Can you provide an example of the problem that you're fixing? What does the URL/path that your getting look like currently, and what do you think it should look like?

So, the fs library we use for browsers in case of Stoplight Studio, operates on / as its entry point, therefore process.cwd() equals /.

[JamesMessinger]

Sorry for the delayed response. Last week got crazy busy.

So, the fs library we use for browsers in case of Stoplight Studio, operates on / as its entry point, therefore process.cwd() equals /.

Right, but what's the result of this? What's the problem that you're seeing and fixing? I want to make sure we're fixing the right problem in the right place. And that we have the right tests in place.

[JamesMessinger]

@P0lip - can you please enable edits from maintainers on this PR?

[P0lip]

Right, but what's the result of this? What's the problem that you're seeing and fixing? I want to make sure we're fixing the right problem in the right place. And that we have the right tests in place.

The result is that we try reading such paths starting with more than a single slash, i.e ///foo. Node's fs handles them fine, but not every library implementing fs-like interface does it, as the paths are not correct.

@P0lip - can you please enable edits from maintainers on this PR?

Hm, I cannot seem to find that option.
It's neither visible in the edit view nor in the sidebar 🤔

[JamesMessinger]

@P0lip - can you please enable edits from maintainers on this PR?

Hm, I cannot seem to find that option.
It's neither visible in the edit view nor in the sidebar 🤔

Huh... weird. I wonder if it's an org-level setting that someone at Stoplight would need to allow. 🤷‍♂️

Anyway... the PR looks good 👍 I have some changes to the tests, which I'll push after merging your changes.

[P0lip]

Huh... weird. I wonder if it's an org-level setting that someone at Stoplight would need to allow. man_shrugging

Hm, that might be the case. I'll touch base with folks to see whether there is such an option exposed somewhere in the panel.

Anyway... the PR looks good +1 I have some changes to the tests, which I'll push after merging your changes.

Thanks!