Skip to content

Include ParserOptions#parse in TS typings #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2020
Merged

Include ParserOptions#parse in TS typings #152

merged 1 commit into from
Feb 20, 2020

Conversation

P0lip
Copy link
Member

@P0lip P0lip commented Feb 20, 2020

parse is missing despite being accepted.
It's not exposed in options in docs and neither is ResolverOptions#read that's included in typings.
That being said, it feels like a tiny oversight, hence the PR is here.
@P0lip P0lip requested a review from JamesMessinger February 20, 2020 10:57
@coveralls
Copy link

coveralls commented Feb 20, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 380

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.851%
Totals Coverage Status
Change from base Build 379: 0.0%
Covered Lines: 673
Relevant Lines: 706
💛 - Coveralls
@JamesMessinger JamesMessinger merged commit ee4498e into APIDevTools:master Feb 20, 2020
@JamesMessinger
Copy link
Member

Thanks for the PR! much appreciated
@P0lip P0lip deleted the fix/parser-options-typings branch March 18, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@P0lip @coveralls @JamesMessinger