Disable PrivateServiceRule when the class implements ServiceSubscriberInterface #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
iamluc force-pushed the detect-service-subscriber branch 3 times, most recently from b7dfe8d to efe3010 Compare iamluc force-pushed the detect-service-subscriber branch from efe3010 to ecefe2d Compare 
Collaborator
| Merged as c340de8, thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I have a lot of violations
Service "X" is private.when extending theAbstractControllerwhich implements theServiceSubscriberInterface.When implementing this interface, the service receive a special container with the services listed by the method
getSubscribedServices.I think the PrivateServiceRule should be disabled in this case.
(For details: https://symfony.com/doc/current/service_container/service_subscribers_locators.html)