Skip to content

Fixes to reference converter daily workflow #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpith-f5 merged 2 commits into from
Aug 31, 2023
Merged

Fixes to reference converter daily workflow #8

arpith-f5 merged 2 commits into from
Aug 31, 2023

Conversation

@arpith-f5
Copy link
Collaborator

@arpith-f5 arpith-f5 commented Aug 31, 2023 •
edited
Loading

Proposed changes

  • Fix the output directory of the reference converter
  • Return non zero status code in case of a failure in go

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)
ryepup
ryepup reviewed Aug 31, 2023
View reviewed changes
@arpith-f5 arpith-f5 merged commit a4efd18 into main Aug 31, 2023
@arpith-f5 arpith-f5 deleted the avarghese/ref_conv_fixes branch August 31, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@arpith-f5 @ryepup