Strict option #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
| looks great thanks! |
jonschlinkert added a commit to micromatch/nanomatch that referenced this pull request Apr 11, 2017
inspired by @doowb's [pr to split-string](jonschlinkert/split-string#2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds a
strictoption to turn off throwing an error if a string has unclosed quotes.I can see how this is useful for single quotes like
'doowb\'s'. I'm not sure when it makes sense for double quotes, but it handles that too.I also changed the error message for single quotes to
unclosed single quoteso it differentiates between the two.Let me know if this looks okay or if you think there might be a better way of doing this.