Fixed pinger interval bug #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AJIOB reviewed Apr 25, 2025
Owner
| Thank you for the PR! Could AtomicU64 help reduce locking overhead here? |
Contributor
| I think it may be done via dancing with swap or compare_exchange methods, but it should be done as an additional improvement, IMO |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello, dear developers of async-smux library.
In my project, I used this library to multiplexing streams and I saw an error:
I created a server with MuxBuilder::server() and I used keep_alive_interval 10 seconds. I tested the solution and server after 10 seconds was sending NOP-requests to client with intervals of 0,5 seconds.
In this pull request I decided that problem. The server will now send NOP packets at the interval that was set.