Improve environment printing format #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| oops broke the test |
Contributor Author
| @zeryx please see comment in initial PR description |
Contributor Author
| hey @zeryx I forgot this was still a draft PR. please have a look when able. |
zeryx suggested changes Jul 12, 2021
Contributor
zeryx left a comment
zeryx left a comment There was a problem hiding this comment.
Looks like your test modifications fail, not sure if you're able to access gitlab; in any case here's the failure message:
self = <Test.CLI_test.CLITest testMethod=test_get_environment> def test_get_environment(self): result = CLI().get_environment_by_language("python2",self.client) print(result) if("error" in result): print(result) > self.assertTrue(result is not None and "Python 2.7" in result) E AssertionError: False is not true Test/CLI_test.py:180: AssertionError ----------------------------- Captured stdout call ----------------------------- ['Display Name Specification ID ', '********************************************************************************', 'Python 2.7 f626effa-e519-431e-9d7a-0d3a7563ae1e ', 'Python 2.7 + GPU support faf81400-eb15-4f64-81c0-3d4ed7181e77 '] _________________________ CLITest.test_list_languages __________________________ self = <Test.CLI_test.CLITest testMethod=test_list_languages> def test_list_languages(self): result = CLI().list_languages(self.client) if("error" in result[0]): print(result) > self.assertTrue(result is not None and "anaconda3" in result[1]) E AssertionError: False is not true Test/CLI_test.py:186: AssertionError Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
DEV-331 - making env-listing output more user friendly
@zeryx is there a case when the environments response comes back as empty list? I've added some code for sorting the environments but I didn't add any error handling for this case.