Activity
From 09/11/2022 to 09/17/2022
09/17/2022
-
09:35 PM Feature #19008: Introduce coverage support for `eval`.
- I'm against introducing a keyword argument to `eval`. `coverage` implementation should not leak into unrelated code.
-
08:40 PM Feature #19008: Introduce coverage support for `eval`.
- In terms of ERB template coverage, I recently added support to Tilt for it. Tilt is the library used by Sinatra, Roda, Hanami, dry-view and most non-Rails web frameworks to render templates. Since `eval` doesn't support coverage, the ap...
-
10:15 AM Feature #19008: Introduce coverage support for `eval`.
- Basically I am okay to this proposal. When I first created coverage.so, I tried to support eval. But @ko1 objected to it because the source code for eval is not retained and there is no clear need for it. But I just talked to @ko1, and h...
-
- I'd like to introduce coverage support for `eval`. I mostly only care about the case where an explicit path is given, and I'd even be okay to only handle the case where the line number is the default (0).
https://github.com/ruby/ruby/... -
03:10 PM Revision 67417e79 (git): Replace revision.tmp with the HAVE_BASERUBY trick
- but without relying on replacement.
This seems to work on OpenBSD as well. -
- Non-GNU make seems to generate empty revision.h, but it doesn't make
sense since https://github.com/ruby/ruby/pull/6382.
Also the $(HAVE_BASERUBY:yes=tmp) hack doesn't seem to be working on
OpenBSD. I'll remove it to focus on fixing Rub... -
- With 33c6dd2cc89c27bbf406508ec39038a181fb99bc, it's no longer necessary.
This is what I got on openbsd-current:
```
-bash-5.1$ git -v
unknown option: -v
usage: git [--version] [--help] [-C <path>] [-c <name>=<value>]
[--exec... -
- when -q is given.
One of the RubyCI servers, freebsd12, had a broken git environment:
```
$ git show
fatal: detected dubious ownership in repository at '/usr/home/chkbuild/chkbuild/tmp/build/20220917T123002Z/ruby'
To add an exception f... -
- This test has been unstable, and it seems like we're not interested in
fixing that for MinGW.
https://github.com/ruby/ruby/actions/runs/3073317191/jobs/4965373284 -
- * Auto-generate the release date on version.h
from git CommitDate
* Generate revision.h on mswin -
11:29 AM Bug #18912: Build failure with Xcode 14 and macOS 13 (Ventura) Beta
- I've been doing some digging around the `TestProcess#test_daemon_noclose` test failure.
Minimum reproducible code is here
```ruby
Process.daemon(false, true)
Dir.pwd
```
And got some facts:
- On macOS, you should not use Objective-C ... -
07:47 AM Bug #18912: Build failure with Xcode 14 and macOS 13 (Ventura) Beta
- Xcode 14 has been released. The all stable versions of Ruby couldn't build with Xcode 14.
We fixed this issue at Ruby 2.7-3.1 and master branch. But the stable versions are not released yet.
I strongly recommend to not upgrade Xcod... -
-
-
05:13 AM Feature #19006: Inconsistent behaviour of autoload in wrapped script
- Rethinking this, `autoload` can fairly easily be patched at the gem level to make this work, without changes at the language level, so this isn't strictly necessary. In terms of transitivity, `require` is the more important one.
I'm hap... -
- > It was never designed to be transitive, nor documented as being transitive, so I don't think the current behavior is a bug. Making the behavior transitive would be a feature request, IMO.
Agree, I've changed the tracker to "feature" t... -
- When loading `foo.rb` with the `MyModule` wrapper, you are loading the equivalent of:
```ruby
module MyModule
module Foo
autoload :Bar, "foo/bar"
end
end
```
`foo/bar.rb` defines `::Foo::Bar`, not `::MyModule::Foo::Ba... -
- This is related to: https://bugs.ruby-lang.org/issues/10320#note-13
-
- Suppose I have two files, `foo.rb` and `bar.rb`:
```ruby
# foo.rb
puts "loading Foo..."
module Foo
autoload :Bar, "foo/bar"
end
```
and
```ruby
# foo/bar.rb
puts "loading Foo::Bar..."
module Foo
module Bar
... -
06:59 AM Revision b3969f76 (git): Merge openssl-3.0.1
- The changes can be found at:
https://github.com/ruby/openssl/compare/v3.0.0...v3.0.1 -
05:06 AM Bug #19003: TracePoint behavior inconsistency in 3.2.0-preview2
- jeremyevans0 (Jeremy Evans) wrote in #note-2:
I just saying this behavior is inconsistent between versions.
Current behavior looks like a bug to me, because it feels like only hooks already set at the moment of the event arrival sh... -
05:05 AM Bug #18816: Ractor segfaulting MacOS 12.4 (aarch64 / M1 processor)
- ruby_3_1 99d254d8b025fd952375ed15c345ecc1b806652a merged revision(s) de51bbcb544651fb499dd4cc757a2bf6f3b439cf.
-
- Use VM Lock when mutating waiting threads list
`rb_thread_wait_for_single_fd` needs to mutate the `waiting_fds` list
that is stored on the VM. We need to delete the FD from the list before
returning, and deletin... -
04:30 AM Bug #19005: Ruby interpreter compiled XCode 14 cannot build some native gems on macOS
- Thanks! I've confirmed this solves the problem and that the linker adds this argument.
Could this patch be backported to 2.7 as well? Thanks! -
03:10 AM Bug #19005 (Closed): Ruby interpreter compiled XCode 14 cannot build some native gems on macOS
- Applied in changeset commit:git|6898984f1cd1b0375c3da44d7832724489e0e470.
----------
[Bug #19005] dynamic_lookup linker option in external libraries
The warning against `-undefined dynamic_lookup` is just a warning yet,
and many gems s... -
- I found the header in Unicode Emoji 14.0 data files had changed slightly (and again at 15.0), but `enc/unicode/case-folding.rb` didn't follow it.
Then I fixed it and rebuilt the headers under `enc/unicode/14.0.0`, `name2ctype.h` had dif... -
-
-
-
- The header of emoji data files in UCD, which were moved at 13.0.0, has
been changed since 14.0.0. It seems to be the same as other files in
UCD. -
- The warning against `-undefined dynamic_lookup` is just a warning yet,
and many gems seem to pay no attention to warnings. Until it fails
actually, keep it as a migration path, except for standard extension
libraries and bundled extensi... -
- @shyouhei
> Pure-ruby codes could perhaps be loaded multiple times side-by-side
Not multiple times, loaded only once in the namespace where `require` is called (wrap module), then when loaded again original constants are aliased to the... -
- > This NilClass definition, even if reassigning global ::NilClass doesn't have any effect on nil though, isn't it?
Or do you actually define mod::NilClass = NilClass before loading the ActiveSupport files?
Yes, `mod::NilClass = NilClass... -
- > I have only quickly skimmed Im, so I may say innacurate things, but it seems to me that what would be desirable would be to load a "namespace" in isolation, but not necessarily its dependencies as well.
`Im` uses a registry to track f...
09/16/2022
-
09:45 PM Feature #10320: require into module
- > Loading ActiveRecord::Base won't work because when it tries to dynamic-link libpq.so or libmysqlclient.so or whatever, that can already be loaded under another namespace; then fails.
An orthogonal question is whether loading two ver... -
- It is declared that `dlopen` will not fail in such cases.
https://pubs.opengroup.org/onlinepubs/9699919799/functions/dlopen.html
> Only a single copy of an executable object file shall be brought into the address space, even if `dlopen... -
07:34 AM Feature #10320: require into module
- Pure-ruby codes could perhaps be loaded multiple times side-by-side, but the problem is a DLL.
Loading ActiveRecord::Base won't work because when it tries to dynamic-link libpq.so or libmysqlclient.so or whatever, that can already be lo... -
06:52 AM Feature #10320: require into module
- This NilClass definition, even if reassigning global ::NilClass doesn't have any effect on nil though, isn't it?
Or do you actually define mod::NilClass = NilClass before loading the ActiveSupport files? -
07:55 PM Feature #18776: Object Shapes
- The performance numbers look good and I'm very happy with the improvements that you've made wrt shape ids being 32 bits. It's also nice to see that the generated code for property accesses in YJIT is shorter than before.
There seems t... -
- This issue shows a case where you are adding a local tracepoint during global tracepoint processing. There are a couple approaches Ruby could take here:
1) For a local tracepoint added during global tracepoint processing, only call it... -
- Returning Infinity for numeric ranges bounded in either direction is expected (there are tests explicitly for it).
It does seem inconsistent that `(..object).size` returns Infinity and `(object..).size` returns nil for non-numeric obj... -
05:25 PM Feature #15371 (Closed): IRB with ARGV
- Applied in changeset commit:git|b07db967441161a84386bcbbb41d990a2f3ad31c.
----------
[ruby/irb] Support --noscript option to not use first non-option argument as script
Also add --script option to turn the option back on.
Previously t... - 05:25 PM Revision e3a32abe (git): * 2022-09-17 [ci skip]
-
- Also add --script option to turn the option back on.
Previously there wasn't a way to get an interactive IRB session
and access arguments provided on the command line.
Additionally, handle `-` as script as stdin. In Unix-like tools, `-... -
01:47 PM Revision 64200990 (git): [ci skip] Fix typos in documentation in io.c
-
- Update bundled_gems
Try latest patch to avoid some race on Mac OS X.
---
gems/bundled_gems | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-) -
- Yes, it's only a few gems that previously depended on `-undefined,dynamic_lookup` being present as a linker argument.
In the `pg_query` case, it seems that there is a bug: the library exports a symbol that's not actually present.
In th... -
- Ah, Sorry. I misunderstood. I could install other native extensions like ffi, hiredis and eventmachine.
this issue happens like ffi-yajl. -
- `ruby_3_1` head already fixed a similar issue with bundle loader. But I could reproduce https://bugs.ruby-lang.org/issues/19005#note-3 with `ruby_3_1` head.
We should fix this before 3.1.3 release. -
- I think we can close this issue, unless someone thinks we might want to relax the `configure` check so that the `-undefined,dynamic_lookup` linker flag is again the default for macOS.
Gems should be able to handle building without `-und... -
- A related issue was discussed in https://gitlab.kitware.com/vtk/vtk/-/issues/17214#note_385533 in the context of Python.
https://github.com/apple-opensource/ld64/pull/1/files would indeed be useful. -
- nobu (Nobuyoshi Nakada) wrote in #note-5:
> What is the version of ruby you are using?
ruby 2.7.6p219 (2022-04-12 revision 44c8bfa984) [arm64-darwin21] -
- What is the version of ruby you are using?
-
- `ffi-yajl` expects to run `dlopen` to bring in these symbols: https://github.com/chef/ffi-yajl/blob/2ac7f207c0850a7621880ea03c85c509072fff85/ext/ffi_yajl/ext/dlopen/dlopen.c#L29
-
- It's possible this is a problem with the respective gems. In https://github.com/pganalyze/pg_query/issues/255#issuecomment-1248800937, I note that the `Init_pg_query` is using C++ visibility rules.
However, for `ffi-yajl`, I'm not sur... -
- I should note that it's also possible to workaround the issue by compiling the interpreter with `DLDFLAGS="-Wl,-undefined,dynamic_lookup"`.
`configure` no longer adds this flag by default because of the warning:
```
configure:28712: ch... -
-
- - [Feature #18885] End of boot advisory API (byroot)
- The general concept was accepted, but it need a proper name.
- Suggestions:
- `Kernel.booted` / `Kernel.application_booted` / `Kernel.code_loaded` / `Kernel.startup_done`
... -
09:54 AM Revision a28e7871 (git): Update bundled_gems
- Try latest patch to avoid some race on Mac OS X.
-
- This test seems to leak a thread and let TestIOWait fail:
https://github.com/ruby/ruby/actions/runs/3065426880/jobs/4949517274
DRb almost never seemed to stably work on MinGW. I don't think we intend
to fix it either. We should just omi... - 06:13 AM Revision 6be430ef (git): * 2022-09-16 [ci skip]
-
- Co-authored-by: Yuta Saito <kateinoigakukun@gmail.com>
- 06:11 AM Revision a62cfce7 (git): * 2022-09-16 [ci skip]
-
- Co-authored-by: Yuta Saito <kateinoigakukun@gmail.com>
-
- 04:37 AM Revision 3ff65dcd (git): * 2022-09-16 [ci skip]
- 04:37 AM Revision 2387fbfb (git): Fix splat args (#6385)
- * Fix splat args
Cfuncs were not working properly so I disabled them right now.
There were some checks above that were also actually preventing splat args from being called.
Finally I did some basic code cleanup after realizing I didn...
09/15/2022
-
- This seems related to https://bugs.ruby-lang.org/issues/18912 and https://bugs.ruby-lang.org/issues/18981 .
Steps to reproduce:
1. Upgrade to XCode 14.
2. Compile a new Ruby interpreter. I used the version provided in https://gith... -
07:23 PM Feature #18776: Object Shapes
- # Summary
The implementation has been updated to solve some performance problems and simplify both source code and generated code.
The performance of this branch against multiple benchmarks, including microbenchmarks, RailsBench an... - 02:14 PM Revision cc7f6fe7 (git): YJIT should die if we compile on Aarch64 with no instruction cache clear available (#6380)
- YJIT should die if we compile on ARM64 with no icache clear available
-
-
- - [Bug #18978] Unexpected behaviour in Time.utc and Time.local when 8 arguments are passed in (peterzhu2118)
- Passing 8 arguments causes both the 7th (microseconds) and 8th arguments to be ignored.
- The behaviour is undocumente... -
- * [Bug #18960] Module#using raises RuntimeError when called at toplevel from wrapped script (shioyama)
* @jeremyevans0 mentioned this, but I think this is a bug based on common reading of the wrap argument to load.
* See also context... -
01:28 PM Bug #18995: IO#set_encoding sometimes set an IO's internal encoding to the default external encoding
- Can anyone confirm that this is a bug and not a misunderstanding? It looks like the changes to fix this will require a fair bit of refactoring, and there don't yet appear to be any tests around the various cases for arguments to `IO#set...
-
- So I wrote a reproduction script to showcase the effect of constant caches on Copy on Write performance:
```ruby
class MemInfo
def initialize(pid = "self")
@info = parse(File.read("/proc/#{pid}/smaps_rollup"))
end
def... -
11:21 AM Feature #16946: Add an `intersperse` method
- Just came across this while attempting to see if there was an elegant way to do this. My use case is that I want to generate an array with separator elements -- specifically, I want to generate a nested array of "cellable" objects in Pra...
-
05:49 AM Revision 68a5b0f0 (git): [rubygems/rubygems] Mask the file mode when extracting files
- When extracting files from the tarball, a mode is retrieved from
the header. Occasionally you'll encounter a gem that was packaged
on a system whose permission bits result in a value that is larger
than the value that File.chmod will all... -
- RubyGems.org already has refused connection requests using older than
TLS 1.2. -
- https://github.com/rubygems/rubygems/commit/c03e7e1564
-
- https://github.com/rubygems/rubygems/commit/d7956e9ce5
-
- The `wrap` option to `load` has recently been expanded to allow passing a module instead of a boolean (https://bugs.ruby-lang.org/issues/6210) (thanks @jeremyevans0)! This opens the door to new approaches to this problem.
I think there ... -
- https://github.com/github/codeql/discussions/10120#discussioncomment-3485880
-
01:03 AM Feature #12084: `Class#instance`
- matz (Yukihiro Matsumoto) wrote in #note-6:
> * `attached_object` is better, at least for singleton classes. But there's still no real-world use-case.
I recently ran into a real-world use-case inside one of the gems I maintain and I ... -
09/14/2022
-
- https://github.com/ruby/irb/commit/fd047512b3
-
- https://github.com/ruby/irb/commit/a15f68ffdb
-
10:18 PM Bug #18983: Range#size for beginless Range is not nil.
- Nevermind. Build failed.
-
-
- * [Bug #18960] Module#using raises RuntimeError when called at toplevel from wrapped script (jeremyevans0)
* Do we want to support this? I think since #using is permitted at top level and inside a module, we should.
* [Bug #18919] R... -
08:15 PM Revision f98d6d3f (git): YJIT: Implement specialized respond_to? (#6363)
- * Add rb_callable_method_entry_or_negative
* YJIT: Implement specialized respond_to?
This implements a specialized respond_to? in YJIT.
* Update yjit/src/codegen.rs
Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com> -
-
- 03:32 PM Revision 0953ea64 (git): * 2022-09-15 [ci skip]
-
- `yes-fake` depends on it when `arch=noarch` is given, but the rule to
generate it from fake.rb.in is ignored now. - 02:32 PM Revision 758a1d73 (git): Initial support for VM_CALL_ARGS_SPLAT (#6341)
- * Initial support for VM_CALL_ARGS_SPLAT
This implements support for calls with splat (*) for some methods. In
benchmarks this made very little difference for most benchmarks, but a
large difference for binarytrees. Looking at side exit... -
- * YJIT: Add Opnd#sub_opnd to use only 8 bits
* Add with_num_bits and let arm64_split use it
* Add another assertion to with_num_bits
* Use only with_num_bits - 02:14 PM Revision 2e25b85a (git): configure.ac: Apply suggestions from code review in #6366
- Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
-
02:10 PM Revision 960db13c (git): Reuse `opt_arg_append` function
-
- > Some users even decided to disable it completely because the colors are unreadable to them. I have also seen people sharing tips for disabling this feature: [example](https://twitter.com/sdogruyol/status/1538512030449254400).
JFYI, I'... - 01:17 PM Revision f512df73 (git): configure.ac: Add --with-gmp-dir (#6366)
- Add the `--with-gmp-dir` to specify the prefix directory of GMP.
The`--without-gmp` option is preserved for convenience. It can
be used to force to reject using GMP even if the `--with-gmp-dir`
option is specified. -
-
-
- Currently, miniruby is rebuild **always** when yjit is enabled, even
if nothing is changed. -
11:12 AM Bug #18914: Segmentation fault during Ruby test suite execution
- I believe this error is a problem of the Fiddle gem, as according to FFI upstream, when process forks with allocated FFI Closures on SELinux systems, the Parent and Child process need to coordinate on memory usage see my comment on the F...
-
08:30 AM Revision d66b29cc (git): Add link to how to build Ruby
-
-
-
-
- Use the same regexp to replace "(#NNNN)" and "GH-NNNN" style
references in vcs.rb, too. -
- https://github.com/ruby/irb/commit/6bbde84369
-
- commit:e4f5296f065110fa83eb450d3a861253e76e534f removed them.
-
- * Check rpath flag earlier
* Manage OPT_DIR at once -
- If history file didn't exist when irb was started, @loaded_history_mtime
would be nil. However, if the history file didn't exist before, but it
exists when saving history, that means the history file was modified,
and we should handle i...
09/13/2022
- 10:21 PM Revision b876230e (git): * 2022-09-14 [ci skip]
-
- * Remove CODEOWNERS to switch to auto-request-review
* Random change to test reviews
* Revert "Random change to test reviews"
This reverts commit 814b10d062d82d953019ea4afadc3f8fcf638379. - 06:44 AM Revision 316b44df (git): Add GMP support for mswin
-
- https://github.com/ruby/ruby/actions/runs/3041702828/jobs/4899106526#step:14:1219
-
- because it doesn't seem to be working. It's a bit annoying that
synchronized doesn't work, but in many cases, opened and
ready_for_review should be enough. As a last resort, you could
close/reopen it.
Also, the token scope needs to be p... -
-
- We need to use pull_request_target instead of pull_request to use secrets.
pull_request_target seems to be executed from the default branch, so
pushing this to master to test this. - 12:25 AM Revision bc8bbd23 (git): * 2022-09-13 [ci skip]
-
09/12/2022
-
- In https://github.com/ruby/ruby/pull/6323 I managed to replace all usages of `rb_define_dummy_encoding()` by just `rb_raise(rb_eArgError, "unknown encoding name - %s", name);`, and all tests pass.
Feedback/review appreciated. -
- Done:
* Deprecate Encoding#replicate
* Remove get_actual_encoding() and the dynamic endian detection for dummy UTF-16/UTF-32 (https://github.com/ruby/ruby/pull/6322)
Still to do:
* Limit the number of dynamic encodings defined by rb_def... -
- Applied in changeset commit:git|6525b6f760ccd9612c9546b0313ab1c7e4af5e66.
----------
Remove get_actual_encoding() and the dynamic endian detection for dummy UTF-16/UTF-32
* And simplify callers of get_actual_encoding().
* See [Feature ... -
01:13 PM Revision 2aa8edae (git): [rubygems/rubygems] Deduplicate results just once
- Instead of checking for uniqueness for every spec.
https://github.com/rubygems/rubygems/commit/97d28c9665 -
- https://github.com/rubygems/rubygems/commit/9d7bd177b0
-
- Already done by the gem version promoter.
https://github.com/rubygems/rubygems/commit/aae2cc9fe0 -
- https://github.com/rubygems/rubygems/commit/c4e2737f2c
-
- https://github.com/rubygems/rubygems/commit/3cea25a39d
-
- https://github.com/rubygems/rubygems/commit/823cb1fef9
-
- Specs in a SpecSet with the same name are only sorted by platform
priority when they are read. No need to sort everything eagerly.
https://github.com/rubygems/rubygems/commit/aeafff52df -
-
- * And simplify callers of get_actual_encoding().
* See [Feature #18949].
* See https://github.com/ruby/ruby/pull/6322#issuecomment-1242758474 -
- It is no longer necessary to add it to `CFLAGS`/`CPPFLAGS` later.
Furthermore, as `CPPFLAGS` is used also with C++ compiler, the option
particular to C such as `-std=gnu99` results in an error. -
- @nagachika it's my fault. For backporting purpose `cf7d07570f50ef9c16007019afcff11ba6500d70` alone should be backported and `c6aa65430fbb94651f4d15e2a976f59b5475ca19` should be ignored.
09/11/2022
-
10:50 PM Revision 89077b4c (git): Add comments for some peephole optimizations [ci skip]
- 10:48 PM Revision 6f8267b7 (git): * 2022-09-12 [ci skip]
-
- This reverts commit b8c376cb9d91854fd40f6e06f07773404899b54f, as it
seems no longer needed probably. -
- Applied in changeset commit:git|684353fc03afd6e7c887b65bd18f0b3aeb98101c.
----------
[Win32] Negative length `IO#sysread`
Raise `ArgumentError` in `IO#sysread` on Windows when given a negative
length.
Fixes [Bug #18880] -
- Raise `ArgumentError` in `IO#sysread` on Windows when given a negative
length.
Fixes [Bug #18880] -
10:45 AM Feature #18798: `UnboundMethod#==` with inherited classes
- This would be really helpful for checking if a class has redefined a method inherited form a superclass.
As an example, I’m working on a compiler that replaces certain method calls with their inlined expected behaviour from an abstrac... -
- * [Feature #18798] `UnboundMethod#==` with inherited classes (eregon)
* OK to change `UnboundMethod#==` to check if same method definition (and ignore from which class `instance_method` was used on)? If yes, what about `UnboundMethod#e... -
- openssl v2.2 added OpenSSL::PKey::PKey#public_to_pem and #public_to_der for this purpose.
https://github.com/ruby/openssl/pull/297
Ruby 3.0 includes v2.2 by default. -
- Upstream issue for this bug: https://github.com/ruby/openssl/pull/486
Yes. This is resolved by openssl gem releases 2.1.4/2.2.2/3.0.1. Backporting is requested in #18999. -
- 106744107b made this possible.
-
- https://github.com/ruby/fiddle/commit/4a71246645ccff001292c9d80b855b2ef5bf06c1
-
- zverok (Victor Shepelev) wrote in #note-68:
> Pull request: https://github.com/ruby/ruby/pull/6353
Very nice.
I don't think `keyword_init` and "naming as the first argument"
features are needed for new `Data`. So, I guess that s... -
02:49 AM Feature #18951: Object#with to set and restore attributes around a block
- This idea is very similar to Algebraic effects, which dry-rb has a variant on:
https://dry-rb.org/gems/dry-effects/main/
I would personally like the `with` variant myself, granting that it is a bit vague, but is also in line with w... -
02:34 AM Feature #18951: Object#with to set and restore attributes around a block
- It would be super nice to somehow support `ENV` as well, since it is super common pattern in test suites.
-
- MinGW CI has been crashing too often. Now that we don't have slow test_mjit in MinGW, I'd like to see if not using parallel test workers fixes the problem.
-
- First, rb_mjit_fork should call rb_thread_atfork to stop threads after
fork in the child process. Unfortunately, we cannot use rb_fork_ruby to
prevent this kind of mistakes because MJIT needs special handling of
waiting_pid and mjit_paus...