Activity
From 09/04/2022 to 09/10/2022
09/10/2022
-
09:46 PM Bug #18880: IO#sysread on Windows does not validate arguments
- I submitted PR https://github.com/ruby/ruby/pull/6354 with a simple fix. I don't have a Windows system to test with though, so I couldn't verify that it works.
-
06:14 PM Feature #18949 (Open): Deprecate and remove replicate and dummy encodings
-
- Applied in changeset commit:git|14bcf69c9c36875c7956d0ec8c04bfeaec514dd1.
----------
Deprecate Encoding#replicate
* See [Feature #18949]. -
05:46 PM Bug #19004 (Closed): Complex can be nested by Complex.polar
- `Complex.polar` with one argument can return a "nested" Complex instance, whose real part is also a Complex one.
```ruby
puts RUBY_DESCRIPTION
# ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-linux]
p Complex.polar(1+0i)
... - 05:03 PM Revision c22a6685 (git): * 2022-09-11 [ci skip]
-
- * See [Feature #18949].
-
- Indeed, that's what I meant. Alright, I guess we need to support positional arguments too then.
Because that's implemented in the subclass `.new` it should be possible to optimize it pretty well. -
02:12 PM Feature #16122: Data: simple immutable value object
- > Regarding creating a new Data subclass instance, I wonder if we should support both positional and kwargs, or if we should only support keyword arguments
Am I understanding correctly that you propose to only leave `Measure.new(amoun... -
- zverok (Victor Shepelev) wrote in #note-70:
> I am not sure whether we have a C-level API for passing keyword args one-by-one, not by packing to Hash and unpacking back?.. My C-foo might be not strong enough for defining specialized ini... -
- @Eregon Yeah, those are valuable observations!
The specialized `initialize` also looks more reasonable to me, actually, but I followed what the `Struct` does so far.
I am not sure whether we have a C-level API for passing keyword... -
- Looks good to me.
Regarding overriding `initialize` and calling `super`, that would not work if we define an optimized `initialize` instance method on the subclass by Data.define (it would result in NoMethodError or the slower generic... -
- Pull request: https://github.com/ruby/ruby/pull/6353
Copying from its description:
Example docs rendering: [Data](https://zverok.space/ruby-rdoc/Data.html)
Design and implementation decisions made:
**1. The "define data object method... -
- Agreed with @k0kubun. Also `Class.define` wouldn't make it clear it defines a data class and creates Data (subclass) instances.
-
- There isn't any need for this ticket as a separate request, as far as I am concerned.
It works in the initial implementation of data already as submitted in https://bugs.ruby-lang.org/issues/16122#note-68, and even works with ol' good S... -
12:32 PM Revision f6411795 (git): [win32] Set proper `NULLCMD` in rbconfig.rb [ci skip]
-
12:31 PM Bug #18998: Kernel#Integer does not convert SimpleDelegator object expectly
- > it would be best if you defined #to_int on your delegator
I've tried this approach but it was failed because `base` and `exception` arguments cannot be passed to `#to_i` method on my delegator.
Therefore, I've overridden `Kernel#In... -
- GnuWin32 sed strips only double quotes, but not single quotes, and
dies:
```
sed: -e expression #1, char 1: unknown command: `''
``` -
- * So deprecated methods/constants/functions are dealt with early,
instead of many tests breaking suddenly when removing a deprecated
method/constant/function.
* Follows https://bugs.ruby-lang.org/issues/17591 -
07:54 AM Revision 9581248c (git): merge revision(s) b7577b4d9e0fd92522fc30e10fe712e245adee8c:
- The tzdata 2022c removed Amsterdam Mean Time
---
spec/ruby/core/time/shared/local.rb | 2 ++
1 file changed, 2 insertions(+) -
- ruby_3_1 4508901fbd8825cc8d9aaf535b5201ade17a8392 merged revision(s) 261753249996d46e00c2549fff2527816bf387db.
-
- ruby_3_1 163947f4dc031bb5e619ae64ad4a6a02f8885717 merged revision(s) db0e0dad1171456253ebd899e7e878823923d3d8.
-
- I tried to backport cf7d07570f50ef9c16007019afcff11ba6500d70 and c6aa65430fbb94651f4d15e2a976f59b5475ca19 into ruby_3_1 branch, but the test `test_utf8_method_names` failed. Maybe some more changesets are needed. I will investigate it fu...
-
- Free cached mark stack chunks when freeing objspace
Cached mark stack chunks should also be freed when freeing objspace.
---
gc.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-) -
- Fix unexpected "duplicated key name" error in paren-less one line
pattern matching
[Bug #18990]
---
parse.y | 16 ++++++++++++----
test/ruby/test_pattern_matching.rb |... -
03:29 AM Revision 5e39b3b8 (git): YJIT: Branch directly when nil? is known from types
-
-
12:32 AM Revision 79f50b9d (git): Using is_broken_string function
-
12:32 AM Revision 51830188 (git): Fix parallel build on MINGW
- When the build is running with a base ruby then generating `x64-ucrt-ruby320.rc`
could fail due to a missing dependency to `x64-mingw-ucrt-fake.rb`.
This commit adds this dependency.
A failing build looks like so:
```
generating x64-min...
09/09/2022
-
11:06 PM Feature #16122: Data: simple immutable value object
- shugo (Shugo Maeda) wrote in #note-65:
> why not use Class.define to return a new immutable Struct-like class?
Given that Matz is also thinking about introducing `Struct.define`, if we do the immutable one with `Class.define`, we'd n... -
09:26 PM Feature #16122: Data: simple immutable value object
- If we choose `define` instead of `new`, why not use Class.define to return a new immutable Struct-like class?
* The name Data doesn't imply immutability, so Class.define is OK too.
* It's clearer that Class.define returns a class.
-
10:41 PM Revision 5b5c627d (git): YJIT: eliminate redundant mov in csel/cmov on x86 (#6348)
- * Eliminate redundant mov in csel/cmov. Translate mov reg,0 into xor
* Fix x86 asm test
* Remove dbg!()
* xor optimization unsound because it resets flags -
10:14 PM Bug #18998: Kernel#Integer does not convert SimpleDelegator object expectly
- > My thought is that Integer method should convert a Delegator object like when a String is given.
I don't think it would be advisable for `Kernel#Integer` to know about `Delegator`. `Delegator` is just a class from the stdlib, you co... -
- Thank you for your reply.
I understood that there is no documented specification and the current implementation.
How should Integer method behave for this case?
My thought is that Integer method should convert a Delegator object lik... -
08:44 PM Feature #12354: PKey::EC Can't output public key pem when private key exists
- If you're linked against OpenSSL >= 3, the workarounds suggested here don't seem to work any longer because a pkey is not allowed to be modified:
```
Failure/Error: pub.public_key = SIGNING_KEY.public_key
OpenSSL::PKey::PKeyError:... - 03:38 PM Revision 2a08a39d (git): * 2022-09-10 [ci skip]
-
03:37 PM Revision 848037ca (git): Better offsets (#6315)
- * Introduce InstructionOffset for AArch64
There are a lot of instructions on AArch64 where we take an offset
from PC in terms of the number of instructions. This is for loading
a value relative to the PC or for jumping.
We were usually... -
10:38 AM Revision b350053a (git): [rubygems/rubygems] Fix resolution on non-musl platforms
- Gems without specific platform were being preferred over matching
platform specific gems.
https://github.com/rubygems/rubygems/commit/37b95b9159 -
-
09:17 AM Bug #19003 (Rejected): TracePoint behavior inconsistency in 3.2.0-preview2
- This is kind of continuation of my previous report about global/local TP processing (#18730).
Sample script:
```rb
def foo
return 1
end
puts RubyVM::InstructionSequence.of(method :foo).disasm
def step_over
TracePoint.ne... -
07:03 AM Revision aff6534e (git): Avoid unnecessary copying when removing the leading part of a string
- Remove the superfluous str_modify_keep_cr() call from rb_str_update().
It ends up calling either rb_str_drop_bytes() or rb_str_splice_0(),
which already does checks if necessary.
The extra call makes the string "independent". This is no... -
- Previously, it was supported in prelude.c, but has not followed up the
builtin-loader system. -
06:19 AM Revision 56e5210c (git): More robust macro parser (#6343)
- I want to use more complicated macros with MJIT. For example:
```
# define SHAPE_MASK (((unsigned int)1 << SHAPE_BITS) - 1)
```
This commit adds a simple recursive descent parser that produces an AST
and a small visitor that convert... -
-
-
05:16 AM Bug #18990: Pattern matching unexpectedly raises "duplicated key name" error
- @zeke
Thanks for reporting. -
- Applied in changeset commit:git|db0e0dad1171456253ebd899e7e878823923d3d8.
----------
Fix unexpected "duplicated key name" error in paren-less one line pattern matching
[Bug #18990] -
- [Bug #18990]
-
-
01:47 AM Feature #19002: Explicit splat for enumerator kwarg blocks
- I also had
``` ruby
module Enumerable
def **(proc) = each { |arg| proc[**arg] }
end
ary.map ** ->(foo:, bar:) { foo+bar } #=> [143, 222]
```
which is kinda fun, but not so readable.
-
- I'm renovating some 2.x-era code that relied heavily on autosplat for block kwargs. As we all know, this throws an ArgumentError in Ruby 3:
``` ruby
ary = [
{ foo: 42, bar: 101 },
{ foo: 99, bar: 123 }
]
ary.map { |foo:, ba...
09/08/2022
-
- This commit does a bunch of stuff to try to eliminate as many
unnecessary mov instructions as possible.
First, it introduces the Insn::LoadInto instruction. Previously
when we needed a value to go into a specific register (like in
Insn:... -
07:50 PM Feature #16122: Data: simple immutable value object
- I've filed a 2nd follow-up ticket [here](https://bugs.ruby-lang.org/issues/19001) for the Symmetric `#to_h` method whose values can be fed to a keyword-args constructor
-
- k0kubun (Takashi Kokubun) wrote in #note-62:
> Can you please file a separate ticket to discuss `Data` extensions that don't exist in Struct? There could be so many `Data` extension ideas, such as default values mentioned in #note-49, b... -
07:47 PM Feature #19000: Data: Add "Copy with changes method" [Follow-on to #16122 Data: simple immutable value object]
- 💡 In case it's of interest, I've partially solved this problem in the [Refinements](https://www.alchemists.io/projects/refinements) gem several years back by adding the `#merge` and `#merge!` methods to `Struct` as a refinement. Here's t...
-
- *As requested: extracted a follow-up to #16122 Data: simple immutable value object from [this comment](http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/109815)*
# Proposal: Add a "Copy with changes" method to Data
Assu... -
- So this behavior isn't documented, so it's hard to say wether it's correct:
> Integer(arg, base=0, exception: true) → integer or nil
Converts arg to an Integer. Numeric types are converted directly (with floating point numbers being ... -
- Kernel#Integer method doens not convert a SimpleDelegator object of which value is a String.
This is an sample code.
``` ruby
require 'delegate'
p Integer(SimpleDelegator.new('0x10'))
```
I expect Kernel#Integer to convert the ... -
- Per @Matz [here](https://bugs.ruby-lang.org/issues/16122#note-51), the preference would be for the constructor to take either:
* Only keyword args
* Either keyword args OR positional args
The [Values gem](https://github.com/ms-ati/V... -
- *Extracted a follow-up to [#16122 Data: simple immutable value object](https://bugs.ruby-lang.org/issues/16122)*
# Proposal: Add a `#to_h` method symmetric to a constructor accepting keyword arguments
This allows round-trip between... -
- @rhenium I think we can close this once #18999 is done, right?
-
- 03:46 PM Revision 6d93644b (git): * 2022-09-09 [ci skip]
-
03:45 PM Revision 28030f7b (git): eliminate magic number
-
- classic console(conhost.exe) reports an input with ALT+NUMPAD as VK_MENU, KeyUp, and uChar!=0.
additional fix for #5634 -
- UnicodeChar with lower byte == 0 has dropped accidentaly
this is additional fix for #5634 -
- Please backport the latest openssl to stable branches.
I created GitHub PRs for each branch:
- Ruby 2.7 (v2.1.4) https://github.com/ruby/ruby/pull/6339
- Ruby 3.0 (v2.2.2) https://github.com/ruby/ruby/pull/6338
- Ruby 3.1 (v3.... -
- Applied in changeset commit:git|e2ccb316b437104cd1734c378970d34f5305966d.
----------
[Bug #5317] Use `rb_off_t` instead of `off_t`
Get rid of the conflict with system-provided small `off_t`. -
- Get rid of the conflict with system-provided small `off_t`.
-
- Already using `rb_w32_truncate` and `rb_w32_ftruncate`, and
`HAVE_FTRUNCATE` has been added 14 years ago. -
- We don't need it, and in string interpolation context
that's the common case. -
- That's about 1.30x faster.
-
- https://github.com/rubygems/rubygems/commit/ca8d47e53a
-
11:12 AM Misc #18977: DevMeeting-2022-09-22
- - [Feature #18996] Proposal: Introduce new APIs to reline for changing dialog UI colours (st0012)
- `irb`'s autocompletion background can make texts hard to read for some users.
- Because the colours are hardcoded in `reline`, u... -
- Fixes id.h error during updating ripper.c by `make after-update`.
While it used to update id.h in the build directory, but was trying to
update ripper.c in the source directory. In principle, files in the
source directory can or should... -
- Separate the logic accross the tables from the template view for
id.h. -
- The `ArgumentError` is correct.
Even on Windows, `sysread(-2)` raises an `ArgumentError` too.
At rounding up `len` in io.c:io_setstrbuf(), negative values are not considered. -
08:38 AM Bug #18997 (Closed): Don't define ruby_qsort when POSIX qsort_r is available - Applied in changeset commit:git|7400628cb054a9a9651d69411a100fc9d518099f.
----------
[Bug #18997] Don't define ruby_qsort when POSIX qsort_r is available
The current code would define ruby_qsort as a wrapper of qsort_s
when it is avail... -
07:50 AM Bug #18997 (Closed): Don't define ruby_qsort when POSIX qsort_r is available
- The current code would define ruby_qsort as a wrapper of qsort_s when it is available. When both qsort_s and POSIX (GNU) qsort_r are available, we should call qsort_r directly instead, and the qsort_s wrapper is redundant.
Proposed pa... - 08:37 AM Revision 7400628c (git): [Bug #18997] Don't define ruby_qsort when POSIX qsort_r is available
- The current code would define ruby_qsort as a wrapper of qsort_s
when it is available. When both qsort_s and POSIX (GNU) qsort_r
are available, we should call qsort_r directly instead, and
the qsort_s wrapper is redundant. -
05:31 AM Revision 78af05ba (git): [ruby/forwardable] Freeze VERSION and FORWARDABLE_VERSION to improve Ractor-compliance
- https://github.com/ruby/forwardable/commit/c91f41f4fa
-
- https://github.com/ruby/ipaddr/commit/73461724e5
-
-
-
- 02:25 AM Revision b1efdcee (git): * 2022-09-08 [ci skip]
-
09/07/2022
-
- ### TL;DR
I want to add APIs to `reline` for changing its dialog item's colors.
The APIs I want to add actually have been merged but becaue:
1. This is a design change
2. The maintainer @aycabta is not available to approve nor re... -
-
-
-
- I meant the other one. Otherwise this option doesn't make sense.
-
- to let mjit_add_iseq_to_process work
-
-
-
- fixing the behavior of b726c06e7eeafff52e368179dbe79a11b1aff975
-
-
- 12:51 AM Revision 1b034d66 (git): [ruby/psych] Bump snakeyaml from 1.28 to 1.31
- Resolves CVE-2022-25857, among other fixes.
https://github.com/ruby/psych/commit/918cd25d37 -
- Fix ruby/psych#572
https://github.com/ruby/psych/commit/92304269bc -
12:41 AM Revision bfa6d0f6 (git): fixup 8cd6f2a0872e74c6cc089d2a4f8140483080c67a
- we should handle ensure block when omit this test
09/06/2022
-
- 09:18 PM Revision 4c1f6750 (git): [rubygems/rubygems] Fix: Gem info bug with version flag
- https://github.com/rubygems/rubygems/commit/e4cee1f975
-
- and add another useful one instead.
- 03:05 PM Revision a9c85c0c (git): * 2022-09-07 [ci skip]
-
-
- https://github.com/rubygems/rubygems/commit/c5b2960388
-
- https://github.com/rubygems/rubygems/commit/f9a51e4380
-
- http://rubyci.s3.amazonaws.com/freebsd13/ruby-master/log/20220902T063002Z.fail.html.gz
-
- http://rubyci.s3.amazonaws.com/freebsd13/ruby-master/log/20220906T043002Z.fail.html.gz
http://rubyci.s3.amazonaws.com/freebsd13/ruby-master/log/20220905T103002Z.fail.html.gz -
-
-
- I'm thinking about Ruby builtin code instead of doing this.
It'll be hopefully more portable and easier because the same C code could
handle both 32bit and 64bit. -
- The interface is similar to RubyVM::ISeq.translate; it's used if defined.
Same as --mjit=pause, this is an undocumented feature for MJIT experiments. -
- for performance
-
- You may use `RUBYOPT=--mjit=pause irb` to play with RubyVM::MJIT::C,
control the boot timing of MJIT, or customize the implementation while
paused. It's an undocumented feature for such experiments. -
- fork is for parallel compilation, but --mjit-wait cancels it.
It's more useful to not fork it for binding.irb, debugging, etc. -
- Investigating:
http://ci.rvm.jp/logfiles/brlog.trunk-mjit.20220906-025646
which is not immediately reproducible on my laptop. - 01:42 AM Revision 6d10865c (git): Update default gems list at 2657d8efb9d38761c1e09f54fadea4 [ci skip]
-
- https://github.com/ruby/set/commit/e2419f2d30
09/05/2022
-
- http://ci.rvm.jp/results/trunk-mjit@phosphorus-docker/4225469
- 03:27 PM Revision ca172540 (git): * 2022-09-06 [ci skip]
-
- ```
<internal:mjit_compiler>:43: warning: assigned but unused variable - iseq_addr
<internal:mjit_compiler>:48: warning: assigned but unused variable - ci_addr
<internal:mjit_compiler>:53: warning: assigned but unused variable - ci_addr
... -
- RubyInstaller has released patch versions backporting their changes to
not load `fiddle` on boot, so all these are no longer necessary.
https://github.com/rubygems/rubygems/commit/05a307deb2 -
- 10:06 AM Revision 4331d4bb (git): Update default gems list at 113581d288496f8f3e60851b76b751 [ci skip]
-
- https://github.com/ruby/set/commit/40dda15d7f
-
- It didn't work either.
http://rubyci.s3.amazonaws.com/s390x/ruby-master/log/20220905T080003Z.fail.html.gz -
-
- I tried to debug:
http://rubyci.s3.amazonaws.com/solaris10-gcc/ruby-master/log/20220905T070005Z.fail.html.gz
but I don't have sudo privilege to install dependencies such as xz on
that machine. Thus I can't extract a prebuilt libclang bin... -
-
- `private_constant *constants` seems to be warned for some reason
-
-
-
-
-
- f7cf641469161c3770b58f79e08e312512212aa8 broke spec/bundler/install/gems/resolving_spec.rb:356.
This line seems to impact that test, so I slightly modified the
implementation for that spec's case. -
-
02:43 AM Revision 45fe7f75 (git): [rubygems/rubygems] Feature: `bundle add` supports `--path` option
- https://github.com/rubygems/rubygems/commit/32bee01fbe
-
- After recent musl support was added, Bundler started hanging in musl
platforms. I identified the issue where valid candidates were being
filtered out because their platform was specified as a string, and thus
`Gem::Platform.match_spec?` ... -
-
-
- Then fallbacks to preprocessed version.h.
-
- This takes care of signal_self_pipe and other things.
09/04/2022
-
- I'm interested in submitting a patch for this, but which behavior is considered correct?
-
- This script demonstrates the behavior:
```ruby
def show(io)
printf(
"external encoding: %-25p internal encoding: %-25p\n",
io.external_encoding,
io.internal_encoding
)
end
Encoding.default_external = 'iso-88... -
- 03:00 PM Revision e83183b4 (git): * 2022-09-05 [ci skip]
-
-
02:50 PM Bug #18743: Enumerator#next / peek re-use each others stacktraces
- Good day, @matz. Is the fix above acceptable?
-
- Applied in changeset commit:git|bbe5ec78463f8d6ef2e1a3571f17357a3d9ec8e4.
----------
rb_int_range_last: properly handle non-exclusive range
[Bug #18994] -
- Thanks, I have a patch for it: https://github.com/ruby/ruby/pull/6324
-
- [Bug #18994]
-
-
- Merged https://github.com/ruby/ruby/pull/6296.
-
- Co-authored-by: Yuta Saito <kateinoigakukun@gmail.com>
-
- ruby_3_1 882d4203f184ac93ac5c2c02c1e9f4b26cfad1db merged revision(s) ef525b012a709077ea2797e8642fae0b61234063,dc9a13abeef5a2b936fbb55edc112b8b382a05e7.
-
- ruby_3_1 6b8bf6ba5d1893b3c933c2de3ada1eb59a94b644 merged revision(s) 6d3f447aecfb56f7d3edbdf9cc68e748e150d7d8.
-
- ruby_3_1 1cfc139f6d0cb80d6024b0c416976194929417cf merged revision(s) d8189ed23f02dd197453279aeee9be1785337d4f.
-
- Explicit handling of frozen strings in `IO::Buffer#for`. (#5892)
---
io_buffer.c | 122 +++++++++++++++++++++++++++++++++++---------
test/ruby/test_io_buffer.rb | 36 +++++++------
2 fil... -
- Fix multiplex backreferencs near end of string in regexp match
Idea from Jirka Marsik.
Fixes [Bug #18631]
---
regexec.c | 6 ++++--
test/ruby/test_regexp.rb | 6 ++++++
2 ... -
- Return only captured range in `MatchData` [Bug #18670]
---
re.c | 2 +-
test/ruby/test_regexp.rb | 1 +
2 files changed, 2 insertions(+), 1 deletion(-) -
- same motivation as d6f21b308bcff03e82f8b3dbf11a852ce111b3b3