Activity
From 01/14/2019 to 01/20/2019
01/20/2019
-
10:14 PM Feature #6012: Proc#source_location also return the column
- If changing this API is too complicated due to backwards compatibility, why not introduce new more general API:
```
Method#source -> Source.new(path, line_number, line_count, code, ...)
```
Usage:
```
method.source.code
meth... -
09:25 PM Revision 4487562d (git): Update to ruby/spec@e2fbd4d
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66889 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- FWIW, `sizeof(int) == sizeof(long)` is also the case on i686 Linux:
https://travis-ci.org/ruby/ruby/jobs/482143545 -
- For instance, when `sizeof(int) < sizeof(long)` (such as on Linux), then
```c
FIX2INT(nil)
```
raises TypeError.
But when `sizeof(int) == sizeof(long)` (such as on Windows), then it returns `4`.
So the behavior changes from a cal... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66888 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66887 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- @nobu I think we should backport r66769 to Ruby 2.6, could you do it or file an issue for it?
-
- Specifically, the image generated is incorrect.
When modifying the footer of the benchmark like this:
```ruby
alias printf_orig printf
def printf *args
$fp.printf(*args)
end
File.open("ao.ppm", "w") do |fp|
$fp = fp
pr... -
03:07 PM Revision 1c53f86b (git): process.c: [DOC] small improvements
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66886 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66885 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66884 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:02 PM Revision 8fe427c1 (git): * 2019-01-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66883 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66882 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- nobu (Nobuyoshi Nakada) wrote:
> `rb_str_set_len` is not the true problem.
> ...
That sounds safer, because indeed as soon as the C code can access the `char*` it can change it.
> Or enclose it only for the core and prohibit in exte... -
02:20 PM Bug #15550: Windows - gem bin files - can't run from bash shell
- An easy way to repo this is to open the Git bash shell, and run `bundle version`. I got an error message of:
```
bash: /c/Greg/Ruby99-x64/bin/bundle: No such file or directory
```
I believe the MSYS2 shell changes PATH, the Git ... -
- As I recall, ruby-loco is no longer touching the gem related files located in the bin folder. Previously, there were two files associated with each gem, one with a .cmd/.bat extension, one without.
Currently, there is just one file w... -
10:48 AM Bug #15162: Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW
- ruby_2_5 r66881 merged revision(s) 64879.
-
- transcode.c: add GC guard on raise
* transcode.c (econv_s_search_convpath): add GC guard to fix SEGV
on raise.
[Bug #15162] [ruby-core:89172]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@668... -
- ruby_2_5 r66880 merged revision(s) 63334.
-
- object.c: raise on long invalid float string
* object.c (rb_cstr_to_dbl_raise): check long invalid float
string more precisely when truncating insignificant part.
[ruby-core:86800] [Bug #14729]
git-svn-id: s... -
- ruby_2_5 r66879 merged revision(s) 63322.
-
- object.c: fix exponent with underscore
* object.c (rb_cstr_to_dbl_raise): do not ignore exponent part
when the input string longer than internal buffer contains
underscore(s). [ruby-core:86836] [Bug #14731]
... -
- ruby_2_5 r66878 merged revision(s) 63720.
-
- dir.c: define O_CLOEXEC for older systems
SuSE 10 has openat(), but not O_CLOEXEC
Reported-by: wangpeiwen
[ruby-core:87591] [Bug #14864]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@66878 b2dd... -
- ruby_2_5 r66877 merged revision(s) 66401.
-
- Move autoload to toplevel
So that classes which uses Net::HTTP with https can use OpenSSL
namespace for example exception classes like OpenSSL::SSL::SSLError.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_... -
- ruby_2_5 r66876 merged revision(s) 66242.
-
- io.c (io_write_nonblock): add RB_GC_GUARD, io_fflush may switch threads
Since io_fflush may block on mutex or rb_io_wait_readable and
switch threads, we need to ensure the `str' VALUE returned by
`rb_obj_as_strin... -
04:44 AM Revision afd68cd8 (git): raise FrozenError instead of RuntimeError
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:38 AM Feature #11639 (Closed): Refactor some description of `Forwardable`
- Applied in changeset trunk|r66873.
----------
[DOC] Refactors documentation for `Forwardable`
[ruby-core:71281] [Misc #11639]
From: Sam Morgan <s_morgan@me.com> - 04:38 AM Revision 27f51081 (git): * 2019-01-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66874 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [ruby-core:71281] [Misc #11639]
From: Sam Morgan <s_morgan@me.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I misunderstood this could be reproducible in 2.5 but it isn't.
-
01:15 AM Feature #15517: Net::HTTP not recognizing valid UTF-8
- I think this issue is not a duplicate of issue #2567, but it is clearly related.
Checking whether the string is valid UTF-8 is rather easy;
```
string.force_encoding('UTF-8').valid_encoding?
```
should do.
There are some securi...
01/19/2019
-
09:15 PM Feature #15549: Enumerable#to_reader (or anything enumerable, Enumerator, lazy enums, enum_for results)
- I do not have any major pro or con opinion on the functionality as such; I think the
name #to_reader may not be ideal, though. People may confuse or think about
**attr_reader** ; or they may think about **.to_s** , **.to_i** and so for... -
03:38 PM Feature #15549 (Open): Enumerable#to_reader (or anything enumerable, Enumerator, lazy enums, enum_for results)
- This is a feature proposal for something I've had to implement before multiple times.
For a lot of IO-related APIs, there is this unspoken (because ruby doesn't have official interfaces) notion of a reader/writer protocol, that is, yo... -
11:42 AM Feature #11639 (Assigned): Refactor some description of `Forwardable`
-
- I did not even know that iterator? exists - at first I thought it was something new. :)
I agree with nobu's comment. -
- `block_given?` has been added since 1.6, and `iterator?` is almost never used these days.
I think we can deprecate the latter before Ruby 3. -
- CentOS 5 and Ruby 2.1 are EOL.
-
- r58403 was included in ruby_2_5.
#15500 seems related and r66867 may fix this issue. -
- The versions of Ruby and Rails are outdated today.
-
09:08 AM Revision 46549d6b (git): Revert "mjit_worker.c: try to simplify CC_DLDFLAGS_ARGS"
- This reverts commit 405940234eb7876a063eb7129ca61fcc318a633c.
Not working on MinGW
https://ci.appveyor.com/project/ruby/ruby/builds/21737578/job/09a2tr94vof6fstt
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66872 b2dd03c8-39d4-4d8... -
07:49 AM Revision e90d826d (git): Indented here document (<<~) is Ruby 2.3 feature
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66871 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- assuming that -nostartfiles is just optional for mingw, cygwin, and AIX.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66870 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- >Off topic: can someone give me the grant to copy issues around? It seems disabled for this account.
Enabled it to Developer role now. -
12:29 AM Misc #15462 (Closed): DevelopersMeeting20190110Japan
- @shevegen Here you are https://bugs.ruby-lang.org/issues/15546
Off topic: can someone give me the grant to copy issues around? It seems disabled for this account. -
- Could someone add a date + issue for the next developer meeting, please?
I looked at https://bugs.ruby-lang.org/projects/ruby-trunk/issues for when the next
meeting may be, but was unable to find it (assumingly so it may be in Februa... -
- Applied your patch. Thanks for your help!
-
- Applied in changeset trunk|r66869.
----------
mjit_worker.c: do not use GCC_NOSTDLIB_FLAGS for OpenBSD
OpenBSD's GCC compiler has local extensions that break when
`-nostartfiles -nodefaultlibs -nostdlib` is used.
From: Jeremy Evans <m... -
07:12 AM Bug #15548 (Closed): Fix MJIT on OpenBSD when GCC is used to compile
- OpenBSD's GCC compiler has local extensions that break when `-nostartfiles -nodefaultlibs -nostdlib` is used. If you leave those flags in, MJIT doesn't work. `--jit-verbose=2` output on OpenBSD/amd64 with gcc forced as the compiler show...
-
- OpenBSD's GCC compiler has local extensions that break when
`-nostartfiles -nodefaultlibs -nostdlib` is used.
From: Jeremy Evans <merch-redmine@jeremyevans.net>
[Bug #15548]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66869 b2dd... -
- matz (Yukihiro Matsumoto) wrote:
> This is a very interesting idea but at the same time, it's difficult to keep compatibility.
> ...
If we want to support implicit block arguments, in order to best keep compatibility, we would probably... -
05:50 AM Bug #15469: Ruby2.6 included `bundler` does not handle specified `csv` gem.
- I could reproduce too with "Test code".
Also, I could reproduce with simpler code below.
### Gemfile
``` ruby
source "https://rubygems.org"
gem "csv", "1.0.0"
```
### test.rb
```ruby
require "csv"
p csv: CSV::VERS... -
05:24 AM Misc #15546: DevelopersMeeting20190207Japan
- * [Feature #4475] default variable name for parameter (aycabta)
* In #15483, matz said "I feel the expression `ary.map(&(:to_i << :chr))` is far less readable than `ary.map{|x|x.to_i.chr}`.", and "And this can lead to the default bloc... -
- Please comment your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(your summary/comment will help us because we don't need to read all of ticket comments)
*DO NOT* discuss then on this ticke... -
- @mrkn
Can you try with Ruby 2.5 applied r66867? -
- Applied in changeset trunk|r66867.
----------
Revert r58345 and r58371.
These changes break the behavior of default gems. Bug #13428 says
r58345 is reasonable because gemspec file is installed by `to_ruby_for_cache`
method. But I... - 03:36 AM Revision 31c862a7 (git): * 2019-01-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- These changes break the behavior of default gems. Bug #13428 says
r58345 is reasonable because gemspec file is installed by `to_ruby_for_cache`
method. But I revert `to_ruby_for_cache` in rbinstall.rb at r58403.
There is no reason ... -
03:30 AM Feature #15517: Net::HTTP not recognizing valid UTF-8
- I'm not sure I think this is exactly the same as https://bugs.ruby-lang.org/issues/2567, as that one has focused on using the HTTP headers to guess the content type. Here I'm pointing out that ASCII-only strings are recognized as UTF8, b...
-
- \o/
I noticed a few differences, or I think I noticed it (I am not entirely sure).
For example, I did not notice "Actions" on the very right hand side before.
I also think there may have been another one or two minor changes in ...
01/18/2019
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66866 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66864 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Msys shell may not be able to run a command with a drive letter?
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r66862 merged revision(s) 66796,66797.
-
- No TypeError at nil if exception: false
[ruby-core:91021] [Bug #15525]
No FloatDomainError at non-finitive number if exception: false
[ruby-core:91021] [Bug #15525]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- `rb_str_set_len` is not the true problem.
Should `RSTRING_PTR` make the object unshared and clear the code range?
Or enclose it only for the core and prohibit in extension libraries?
Hmmm, the last choice may be the best, I think. -
- [ruby-core:91134] [Bug #15543]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I'll fill Backport field and close this ticket for backport.
Thank you for notice. -
02:05 AM Bug #15545 (Closed): Backport r58403
- The change in r58403 should be backported in 2.5.
https://github.com/ruby/ruby/commit/cd8f9904427e6db858a4dcc1dabff60a76cad445 -
02:04 AM Revision b4ab9c0e (git): support older BASERUBY for btest.
- * bootstraptest/test_insns.rb: check RbConfig::LIMITS to support
older BASERUBY.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66860 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- MINIRUBY may not be stable enough to run btest, in developing.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66859 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
01/17/2019
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66858 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:23 PM Revision dabbdcfd (git): * 2019-01-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66857 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66856 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@66855 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_6 r66854 merged revision(s) 66681,66682,66684,66688,66697,66751,66693,66694.
-
- complex.c: Optimize Complex#+ for some conditions
Optimize f_add defined in complex.c for some specific conditions.
It makes Complex#+ about 1.4x faster than r66678.
Compared to r66678:
```
mrkn... -
- Please visit https://bugs.ruby-lang.org/ and read the FAQ part.
Next time consider doing so before posting an issue. -
- You should use the bugtracker primarily for ruby-related problems, issues and so forth. For questions
about C not directly related to the ruby implementation, stackoverflow may be a better site. -
07:52 PM Bug #15544 (Rejected): sprintf returns an unexpected string
- Hello,
I've a little problem with the sprintf function. It returns unexpected results ( in my opinion )
``` ruby
sprintf("%.16g", 8.78)
# returns "8.779999999999999"
# my expected result is "8.78"
```
Can somebody explain th... -
- ruby_2_6 r66853 merged revision(s) 66832.
-
- st.c (rb_hash_bulk_insert_into_st_table): avoid out-of-bounds write
"hash_bulk_insert" first expands the table, but the target size was
wrong: it was calculated by "num_entries + (size to buld insert)", but
it wa... -
- ruby_2_6 r66852 merged revision(s) 66779.
-
- configure: refuse to build with jemalloc when header is missing
[ruby-core:90964] [Bug #15520]
Freom: Misty De Meo <mistydemeo@github.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@66852 b2dd03c8-39... -
- ruby_2_6 r66851 merged revision(s) 66819.
-
- ast.c: fix missing head part in dynamic literal
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@66851 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r66850 merged revision(s) 66817.
-
- mjit_worker.c: pass -nostdlib when making pch as well
[Bug #15513]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@66850 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r66849 merged revision(s) 66811,66812,66816.
-
- mjit_worker.c: untangle CC_LIBS nesting
This should have no impact.
The CC_LIBS was too hard to read for human.
I don't remember whether the order of -lmsvcrt and -lgcc matters or not,
but I kept that fo... -
- ruby_2_6 r66848 merged revision(s) 66838.
-
- dir.c: fix Dir.glob with braces and matching dir
* dir.c (join_path_from_pattern): add the last slash for directory
matching.
* test/ruby/test_dir.rb (test_glob_recursive_directory): add a test
for a... -
- ruby_2_6 r66847 merged revision(s) 66756.
-
- Mark array as "going to be modified" in `Array#reject!`
Before this patch, if `reject!` is called on a shared array it can
mutate the shared array rather than a copy. This patch marks the array
as "going to be m... -
- ruby_2_6 r66845 merged revision(s) 66760,66761,66824.
- 09:36 PM Revision 01b6b589 (git): * 2019-01-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@66846 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Follow behaviour of IO#ungetbyte
see r65802 and [Bug #14359]
* expand tabs.
setbyte / ungetbyte allow out-of-range integers
* string.c: String#setbyte to accept arbitrary integers [Bug #15460]
... -
- Applied in changeset trunk|r66844.
----------
Removed old gemspecs of default gems for the Ruby committers.
[Bug #12764][ruby-core:77284] -
- [Bug #12764][ruby-core:77284]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I could reproduce them. But I also reproduce it with Ruby 2.5.3 with RubyGems 2.6.14.3 bundled with Ruby 2.4.
```
~ > ruby -v
ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-darwin18]
~ > gem -v
2.6.14.3
~ > gem list bigdecima... -
- Can you try it with Ruby 2.6.0?
-
10:10 AM Misc #15534 (Closed): Is there reliable way to check for new Ruby releases?
- I updated the URL to the index.txt and the release-monitoring.org picked up the Ruby 2.6.0 just using the default RegExp. So it seems to work right now. I'll keep monitoring the situation with future releases. Until then, this is resolve...
-
- >What is the most reliable version information
Use https://cache.ruby-lang.org/pub/ruby/index.txt. It's generated the latest package information every day by our system.
> ...
I removed "stable" directory and preview versions of Ru... -
09:07 AM Misc #15530: [ANN] Upgrading bugs.ruby-lang.org to Redmine 4.0
- @hsbt Does the new version have a markup settings? Previously, the markup was Markdown-compatible, so `_underscores_` were rendered as italic. Now, it rendered as _underscored_, and while it can be said "logical", but a lot of old texts ...
-
- After Redmine 4.0, We found the breaking change for api endpoint.
Example:
Redmine 3.x: https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions.atom
Redmine 4.x: https://bugs.ruby-lang.org/projects/ruby-trunk/reposito... -
- * hash.c (RHASH_AR_TABLE_SIZE_DEC): generally, we need to check all
entries to calculate exact "bound" in ar_table, but if size == 0,
we can clear bound because there are no active entries.
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... -
- * bootstraptest/runner.rb (assert_normal_exit): check MJIT first
to support btest with ruby ~2.5. btest (bootstraptest) should be
enable to run with stable ruby interpreter because modified ruby
may not able to run runner.rb and we... - 12:36 AM Revision 0280bef3 (git): * 2019-01-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66841 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66840 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- sylvain.joyeux (Sylvain Joyeux) wrote:
> Here's the patch for 2.6. I would be glad if you could consider also applying the other patch to 2.5.
Thank you so much.
In thread_win32.c:
```diff
-#define TIME_QUANTUM_USEC (10 * 1000... -
- I think few people know about this, and `rb_str_modify` isn't documented in doc/extension.rdoc.
I guess some C extensions ignore this requirement and could have bugs because of it.
Isn't it simpler and safer to clear the coderange, a...
01/16/2019
-
- It isn't an issue of `rb_str_set_len`.
The string isn't valid encoding by `@s.RSTRING_PTR_set(@str, 2, 0x80)`.
You should call `rb_str_modify` before modifying a string object.
-
04:35 PM Bug #15543 (Rejected): rb_str_set_len should clear code range
- Calling `rb_str_set_len` on a `String` could alter the code range. I think this hasn't been much of an issue because of pure luck rather than anything that was deliberately designed. If called on a string that already has a `CR_UNKNOWN` ...
-
- Indeed.
-
05:14 PM Feature #6801: String#~ for a here document
- Since this exact behavior was added as "indented here document" with `<<~` in Ruby 2.3.0 (discussed in #9098), I believe this issue can be closed out.
-
07:36 PM Feature #15438: Threads can't switch faster than TIME_QUANTUM_(NSEC|USEC|MSEC)
- Quick question ... what is the preferred method to provide patches now ? I'm seeing that there are PR on GitHub ... Should I propose the patch here instead ?
-
04:32 PM Feature #15353: Support client certificates with TLS 1.3 and OpenSSL 1.1.1
- > Hello, openssl library now has its own tracker. Is it possible to report this issue at ruby/openssl? https://github.com/ruby/openssl/issues
Thank you for explaining that ruby/openssl has its own bug tracker!
I have created an is... -
04:00 PM Bug #15542 (Third Party's Issue): Segmentation fault when Interrupted on rabbit.gem for ruby 2.7.0dev
- I previewed my slide using rabbit.gem and stopped by crtl+c...then core dumped.
reproduction scenario
* gem install rabbit
* rabbit REAME.md (and open slide window)
* crtl+c #=> segmantaition fault
I attached output lo... -
- ruby_2_5 r66839 merged revision(s) 65974.
-
- Normalize month-mday before finding epoch
Especially over the year 2038, 30 Feb and so on may cause odd behavior
on validating found epoch with given year-month-day [Bug #15340]
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... -
02:06 PM Bug #15540 (Closed): 2.6.0 Dir#glob regression - Applied in changeset trunk|r66838.
----------
dir.c: fix Dir.glob with braces and matching dir
* dir.c (join_path_from_pattern): add the last slash for directory
matching.
* test/ruby/test_dir.rb (test_glob_recursive_directory): add... -
05:56 AM Bug #15540: 2.6.0 Dir#glob regression
- Thanks for report. I attached a patch for the issue.
-
- * dir.c (join_path_from_pattern): add the last slash for directory
matching.
* test/ruby/test_dir.rb (test_glob_recursive_directory): add a test
for above.
[ruby-core:91110] [Bug #15540]
git-svn-id: svn+ssh://ci.ruby-lang.org/rub... -
- Thanks for the update. You didn't answer 2 but I guess you're using `trim_mode: '-'` or something including "-". Note that your "extra indentation" result is still not valid one since it should have 4 spaces in the real world. Do not tre...
-
- How about following style?
```
1
<%- [2, 3, 4].each do |num| -%>
<%- unless num == 3 -%>
<%= num %>
<%- end -%>
<%- end -%>
5
``` -
09:58 AM Feature #15538: Erb indenting / unindenting
- (missing closing parenthesis)
-
- Clarified and added some examples
-
- ruby_2_5 r66837 merged revision(s) 64476.
-
- thread_sync.c (rb_mutex_sleep): disable interrupt checking in ensure
This is needed to reliably fix ConditionVariable#wait on Thread#kill
[Bug #14999] because there is still a chance an interrupt could fire
and p... -
- I always thought Proc.new working without an explicit block was an unintended feature in MRI, and indeed fairly magical, so I support taking a more explicit way in 2.7.
-
- > makes it no longer possible to have a default value for a positional argument that uses the block
Surprisingly, we can:
```
def foo o = binding.local_variable_get(:b), &b
p o.class
end
foo{} #=> Proc
```
(of course it... -
- ko1 (Koichi Sasada) wrote:
> I'll file the reason soon.
> ...
I also ran into this issue as `Proc.new` was used in a few places in Sequel. Removing implicit block support for `Proc.new` makes it no longer possible to have a default val... -
01:03 AM Bug #15539: Proc.new with no block shouldn't always warn
- ko1 (Koichi Sasada) wrote:
> I'll file the reason soon.
> ...
Ok, no problem! I'll update Rails and reference the feature when posted. 😊 -
- I'll file the reason soon.
Anyway, I recommend you to rewrite it with a block parameter:
```
def foo bar = nil, &b
(b || bar).call
end
# or
def foo bar = nil, &b
bar ||= b
bar.call
end
```
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66836 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Personally I think that alias name would make sense. With a new alias the backwards
behaviour would also be retained. -
01:44 AM Feature #15541 (Third Party's Issue): Add alias symbolize_keys for symbolize_names kwarg for JSON.parse
- https://github.com/ruby/psych/issues/341
When trying to symbolize keys on JSON parsing, it's really hard to remember the name `symbolize_names`:
```
JSON.parse(data, symbolize_names: true)
```
I would like to propose that we c... -
- "Makefile.in: reconfig with the original warnflags"
It would be unnecessary since r65803 and r65805.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:48 AM Revision 98e218b6 (git): * 2019-01-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66834 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66833 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:19 AM Bug #15503: Error in Ruby 2.6 when trying to shell out to invoke `irb` while in a `bundle exec` session
- schneems (Richard Schneeman) wrote:
> Hello. This script fails on Ruby 2.6 but works successfully with Ruby 2.5:
I believe that's because irb was not a gem in Ruby 2.5 and was part of the stdlib, but in 2.6 it's a gem.
01/15/2019
-
11:15 PM Bug #15540 (Closed): 2.6.0 Dir#glob regression
- in an empty base folder create the following structure
```
.
└── c
├── d
│ └── a
│ ├── a.file
│ └── b
│ ├── b.file
│ └── c
│ └── c.file
└── e
... -
- Hi,
r66772 introduced a warning for the following code:
``` ruby
def foo bar = Proc.new
bar.call
end
foo { p "block" } # warn
foo ->() { p "block" } # no warn
```
I don't think this case of `Proc.new` should warn.... -
- If we want to remove a feature, we deprecate and warn first, that has always been the case in MRI.
@shyouhei Please add the warning. Otherwise, no users will consider it deprecated.
@normalperson If you disagree, please start a gen... -
03:34 PM Bug #15536: Crash on merging specific hashes using keyword splat
- That was fast, thank you.
-
02:19 PM Bug #15536 (Closed): Crash on merging specific hashes using keyword splat
- Applied in changeset trunk|r66832.
----------
st.c (rb_hash_bulk_insert_into_st_table): avoid out-of-bounds write
"hash_bulk_insert" first expands the table, but the target size was
wrong: it was calculated by "num_entries + (size to b... -
- Good catch. The following code still crashes on trunk.
```
{
**{
a0: nil,
a1: nil,
a2: nil,
a3: nil,
a4: nil,
a5: nil,
a6: nil,
a7: nil,
a8: nil,
},
a0: nil,
a1: nil,
a2: n... -
- Here's a snippet that leads to a crash on ruby 2.5.3. I tried to make it as small as possible.
```ruby
1000.times do
{
**{
a1: nil,
a2: nil,
a3: nil,
a4: nil,
a5: nil,
a6: nil,
a... -
- kke (Kimmo Lehto) wrote:
> In `Erb`, would it be possible to add a new trim mode that would indent the following content to match the depth of the tag? The tag could for example be `<%|` and it would be enabled using `Erb.new(template, ... -
- It's hard to understand your proposal for me. Could you fix the following two parts first?
1. Do not use "...." in the template. We are talking about a feature to change indentation and the indentation you imagine in "...." is not cle... -
- In `Erb`, would it be possible to add a new tag that would indent the following content to match the depth of the tag? The tag could be `<%~` (to resemble the `<<~EOS` squiggy heredoc).
## Reason
Something like this would be easy t... -
- "hash_bulk_insert" first expands the table, but the target size was
wrong: it was calculated by "num_entries + (size to buld insert)", but
it was wrong when "num_entries < entries_bound", i.e., it has a deleted
entry. "hash_bulk_insert"... -
- Currently we are not explicit enough regarding the potentially confusing
behavior of `Array#-` and `Array#difference` when it comes to duplicate items
within receiver arrays.
Although the original documentation for these methods does us... -
- Hi nobu. Thanks for looking into this !
Here's the patch for 2.6. I would be glad if you could consider also applying the other patch to 2.5. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66830 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:17 AM Bug #15537 (Closed): Numeric#step doesn't iterate under some conditions
- Numeric#step doesn't iterate under the following conditions:
- receiver and/or `by` are `Float`
- `by` is negative
- `to` is default
- without block
### Example:
Good:
~~~ruby
p 1.step(by: 3).take(2) ... -
- ruby_2_6 r66829 merged revision(s) 66767.
-
- insns.def (duparray, duphash): add dtrace hooks
They are considered Array and Hash creation events, so
allow dtrace (and systemtap) to track those creations.
Co-Authored-By: Eric Wong <e@80x24.org>
git-svn-id: ... -
- ruby_2_6 r66828 merged revision(s) 66788.
-
- Update refinements docs
Co-Authored-By: Vladimir Dementyev <dementiev.vm@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@66828 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r66827 merged revision(s) 66736.
-
- ast.c: argument must be a string
[ruby-core:90904] [Bug #15511]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@66827 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r66826 merged revision(s) 66745.
-
- Bump version to date-2.0.0.
I forgot to change it when Ruby 2.6.0 was released.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@66826 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r66825 merged revision(s) 66735.
-
- Fix mday overflow
[ruby-core:90897] [Bug #15506]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@66825 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:38 AM Feature #11741: Migrate Ruby to Git from Subversion
- Thumbs up for this incredible discussion of yours. I've truly appreciated perusing this discussion today and I figure this may be extraordinary compared to other discussions that I've perused yet. If it's not too much trouble prop this w...
-
- Applied in changeset trunk|r66824.
----------
setbyte / ungetbyte allow out-of-range integers
* string.c: String#setbyte to accept arbitrary integers [Bug #15460]
* io.c: ditto for IO#ungetbyte
* ext/strringio/stringio.c: ditto for S... -
- * string.c: String#setbyte to accept arbitrary integers [Bug #15460]
* io.c: ditto for IO#ungetbyte
* ext/strringio/stringio.c: ditto for StringIO#ungetbyte
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66824 b2dd03c8-39d4-4d8f-... -
06:01 AM Bug #15513: MJIT compilation terminated due to -Wfatal-errors on GCC 7.3.0
- バージョンがかわってしまったので元にもどしました。
-
- 下記のとおりコンパイルされることが確認できました！ありがとうございます。
~~~
$ time ruby -v --jit-verbose=2 --jit-save-temps --disable-gems /tmp/t.rb
ruby 2.7.0dev (2019-01-15 trunk 66823) +JIT [x86_64-linux]
MJIT: CC defaults to /usr/bin/gcc
MJIT: tmp_dir is /tmp
... -
- This reverts commit b32fb23083912c37a2601c66531ed786a7c9f3e5.
This didn't work on AIX.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66823 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:53 AM Feature #15523: Let `Range#begin` and `Range#end` be aliases of Range#first and Range#last
- mame (Yusuke Endoh) wrote:
> I understand that "your problem" is confusion between a keyword "begin" and "Range#begin". First, I have never been confused by the fact. Then,
Actually, that was a minor point (I, myself, have not be... - 03:43 AM Revision a01f2f0a (git): * 2019-01-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66822 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66821 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- Eregon (Benoit Daloze) wrote:
> tenderlovemaking (Aaron Patterson) wrote:
> ...
Yes, I totally agree. I think `deep_freeze` is going to be necessary for adoption of Guilds, and the code I'm proposing in this patch would be an optimiza...
01/14/2019
-
- Required arguments cannot be placed between optional arguments **syntactically**, so it must be a `SyntaxError`.
`ArgumentError` is a runtime error.
-
07:52 PM Bug #15535 (Rejected): Optional arguments for definition - Syntax Error is not the correct Error type
- The below definition throws a Syntax Error, while there is no syntax error and I'm not sure what is the intention behind the Syntax Error
``` ruby
def hello(foo="bar", bar, yanko="me")
p "Hello"
end
```
The same definition be... -
- Your patch can't apply to the latest code.
Could you rebase it? -
- Anyone interested on the subject ?
-
- Thank you for the confirmation.
-
- The example appears to have been a little mangled on Redmine.
This code reproduces the issue on 1.9.3-p327 and 1.9.3-p551:
~~~
class Superclass
define_method :regex do
/^(\d)$/
end
end
class Subclass < Superclass
... -
- > Note that a timezone system requires two API.
Sorry for my arrogance, but can you please explain this a bit?..
From what I can understand from code, `local_to_utc` is used only from `Time.new`, but I am not quite sure why exactly.
... -
- This appears to still be an issue with Ruby 2.6.0 (ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-linux]):
Example:
~~~
module M
@@xyz = 123
end
puts "M.class_variables: #{M.class_variables.inspect}"
puts "M.class_variable... -
03:45 PM Feature #15526: New way to destruct an object hash
- Related/duplicate https://bugs.ruby-lang.org/issues/11758
-
- In Fedora, we are using https://release-monitoring.org/ to check for packages updates. Unfortunately, the content of https://cache.ruby-lang.org/pub/ruby/ is a bit inconsistent which makes this service unuseful.
If I open the page, th... -
- @sawa Sorry, please don't mind my previous comment. I confused the behavior of Range and one of ArithmeticSequence.
-
- @sawa Please tell us how can we get both the end-value of the exclude-end range and the last element of the sequence generated by the range if your proposal were accepted?
-
- k0kubun (Takashi Kokubun) wrote:
> @vo.x Could you check if r66812 works?
Actually it is r66811 + r66812. Applying these two patches, the test suite passes on RHEL7 on all supported architectures and it keeps passing on Fedora Rawhid... -
- @vo.x Could you check if r66812 works?
-
- Applied in changeset trunk|r66812.
----------
mjit_worker.c: pass -lgcc to GCC platforms
using `-nodefaultlibs -nostdlib`.
I assume libgcc is needed when we use -nostdlib, and it's linked on some
platforms but not linked on some platf... -
- Memo: r61591, r61592, r66324 are related.
-
- > Maybe this patch too.
> ...
Hmm, these two pull requests are not merged yet in ruby/openssl and neither committed into ruby trunk.
We can backport them only after they are committed into trunk according to our stable branch managemen... -
11:17 AM Bug #15533 (Third Party's Issue): Segmentation fault: mysql2 client
- Started GET "/" for 127.0.0.1 at 2019-01-14 10:55:17 +0000
/../../.rvm/gems/ruby-2.6.0/gems/mysql2-0.5.2/lib/mysql2/client.rb:90: [BUG] Segmentation fault at 0x0000000000000000
ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-darwin17] -
- This is a ticket for backport management.
r66819 contains bug fix for RubyVM::AbstractSyntax.parse/.parse_tree.
-
- tool/redmine-backporter.rb: change revision resource URL.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66820 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66819 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Fixed at r66788
-
- ruby_2_5 r66818 merged revision(s) 64589,64593.
-
- cont.c: set th->root_fiber to current fiber at fork
Otherwise, th->root_fiber can point to an invalid Fiber,
because Fibers do not live across fork. So consider
whatever Fiber is running the root fiber.
... -
- Target version is used by release engineering; don't use this as just a goal.
In this case set target version after drb removes `ObjectSpace._id2ref`. -
- Target version is used by release engineering; don't use this as just a goal.
-
- @kajisha 多分 r66817 で直ると思うのですが、最新のtrunkでMJITが動くかご確認いただけないでしょうか。
-
- Applied in changeset trunk|r66817.
----------
mjit_worker.c: pass -nostdlib when making pch as well
[Bug #15513] -
- [Bug #15513]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66817 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- r66812 might have allowed this. Testing.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66816 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r66815 merged revision(s) 66595.
-
- fix missed script_compiled events. [Bug #15471]
* ruby.c (process_options): script_compiled events are missed on
command line -e or specified file. this commit fix it.
[Bug #15471]
This patch shoul... -
- ruby_2_6 r66813 merged revision(s) 66670,66676.
- 06:34 AM Revision 8e2c6c16 (git): * 2019-01-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@66814 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- compile.c: support branch coverage for `a&.foo = 1`
[Bug #15476]
compile.c (iseq_set_sequence): fix branch coverage table
Not only TRACE_ELEMENT but also INSN_ELEMENT may have events.
The old pc2branchi... -
- using `-nodefaultlibs -nostdlib`.
I assume libgcc is needed when we use -nostdlib, and it's linked on some
platforms but not linked on some platforms (like aarch64, and possibly
AIX as well) as said in https://wiki.osdev.org/Libgcc :
>... -
- This should have no impact.
The CC_LIBS was too hard to read for human.
I don't remember whether the order of -lmsvcrt and -lgcc matters or not,
but I kept that for the best safety.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@668... - 04:49 AM Revision b4bc6ccb (git): * 2019-01-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66810 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- In r66597, both VM and JIT seem to be made slower:
```
$ benchmark-driver benchmark.yml --rbenv 'r66596::before --disable-gems;r66597::after --disable-gems;r66596+JIT::before --disable-gems --jit;r66597+JIT::after --disable-gems --jit' ...