Project

General

Profile

Activity

From 01/07/2019 to 01/13/2019

01/13/2019

01:49 PM Bug #15531 (Closed): Ignore gemspec files for rdoc.
Applied in changeset trunk|r66808.
----------
rdoc: ignore gemspec files
[ruby-core:91067] [Bug #15531]
nobu (Nobuyoshi Nakada)
12:07 PM Bug #15531 (Closed): Ignore gemspec files for rdoc.
Followed up https://bugs.ruby-lang.org/issues/14163#note-5.
The current documentation generated by rdoc shows gemspec files like:
https://docs.ruby-lang.org/en/2.6.0/lib/csv/csv_gemspec.html
It should be ignored.
hsbt (Hiroshi SHIBATA)
01:49 PM Revision edb65a62 (git): rdoc: ignore gemspec files
[ruby-core:91067] [Bug #15531]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66808 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:41 PM Revision 71d2695d (git): rdoc: fixup the test for r66806
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66807 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
01:17 PM Feature #15523: Let `Range#begin` and `Range#end` be aliases of Range#first and Range#last
Objection.
I understand that "your problem" is confusion between a keyword "begin" and "Range#begin". First, I have never been confused by the fact. Then,
> * Let Range#begin and Range#end be aliases of Range#first and Range#last...
mame (Yusuke Endoh)
01:16 PM Revision 0fb782ea (git): rdoc: ignore garbage files
* lib/rdoc/options.rb (RDoc::Options#init_ivars): exclude backup
files by default.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66806 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:16 PM Revision 6feee125 (git): common.mk: common rdoc variables
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66805 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
11:56 AM Bug #14163 (Closed): Pages of rdoc include files which are not documents
Do not reuse the existence issue and modify status by yourself without maintainers. Because We use status is backport workflow for stable versions.
Please open another issue.
hsbt (Hiroshi SHIBATA)
11:42 AM Bug #14163 (Open): Pages of rdoc include files which are not documents
And here they are again: https://docs.ruby-lang.org/en/2.6.0/ (seems the problem is related to new default gems?) zverok (Victor Shepelev)
09:53 AM Feature #15527: Redesign of timezone object requirements
Sounds interesting, but `zone.utc_offset(time)` can only be a partial alternative of `utc_to_local` with using `gmtime(3).
Note that a timezone system requires two API.
One is an API which converts from [year, month, day, hour, minut...
naruse (Yui NARUSE)
08:37 AM Feature #12208 (Assigned): Improve ri command
hsbt (Hiroshi SHIBATA)
08:09 AM Bug #10422 (Assigned): RDoc for BasicObject has methods that do not exist
hsbt (Hiroshi SHIBATA)
08:06 AM Bug #11746 (Assigned): RDoc incorrect example call method on heredoc
hsbt (Hiroshi SHIBATA)
08:05 AM Bug #12888 (Rejected): Require 'thread' crash on recent 2.2.x
Ruby 2.2.x is EOL status. hsbt (Hiroshi SHIBATA)
08:03 AM Feature #15415 (Assigned): [PATCH] fileutils (mv): fall back to copy + unlink on EPERM
hsbt (Hiroshi SHIBATA)
07:50 AM Bug #15390: Error installing nokogiri on ruby-2.6.0-rc1
Possibly related: https://github.com/Homebrew/brew/issues/5068
Also this section from Nokogiri documentation: https://nokogiri.org/tutorials/installing_nokogiri.html#unable-to-find-libraries-on-macos-mojave
franklinyu (Franklin Yu)
05:56 AM Bug #15428: Refactor Proc#>> and #<<
zverok (Victor Shepelev) wrote:
> Now, from what I can understand, you followed this rule of thumb:
> ...
Right.
> So, in fact, it is my "option 2": "codify that `#call` from now on has a special meaning in Ruby", and considering your a...
nobu (Nobuyoshi Nakada)
04:36 AM Revision 665d9a43 (git): time.c: separate sign argument
* time.c (vtm_add_offset): separate sign argument to get rid of
repeated negations.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66804 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
03:37 AM Misc #15530: [ANN] Upgrading bugs.ruby-lang.org to Redmine 4.0
I fixed the mail-bomb issue [ruby-core:91051](http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/91051) - [ruby-core:91056](http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/91056). hsbt (Hiroshi SHIBATA)
03:17 AM Misc #15530 (Assigned): [ANN] Upgrading bugs.ruby-lang.org to Redmine 4.0
hsbt (Hiroshi SHIBATA)
01:36 AM Misc #15530 (Closed): [ANN] Upgrading bugs.ruby-lang.org to Redmine 4.0
Now, I did upgrade bugs.ruby-lang.org to Redmine 4.0 from 3.2.
See, notable changes via official announcement.
https://www.redmine.org/news/119
I migrated our custom plugins for Redmine 4.0 and Rails 5.2. When you encountered th...
hsbt (Hiroshi SHIBATA)
03:31 AM Revision 019c8915 (git): time.c: do not set utc_offset in vtm_add_offset
* time.c (vtm_add_offset): just add offset to other components
only. removed subtraction of utc_offset as it is overwritten
always immediately in callers.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66803 b2dd03c8-39d4-4d8f-9...
nobu (Nobuyoshi Nakada)
03:27 AM Revision 128b6577 (git): * 2019-01-13
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66802 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:27 AM Revision 6d181873 (git): Fix remaining syntax errors in Binding#irb docs
Apologies for catching those so late.
[Fix GH-2067] [ci skip]
From: Olivier Lacan <hi@olivierlacan.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66801 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)

01/12/2019

09:04 PM Bug #15519: addr2line compile error on RHEL7
ruby_2_6 r66800 merged revision(s) 66768. naruse (Yui NARUSE)
09:04 PM Revision d3aa6514 (git): merge revision(s) 66768: [Backport #15519]
Get rid of C99 feature for now [ruby-core:90949] [Bug #15519]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@66800 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
naruse (Yui NARUSE)
09:03 PM Bug #15468: Net::Protocol::BufferedIO#write raises NoMethodError when sending large multi-byte string
ruby_2_6 r66799 merged revision(s) 66582. naruse (Yui NARUSE)
09:03 PM Bug #15472: Invalid JSON data being sent from Net::HTTP in some cases with Ruby 2.6.0
ruby_2_6 r66799 merged revision(s) 66582. naruse (Yui NARUSE)
09:02 PM Revision 9548df04 (git): merge revision(s) 66582: [Backport #15468][Backport #15472]
Fix Net::Protocol::BufferedIO#write when sending large multi-byte string
This commit should fix Net::Protocol::BufferedIO#write when sending
large multi-byte string like following example.
```
$ ruby -rn...
naruse (Yui NARUSE)
03:04 PM Feature #15526: New way to destruct an object hash
zverok (Victor Shepelev) wrote:
> 1) Ruby has very consistent "argument **deconstruction**" rules. Basically, "it is deconstructed the same way it is constructed", e.g., if you can _call_ (construct) with arguments like `meth(a, *b, c: ...
janfri (Jan Friedrich)
02:21 PM Misc #15529 (Closed): Document Enumerator::Lazy
In this patch:
* explanation of the class concept, with examples;
* docs for all class methods (most of them just say "Like `Enumerable#<methodname>`, but chains operation to be lazy-evaluated.", but I believe they are useful this way ...
zverok (Victor Shepelev)
01:59 PM Feature #15301: Symbol#call, returning method bound with arguments
In the light of discussions here: https://bugs.ruby-lang.org/issues/15428#change-76265 (TL;DR: `#call` is "implicit Proc conversion") I retract this proposal.
Please close.
zverok (Victor Shepelev)
01:24 PM Bug #15428: Refactor Proc#>> and #<<
> `#call` method is called by `Enumerable`, `Enumerator`, finalizer and `Signal`.
That's interesting. I just looked through the docs and understood I was not very aware of this fact:
* `Enumerable#find` (is the only method using `#ca...
zverok (Victor Shepelev)
12:35 PM Bug #15428: Refactor Proc#>> and #<<
nobu (Nobuyoshi Nakada) wrote:
> `#call` method is called by `Enumerable`, `Enumerator`, finalizer and `eval`.
Sorry, the last is `Signal`, not `eval`.
nobu (Nobuyoshi Nakada)
12:31 PM Bug #15428: Refactor Proc#>> and #<<
> > `#to_proc` is not an implicit conversion method, as it needs the specific syntax, `&`.
> ...
The point is that is done **explicitly**.
> > It is a usual case that a method may expect its argument to have particular method(s),
> ...
nobu (Nobuyoshi Nakada)
12:08 PM Bug #15428: Refactor Proc#>> and #<<
> `#to_proc` is not an implicit conversion method, as it needs the specific syntax, `&`.
But ideologically, it is the way to designate "this object quacks as a `Proc`", e.g. could be used instead of a `Proc` object.
> ...
Well, I b...
zverok (Victor Shepelev)
11:35 AM Bug #15428: Refactor Proc#>> and #<<
Sorry, I was going to reopen this after r66769, but have forgotten.
> Currently, it is the **only** place in Ruby where coercing argument to `Proc` is done with `#call` method.
These methods do not coerce argument, but just expect...
nobu (Nobuyoshi Nakada)
09:36 AM Bug #15428 (Open): Refactor Proc#>> and #<<
Sorry for my arrogance, but I am kinda surprised (to say the least) with how this ticket is treated.
* Ticket is closed silently (are you aware that it is an event when Redmine doesn't send the notification, so unless I'll check manua...
zverok (Victor Shepelev)
12:39 PM Revision ad0ba0dc (git): trivial fix r66778 [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66798 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
11:56 AM Bug #15528: Bundler stdlib is not documented
@hsbt Thanks, I'll provide the patch.
Can we leave this ticket open? I believe it is an existing problem of the trunk, that should be tracked here, too.
zverok (Victor Shepelev)
11:20 AM Bug #15528 (Closed): Bundler stdlib is not documented
I welcome the patch for documentation of bundler on the upstream that is https://github.com/bundler/bundler or ruby repo both.
I can handle it because I'm a member of Bundler team.
hsbt (Hiroshi SHIBATA)
11:08 AM Bug #15528 (Closed): Bundler stdlib is not documented
Since 2.6, Bundler is a part of the standard library. But the logic of standard library docs for "default gems" (only gem's `lib` is copied to Ruby source tree, and libraries main class/module is rendered as a docs entry point) lead to u... zverok (Victor Shepelev)
09:36 AM Revision 4e28fdf4 (git): No FloatDomainError at non-finitive number if exception: false
[ruby-core:91021] [Bug #15525]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66797 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
09:02 AM Feature #15527 (Closed): Redesign of timezone object requirements
In #14850, there was timezone support introduced, there were pretty specific requirements for the Timezone object:
> A timezone argument must have `local_to_utc` and `utc_to_local` methods... The `local_to_utc` method should convert a...
zverok (Victor Shepelev)
05:03 AM Bug #15525 (Closed): Complex(nil, exception: false) and Rational(nil, exception: false) raises an error
Applied in changeset trunk|r66796.
----------
No TypeError at nil if exception: false
[ruby-core:91021] [Bug #15525]
nobu (Nobuyoshi Nakada)
05:02 AM Revision 62c17a2f (git): No TypeError at nil if exception: false
[ruby-core:91021] [Bug #15525]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66796 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:53 AM Revision 52a97e36 (git): * 2019-01-12
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66795 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:53 AM Revision 056c24d3 (git): RbConfig::CONFIG never had "exeext"
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66794 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)

01/11/2019

08:35 PM Feature #15526: New way to destruct an object hash
> Admit it, you only wanted to use `.then`
That's absolutely not the point. The real point here is:
1) Ruby has very consistent "argument **deconstruction**" rules. Basically, "it is deconstructed the same way it is constructed", ...
zverok (Victor Shepelev)
08:15 PM Feature #15526: New way to destruct an object hash
> What do you guys think?
Ultimately you only have to convince matz, so the rest is just people giving opinions. :)
Victor wrote:
> ...
config.then { |host:, port:|
Admit it, you only wanted to use **.then**. ;)
To the o...
shevegen (Robert A. Heiler)
07:57 PM Feature #15526: New way to destruct an object hash
Not exactly what you are describing, but, funny enough, there is a way!
```ruby
config = { host: 'localhost', port: 3000 }
config.then { |host:, port:|
p "host=#{host}, port=#{port}"
}
```
zverok (Victor Shepelev)
07:45 PM Feature #15526 (Open): New way to destruct an object hash
JavaScript has a nice a neat way to destruct objects.
~~~ javascript
const person = { name: "John Doe", age: 33 };
const { name, age } = person;
~~~
Erlang has a similar way to destruct a tuple:
~~~ erlang
Person = {"John Doe...
alissonbruno.sa (Alisson Santos)
07:52 PM Misc #15462: DevelopersMeeting20190110Japan
On 2019/01/11 06:53, dementiev.vm@gmail.com wrote:
> Issue #15462 has been updated by palkan (Vladimir Dementyev).
>
>
> * [Feature #14344] refine at class level
> * there are some proposals for shorter refinements syntax; wan...
duerst (Martin Dürst)
04:11 PM Bug #15522: TestJIT#test_compile_insn_local fails on aarch64 RHEL7
sharkcz (Dan Horák) wrote:
> I guess -nodefaultlibs should be omitted and/or -static-libgcc added. Skipping libgcc seems dangerous in general on any arch.
I removed `-nodefaultlibs` and it changed nothing. But reading GCC options [1]...
vo.x (Vit Ondruch)
11:10 AM Bug #15522 (Assigned): TestJIT#test_compile_insn_local fails on aarch64 RHEL7
> Header and the content of /tmp directory (except the .gch, which was huge :/) are attached.
Thanks! Much appreciated.
> ...
Possibly. It's causing issues on #15513 as well... I'll try to fix it.
k0kubun (Takashi Kokubun)
10:42 AM Bug #15522: TestJIT#test_compile_insn_local fails on aarch64 RHEL7
I suppose "-nostartfiles -nodefaultlibs -nostdlib" are the reason that libgcc isn't linked into the _ruby_mjit_p111u0.so
__multi3 is provided in /lib64/libgcc_s-4.8.5-20150702.so.1
I guess -nodefaultlibs should be omitted and/or -s...
sharkcz (Dan Horák)
10:02 AM Bug #15522 (Open): TestJIT#test_compile_insn_local fails on aarch64 RHEL7
So here is the output:
~~~
$ ruby --disable-gems --jit-verbose=2 --jit-min-calls=1 --jit-debug --jit-wait --jit-save-temps -e "
begin
def foo
a = 0
[1, 2].each do |i|
a += i
[3, 4]....
vo.x (Vit Ondruch)
04:04 PM Feature #14344: refine at class level
shevegen (Robert A. Heiler) wrote:
> I think that:
> ...
On the other hand, it's closer to what we have to write now (`using(Module.new do`) and it doesn't have any additional constraints like being at the top level of class/module con...
palkan (Vladimir Dementyev)
11:05 AM Feature #14344: refine at class level
I think that:
using do
refine Array do
Is not good. It looks very strange to me.
The other variants, such as the original one:
class Test
refine String do
or just toplevel:
refine String do
...
shevegen (Robert A. Heiler)
02:33 PM Bug #15460 (Assigned): Behaviour of String#setbyte changed
I had a chance this week to ask matz if he wants to allow bigger inputs or not for those methods. He answered yes. He prefers mod 256 behaviour for larger numbers. I will fix them again. shyouhei (Shyouhei Urabe)
02:32 PM Bug #15525: Complex(nil, exception: false) and Rational(nil, exception: false) raises an error
Found by specs added in https://github.com/ruby/spec/pull/648 Eregon (Benoit Daloze)
02:16 PM Bug #15525 (Closed): Complex(nil, exception: false) and Rational(nil, exception: false) raises an error
Each line below raises an error
~~~
Complex(:sym, 0, exception: false) # TypeError (not a real)
Complex(nil, exception: false) # TypeError (can't convert nil into Complex)
Complex(0, nil, exception: false) # TypeError (can't convert ...
ibylich (Ilya Bylich)
11:13 AM Feature #15523: Let `Range#begin` and `Range#end` be aliases of Range#first and Range#last
I have no particular pro or con opinion towards this proposal per se; however within
the two suggestions made, I think having these as aliases would be better than
obsolete them. People could then decide to use either variant if they w...
shevegen (Robert A. Heiler)
04:51 AM Feature #15523: Let `Range#begin` and `Range#end` be aliases of Range#first and Range#last
Done. kou (Kouhei Sutou)
04:45 AM Feature #15523: Let `Range#begin` and `Range#end` be aliases of Range#first and Range#last
Sorry, please change this to a feature request instead of a bug report. sawa (Tsuyoshi Sawada)
04:44 AM Feature #15523 (Open): Let `Range#begin` and `Range#end` be aliases of Range#first and Range#last
My understanding is that `Range#begin` and `Range#end`'s features are just subsets of `Range#first` and `Range#last`, respectively. And since they are slightly confusing with the keywords `begin` and `end`, I propose to either:
* Let ...
sawa (Tsuyoshi Sawada)
09:36 AM Revision 0a5655a5 (git): Drop whole examples
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66793 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
08:53 AM Bug #15524 (Rejected): Unicode not Supported in Class Names
It is supported since 2.6, [Feature #13770]. nobu (Nobuyoshi Nakada)
08:31 AM Bug #15524 (Rejected): Unicode not Supported in Class Names
The details are at the attached file. martin_vahi (Martin Vahi)
08:46 AM Bug #15493 (Feedback): Seg Fault on 'vagrant up' Fedora29 intel
You have not provided enough information about your environment. Could you please provide output of the following commands?
~~~
$ rpm -q ruby
$ rpm -q rubygem-nokogiri
~~~
Also, your backtrace has no debug information. You shoul...
vo.x (Vit Ondruch)
08:44 AM Revision 8197abf9 (git): Fix r66791
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66792 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
07:50 AM Revision d03771d8 (git): Fix r66772
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66791 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
04:58 AM Revision e4f46eab (git): Fix make-snapshot for trunk
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66790 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
02:32 AM Bug #15468 (Closed): Net::Protocol::BufferedIO#write raises NoMethodError when sending large multi-byte string
nobu (Nobuyoshi Nakada)
01:49 AM Feature #14145: Proposal: Better Method#inspect
Eregon (Benoit Daloze) wrote:
> ko1 (Koichi Sasada) wrote:
> ...
+1. I'm using `#source_location` like `p method(:foo).source_location` sometimes to know the definition. If "Method#inspect" shows this information, it will help *me*.
...
ko1 (Koichi Sasada)
01:18 AM Revision bdc36b36 (git): Ensure to terminate the child
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66789 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)

01/10/2019

11:40 PM Bug #15520: [patch] configure should refuse to build with jemalloc when headers are missing
Thanks for the quick response! Could you backport this to the active backport branches, too? mistydemeo (Misty De Meo)
02:44 PM Bug #15520 (Closed): [patch] configure should refuse to build with jemalloc when headers are missing
Applied in changeset trunk|r66779.
----------
configure: refuse to build with jemalloc when header is missing
[ruby-core:90964] [Bug #15520]
Freom: Misty De Meo <mistydemeo@github.com>
nobu (Nobuyoshi Nakada)
07:53 AM Bug #15520: [patch] configure should refuse to build with jemalloc when headers are missing
> The actual build is unlikely to succeed in this case since the functions won't be defined.
Agreed, makes sense to me. I remember that I may run into similar situations every now
and then when I e. g. wish to upgrade some program m...
shevegen (Robert A. Heiler)
04:03 AM Bug #15520 (Closed): [patch] configure should refuse to build with jemalloc when headers are missing
When the `--with-jemalloc` option is passed, the configure script will correctly fail with an error if the library is missing. However, if the library is present and headers are missing, configure will succeed and allow the build to proc... mistydemeo (Misty De Meo)
11:07 PM Feature #6240 (Closed): Enumerable#drop with negative argument
knu (Akinori MUSHA) wrote:
> Using an existing feature, `[1,2,3,4,5].lazy.drop(-n)` could be written as `[1,2,3,4,5].each_cons(n+1).lazy.map(&:first)`.
> ...
That is clever.
I'll close this request, since it's not clear how frequent t...
marcandre (Marc-Andre Lafortune)
08:30 AM Feature #6240: Enumerable#drop with negative argument
Using an existing feature, `[1,2,3,4,5].lazy.drop(-n)` could be written as `[1,2,3,4,5].each_cons(n+1).lazy.map(&:first)`.
Enumerable#each_cons does not use a circular buffer, though. (It currently uses push & shift)
knu (Akinori MUSHA)
08:23 AM Feature #6240 (Feedback): Enumerable#drop with negative argument
usa (Usaku NAKAMURA)
09:53 PM Misc #15462: DevelopersMeeting20190110Japan
* [Feature #14344] refine at class level
* there are some proposals for shorter refinements syntax; want to hear commiters opinions (which one is better and good to be implemented)
palkan (Vladimir Dementyev)
07:50 AM Misc #15462: DevelopersMeeting20190110Japan
* [Feature #15477] Proc#arity returns -1 for composed lambda Procs of known arguments
* May I commit?
mame (Yusuke Endoh)
04:31 AM Misc #15462: DevelopersMeeting20190110Japan
* [Feature #11473] Immutable String literal in Ruby 3
* As I recall, matz said that this has been cancelled at the old developers' meeting. I'd like to confirm.
mame (Yusuke Endoh)
05:28 PM Revision d95b13ea (git): Update refinements docs
Co-Authored-By: Vladimir Dementyev <dementiev.vm@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66788 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlovemaking (Aaron Patterson)
05:00 PM Bug #15468: Net::Protocol::BufferedIO#write raises NoMethodError when sending large multi-byte string
Can we get this issue closed and the with right backport field values? rafaelfranca (Rafael França)
04:43 PM Misc #15514: Add documentation for implicit array decomposition
If that's covered (and I agree it should be) it's also worth showing a case where they are not optional:
```
def baz
yield [1, 2], 3
end
baz { |a, b, c| p a: a, b: b, c: c }
#=> {:a=>[1, 2], :b=>3, :c=>nil}
baz { |(a, b), c|...
lugray (Lisa Ugray)
03:42 PM Revision dd67af48 (git): addr2line.c: fix -Wextra-semi
and ignore only -Wgnu-empty-initializer.
https://travis-ci.org/ruby/ruby/jobs/477867392
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66787 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
03:02 PM Revision d74fc1b1 (git): addr2line.c: do not suppress -Wpedantic
because it was for "-assi -Wpedantic" on Travis, but we changed the
Travis build to "-std=c99 -Wpedantic".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66786 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
03:02 PM Bug #15479: Array#reject! modifies literal Array
ruby_2_5 r66784 merged revision(s) 66756. nagachika (Tomoyuki Chikanaga)
03:02 PM Revision 06c98773 (git): * 2019-01-11
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@66785 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:02 PM Revision 5b23824b (git): merge revision(s) 66756: [Backport #15479]
Mark array as "going to be modified" in `Array#reject!`
Before this patch, if `reject!` is called on a shared array it can
mutate the shared array rather than a copy. This patch marks the array
as "going to be m...
nagachika (Tomoyuki Chikanaga)
03:00 PM Revision 1e19973d (git): * 2019-01-11
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66783 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:00 PM Revision 299e9cd9 (git): revert r66768 for Ruby 2.7 due to Misc#15347
It's safer to backport r66768 to 2.6 branch, but for 2.7 it's not
needed anymore.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66782 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
02:56 PM Bug #15522 (Feedback): TestJIT#test_compile_insn_local fails on aarch64 RHEL7
Thank you. I'll wait for that first.
Also having logs with --jit-verbose=2 version of https://bugs.ruby-lang.org/issues/15522#note-3 would be helpful.
P.S. The output format is changed in r66781.
k0kubun (Takashi Kokubun)
02:06 PM Bug #15522: TestJIT#test_compile_insn_local fails on aarch64 RHEL7
k0kubun (Takashi Kokubun) wrote:
> > Also, it would be nice if the JIT output used different markup, which does not collide with Redmine markup :/
> ...
Thx
> > This should be the C code (although generated on my x86_64, because I d...
vo.x (Vit Ondruch)
12:39 PM Bug #15522: TestJIT#test_compile_insn_local fails on aarch64 RHEL7
> Also, it would be nice if the JIT output used different markup, which does not collide with Redmine markup :/
Yeah. I'll change that later.
> ...
How did you get the output in the ticket description? If possible, I want you to up...
k0kubun (Takashi Kokubun)
11:48 AM Bug #15522: TestJIT#test_compile_insn_local fails on aarch64 RHEL7
This should be the C code (although generated on my x86_64, because I don't have aarch64 readily available). vo.x (Vit Ondruch)
11:36 AM Bug #15522: TestJIT#test_compile_insn_local fails on aarch64 RHEL7
The smaller reproducer probably is:
~~~
$ ruby --disable-gems --jit-verbose=10 --jit-min-calls=1 --jit-debug --jit-wait --jit-save-temps -e "
begin
def foo
a = 0
[1, 2].each do |i|
a += i
...
vo.x (Vit Ondruch)
11:08 AM Bug #15522: TestJIT#test_compile_insn_local fails on aarch64 RHEL7
IMHO either something calls __multi3 and doesn't link to libgcc or gcc emits call to __multi3 and it's not implemented in libgcc.
Would be useful to see /tmp/_ruby_mjit_p20163u1.c source and the command line used to compile/link it.
sharkcz (Dan Horák)
10:46 AM Bug #15522: TestJIT#test_compile_insn_local fails on aarch64 RHEL7
Also, it would be nice if the JIT output used different markup, which does not collide with Redmine markup :/ vo.x (Vit Ondruch)
10:44 AM Bug #15522 (Closed): TestJIT#test_compile_insn_local fails on aarch64 RHEL7
Trying to build Ruby 2.6 on RHEL7, I observe the following test failure on RHEL7, but just on aarch64. The other platforms pass just fine:
~~~
1) Failure:
TestJIT#test_compile_insn_local [/builddir/build/BUILD/ruby-2.6.0/test/ruby...
vo.x (Vit Ondruch)
02:55 PM Revision d31cbd4f (git): test_jit.rb: change format of test error output
to avoid breaking redmine quote like
https://bugs.ruby-lang.org/issues/15522
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66781 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
02:47 PM Bug #14880: Time#localtime doesn't always seem to respect TZ
ruby_2_5 r66780 merged revision(s) 63823,63839. nagachika (Tomoyuki Chikanaga)
02:46 PM Bug #14890: test/ruby/test_time_tz.rb - Skip on Windows (mswin|mingw)?
ruby_2_5 r66780 merged revision(s) 63823,63839. nagachika (Tomoyuki Chikanaga)
02:46 PM Revision 4f0899d4 (git): merge revision(s) 63823,63839: [Backport #14890]
time.c: [DOC] Time#localtime
* time.c: state that Time#localtime does nothing when nothing
changes. [ruby-core:87675] [Bug #14880]
skip test_localtime_zone if force_tz_test is false
For example Solar...
nagachika (Tomoyuki Chikanaga)
02:44 PM Revision bb44d9ec (git): configure: refuse to build with jemalloc when header is missing
[ruby-core:90964] [Bug #15520]
Freom: Misty De Meo <mistydemeo@github.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66779 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:40 PM Feature #6470: Make attr_accessor return the list of generated method
> There's no use for private attr_reader, attr_writer, etc.
The intended usage is to ease future refactorings. If you always start with a method then later you can easily redefine just the method.
Initial code
~~~
class Somet...
rupert (Robert Pankowecki)
11:26 AM Feature #6470: Make attr_accessor return the list of generated method
In general I support this request, but in this proposed use-case ...
> ```ruby
> ...
`foo=` without `@` or `self.` will assign a local variable. You'd have to change it to `foo=(...)` or `send :foo=, ...` anyway, no?
phluid61 (Matthew Kerwin)
09:15 AM Feature #6470 (Open): Make attr_accessor return the list of generated method
@matz There are use cases, see https://bugs.ruby-lang.org/issues/11539 and https://bugs.ruby-lang.org/issues/11541.
Also, one case which has been IIRC frequently requested (mentioned just above in this issue, https://bugs.ruby-lang.or...
Eregon (Benoit Daloze)
08:28 AM Feature #6470 (Rejected): Make attr_accessor return the list of generated method
There's no use for `private` attr_reader, attr_writer, etc.
And `protected` is not encouraged enough for new features. So I reject this.
Matz.
matz (Yukihiro Matsumoto)
02:31 PM Revision 56bf732a (git): mjit.c: use boolean type for boolean variables
and functions to clarify the intention and make sure it's not used in a
surprising way (like using 2, 3, ... other than 0, 1 even while it seems
to be a boolean).
This is a retry of r66775. It included some typos...
git-svn-id: svn+ssh...
k0kubun (Takashi Kokubun)
02:18 PM Bug #15362: [PATCH] Avoid GCing dead stack after switching away from a fiber
ruby_2_5 r66777 merged revision(s) 66111. nagachika (Tomoyuki Chikanaga)
02:18 PM Bug #14561: Consistent 2.5.0 seg fault in GC, related to accessing an enumerator in a thread
ruby_2_5 r66777 merged revision(s) 66111. nagachika (Tomoyuki Chikanaga)
02:18 PM Revision 0e0d0c47 (git): merge revision(s) 66111: [Backport #14561]
Avoid GCing dead stack after switching away from a fiber
Fixes <https://bugs.ruby-lang.org/issues/14561> and discussed
<https://bugs.ruby-lang.org/issues/15362>.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby...
nagachika (Tomoyuki Chikanaga)
01:51 PM Feature #6256 (Feedback): Slightly improve ruby_qsort performance
A volunteer is welcome: update the patch for trunk, test, perform re-experiment, etc. mame (Yusuke Endoh)
01:29 PM Revision efd99b53 (git): Revert "mjit.c: use boolean type for boolean variables"
This reverts commit bb1a1aeab0f2a5fe437c89b841a887ba56653453.
We hit something on ci.rvm.jp, reverting until investigation is done.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66776 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
01:21 PM Revision bb1a1aea (git): mjit.c: use boolean type for boolean variables
and functions to clarify the intention and make sure it's not used in a
surprising way (like using 2, 3, ... other than 0, 1 even while it seems
to be a boolean).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66775 b2dd03c8-39d4-4d8...
k0kubun (Takashi Kokubun)
12:41 PM Revision 5da9bd0e (git): test/ruby/test_method.rb: Remove unreachable call
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66774 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
12:10 PM Bug #15499: Breaking behavior on ruby 2.6: rb_thread_call_without_gvl doesn't invoke unblock_function when used on the main thread
> Patrik: can you try r66708? (git 9e66910b3bd85de32e95cf019ed285a36aecfd9e)
Eric: Sorry, I should have mentioned it in my comment. I also tried r66716 (`ruby 2.7.0dev (2019-01-05 trunk 66716) [x86_64-darwin18]`), [which can be seen a...
dentarg (Patrik Ragnarsson)
10:14 AM Feature #14444: MatchData: alias for #[]
Ugh. I feel ashamed, honestly :)
Never thought about using `.slice` this way, somehow! It is definitely cleaner.
Can be closed.
zverok (Victor Shepelev)
04:29 AM Feature #14444 (Feedback): MatchData: alias for #[]
Following is better
```ruby
next_page = response.dig('meta', 'pagination', 'next')&.slice(/&page=(\d+)/, 1)
```
naruse (Yui NARUSE)
08:56 AM Bug #15500 (Assigned): Behavior of require method in 2.5 is different from 2.4 and 2.6
hsbt (Hiroshi SHIBATA)
08:28 AM Feature #6198 (Rejected): public/protected/private with attr_*
There's no use for `private` attr_reader, attr_writer, etc.
And `protected` is not encouraged enough for new features. So I reject this.
Matz.
matz (Yukihiro Matsumoto)
08:22 AM Revision bfb684c0 (git): NEWS: announce C99 requirement [ci skip]
[Misc #15347]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66773 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
08:19 AM Revision 9f1fb0a1 (git): proc.c: proc without block
* proc.c (proc_new): promoted lambda/proc/Proc.new with no block
in a method called with a block to a warning/error.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66772 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
08:16 AM Misc #15347: Require C99
For developer's reference, I created <s>https://bugs.ruby-lang.org/projects/ruby-trunk/wiki/C99</s> https://github.com/ruby/ruby/wiki/C99-Usage-Guidelines and linked it from <s>https://bugs.ruby-lang.org/projects/ruby/wiki/DeveloperHowto... k0kubun (Takashi Kokubun)
08:04 AM Misc #15347 (Closed): Require C99
Applied in changeset trunk|r66771.
----------
configure.ac: Require C99
We already added AC_PROG_CC_C99 in r66605.
This commit stops warning C99 features.
[Misc #15347] [close https://github.com/ruby/ruby/pull/2064]
k0kubun (Takashi Kokubun)
07:55 AM Misc #15347: Require C99
This is accepted for Ruby 2.7 at DevelopersMeeting20190110Japan [Misc #15462]. I'll take following actions:
* Disable change C90 checking on Travis to C99 https://github.com/ruby/ruby/pull/2064
* Fix configure as needed
* -std=c99...
k0kubun (Takashi Kokubun)
08:16 AM Feature #6118 (Feedback): Hash#keys_of(values), returns related keys of given values
I forgot use case.
use case is welcome
naruse (Yui NARUSE)
08:11 AM Misc #15486: Default gems README.md
duerst (Martin Dürst) wrote:
> But I still have a very fundamental question: Why isn't this information available by introspection, without having to go over the net to a Web API? Ruby itself should not have any problem providing this...
duerst (Martin Dürst)
06:10 AM Misc #15486: Default gems README.md
Hello Jan,
> You are right, there is no guarantee and I agree with your thoughts. Nevertheless, I've also put the raw data on GitHub, so it does not depend on me solely: https://github.com/janlelis/stdgems. If there is an interest in ...
duerst (Martin Dürst)
08:04 AM Revision ec336fb4 (git): configure.ac: Require C99
We already added AC_PROG_CC_C99 in r66605.
This commit stops warning C99 features.
[Misc #15347] [close https://github.com/ruby/ruby/pull/2064]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66771 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
08:04 AM Feature #15477: Proc#arity returns -1 for composed lambda Procs of known arguments
Yes, please.
Matz.
matz (Yukihiro Matsumoto)
07:59 AM Feature #15445: Reject '.123' in Float() method
duerst (Martin Dürst) wrote:
> I seem to remember from the book (http://exceptionalruby.com/) by Avdi Grimm that in general, methods that have the same name as classes are more tolerant than other constructors. If I remember correctly, ...
duerst (Martin Dürst)
07:59 AM Revision dfdd0e1d (git): .travis.yml: allow C99 on pedanticism buid
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66770 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
07:19 AM Feature #15456: Adopt some kind of consistent versioning mechanism
ioquatix (Samuel Williams) wrote:
> > But dropping old rubies will happen every year and it can affect gems to remove legacy code. If it is considered as breaking changes as you said, it will cause major bump and it's false positive for...
naruse (Yui NARUSE)
07:10 AM Feature #2250 (Rejected): IO::for_fd() objects' finalization dangerously closes underlying fds
We discussed this issue today's Ruby developer meeting.
Our conclusion is that changing the default behavior of IO.for_fd is
too incompatible. It changes good working program to FD-leaking program.
It is another big issue, especial...
akr (Akira Tanaka)
06:57 AM Bug #15416 (Closed): 配列リテラル内の引数を伴う括弧なしのメソッド呼び出しで syntax error
まつもと ゆきひろです。
一貫性という観点からは、両方共括弧なしでは呼べないという風にしたいのですが、どうやら互換性の問題が大きいので、とても直せそうにありません。ということで、苦肉の策ですが、現状維持とします。
調べると2006年まで両方とも「括弧を省略するな」という警告を出してました。が、リテラル内は2006年に文法エラーにできましたが、引数の方は、2007年にあきらめてしまって警告もなくしてしまってたようです。犯人は私ですがまったく覚えていなかった。禁...
matz (Yukihiro Matsumoto)
06:57 AM Bug #15521: encoding is missed when using `CSV.generate`
Thank you.
I used `ruby/csv@master`, I confirmed this is fixed
sue445 (Go Sueyoshi)
06:34 AM Bug #15521 (Closed): encoding is missed when using `CSV.generate`
Thanks for your report.
This has been fixed at master: https://github.com/ruby/csv/issues/62
I'll release a new version in a few weeks. Could you try the release (or master) again?
kou (Kouhei Sutou)
06:20 AM Bug #15521 (Closed): encoding is missed when using `CSV.generate`
# Sample code
~~~ ruby
require "csv"
rows = [
["a", "b", "c", "d", "e"],
["あ", "い", "う", "え", "お"],
]
str = CSV.generate do |csv|
rows.each do |row|
csv << row
end
end
p str
p str.encoding
~~~
# Expec...
sue445 (Go Sueyoshi)
06:01 AM Bug #15428 (Closed): Refactor Proc#>> and #<<
Applied in changeset trunk|r66769.
----------
proc.c: check if callable
* proc.c: check the argument at composition, expect a Proc,
Method, or callable object. [ruby-core:90591] [Bug #15428]
nobu (Nobuyoshi Nakada)
06:01 AM Revision 33a75edd (git): proc.c: check if callable
* proc.c: check the argument at composition, expect a Proc,
Method, or callable object. [ruby-core:90591] [Bug #15428]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66769 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
05:49 AM Feature #11473 (Closed): Immutable String literal in Ruby 3
I consider this for years. I REALLY like the idea but I am sure introducing this could cause HUGE compatibility issue, even bigger than Ruby 1.9. So I officially abandon making frozen-string-literals default (for Ruby3).
This does not...
matz (Yukihiro Matsumoto)
05:37 AM Feature #15483 (Rejected): Proc or Method combination with Symbol
I feel the expression `ary.map(&(:to_i << :chr))` is far less readable than `ary.map{|x|x.to_i.chr}`.
And the latter is faster and can take arguments NOW e.g. `ary.map{|x|x.to_i(16).chr}`.
Given these superiorities, this proposal doe...
matz (Yukihiro Matsumoto)
05:02 AM Feature #14145: Proposal: Better Method#inspect
I agree with the concept of showing more information by `Method#inspect`. Patch welcome.
Matz.

matz (Yukihiro Matsumoto)
01:05 AM Bug #15519: addr2line compile error on RHEL7
If it doesn't work, please upload the full command logs of ./configure and make (on the slightly older trunk, r66767 as said above), or at least configure flags and CFLAGS if you don't want to show a full output. k0kubun (Takashi Kokubun)
12:51 AM Bug #15519: addr2line compile error on RHEL7
I agree r66768 should be backported to 2.6 to fix it safely. But at the same time,
> It should be fixed IMO, unless #15347 is accepted.
I think the build error should be fixed regardless of #15347 acceptance. Due to r66605, I belie...
k0kubun (Takashi Kokubun)
12:36 AM Bug #15519 (Closed): addr2line compile error on RHEL7
Applied in changeset trunk|r66768.
----------
Get rid of C99 feature for now [ruby-core:90949] [Bug #15519]
nobu (Nobuyoshi Nakada)
12:37 AM Bug #15399: [PATCH] insns.def (duparray, duphash): add dtrace hooks
I filled Backport field.
It's up to the 2.6 maintainer (not me now, I think) but this could be a bugfix rather than a feature change.
nagachika (Tomoyuki Chikanaga)
12:36 AM Revision 671ef4e9 (git): Get rid of C99 feature for now [ruby-core:90949] [Bug #15519]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66768 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
12:32 AM Bug #7492 (Closed): Segmentation fault at DL::TestDL#test_call_double on x64 Windows 8
These tests were removed in r48217, so I'm closing this. tenderlovemaking (Aaron Patterson)
12:26 AM Feature #11140: Allow rubygems' `require` to handle `autoload` calls
Is this still failing? I don't see it on RubyCI.org tenderlovemaking (Aaron Patterson)
12:23 AM Bug #13286 (Closed): Segfault when using rb_debug_inspector_open / rb_debug_inspector_frame_binding_get with Fiddle, but not when directly from C extension
Fixed here: https://github.com/ruby/fiddle/commit/0fc697bbc5c55c5f45ea4f67a6279fba38d2d514 tenderlovemaking (Aaron Patterson)

01/09/2019

11:04 PM Bug #15399 (Closed): [PATCH] insns.def (duparray, duphash): add dtrace hooks
Applied, thank you. tenderlovemaking (Aaron Patterson)
11:04 PM Revision 5577a877 (git): insns.def (duparray, duphash): add dtrace hooks
They are considered Array and Hash creation events, so
allow dtrace (and systemtap) to track those creations.
Co-Authored-By: Eric Wong <e@80x24.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66767 b2dd03c8-39d4-4d8f-98ff-823fe...
tenderlovemaking (Aaron Patterson)
10:38 PM Bug #9639 (Rejected): libyaml not found, rubygems not functional on freebsd with ruby 2.1.0
Closing because there is no feedback tenderlovemaking (Aaron Patterson)
10:37 PM Bug #13115 (Closed): `YAML.dump` outputs deperecated message even with delegated object
This has been fixed since Psych 3.0.0 https://github.com/ruby/psych/commit/712a65a53f3c15105cd86e8ad3ee3c779050ada4 tenderlovemaking (Aaron Patterson)
10:32 PM Bug #9827 (Closed): Segmentation fault when running `gem`
Closing as I think this is a dup of Bug #9933 (and already fixed) tenderlovemaking (Aaron Patterson)
10:25 PM Bug #6312 (Closed): Psych needlessly noisy parsing string node starting with number-ish string
I think all these warnings are fixed, so I'm closing this now tenderlovemaking (Aaron Patterson)
09:54 PM Bug #8303 (Closed): YAML does not persist Exception#backtrace
This is fixed here: https://github.com/ruby/psych/pull/382 tenderlovemaking (Aaron Patterson)
08:59 PM Bug #7568 (Closed): Yaml fails to encode zero date string.
tenderlovemaking (Aaron Patterson)
07:13 PM Misc #15462: DevelopersMeeting20190110Japan
* [Feature #15456] Adopt some kind of consistent versioning mechanism
* More uniformity within the ecosystem would be nice.
alanwu (Alan Wu)
01:30 PM Misc #15462: DevelopersMeeting20190110Japan
* [Bug #15500] Behavior of require method in 2.5 is different from 2.4 and 2.6
* Is this bug or not?
mrkn (Kenta Murata)
01:52 AM Misc #15462: DevelopersMeeting20190110Japan
* [Feature #15445] Reject '.123' in Float() method
* I want to know Matz's opinion.
mrkn (Kenta Murata)
07:11 PM Revision 5f17fa6c (git): * 2019-01-10
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66766 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
07:11 PM Revision e3dbe84e (git): add setter of iter_lev.
* hash.c: add special setter function (inc and dec).
* internal.h: constify RHash::iter_leve.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66765 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
05:46 PM Feature #15408: Deprecate ObjectSpace._id2ref
@headius Would you like to start the deprecation of `ObjectSpace._id2ref` since you started this issue? Eregon (Benoit Daloze)
04:16 PM Bug #15519 (Closed): addr2line compile error on RHEL7
I am observing following compilation:
~~~
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -mtune=generic -fPIC -m64 -D_FORTIFY_SOURCE=2 -fstack-prot...
vo.x (Vit Ondruch)
02:38 PM Misc #15486: Default gems README.md
Thank you for the feedback. In the GH issue the general opinion is to have a single README file with all the info.
duerst (Martin Dürst) wrote:
>
> ...
This is correct, although it might not be overly complex. If I understood hsbt c...
rbjl (Jan Lelis)
02:07 PM Bug #15502: Expired certificates in Ruby 2.6.0 test suite
It was backported into 2.5 branch by r66689. vo.x (Vit Ondruch)
02:04 PM Bug #15501 (Closed): private_methods(false) changes behavior based on singleton class allocation
Applied in changeset trunk|r66764.
----------
class.c: refactor class_instance_method_list
* class.c (class_instance_method_list): gather singleton and
extended methods first separately from ancestors.
[ruby-core:90872] [Bug #15501]
nobu (Nobuyoshi Nakada)
02:04 PM Revision 140f8b94 (git): class.c: refactor class_instance_method_list
* class.c (class_instance_method_list): gather singleton and
extended methods first separately from ancestors.
[ruby-core:90872] [Bug #15501]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66764 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:58 PM Revision 347f3f30 (git): time.c: update error message for invalid utc_offset
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66763 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
01:58 PM Revision 78d6e337 (git): Fix styles [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66762 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
12:55 PM Revision df0faba1 (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66761 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:55 PM Revision 730f2886 (git): Follow behaviour of IO#ungetbyte
see r65802 and [Bug #14359]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66760 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
znz (Kazuhiro NISHIYAMA)
12:37 PM Feature #15483: Proc or Method combination with Symbol
I think it will not work in the following cases.
```ruby
# NG: Error undefined method `call' for :chr:Symbol (NoMethodError)
p (30.method(:+) >> :chr).call 42
h = { Alice: 30, Bob: 60, Cris: 90 }
# OK
p (:to_sym >> h).call ...
osyo (manga osyo)
10:27 AM Feature #15483: Proc or Method combination with Symbol
I made [function-composite](https://rubygems.org/gems/function-composite) gem, as a PoC. nobu (Nobuyoshi Nakada)
07:18 AM Feature #15483: Proc or Method combination with Symbol
```ruby
# symbol/functionalized.rb
module Symbol::Functionalized
refine(Symbol) do
def call(*args, &block)
to_proc.call(*args, &block)
end
def <<(other = (b = true), &block)
to_proc << (b ? block : oth...
nobu (Nobuyoshi Nakada)
06:48 AM Feature #15483: Proc or Method combination with Symbol
hi, nobu :)
> 引用
Why not using refinements?
It is example code.
Also, `Symbol#call` is not called in `Proc#<<`.
```ruby
# Error: undefined method `call' for :chr:Symbol (NoMethodError)
p %w{72 101 108 108 111}.map(&proc { |s...
osyo (manga osyo)
05:40 AM Feature #15483: Proc or Method combination with Symbol
Why not using refinements?
```ruby
# symbol/functionalized.rb
module Symbol::Functionalized
refine(Symbol) do
def call(*args, &block)
to_proc.call(*args, &block)
end
def <<(other = (b = true), &block)
...
nobu (Nobuyoshi Nakada)
10:15 AM Feature #14594: Rethink yield_self's name
I think the word should be `hit`.
Example:
~~~ ruby
construct_url.
hit(&Faraday.method(:get)).body.
hit(&JSON.method(:parse)).dig('object', 'id').
hit { |id| id || '<undefined>' }.
hit { |id| "server:#{id}" }
~~~
WaKeMaTTa (Mohamed Ziata)
09:34 AM Bug #15518: good old Infinite range notation behavior
At first, it isn't intentional behavior change. I should fix it, but I need to consider what is the correct behavior.
Ruby 2.5's behavior is given below:
```
$ RBENV_VERSION=2.5 irb --simple-prompt
>> (1 .. 10).first(5)
=> [1, 2...
mrkn (Kenta Murata)
08:34 AM Bug #15518 (Assigned): good old Infinite range notation behavior
mrkn (Kenta Murata)
07:19 AM Bug #15518: good old Infinite range notation behavior
With finite ranges, the class of the elements in the return value seems to reflect the class of the `step` parameter as shown below (although, I am not sure why the one with rational has `1` instead of `(1/1)`. A bug, perhaps?):
```ru...
sawa (Tsuyoshi Sawada)
05:44 AM Bug #15518 (Closed): good old Infinite range notation behavior
Ruby 2.5.3's behavior
~~~
# without step, it produces integer sequence
(1..Float::INFINITY).first(10) #=> [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
# with step, it produces floats instead of integers
(1..Float::INFINITY).step(1).first(10) #...
sakuro (Sakuro OZAWA)
08:43 AM Revision bc27f878 (git): Remove duplicate macro definition
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66759 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
07:55 AM Bug #15465: Tests failed on i386-cygwin
In case of `make btest`, test_massign.rb and test_thread.rb succeeded.
The cause of failures is environment variable `RUBY_FIBER_MACHINE_STACK_SIZE=1` in tools/runruby.rb.
The workaround (not beautiful) is as follows:
```diff
...
fd0 (Daisuke Fujimura)
07:05 AM Revision fc9e0302 (git): complex.c: optimize zero check for Float
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66758 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Kenta Murata

01/08/2019

07:23 PM Bug #15479: Array#reject! modifies literal Array
r66756 should be backported, so I updated the backport field. tenderlovemaking (Aaron Patterson)
07:22 PM Bug #15479 (Closed): Array#reject! modifies literal Array
Applied in changeset trunk|r66756.
----------
Mark array as "going to be modified" in `Array#reject!`
Before this patch, if `reject!` is called on a shared array it can
mutate the shared array rather than a copy. This patch marks the ...
tenderlovemaking (Aaron Patterson)
05:24 PM Bug #15479: Array#reject! modifies literal Array
It seems like this is also a bug in Ruby 2.5 and Ruby 2.4. If you modify the test program a little bit like this:
~~~ ruby
def foo
b = [1, 2, 3, 4]
3.times do
a = b.dup
puts "initial: #{a}"
begin
a.reject...
tenderlovemaking (Aaron Patterson)
07:22 PM Revision f7c0abea (git): * 2019-01-09
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66757 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
07:22 PM Revision 79c150f8 (git): Mark array as "going to be modified" in `Array#reject!`
Before this patch, if `reject!` is called on a shared array it can
mutate the shared array rather than a copy. This patch marks the array
as "going to be modified" so that the shared source array isn't
mutated.
[Bug #15479] [ruby-core:...
tenderlovemaking (Aaron Patterson)
06:22 PM Bug #15499: Breaking behavior on ruby 2.6: rb_thread_call_without_gvl doesn't invoke unblock_function when used on the main thread
> Issue #15499 has been updated by dentarg (Patrik Ragnarsson).

Patrik: can you try r66708? (git 9e66910b3bd85de32e95cf019ed285a36aecfd9e)
It was committed before your comment.

Sorry, I barely have time for Ruby, anymore.
normalperson (Eric Wong)
04:13 PM Feature #15517 (Closed): Net::HTTP not recognizing valid UTF-8
I created a case at https://github.com/Cohen-Carlisle/utf8app that shows Net::HTTP labeling a response body as ASCII-8BIT encoded because it contains a non-ascii character (specifically, the double prime symbol: ″), but recognizing ascii... cohen (Cohen Carlisle)
02:47 PM Feature #15483: Proc or Method combination with Symbol
I am thinking like this.
NOTE: Here we define it as follows.
* functional object
* defined `#call` (and `#<<` `#>>`) object
* e.g. `Proc` `Method`
* blockable object
* defined `#to_proc` object
* e.g. `Symbol` `Hash`
...
osyo (manga osyo)
12:30 PM Bug #15516: Ruby 2.6: `gem build` requires files located in gemspec directory
Reported upstream:
https://github.com/rubygems/rubygems/issues/2587
vo.x (Vit Ondruch)
12:20 PM Bug #15516: Ruby 2.6: `gem build` requires files located in gemspec directory
This is the original PR changing the behavior
https://github.com/rubygems/rubygems/pull/2204
I cannot imagine features like this are accepted without any comparison with other build systems etc.
vo.x (Vit Ondruch)
07:36 AM Bug #15516: Ruby 2.6: `gem build` requires files located in gemspec directory
https://github.com/rubygems/rubygems/issues/2580 is the same issue maybe. hsbt (Hiroshi SHIBATA)
05:02 AM Bug #15516: Ruby 2.6: `gem build` requires files located in gemspec directory
Can you file this into https://github.com/rubygems/rubygems/issues? hsbt (Hiroshi SHIBATA)
12:18 PM Bug #15513 (Assigned): MJIT compilation terminated due to -Wfatal-errors on GCC 7.3.0
お二人ともご強力ありがとうございます。
> Dockerhub の gentoo/stage3-amd64:20190106 で再現しました。
> ...
リンカ向けに渡していたフラグが(少なくともそのGentoo Linuxの環境では)cc1に渡るフラグにも影響を与えるようになっていたのですね。なるほど。
そのDockerイメージを利用し、現時点での情報量で何らか対応できそうなので、後で直しておきます。
k0kubun (Takashi Kokubun)
12:07 PM Bug #15513: MJIT compilation terminated due to -Wfatal-errors on GCC 7.3.0
Dockerhub の gentoo/stage3-amd64:20190106 で再現しました。
Gentoo Linux では独自に https://gitweb.gentoo.org/proj/gcc-patches.git/tree/7.3.0/gentoo/13_all_default-ssp-fix.patch のようなパッチを当てていて、-nodefaultlibs オプションをつけると `-fno-stack-protector` オプションもあわせて...
wanabe (_ wanabe)
10:53 AM Revision e9dc6f60 (git): Check by #name [ruby-core:90853] [Bug #15497]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66755 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
09:08 AM Bug #15497 (Closed): Encoding of error messages should not depend on the locale encoding
Applied in changeset trunk|r66753.
----------
Defer escaping control char in error messages
* eval_error.c (print_errinfo): defer escaping control char in
error messages until writing to stderr, instead of quoting at
building the m...
nobu (Nobuyoshi Nakada)
09:08 AM Revision 497075b3 (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66754 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
09:08 AM Revision 50784a0a (git): Defer escaping control char in error messages
* eval_error.c (print_errinfo): defer escaping control char in
error messages until writing to stderr, instead of quoting at
building the message. [ruby-core:90853] [Bug #15497]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@667...
nobu (Nobuyoshi Nakada)
07:45 AM Revision e52b102c (git): Test for "%p" in Time.strptime
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66752 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
05:26 AM Bug #15467: Creating a class with a Cyrillic first symbol in the name leads to a SyntaxError in IRB
It is indeed the first letter that's relevant. Examples such as
`class Sigmα`
(last letter of class name is Greek alpha) and
`class Sιγμα`
(only first letter is Latin, rest is Greek) work without problems.
The problem for me is th...
duerst (Martin Dürst)
04:53 AM Revision bbd1e83e (git): complex.c: replace misused UNLIKELY with LIKELY
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66751 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Kenta Murata
04:37 AM Revision 1e879359 (git): * 2019-01-08
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66750 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:37 AM Revision 2b9c6e1a (git): range.c (range_last): disable optimization when each is redefined
Do not use the optimized version of Range#last when Range#each is
redefined.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66749 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Kenta Murata

01/07/2019

11:43 PM Bug #15513: MJIT compilation terminated due to -Wfatal-errors on GCC 7.3.0
再起動で /tmp 以下が消えたため `ruby -v --jit-verbose=2 --jit-save-temps --disable-gems /tmp/t.rb` から再度実行しました
~~~
$ ruby -v --jit-verbose=2 --jit-save-temps --disable-gems /tmp/t.rb
ruby 2.6.0p0 (2018-12-25 revision 66547) +JIT [x86_64-linux]
...
kajisha (Hiroshi Kajisha)
11:41 AM Bug #15513: MJIT compilation terminated due to -Wfatal-errors on GCC 7.3.0
共有ありがとうございます。いただいたファイルを手元で同様のコマンドにてコンパイルしたところコンパイルエラーにならないので、先ほどのファイルが /tmp にある状態で(削除済であれば再度実行し、pXXXXX 部分をご変更ください)以下のコマンドのログをご共有いただけないでしょうか。
```
/usr/bin/gcc -w -Winvalid-pch -fPIC -shared -w -pipe -O3 -o /tmp/_ruby_mjit_p23890u0.o /...
k0kubun (Takashi Kokubun)
10:40 AM Bug #15513: MJIT compilation terminated due to -Wfatal-errors on GCC 7.3.0
- (rm -f /tmp/_ruby_mjit* の後) ruby -v --jit-verbose=2 --jit-save-temps --disable-gems /tmp/t.rb を実行したログ全体
以下実行ログになります。
~~~
$ ruby -v --jit-verbose=2 --jit-save-temps --disable-gems /tmp/t.rb
ruby 2.6.0p0 (2018-12-25 revision 6654...
kajisha (Hiroshi Kajisha)
10:29 AM Bug #15513 (Feedback): MJIT compilation terminated due to -Wfatal-errors on GCC 7.3.0
ご報告ありがとうございます。私も普段Linux上でgcc 7.3.0を使って開発をしていますが、現在同様の問題を再現できないので、デバッグのため以下の3つをいただけないでしょうか。
* (`rm -f /tmp/_ruby_mjit*` の後) `ruby -v --jit-verbose=2 --jit-save-temps --disable-gems /tmp/t.rb` を実行したログ全体
* ↑のログに出現する `include/ruby-2.6.0/...
k0kubun (Takashi Kokubun)
10:08 AM Bug #15513 (Assigned): MJIT compilation terminated due to -Wfatal-errors on GCC 7.3.0
hsbt (Hiroshi SHIBATA)
09:52 AM Bug #15513 (Closed): MJIT compilation terminated due to -Wfatal-errors on GCC 7.3.0
GCC 7.3.0 で MJIT を有効にしてみたところ、生成されたヘッダファイルがコンパイルエラーになるようです。
## GCC のバージョン
~~~
$ gcc --version
gcc (Gentoo 7.3.0-r3 p1.4) 7.3.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying con...
kajisha (Hiroshi Kajisha)
11:25 PM Bug #15516 (Third Party's Issue): Ruby 2.6: `gem build` requires files located in gemspec directory
nobu (Nobuyoshi Nakada)
09:06 PM Bug #15516 (Third Party's Issue): Ruby 2.6: `gem build` requires files located in gemspec directory
The `gem build` command requires gem files located in the directory where .gemspec file is.
Introduced with Merge RubyGems 3.0.0.beta1[1],
specifically ` Dir.chdir(File.dirname(gemspec)) do`.
On Fedora[2], this results in pa...
pvalena (Pavel Valena)
06:02 PM Bug #15499: Breaking behavior on ruby 2.6: rb_thread_call_without_gvl doesn't invoke unblock_function when used on the main thread
After switching to Ruby 2.6.0 for our application on Heroku, we have been getting [R12 - Exit timeout](https://devcenter.heroku.com/articles/error-codes#r12-exit-timeout) errors after each deploy. The application is using Puma in cluster... dentarg (Patrik Ragnarsson)
05:04 PM Feature #15192: Introduce a new "shortcut assigning" syntax to convenient setup instance variables
jjyr (Jinyang Jiang) wrote:
> I am surprised this syntax has been repeatedly requested and rejected since 7 years ago.
> ...
As someone who has been writing Ruby for over 10 years, this syntax is exactly that I would like.
I grow really...
jsc (Justin Collins)
04:26 PM Bug #15515: OpenStruct raising NoMethodError instead of ArgumentError
devpolish (Nardo Nykolyszyn) wrote:
> Did you mean? OpenStruct
Yes, thanks, fixed.
lugray (Lisa Ugray)
04:14 PM Bug #15515: OpenStruct raising NoMethodError instead of ArgumentError
Did you mean? OpenStruct devpolish (Nardo Nykolyszyn)
01:41 PM Bug #15515 (Closed): OpenStruct raising NoMethodError instead of ArgumentError
When an `OpenStruct` has some attribute `foo`, calling the `foo` method with an argument gives a no method error:
```ruby
foo = OpenStruct.new(bar: 'baz')
foo.bar(0) # => NoMethodError (undefined method `bar' for #<OpenStruct bar="baz...
lugray (Lisa Ugray)
01:21 PM Bug #15497: Encoding of error messages should not depend on the locale encoding
It is intended for not only different encoding characters, but also control characters, e.g., "\0".
The `message` is to display, and it is not good idea to show such chars directly, I guess.
And `name` is available for the bare purpose.
nobu (Nobuyoshi Nakada)
11:38 AM Bug #15497: Encoding of error messages should not depend on the locale encoding
I agree that the locale encoding should only be taken into account when the message is actually output, not as long as it is passed around inside Ruby. duerst (Martin Dürst)
12:05 PM Bug #14571: File descriptor leak in resolv.rb
ruby_2_5 r66748 merged revision(s) 62671. nagachika (Tomoyuki Chikanaga)
12:05 PM Revision e804822e (git): merge revision(s) 62671: [Backport #14571]
resolv.rb: close socket
* lib/resolv.rb (UnconnectedUDP#lazy_initialize): store new
sockets before binding, so the sockets get closed when the
requester is closing.
* lib/resolv.rb (ConnectedUDP#lazy...
nagachika (Tomoyuki Chikanaga)
11:10 AM Misc #15514: Add documentation for implicit array decomposition
Agreed. shevegen (Robert A. Heiler)
10:26 AM Misc #15514 (Open): Add documentation for implicit array decomposition
The documentation for [Array Decomposition](http://ruby-doc.org/core/doc/syntax/assignment_rdoc.html#label-Array+Decomposition) says: _"[...] you can decompose an Array during assignment using parenthesis [sic]"_ and gives an example:
...
sos4nt (Stefan Schüßler)
10:13 AM Bug #8123 (Closed): Transcoding exception when using replace along with universal_newline
It seems fixed by #11324. nobu (Nobuyoshi Nakada)
05:48 AM Bug #8123: Transcoding exception when using replace along with universal_newline
jsc (Justin Collins) wrote:
> This code appears to be working (not raising an exception) as early as Ruby 2.1.10:
This may be related to issue #12431 (Strange behavior of String#encode('UTF-8', 'UTF-8', ...) when the encoding of the ...
duerst (Martin Dürst)
07:06 AM Bug #15250 (Closed): Concurrent fibers segfault when thread caching is disabled
nagachika (Tomoyuki Chikanaga)
07:03 AM Revision 8371a9a4 (git): time.c: support military time zone names
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66747 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
06:59 AM Revision 4f9ab3a0 (git): time.c: UTC and Z timezones should be utc
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66746 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
06:07 AM Bug #15512 (Closed): Backport r66745
Please backport r66745 for bumping version of Date.
hsbt (Hiroshi SHIBATA)
06:01 AM Revision da1f9199 (git): Bump version to date-2.0.0.
I forgot to change it when Ruby 2.6.0 was released.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66745 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
04:49 AM Bug #15505 (Closed): Complex#/ canonicalize rationals only when divisor is Complex
Applied in changeset trunk|r66744.
----------
complex.c (f_divide): canonicalize a quotient
Cannonicalize resultant real and imaginary parts when complex number
divided by non-complex number.
[Fix GH-2065] [Bug #15505] [ruby-core:9089...
mrkn (Kenta Murata)
04:49 AM Revision a288ff50 (git): complex.c (f_divide): canonicalize a quotient
Cannonicalize resultant real and imaginary parts when complex number
divided by non-complex number.
[Fix GH-2065] [Bug #15505] [ruby-core:90891]
From: Joe Peric <peric.joe@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6...
Kenta Murata
02:05 AM Revision 72ad0929 (git): Time.strptime benchmarks
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66743 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
01:58 AM Revision 9e3ffd41 (git): Select ruby to run benchmarks with BENCH_RUBY
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66742 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
 

Also available in: Atom