Activity
From 12/11/2018 to 12/17/2018
12/17/2018
-
11:06 PM Bug #15429 (Closed): Fix test failure if ENV["USER"] doesn't match Process.euid
- Thanks. r66428
Oops, forgot to edit commit message before committing :x
-
10:07 PM Bug #15429 (Closed): Fix test failure if ENV["USER"] doesn't match Process.euid
- When dropping privileges to run tests, ENV["USER"] could be set
to a user that doesn't match Process.euid, which causes
test_seteuid_name to fail with Errno::EPERM.
Attached is a patch that fixes this issue by trying to get the
nam... - 10:49 PM Revision 04a9b0da (git): * 2018-12-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66429 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:48 PM Revision 5245ed6b (git): Fix test failure if ENV["USER"] doesn't match Process.euid
- When dropping privileges to run tests, ENV["USER"] could be set
to a user that doesn't match Process.euid, which causes this
test to fail with Errno::EPERM. Try to get the name for the
current euid, and only fallback to ENV["USER"] if t... -
10:00 PM Bug #15428: Refactor Proc#>> and #<<
- BTW, having `>>` and `<<` convert objects via `to_proc` would have a nice (?) addition of chaining symbols too:
```ruby
PROCESS = ->(url) { get(url) } >> JSON.method(:parse) >> :symbolize_keys >> :invert
``` -
- #6284 introduced `Proc#>>` and `Proc#<<`, but the requirements to the argument is totally inconsistent with ANY other place in Ruby.
Currently, it is the **only** place in Ruby where coercing argument to `Proc` is done with `#call` me... -
05:16 PM Feature #15301: Symbol#call, returning method bound with arguments
- @zverok wrote:
> I don't believe it is possible at all (both from the technical and organizational points of view).
Ah ok bummer if true! Can you please clarify what you meant by `organizational` above?
Note to future self (or oth... -
04:08 PM Bug #15427 (Closed): Assertion Failed: vm_method.c:858:prepare_callable_method_entry:callable_method_entry_p(cme)
- 以下のようなコードで Ruby(trunk) が SEGV しました。
## 再現コード
```ruby
module M1
def bar
"bar"
end
end
module M2
include M1
# これをコメントアウトすると落ちない
private(*M1.instance_methods(false))
def meth
bar
end
end
sel... -
03:54 PM Bug #15426 (Closed): BigDecimal: "1.2.3".to_d が 0.0 になる
- Ruby 2.6.0-rc2 で "1.2.3".to_d が 0.0 になります。
```
% ruby -v -rbigdecimal -rbigdecimal/util -e 'p "1.2.3".to_d'
ruby 2.6.0rc2 (2018-12-15 trunk 66408) [x86_64-linux]
0.0
```
Ruby 2.5.3p105 では 0.12e1 を返してました。
```
% ruby -v -rbig... -
03:08 PM Feature #15425: Store MJIT header into Ruby versioned directory.
- I am using `--with-rubyhdrdir=/usr/include --with-rubyarchhdrdir=/usr/include --enable-multiarch` configuration options. This is the output:
~~~
$ tree
.
`-- ruby-2.6.0
|-- ruby
| |-- backward
| | |-- classext.... -
02:29 PM Feature #15425 (Feedback): Store MJIT header into Ruby versioned directory.
- It should be placed under the directory which has the version and architecture name.
How did you configure it? -
- This is a followup of #15391 which fixes JIT to respect the configuration options. However, I still wonder, why the file is versioned and why it is not stored in the versioned directory alongside all other internal Ruby headers. I believ...
-
07:42 AM Feature #14813: [PATCH] gc.c: make gc_enter+gc_exit pairs dtrace probes, too
- On 2018/12/16 21:20, Eric Wong wrote:
> I think the caps change is a minor issue. It's more important to
> use ALL_CAPS to help identify macros (because of side-effects).
I mean, to reach "gc_enter" function is a bit difficult bec... -
- mat999@gmail.com wrote:
> /.../config/application.rb:107: [BUG] invalid keeping_mutexes: Attempt to unlock a mutex which is locked by another thread
> ruby 2.6.0rc2 (2018-12-15 trunk 66408) [armv8l-linux-eabihf]
Are you able to rep... -
03:13 AM Bug #15424 (Closed): Ruby 2.6.0rc1 & 2.6.0rc2 mutex exception
- Steps to reproduce
At the end of a bootstraped rails application (tested with a postgres database) put the following code:
pid = fork do
STDOUT.sync = true
STDERR.sync = true
require('rake')
Application.load_tasks
Rake::Task... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66427 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66426 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66425 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:43 AM Feature #15323: [PATCH] Proposal: Add Enumerable#filter_map
- tny (Tony Sunny) wrote:
> Could't we use reduce for this?
> ...
Yep, that's mentioned in the original ticket too. There's also #each_with_object that lets you write the block almost the same as in the proposal:
~~~ruby
(1..10).each... - 03:08 AM Revision 7d4bfb53 (git): NEWS: Note for the bigdecimal versions
- The differences between bigdecimal 1.3.5, 1.4.0, and 1.5.0 are explained.
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66424 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r66423.
----------
Workaround for OpenBSD make
* common.mk: read from node.h in the source directly, without
VPATH. [ruby-core:89151] [Bug #15154]
From: kernigh (George Koehler) <xkernigh@netscape.net> -
- * common.mk: read from node.h in the source directly, without
VPATH. [ruby-core:89151] [Bug #15154]
From: kernigh (George Koehler) <xkernigh@netscape.net>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66423 b2dd03c8-39d4-4d8f-98... - 12:43 AM Revision 89955d54 (git): * 2018-12-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66422 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * time.c (time_timespec): range check is only for time interval
value if time_t is signed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66421 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/16/2018
-
10:09 PM Bug #14018 (Third Party's Issue): Sidekiq rejects output of Marshal.dump
-
- I don't believe it is possible at all (both from the technical and organizational points of view).
If you do, probably you should create another ticket, not turning this one, pretty short and focused on _one particular proposal_ into th... -
- zverok (Victor Shepelev) wrote:
> ...but instead will require the change of ALL the methods in standard library accepting a block? Or what do you mean?..
Exactly - no new method/operator, just changes at the parser/compiler level -
- > ...which wouldn't require a new method/operator?
...but instead will require the change of ALL the methods in standard library accepting a block? Or what do you mean?.. -
- @matz @zverok
What do you think of this alternative syntax which wouldn't require a new method/operator?
```ruby
[1, 2, 3, 4].map(&:**, 2) #=> [1, 4, 9, 16]
[1, 2, 3].tap(&:delete, 1) #=> [2, 3]
``` -
- @matz (Yukihiro Matsumoto) wrote:
> Interesting idea of partial evaluation, but `call` is too generic, and could cause confusion. I am not positive about the expression.
Believe this concept is called [partial application](https://en... -
- Close to be on tracking on backport process.
-
-
-
- Changed backport field of #14571, thank you for reporting!
-
- > Eregon (Benoit Daloze) wrote:
> ...
Perfect thanks @Eregon, [pull request](https://github.com/ruby/ruby/pull/2050) updated!
> oleynikov (Alexander Oleynikov) wrote:
> ...
Thanks for the links to the other discussions @oleynikov, p... -
10:58 AM Feature #15419: Allow Kernel#tap to be invoked with arguments like Kernel#send - It is not backward compatible.
And I'm not sure why we need to change just `#tap` and not other methods.
There are some discussions going on about passing arguments whith `Symbol#to_proc` shorthand: #12115, #15301, etc. Personally I'... -
10:44 AM Feature #15419: Allow Kernel#tap to be invoked with arguments like Kernel#send
- shuber (Sean Huber) wrote:
> The `ruby/spec on Ruby 2.3` check is failing in this PR - I'm not sure what the existing conventions are for adding specs for new features like this.
> ...
Yes, in such a case you need to use `ruby_version_... - 06:53 PM Feature #15215: HTTPS server name indication (SNI): explicit server_name in Net::HTTP
- I still like to have this feature. Any opinion on this? Especially @naruse as a maintainer of lib/net/http(s).rb?
Thanks! -
04:32 PM Misc #15275: [DOCs] Documentation for ruby's jit model - from the ruby "end user" perspective
- I know these explanations are obviously not end-user friendly yet. To be improved.
-
- For the initial version of (3) and (4), I added a few Advantages/Disadvantages explanations on that page.
-
- In https://bugs.ruby-lang.org/projects/ruby/wiki/MJIT, I finished the following parts:
(1) Done.
(5) Linked from https://bugs.ruby-lang.org/projects/ruby/wiki. Also I'll add a link to it in the final release note.
Closing this tic... -
- I'm struggling to remember the contents of this ticket in my small memory, so I'll summarize what I interpreted here:
## terminology
* end user: semi-advanced ruby user
## missing documentation
* how such a "end user" may ben... -
02:54 PM Revision 968fcd83 (git): [DOC] Update Object#=~ [ci skip]
- see r65989
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66420 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It happens on 2.4.5, too; so it's not a new problem.
fork leap-frogging (without exec) is an uncommon case,
so I'll let somebody else fix it.
-
- おっしゃる通りと思いましたので、そのままパッチを取り込まさせていただきました。
が、パッチ作成者の情報をコミットメッセージに入れ忘れたままコミットしてしまいました…すみません。 -
- Applied in changeset trunk|r66419.
----------
bin/erb: improve documentation of -P flag
man/erb.1: ditto
[Bug #15421] -
11:49 AM Bug #15421 (Closed): erb コマンドの -P オプションの説明
- `erb` コマンドの `-P` オプションは、`%` で始まる行を Ruby コードとして評価する機能を無効にする、という意味だと思うのですが、man ページの説明は以下のようになっていて正しくないように思います。
~~~
-P Evaluates lines starting with % as Ruby code and removes
the tailing EOLs.
~~~
また、`erb --help` の説明は以下のよ... -
- man/erb.1: ditto
[Bug #15421]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66419 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=66413
Finally fixed for GNU/Linux. Not on FreeBSD 11.2,
but it was also present in 2.4.5:
==> fork_leapfrog_freebsd.rb <==
require 'io/wait'
prev =... -
01:04 PM Bug #9367 (Closed): REXML::XmlDecl doesn't use user specified quotes
- I've implemented `:prologue_quote` context option. Available values are `:quote` and `:apostrophe`.
https://github.com/ruby/rexml/commit/e89702294881a8aedb15905d8a85137876749f7f -
- I've implemented `:prologue_quote` context option. Available values are `:quote` and `:apostrophe`.
https://github.com/ruby/rexml/commit/e89702294881a8aedb15905d8a85137876749f7f -
- Applied in changeset trunk|r66418.
----------
Refine error message for time interval
* time.c (time_timespec): Time interval value can be zero, not
only positive. [ruby-dev:50709] [Bug #15420]
From: shuujii (Shuji KOBAYASHI) <shuuj... -
- `sleep` に負数を渡した場合のエラーメッセージは以下のようになります。
~~~
$ ruby -e 'sleep(-1)'
Traceback (most recent call last):
1: from -e:1:in `<main>'
-e:1:in `sleep': time interval must be positive (ArgumentError)
~~~
しかし、0 は許容されているので "must not be n... -
- * time.c (time_timespec): Time interval value can be zero, not
only positive. [ruby-dev:50709] [Bug #15420]
From: shuujii (Shuji KOBAYASHI) <shuujii@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66418 b2dd03c8-39d4-4d... - 12:33 PM Revision bb1e08e7 (git): thread_pthread (ubf_timer_destroy): use VM_ASSERT
- Don't need the overhead at runtime
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66417 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:26 PM Revision 4cf82863 (git): Pathname#relative_path_from compatible with mock.
- [Fix GH-2049]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66416 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > https://bugs.ruby-lang.org/issues/14813#change-75529
>
> I have no strong idea. If it will help for systemtap user. I don't care.
> (I feel changinge "gc_enter" to "GC_ENTER" is a bit difficult to read, but I understand why...).
... -
- Applied in changeset trunk|r66415.
----------
Enhance Tempfile docs [ci skip]
[ruby-core:90525] [Bug #15411]
From: zverok (Victor Shepelev) <zverok.offline@gmail.com> -
- [ruby-core:90525] [Bug #15411]
From: zverok (Victor Shepelev) <zverok.offline@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66415 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Let's deprecate `ObjectSpace._id2ref` in 2.7 then.
I think we also need to address the usage in DRb. cc @seki -
- Eregon (Benoit Daloze) wrote:
> @naruse @matz Is it still time to deprecate `ObjectSpace._id2ref` for 2.6, or is it too late already in the release cycle?
For 2.6, it's too late because people don't have a chance to check the breakag... -
- @naruse @matz Is it still time to deprecate `ObjectSpace._id2ref` for 2.6, or is it too late already in the release cycle?
-
- Try nokogiri v1.9.0.rc1.
https://github.com/sparklemotion/nokogiri/issues/1833#issuecomment-445699368 - 07:51 AM Revision 3b13bc63 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66414 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:51 AM Revision f547d391 (git): thread_pthread.c: fix memory leak from fork loop leapfrog (v3)
- Constantly forking a single-threaded process in a loop leads to
a memory leak when using POSIX timers. This fixes the leak for
GNU/Linux systems running glibc.
v2: disarm before timer_delete
v3: ubf_timer_arm prevents double-arming
Th... -
- https://gist.github.com/ko1/72c03695e81a54d40649f29d0c421f26
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66412 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/15/2018
-
- The `ruby/spec on Ruby 2.3` check is failing in this PR - I'm not sure what the existing conventions are for adding specs for new features like this.
* Should the new tests be wrapped in `unless RUBY_VERSION <= "2.3"` conditions?
* O... -
- Tapping methods without any arguments already has nice shorthand via `Symbol#to_proc`:
```ruby
object.tap { |o| o.example }
# vs
object.tap(&:example)
```
Unfortunately once other arguments are involved we have to switch back t... -
11:30 PM Bug #15390: Error installing nokogiri on ruby-2.6.0-rc1
- I have confirmed that this bug is still present in rc2.
I have not changed the Status from "Third Party's Issue" to "Open", but unless I'm overlooking something, I do think that would be appropriate.
I'm hoping that someone who is ... -
- `Kernel#tap` related: Allow `Kernel#tap` to be invoked with arguments like `Kernel#send` - https://bugs.ruby-lang.org/issues/15419
If the `LocalJumpError` breaking change from this ticket is not an issue then it'd be pretty easy to ad... - 09:28 PM Revision 5c130f94 (git): * 2018-12-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66411 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:28 PM Revision 52a71df0 (git): time.c: [DOC] improve docs for tz argument of Time.new
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66410 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:17 PM Misc #15418: Date.parse('2018')
- I can understand you to some extent.
I live in Europe and we tend to use the dd.mm.yyyy notation a lot,
at the least in central europe; so I would have assumed that
Date.parse('2018') would mean Date.parse('01.01.2018'), even
thoug... -
06:43 PM Misc #15418 (Open): Date.parse('2018')
- Date.parse('2018')
ArgumentError: invalid date
I did expect that to return the same as:
Date.parse('2018-1-1')
=> Mon, 01 Jan 2018
working with dates and times is really weird and complicated,
so it makes sense to be strict wit... -
- This reverts commit 298180f0450df6e975057cc7e90b3ae3248586fc.
It looks like we should not expand ext/nkf:
https://git.ruby-lang.org/ruby-commit-hook.git/commit/?id=91fd9708b7cf04a4dcddd9614c24e27ddef5d43b
git-svn-id: svn+ssh://ci.ruby-... -
02:29 PM Feature #15408: Deprecate ObjectSpace._id2ref
- I agree with removing `_id2ref` (gradually for not breaking existing code, of course).
I am against removing `object_id` since it is used widely. But by removing `_id2ref`, the implementation of `object_id` can be separated from pointer... -
- tenderlovemaking (Aaron Patterson) wrote:
> I thought about doing this with ".freeze", introducing a special instruction the same way we do for the `"string".freeze` optimization, but dealing with deoptization in the case someone monkey... -
- 1.8でも -w オプション付きなら警告が出るようになったはずだったんですが、結局その1.8.8はリリースされず1.9になってしまったんですよね…。
-
- もうちょっと調べてみたんですが `#[]` だと `[meth(1, 2)]` として扱われるんですね、なるほど。
```ruby
class X
def [](*args)
args
end
end
def meth a, b = 42
a + b
end
def hoge
X.new[meth 1, 2] # => [meth(1, 2)]
end
hoge # => [3]
``` -
- これですが、メソッド呼び出しに `()` を付けると問題ないようですね
```shell
$ ruby -ce '[p(1)]'
Syntax OK
```
また、 `()` をつけない場合、次のような問題があるかと思います。
```ruby
def meth a, b = 42
a + b
end
def hoge
[meth 1, 2] # => [meth(1), 2] or [meth(1, 2)] ?
end
... -
- 以下のような配列リテラル内の引数を伴う括弧なしのメソッド呼び出しで syntax error が発生します。
~~~
$ ruby -ce '[p 1]'
-e:1: syntax error, unexpected tINTEGER, expecting do or '{' or '('
[p 1]
^
~~~
メソッドの `[]` や `[]=` の中ではエラーにならないので許容されたほうが良いと思います。
~~~
$ ruby... -
- > https://bugs.ruby-lang.org/issues/13618
Rebased against r66407, fixed fork+GC bug on th->interrupt_lock
and added RDoc for Thread::Light class
https://80x24.org/ruby.git thread-light-r66407
(also, the "thread-light" branch is ... -
- It's fixed by r66384
- 09:55 AM Revision 298180f0 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66407 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66406 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:04 AM Revision 2812ffc6 (git): use System Monitor Control for spec of Win32OLE.
- * spec/ruby/library/win32ole/win32ole_method/event_interface_spec.rb:
use System Monitor Control instead of Microsoft Internet Control
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66405 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:40 AM Revision 05da6568 (git): test/lib/test/unit.rb: do not propagate MAKEFLAGS to children
- Propagating MAKEFLAGS to children running test/unit caused stuck
tests with GNU make when "-jN" is passed in both the make(1)
command-line and the "TESTS=" variable; because the forked child
process would see MAKEFLAGS and try to use job... -
04:35 AM Bug #15417 (Closed): Pathname case insensitive comparison
- While fixing some issues with Pathname, I noticed the following comparison:
```
SAME_PATHS = if File::FNM_SYSCASE.nonzero?
# Avoid #zero? here because #casecmp can return nil.
proc {|a, b| a.casecmp(b) == 0}
else
... -
03:03 AM Feature #15195: Deal with new Japanese era
- According to https://www.japantimes.co.jp/news/2018/12/06/national/politics-diplomacy/japan-mulls-announcing-new-era-name-april-11-sources/#.XBQPC6qWxD8, the announcement of the new area name may be postponed until about April 11.
-
- Koichi Sasada <ko1@atdot.net> wrote:
> On 2018/12/15 6:32, normalperson@yhbt.net wrote:
> > We should experiment a bump allocator for temporary allocations which
> > behaves like the stack, but does not get marked by GC. VALUEs will... -
- On 2018/12/15 6:32, normalperson@yhbt.net wrote:
> We should experiment a bump allocator for temporary allocations which
> behaves like the stack, but does not get marked by GC. VALUEs will continue
> to be allocated on normal C sta... -
- fileutils (mv): fall back to copy + unlink on EPERM
With ext4 encrypted directories, renaming a file from an
unencrypted directory to an encrypted directory gives EPERM.
Fall back to copying and unlink in that case, since it's
simi...
12/14/2018
-
09:50 PM Bug #15414 (Closed): backport #14571 (File descriptor leak in resolv.rb)
- https://bugs.ruby-lang.org/issues/14571 was merged to 2.6 and backported to 2.3 and 2.4
it should be also backported to 2.5 -
09:32 PM Bug #15362: [PATCH] Avoid GCing dead stack after switching away from a fiber
- Did this get backported to ruby_2_5? I don't see a corresponding commit in the github mirror https://github.com/ruby/ruby/commits/ruby_2_5
-
- The current machine (C) stack can get pretty big for some C functions
(rb_ensure, rb_f_select/rb_thread_fd_select/...). This is harmful when we stop
a fiber/thread and all that stack becomes eligible for marking.
We should experime... - 08:32 PM Feature #15323: [PATCH] Proposal: Add Enumerable#filter_map
- nardonykolyszyn@gmail.com wrote:
> (1..10).map { |e| e.even? ? (e * 2) : e }
Yeah, but without `#filter` this is still an array with 10 elements. -
07:58 PM Feature #15323: [PATCH] Proposal: Add Enumerable#filter_map
- (1..10).map { |e| e.even? ? (e * 2) : e }
-
- I've been waiting this for a while. I'm completely agree.
-
05:35 PM Feature #11076: Enumerable method count_by
- For me the definition of tally does seem to fit the use case, so +1 to `tally(_by)`.
Couple of alternatives, how about:
- [census](https://www.merriam-webster.com/dictionary/census) (as in `census_by(&:downcase)`)
- [inventory](h... - 03:18 PM Revision 347ed211 (git): * 2018-12-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66403 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66402 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:50 PM Bug #15392: Crash in RubyVM::InstructionSequence#to_binary
- shyouhei (Shyouhei Urabe) wrote:
> It seems fixed on my machine. Can be a dup of #14897 ?
The symptoms I observed are the same as #15200, so I expect it is a duplicate of that issue. -
12:08 PM Bug #15412 (Closed): backport r66401 (Move autoload to toplevel)
- チケットの backport 管理用です。
r66401 は ruby_2_4、ruby_2_5 でも autoload が module 内に書かれているので backport が必要かと思います。
-
- So that classes which uses Net::HTTP with https can use OpenSSL
namespace for example exception classes like OpenSSL::SSL::SSLError.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66401 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- OpenSSL maybe aren't loaded in rubygems.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66400 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:44 AM Revision 69ab98ff (git): * remove trailing spaces. [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66399 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66398 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66397 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:50 AM Feature #14594: Rethink yield_self's name
- FYI: mruby 2.0 has been already released with `Kernel#then`. I think we've gone beyond the point of no return.
-
03:30 AM Feature #14594: Rethink yield_self's name
- So we will have the questionable (as confusing for promise library users) `then` in 2.6? There were a lot of concerns mentioned above. `to_be` (or other suggestions) wouldn't have these problems. I would advice to re-think this one final...
- 03:45 AM Revision 308360f1 (git): NEWS: Fix description of BigDecimal.new [ci skip]
- BigDecimal.new is restored, and will be removed on bigdecimal 1.5
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66396 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66395 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:33 AM Revision 48d1f45b (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66394 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:33 AM Revision 62b55d94 (git): Import bigdecimal-1.4.0.pre.20181214a
- * https://github.com/ruby/bigdecimal/compare/v1.4.0.pre.20181205a..v1.4.0.pre.20181214a
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66393 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * hash.c: separate NULL and EMPTY check functions.
`RHASH_TABLE_EMPTY` function checks NULL table or not,
but it should be named "NULL_P".
Introduce `RHASH_TABLE_EMPTY_P` function to check size == 0.
There are cases that hash has... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66391 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * internal.h: rename the following names:
* li_table -> ar_table. "li" means linear (from linear search),
but we use the word "array" (from data layout).
* RHASH_ARRAY -> RHASH_AR_TABLE. AR_TABLE is more clear.
* rb_hash_array_...
12/13/2018
-
- Several small style enhancements + I don't know why the "fake" docs for `::new` were done this way, but they hid the `mode:` keyword argument, which once cost me several dozens of minutes to investigate.
Docs [currently](https://ruby... -
- * time.c: [DOC] fix typos, drop unnecessary `p' from code examples,
add missing `#' for return values, other small improvements.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66389 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Fix some typos; fix syntax in a code example; fix unintentional
description list for ticket numbers; other fixes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66388 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66387 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:24 PM Revision 945d82ed (git): * 2018-12-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66386 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66385 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:51 PM Feature #13581: Syntax sugar for method reference
- Triple `:` doesn't parse right now and has some synergy with constant references:
```
obj:::foo # => obj.method(:foo)
``` -
- Also discussing pipe operators in https://bugs.ruby-lang.org/issues/14392#note-26
-
- > i hope you don't plan to mess with the VALUE type too
Again, ko1 can explain better, but my understanding is that any direct references to VALUE (pointers to actual heap objects) will mark those objects as "shady" and they will not ... -
04:01 PM Feature #15408: Deprecate ObjectSpace._id2ref
- i hope you don't plan to mess with the VALUE type too
i jumped through many loops to get it right. I connected the Ruby GC with the Object handing from wxWidgets.
* the wx Object holds a Holder Type which has the Ruby value inside
... -
- > I found the following note in the comment
Yes, I want WeakMap to become part of the public API. I think that needs to happen to smoothly replace _id2ref.
> ...
Or you can just wrap the whole thing with StandardError like the newr... -
03:36 PM Feature #15408: Deprecate ObjectSpace._id2ref
- > Could you use WeakMap to simply map the Python object pointer to the wrapper?
Yes, I think I can use WeakMap for my purpose, maybe.
If my memory serves me correctly, when I implemented such a table, I investigated WeakMap. I foun... -
- mrkn (Kenta Murata) wrote:
> Rather, in pycall, I use `object_id` and `_id2ref` for managing wrappers of Python classes and Python modules in Ruby.
> ...
But then this is exposed to the _id2ref bug, i.e., it could return another wrappe... -
- > For this purpose, pycall has mappings from a Python object pointer to an ID of Ruby object, which is a wrapper of the Python object.
Could you use WeakMap to simply map the Python object pointer to the wrapper? I'm guessing Python d... -
- Endo-san, thank you for describing the case of pycall.
But, unfortunately, I'm not using `object_id` and `_id2ref` for managing Ruby object references in Python.
Rather, in pycall, I use `object_id` and `_id2ref` for managing wrapper... -
- > I'm unsure how to garbage-collect the wrapped objects, though
Oh this leads to another item Ruby really needs to add, related to the _id2ref removal: reference queues.
On the JVM, when you create a WeakReference, you can register... -
- > I've heard that pycall is also using _id2ref. This API seems to be useful to create a remote wrapper of a Ruby object out of the Ruby process...
This isn't a problem. pycall needs to have its own unique ID generator for each object ... -
- > The world is not going to end if object_id is removed; but it is not going to end when object_id remains, either.
I don't think the world is going to end regardless of what we do. But object_id is going to become even less ID-like a... -
- I'm glad most of us are in agreement about _id2ref!
> object_id ... is idempotent,
Yeah you're right here...I realize the lack of idempotency applies to using it in _id2ref, since it will eventually return a different result over t... -
- Eregon (Benoit Daloze) wrote:
> It seems only drb is using _id2ref in the standard library. We will need to find a replacement for that usage.
I've heard that [pycall][1] is also using _id2ref. This API seems to be useful to create ... -
- I originally wanted to write a very long reply but I think it becomes too difficult
to keep track of what is being said, so just my opinion in a somewhat more condensed
form than before:
- I have no strong opinion on _id2ref. I thin... -
- Agreed we should remove ObjectSpace._id2ref, since it's fundamentally broken on MRI with the current MRI object_id semantics (could get another object if that memory address is reused after GC'ing the old object).
Removing #object_id ... -
- headius (Charles Nutter) wrote:
> > I use object_id for debugging to compare identities.
> ...
Yes. The problem is I always forget which is identity comparison, `equal?`, `eql?`, `eq?`, `==`.
:p
-
- > object_id does precisely what I expect.
Then your expectations do not include that it's actually an ID, since it's literally just a pointer into the heap. In the short term, that pointer will likely be occupied by other objects. Lon... -
05:00 AM Feature #15408: Deprecate ObjectSpace._id2ref
- duerst (Martin Dürst) wrote:
> On the other hand, if `object_id` is just a form of the pointer, then I wonder whether we're safe for transient heaps and the like, where objects are being moved around.
Just to tell you that transient ... -
- headius (Charles Nutter) wrote:
> I should point out that even the monotonically-increasing ID will eventually break once enough objects have been created to roll over a 64-bit integer limit unless object_id can be a `Bignum`, which wou... -
04:13 AM Feature #15408: Deprecate ObjectSpace._id2ref
- > ((2**64)/1_000_000_000)/60.0/60.0/24.0/365.25
> => 584.5420460681421
>
> (Merely an aside, since I maintain object_id is fine as-is. But this
> appears to be a billion objects per second for 584 years.)
Sorry, subtract the... -
- On 12/12/2018 4:53 PM, headius@headius.com wrote:
> I propose that both methods should immediately be deprecated for removal in Ruby 3.0.
Agree on id2ref; *strongly* disagree on object_id.
> * They do not do what people expect.... -
- > object_id is used even in rspec for debugging.
All objects need to have a base hashcode; that's what we should be logging instead. In Java, this is accessible using System.identityHashCode(obj). JRuby uses this for the base object h... -
- My proposal would make WeakMap a standard Ruby feature, so you can implement your own ID system and weakly track objects in the right way. Maybe we need IDMap that returns a guaranteed-unique generated key when you insert an object.
h... -
- https://github.com/rspec/rspec-expectations/blob/848fcb426cca1977b75909d0cb8a10f03a104b36/lib/rspec/matchers/built_in/equal.rb#L76
object_id is used even in rspec for debugging.
I also find it useful to estimate how many objects were c... -
- There are currently 64 references in ext+lib to `object_id`, `__id__`, or `_id2ref`.
```
[] ~/projects/ruby $ git grep object_id lib | wc -l
40
[] ~/projects/ruby $ git grep __id__ lib | wc -l
9
[] ~/projects/rub... -
- Oh, I'd also rather not even see these features moved into `ext/objspace` since that just means people will start adding `require 'objspace'` so they can keep using the features. They should always warn, and ideally just disappear altoge...
-
- > These methods show too much internals (bare C pointer values).
It is possible to implement them as lazy monotonically increasing integers, but you either have to accept that they will overflow into bignum or wrap around at some poin... -
- > I use object_id for debugging to compare identities.
> ...
I believe you are saying that using `equal?` is an acceptable alternative to comparing object_id's, yes? -
- I use `object_id` for debugging to compare identities.
comparison methods can be enough. -
- 100% agree. These methods show too much internals (bare C pointer values). Maybe I can compromise on them moving into ext/objspace, but at least they should be hidden from the core API.
-
- I should point out that even the monotonically-increasing ID will eventually break once enough objects have been created to roll over a 64-bit integer limit unless object_id can be a Bignum, which would mean holding references Bignums fo...
-
- Ruby currently provides the object_id method to get a "identifier" for a given object. According to the documentation, this ID is the same for every object_id call against a given object, and guaranteed not to be the same as any other ac...
-
- こちら修正してみたので再度ご確認をお願いします。
手元では `make DEFS=-DVM_CHECK_MODE=2 check` のテストは通りました。
pull request : https://github.com/ruby/ruby/pull/2039 -
11:55 AM Bug #15339 (Closed): CI - add checks for std-lib CLI ?
- Hi Greg.
Thanks for your report.
This is fixed ar r66384 by @usa.
I will consider to add cli check to our CI after Ruby 2.6 releasing. - 10:51 AM Revision adc32fd3 (git): Install script of default gems as is to its libexec dir
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66384 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- duerst (Martin Dürst) wrote:
> I just found `-Wdeclaration-after-statement`. So I would definitely suggest that this warning is switched on as long as we require commits to conform to this and check this in CI. This warning alone woul... -
- shyouhei (Shyouhei Urabe) wrote:
> duerst (Martin Dürst) wrote:
> ...
I agree we don't want to do this.
> This can be okay for CI but not a realistic usage nowadays. Please do not do this by default.
Then what about by default a... -
10:32 AM Feature #11076: Enumerable method count_by
- Just my 2 cents: I'm not a native English speaker. Never heard the word "tally" before. So I would never remember it and has always to look at the api docs.
-
12:23 AM Feature #11076: Enumerable method count_by
- @matz / @ko1: Any chance of this making it into 2.6? The code is already done (thanks @nobu) and the only consideration left is the name. Would `tally_by` be an acceptable compromise?
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66383 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- @dsferreira @zverok @shevegen @bughit
How do you feel about the syntax from this working proof of concept? https://github.com/LendingHome/pipe_operator
```ruby
"https://api.github.com/repos/ruby/ruby".pipe do
URI.parse
Net::... - 09:41 AM Revision 2d4c248d (git): thread_pthread.c (native_ppoll_sleep): drop ubf_select references
- We don't use ubf_select after r65495 / 5de7b3b4f27df747899c243adbb10c9799ad1399
("thread_pthread.c (native_ppoll_sleep): new eventfd (or pipe) for ubf"),
so we don't need to unregister the thread from the ubf list.
git-svn-id: svn+ssh:/... -
- Applied in changeset trunk|r66381.
----------
thread_pthread.c (native_sleep): sched_yield if GVL uncontended
Uncontended GVL waitqueue could mean a single CPU setup where
threads are starved and can't even insert themselves into our
w... -
- > https://bugs.ruby-lang.org/issues/15398
>
> OK, problem happens on single-CPU setup.
Testing this (could take a while):
https://80x24.org/spew/20181213064144.84663-1-e@80x24.org/raw -
- > > https://bugs.ruby-lang.org/issues/15398
OK, problem happens on single-CPU setup.
"cpuset -l 1 make ..." replicates the problem. Not sure what to
do about it, yet; need food :< - 09:25 AM Revision 89db85f7 (git): thread_pthread.c (native_sleep): sched_yield if GVL uncontended
- Uncontended GVL waitqueue could mean a single CPU setup where
threads are starved and can't even insert themselves into our
waitqueue. So we force other threads to run upon releasing
the GVL in an uncontended state, in the hope that we ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66380 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- shan (Shannon Skipper) wrote:
> I had the same thought as shevy, that it'd be nice to have a:
> ...
+1
- 08:44 AM Revision 690fd763 (git): thread_pthread.c (gvl_release_common): constify return value
- No need for it to be mutable
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66379 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > `OpenStruct` is kind of an anti-pattern.
Completely agreed. I'd like to prohibit the library itself, honestly.
> ...
Interesting. I believe no one passes untrusted keys to Struct. But I heard that OpenStruct is used for JSON.
... -
- I think it should be overridable and a warning could be issued for those methods that would lead to breakage. I don't really use Struct and OpenStruct much at all these days though - I tend to just define what I need via simple classes.
-
06:59 AM Bug #15409: OpenStruct error when attribute is called 'method'
- I don't have a good solution.
`OpenStruct` is kind of an anti-pattern. This is even more apparent when adding methods to `Object/Kernel`.
I note that `Struct` allows overriding builtin methods:
Struct.new(:method, keyword_in... -
- Yes, the current behavior is intentional. OpenStruct prohibits redefinition of the superclass methods.
However, the current spec that prohibits overwrite is fragile against newly introduced methods to Object class. For example, Obje... - 05:46 AM Bug #15409: OpenStruct error when attribute is called 'method'
- According to the docs, `OpenStruct` uses `method_missing`, so it does not redefine existing methods of `Object` or `BasicObject`.
https://docs.ruby-lang.org/en/trunk/OpenStruct.html
```ruby
o = OpenStruct.new(
method: 'method',
... -
03:25 AM Bug #15409 (Closed): OpenStruct error when attribute is called 'method'
- The following error is shown when you try to access an OpenStruct with a property called method:
`method': wrong number of arguments (given 0, expected 1) (ArgumentError)
To replicate:
~~~ ruby
require 'ostruct'
o = OpenStruct... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66378 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:45 AM Bug #15395: Stack consistency error (2.6.0-rc1, JIT)
- 治りました。
ruby 2.6.0dev (2018-12-13 trunk 66372) [x86_64-linux]
で試しまして、テストコードのほうもRailsのほうも落ちなくなりました。
ありがとうございます。 -
- Closed at request of original submitter.
-
05:04 AM Bug #15410: double-splatted parameters behave differently if one of the keys is an array
- I've been informed that this is expected behavior according to the spec, but I don't know how to close my own issues (or even if I can), so feel free to close this.
-
- ~~~
➜ irb
2.5.1 :001 > def thingy(x, **y); [x, y]; end
=> :thingy
2.5.1 :002 > thingy(4, {:x => 5})
=> [4, {:x=>5}]
2.5.1 :003 > thingy(4, {[:x] => 5})
Traceback (most recent call last):
16: from /home/choffman/.rvm/ge... -
- Do not apply RSTRING_PTR, a macro which evaluats its argument
multiple times, on a function call.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66377 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:02 AM Bug #15406: Loaded iseq may cause SEGV on GC
- ko1 (Koichi Sasada) wrote:
> This patch will fix.
> ...
I bisected this and r62851 introduced the issue. The patch makes sense, so I applied it in r66376. Thanks ko1!
-
- Applied in changeset trunk|r66376.
----------
Don't increment `code_index`
`code_index` doesn't need to be incremented since the mark array has
been removed. Thanks for the patch ko1!
[ruby-core:90456] [Bug #15406] -
- This patch will fix.
Aaron, could you confirm it?
```
Index: compile.c
===================================================================
--- compile.c (revision 66375)
+++ compile.c (working copy)
@@ -8786,7 +8786,6 @@ ibf_loa... -
- `code_index` doesn't need to be incremented since the mark array has
been removed. Thanks for the patch ko1!
[ruby-core:90456] [Bug #15406]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66376 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Be advised: Please do not reuse existing tickets to report something completely different.
Also be advised: please do understand that this is not where ActiveSupport::TimeZone issue should be reported. -
01:18 AM Feature #13822: Time.dst_changes(t=Time.now.year)
- Is it bug or feature?
Receiving same result for Time.dst? method.
I belive it suppose to base it response on date in variable, correct me if i'm wrong.
Receiving it in Rails 5.1.2, but Time class is in ruby core
gems tzinfo, tzinfo... -
-
- With recent changes to tool/rbinstall.rb, if you use --program-suffix (or a similar option),
it will result in bundle, bundler, irb, rdoc, ri not working, because they try to load a
file from the gem directory which has been modified w... -
- You would be well-advised to avoid object_id. It does not do what you think it does. By returning a pointer reference into the garbage-collected heap, it's possible for the same object_id to refer to different objects over time.
I hav...
12/12/2018
-
- For what it's worth, if I comment out a line in configure.ac, I can still build and install ruby locally and the version I install can then build and install nokogiri. However, my guess is that the altered code wouldn't build properly on...
-
- I absolutely hate to waste anyone's time with speculation, but this may not be a problem with nokogiri, per-se. I mention this based on having spent a little time tracking this one down on my own and coming to partial conclusions when it...
-
- Thanks!
-
- Fixed, thanks
-
- @marcandre Thanks!
https://github.com/ruby/ruby/commit/296bd00e02573a231ec52da538fc3b7d9745f688#diff-dbb13b1d844c49e5b1350ddf0a5ca8cbR1490 -- It looks like something went wrong in this line ("...represents **and** semi-infinite ranges.") -
- Thanks for the patch!
I've modified it slightly and committed it. -
- Sorry if this is the redundant work and the core team plans to do it themselves, but I noticed that new endless ranges have no mentions in Range documentation.
Trying to fix that. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66375 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66374 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:45 PM Revision c3fe2cb6 (git): range.c: Typo fix [DOC] [ci skip] [#15405]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66373 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:35 PM Feature #15393: Add compilation flags to freeze Array and Hash literals
- I had the same thought as shevy, that it'd be nice to have a:
~~~ ruby
# frozen_literals: true
~~~
It might also be worth considering a separate `frozen_array_literal` and `frozen_hash_literal`. I have files where I'd initially o... - 09:17 PM Revision 27ed9b25 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66372 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:17 PM Revision 68bdef00 (git): Add test cases of rb_arithmetic_sequence_extract
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66371 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:59 PM Bug #15406 (Closed): Loaded iseq may cause SEGV on GC
- Attached `test.rb` causes SEGV on trunk r66370.
`test.log` is stderr log.
I don't known what `[0, 13, 0]` means, but I guess environment dependent.
`./miniruby test.rb 4 17 0` also causes SEGV on mn environment but `./miniruby test.... - 07:51 PM Revision fc4029b8 (git): NEWS: Mention (1...) in addition to (1..) [DOC]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66370 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:49 PM Revision 296bd00e (git): range.c: Documentation on endless ranges.
- Based on patch by Victor Shepelev [DOC] [#7552]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66369 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:47 PM Bug #15400: Ruby 2.6.0 broken string literal assignment to a local variable in Dir.tmpdir
- nice! thank you. that was a bizarre one.
-
- I found a bug of webmock.
https://github.com/bblimke/webmock/pull/788
Not a ruby matter :p -
- I can reproduce it on my environment and am debugging now.
-
- * test/ruby/test_literal.rb (test_debug_frozen_string_in_array_literal):
skip last test if `RUBY_ISEQ_DUMP_DEBUG` is specified because round-trip
(iseq <-> binary/array) doesn't support this feature.
git-svn-id: svn+ssh://ci.ruby-l... -
- * compile.c (ibf_load_iseq_each): iseq_mark assumes that if
param.flags.has_kw is TRUE, then param.keyword is not NULL.
To confirm this assumption, make it FALSE before param.keyword
is initialized.
git-svn-id: svn+ssh://ci.ruby-... -
- r66366 で治るんじゃないかと思うんですが、試して頂けませんでしょうか。
よろしくお願いします。 -
- Applied in changeset trunk|r66366.
----------
restore `catch_except_p` flag.
* compile.c: we need to restore `catch_except_p` flag at
`load_from_binary`. [Bug #15395] -
- This ticket was discussed at today's developer meeting.
Nobu said that per-method entries are removed when it becomes unneeded. So, the "leak" is one hash object per thread. Correct? If so, it is not a big deal. Let us know if we ... -
- * compile.c: we need to restore `catch_except_p` flag at
`load_from_binary`. [Bug #15395]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66366 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:45 PM Revision 1ca0d427 (git): * 2018-12-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66365 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_trace.c: remove `compiled_` prefix from the following methods:
* `compiled_eval_script`
* `compiled_instruction_sequence`
[Feature #15287]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66364 b2dd03c8-39d4-4d8f-98ff-823fe... -
- Thank you for your report.
valich (Valentin Fondaratov) wrote:
> ## Why it's important
> ...
I understand the problem. But, it is not specific to endless range, is it? In fact, `(1..1)..1` does parse, and fails to run.
It is po... -
01:08 PM Bug #15404 (Rejected): Endless range has inconsistent chaining behaviour
- Everything below is tested on `Ruby 2.6.0-rc1`. Particular sexp column coordinates are wrong because I've had some leading spaces in the file, sorry.
## The essence of the bug
Syntactically, chaining normal ranges is prohibited. Fo... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66363 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:07 PM Bug #15303: Return tracepoint doesn't fire when tailcall optimization is applied
- Thank you! That works for me too, and will solve the majority of the cases :)
-
- Matz decided to remove tailcall opt from core libraries.
r66349 was committed by nobu.
-
- Applied in changeset trunk|r66349.
----------
Disable tailcall optimization [Bug #15303] -
- Applied in changeset trunk|r66362.
----------
Revise Date#hour, #min, #sec
For ActiveSupport. [ruby-core:90443] [Bug #15403] -
- > This seems incompatible changes. Is it not possible to make it deprecate
> ...
You are probably right there. I assume it may not have been intentional
for 2.6.x; perhaps not even to deprecate it but most certainly not for
removal.
... -
10:34 AM Bug #15403 (Closed): Some methods of Date available in Ruby 2.5 are not available since r66329
- In r66329, some methods were moved to DateTime from Date.
This makes it not available to use methods that were available in Ruby 2.5, like `hour`.
It may not have been intentional that these methods could be used in Date. But Rail... -
- For ActiveSupport. [ruby-core:90443] [Bug #15403]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66362 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66361 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r66360.
----------
complex.c: new APIs for Complex
[Feature #15066] -
- At the meeting today, mrkn also wanted these APIs.
-
- [Feature #15066]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66360 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * complex.c (rb_complex_new_polar): renamed with _new to clarify
that it creates a new instance, but is not an instance method.
* complex.c (rb_complex_polar): deprecated.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66359 b2dd0... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66358 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- duerst (Martin Dürst) wrote:
> So what I'm proposing is to use an option that says that we are on C90, and gives a warning for `//` comments and for declarations after statements and so no.
This effectively kills 64 bit integer capab... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66357 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Fix and improve version string by @stomar
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66356 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r66355.
----------
Enhance Proc docs [Misc #14610]
From: Victor Shepelev <zverok.offline@gmail.com> -
- I'll try to have a look at it later today or tomorrow.
-
- From: Victor Shepelev <zverok.offline@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66355 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66354 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:16 AM Revision 31eb48a0 (git): enumerator.c: Add rb_arithmetic_sequence_components_t
- Add rb_arithmetic_sequence_components_t struct for encapsulating
the components of ArithmeticSequence.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66353 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- We picked `constant_source_location`. We will experiment with this method in 2.7 development.
Matz.
-
- From the backtrace, it looks ruby2d's issue.
-
- Changed subject to English.
I don't think we support Ruby 2.3 anymore, please update to a newer version and try again.
Also, please provide a script that reproduces this bug. -
- revert r43582, r49173 and r49177.
open3 arguments uses spawn-like keyword arguments.
Both symbol and integer keys are used.
```
Open3.capture2(*command, :in => IO::NULL, 3 => IO::NULL)
``
This style cannot be supported with keyword spl... - 06:39 AM Revision 914a2903 (git): enumerator.c: rb_arithmetic_sequence_extract
- New public C-API for extracting components of Enumerator::ArithmeticSequence
or Range.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66351 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Adding examples looks nice, thank you for contributing.
-
- Applied in changeset trunk|r66350.
----------
Enchance MatchData docs [Bug #14450]
From: Victor Shepelev <zverok.offline@gmail.com> -
- From: Victor Shepelev <zverok.offline@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66350 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Matz decided to remove `compiled_` prefix.
I'll commit it soon.
-
05:48 AM Misc #15342: DevelopersMeeting20181212Japan
- * [Bug #15114] Ruby で定義したメソッドに `&:hoge` を渡しても refinements が有効にならない
* [Feature #14609] `Kernel#p` without args shows the receiver -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66349 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66348 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * [BudlerVersionFinder] set .filter! and .compatible? to match only on major versions https://github.com/rubygems/rubygems/pull/2515
* Fix broken symlink that points to ../* https://github.com/rubygems/rubygems/pull/2516
git-svn-id: s... -
- Following methods use corresponding File class methods
instead of IO class methods.
- Pathname#each_line
- Pathname#read
- Pathname#binread
- Pathname#write
- Pathname#binwrite
- Pathname#readlines
Reported by ooooooo_q.
git-svn-i... -
- こちら、わたしの方でも調査しているんですが、ちょっと時間がかかりそうなので、引き続きわたしの方でも調査しますが詳しい方に見てもらえると助かります。
- 02:31 AM Revision 337cabf7 (git): Fix location of NEWS for native coroutine.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66345 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- >1) I believe we need to provide documentation for this. The NEWS file doesn't have much at all. The respective READMEs also have no relevant information and are misleading (see https://github.com/ruby/ostruct/pull/6). I'll be glad to wr...
-
- @ko1 do you think we can aim for 2.6? I don't mind reviewing this patch and merging it if you are happy with it.
-
- I think this is a good idea. I already ended up implementing it by hand, but it's messy.
https://github.com/socketry/async/blob/e169aac7bc47f251ae7c6ebe94820b41bc2d063f/lib/async/task.rb#L43-L55 -
- because test_io.rb:33 randomly fails
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1519055
checking MJIT.enabled? on driver might not make sense for target, but as
long as the CI is -DMJIT_FORCE_ENABLE, I believe it works for ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66343 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I've fixed x86 implementation too, now that it was confirmed the previous effort to fix x64 worked as expected. This issue should be completely resolved now (dc6908ab44c3a3fc78319422410b57d3b7fb6c0c / r66341).
12/11/2018
- 11:56 PM Revision ace30f4d (git): Explain which architectures are supported in NEWS.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66342 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This is now implemented across: arm32, arm64, ppc64le, win32, win64, x86, amd64. Thanks to everyone who helped with this. This is a really awesome first step to improving Ruby Fiber performance.
- 11:49 PM Bug #15335 (Closed): Ruby 2.6.0 is not properly fortified
- Applied in changeset trunk|r66341.
----------
Ensure x86 stack is fortified, fixed #15335. - 11:49 PM Revision dc6908ab (git): Ensure x86 stack is fortified, fixed #15335.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66341 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:49 PM Revision 20c99b1f (git): * 2018-12-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66340 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:49 PM Revision 61c20225 (git): Add NEWS about coroutine implementation.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66339 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Hello! I have very similar views to alanwu.
The original proposal of extending the API to be able to distinguish between regular method calls and tail calls sounds good to me in principle and looks like it would solve the problem in t... -
- > Added by zverok (Victor Shepelev) 10 months ago.
> ...
Sorry, is it possible to have this merged before 2.6 release? What can I do for it?.. -
- > Added by zverok (Victor Shepelev) 9 months ago.
> ...
Sorry, is it possible to have this merged before 2.6 release? What can I do for it?.. -
08:43 PM Misc #15402 (Open): Shrinking excess retained memory of container types on promotion to uncollectible
- I've been toying with the idea of the viability of attempting to reclaim over provisioned memory from buffer capacity of container objects like `Array` and `String`, effectively reducing the footprint of retained memory of such objects.
... -
08:29 PM Bug #15401 (Third Party's Issue): Problem with Ruby interpreter or library extensions
- I have the next issue when i use de ruby2d gem:
bundle exec ruby snake.rb
/Library/Ruby/Gems/2.3.0/gems/ruby2d-0.5.1/lib/ruby2d/ruby2d.bundle: [BUG] Segmentation fault at 0x00000000000dd1e0
ruby 2.3.7p456 (2018-03-28 revision 630... -
- naruse@airemix.jp wrote:
> https://bugs.ruby-lang.org/issues/15398
Odd, r65495 could've solved it, but didn't...
> https://rubyci.org/logs/rubyci.s3.amazonaws.com/freebsd11zfs/ruby-trunk/log/20180826T003001Z.diff.html.gz
>
> N... -
- Since r64538 or r64539, TestThread#test_signal_at_join is failing on our FreeBSD CI.
```
+ <n>) Error:
+TestThread#test_signal_at_join:
+Timeout::Error: execution of assert_separately expired timeout (120 sec)
+pid 80587 killed by... -
- Also I've replicated this failure on ruby-head as of a few minutes ago.
Based on the nature of the test, it is plausible that something is happening related to the 2.6.0 ruby changes to introduce the write_timeout -- but whatever is b... -
- I think I've found a critical bug in ruby 2.6.0 unfortunately the failure condition is not easy to replicate or convert to a minimal example, or for me to even guess what the problem could be caused by.
To replicate:
~~~
git clone... -
- Inheritance of @@class variables is precisely what makes them useful, since they're truly one single global value.
And in addition to what matz points out rubocop has the Cop::Style::ClassVars warning.
As someone who manages a 10 y... -
- I didn't confirm this can be reproduced on ruby_2_4 too.
After a quick code reading, I think it might be. -
- Applied in changeset trunk|r66326.
----------
Fix infinite loop by ensure
* compile.c (iseq_insert_nop_between_end_and_cont): insert nop so
that the end of rescue and continuing points are not same, to
get rid of infinite loop. [B... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66338 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66337 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- insns.def (duparray, duphash): add dtrace hooks
They are considered Array and Hash creation events, so
allow dtrace (and systemtap) to track those creations.
I guess they are, at least something is needed to get dtrace
tests ... - 09:49 AM Revision 0046a4a5 (git): test/dtrace: use TracePoint.__enable
- "TracePoint.enable" is implemented in prelude.rb since
r66003 / commit 96990203b71184003cf8a9bad5cc177645820fd4
and not available in miniruby. I tried using regular "ruby"
for testing, but it proved noisy and caused test failures.
git-... - 09:49 AM Revision 349f6a32 (git): test/dtrace: improve diagnostics
- These will help us track down test failures more easily
(on FreeBSD 11.2)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66335 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- http://rubyci.s3.amazonaws.com/centos7/ruby-trunk/log/20181206T080003Z.diff.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66334 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- @matz This `pipe_operator` syntax actually looks very similar to https://github.com/matz/streem!
url.pipe { URI.parse | Net::HTTP.get | JSON.parse }
"https://api.github.com/repos/ruby/ruby".pipe do
URI.parse
N... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66333 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Now takano32-san has no IA-64 machine for test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66332 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- 再現コードを小さくしていただきありがとうございます。非常に助かります。
-
- これで再現しました。ただ、temple/map.rb そのままじゃないと再現しないので、何が引っかかっているのか。
Gemfile
~~~ ruby
source "https://rubygems.org"
gem "bootsnap", require: false
gem "temple"
~~~
test.rb
~~~ ruby
require 'bundler/setup'
require 'bootsnap'
Bootsnap.... -
- 承知しました。切り分けの助けになります、ありがとうございます。
> なお明記しませんでしたが、SEGVはしていません。
これに関して、"--jitなしでrailsを起動している最中bootsnapでSEGVしてしまった" のはload_from_binary内で、cfp consistency errorとは全く別の問題の話でした。混同させてしまったようでしたらすみません。
いずれにせよ、これら2つの問題からbootsnapが現在Ruby 2.6では正しく... -
- bootsnapを無効にしたところ、再現しなくなりました。
なお明記しませんでしたが、SEGVはしていません。
ただしPumaがfatalが起きても動き続けていたせいか、`^C`で落とせずにKILLしました。
追試：
* bootsnapを有効にしつつ、bootsnapのキャッシュを削除して起動→再現せず
* そのままPumaを再起動→再現、かつ [BUG] vm_call_cfunc: cfp consistency error (0x000056342... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66331 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66330 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/date/date_core.c (Init_date_core): moved methods which make
sense only for DateTime to that class, instead of defining
private methods in Date and making them public in DateTime.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tru... -
- * ext/date/date_core.c (ComplexDateData): reordered to adjust
common part with SimpleDateData.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66328 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66327 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (iseq_insert_nop_between_end_and_cont): insert nop so
that the end of rescue and continuing points are not same, to
get rid of infinite loop. [Bug #15385]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66326 b2dd03c8... - 04:13 AM Revision 8e9aa75d (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66325 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66324 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:31 AM Bug #15397 (Rejected): Ruby process doesn't release memory back to os on CentOS
- I'm not familiar with low level knowledge, so I'm not sure if this issue belongs to Ruby or CentOS, sorry for this, but it's very easy to produce the problem.
## Reproducer:
ruby -v, I have test this script in both 2.5.1 and 2.5.3,... -
- We have the platform issue on heroku:
* https://gist.github.com/schneems/26452540f6e2bbbcf2ea144f45f6b305
* https://github.com/heroku/heroku-buildpack-ruby/issues/833
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66323 b2dd0... -
12:47 AM Bug #15394: Ruby adds unexpected HTTP header value when using symbol key
- Thanks!!
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66322 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:36 AM Bug #15292: Since r64852, on Solaris with Oracle Developer Studio 12.6, compile error of iseq.c
- 実は既に2017年7月頃に正式リリース済です。
https://www.oracle.com/technetwork/server-storage/developerstudio/downloads/index.html
日本語翻訳のページはベータ時のまま放置されているため、誤解されても仕方ないとは思います。
Oracleに報告しようと試みましたが、窓口が不明のため中断しています。
私が実用上不便に感じたらWorkaroudを入れるかもしれません。
-
- Stringify after downcase, to restrict arguments.
[Bug#15394]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66321 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66320 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I only got to know it after having read the news entry just now. :-)
I think the impact of its removal will be very, very little - not
many need it; and I am sure even less depend on it. Personally after
having seen it, I would not ...