Activity
From 12/18/2018 to 12/24/2018
12/24/2018
-
11:12 PM Revision 5300cdc0 (git): Add ruby_2_6 branch to .travis.yml
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66533 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@66532 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66531 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:42 PM Feature #15456: Adopt some kind of consistent versioning mechanism
- Just for a point of reference, I use "~> x.y" for all my dependencies, as, taking into consideration semantic versioning, this allows for the maximum range of support but excluding breaking changes (i.e. x must stay the same, but y can i...
-
03:35 PM Feature #15456: Adopt some kind of consistent versioning mechanism
- > These days many people specify versions in Gemfile like gem "some-libs", "< 2".
> ...
More people use `gem "some-libs", "~> 2.0.0"` and having breaking changes in a minor or patch release break the applications dependant on them.
T... -
- You can understand Ruby versioning as some kind of rolling release.
X.Y is decided with marketing consideration, though .Z is the same as Semantic Versioning's TEENY.
see also https://www.ruby-lang.org/en/news/2013/12/21/ruby-version-p... -
09:14 PM Revision 014a9e05 (git): Small improvement in refinements docs
- Move general statement about refinements of modules
from example to the top of the document.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66530 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:41 PM Revision 3c16862c (git): * 2018-12-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66529 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66528 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:03 AM Revision 1cc8ff00 (git): Added entry for RubyGems 3.0.1 to NEWS.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66527 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66526 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:59 AM Feature #15240: Set operations check for is_a?(Set), rather than allowing duck typing
- I can't recall everything in details, but I think interaction with other types of objects, especially comparison operations, was out of the scope when I wrote Set, and there were some points to consider in my mind.
First, implicit con... -
09:08 AM Bug #15457 (Closed): Weird behaviour when having multiple arguments of same name and splat operator
- Thank you. This is duplicate of #14611. The behavior has been changed in trunk (and 2.6).
```
$ cat bug.rb
def test(_a, b, *_a)
pp _a
pp b
end
test(*%W{a b c d e})
$ ./local/bin/ruby -v bug.rb
ruby 2.6.0dev (2018-12-2... - 08:11 AM Revision e69dbc09 (git): Document the "cause" keyword argument for raise
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66525 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:07 AM Feature #15458 (Open): Automatic Exception#cause print in IRB
- According to Ruby 2.6 NEWS, the following feature will be added:
> Print cause of the exception if the exception is not caught and printed its backtraces and error message [Feature #8257]
I expected it would be applied in IRB too, ... -
03:50 AM Revision 72c62dc0 (git): test_win32ole_event.rb: use better retry strategy
- because
https://ci.appveyor.com/project/ruby/ruby/builds/21208728/job/lm5k0lxnn51pcljl
seems to fail with just sleeping
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66524 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66523 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:03 AM Bug #15300: rb_frame_method_id_and_class deprecated in 2.6
- sorry for long absent. I remove "deprecated" for this API. Could you check it?
Thanks,
Koichi -
- Applied in changeset trunk|r66522.
----------
remove "deprecated" for rb_frame_method_id_and_class [Bug #15300]
* include/ruby/backward.h (rb_frame_method_id_and_class): we had labeled
`rb_frame_method_id_and_class()` as deprecated b... -
- * include/ruby/backward.h (rb_frame_method_id_and_class): we had labeled
`rb_frame_method_id_and_class()` as deprecated because MRI internal
doesn't use it, but we found there are user of this API in external
C-extensions. Now we d... -
01:56 AM Revision 04994454 (git): Compact AST::Node#inspect
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66521 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r66520.
----------
time.c: zone in fixoff mode
* time.c (time_set_utc_offset): reset zone when setting to fixoff
mode. while previously TZMODE_SET_FIXOFF has reset it always,
the zone is kept for loaded ... -
- * time.c (time_set_utc_offset): reset zone when setting to fixoff
mode. while previously TZMODE_SET_FIXOFF has reset it always,
the zone is kept for loaded zone since r65025.
[ruby-core:90627] [Bug #15439]
git-svn-id: svn+ssh://c... -
- Applied in changeset trunk|r66519.
----------
enumerator.c: fix inspect with the last empty hash
[ruby-core:90685] [Bug #15455] -
- [ruby-core:90685] [Bug #15455]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66519 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/23/2018
-
11:50 PM Bug #15455: In v2.6.0 the return value of `each_with_object` and `each_object` is truncated when the object is a hash.
- Corrected a <sub>tiny</sub> typo.
-
11:04 PM Bug #15455: In v2.6.0 the return value of `each_with_object` and `each_object` is truncated when the object is a hash.
- X-mas day change doable? :)
-
- RUBY VERSION: 2.6.0 (2018-12-23 patchlevel -1)
`a = [1, 2, 3]`
`a.each_with_object([]) #=> #<Enumerator: [1, 2, 3]:each_with_object([])>
a.each_with_object(1..3) #=> #<Enumerator: [1, 2, 3]:each_with_object(1..3)>
a.each_wi... -
11:47 PM Bug #15457 (Closed): Weird behaviour when having multiple arguments of same name and splat operator
- When multiple arguments of the same name are provided and last one of
them has splat operator, everything gets weird.
```
+ $ cat bug.rb
def test(_a, b, *_a)
pp _a
pp b
end
test(*%W{a b c d e})
+ $ RUBYOPT=-rpry rvm ... -
11:02 PM Bug #15439: Time object's zone generated by Time.getlocal returns a strange value
- It does not seem to happen if `utc` is not used.
```
$ ruby -ve 'p Time.new.getlocal(0).zone'
ruby 2.6.0dev (2018-12-21 trunk 66474) [x86_64-linux]
nil
```
Active Support is affected by this change and the test is broken. If... -
- I was about to write a lot as a comment but I feel it just gets too long.
So a few comments - sorry for being short:
- You should not forget that management of gems (code in these gems) also
takes time away from developers who mai... -
- After the discussion https://github.com/ruby/bigdecimal/issues/114 I feel like we would benefit from some consistent versioning mechanism across all of Ruby.
So far, I feel the majority of Ruby uses some form of semantic versioning.
... - 06:54 PM Revision 5c3be90a (git): Add test case of ArithmeticSequence#sum
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66518 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:32 PM Revision 325f9890 (git): NEWS: Update for bigdecimal future plan
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66517 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:32 PM Revision 8754b239 (git): Import bigdecimal-1.4.0
- * https://github.com/ruby/bigdecimal/compare/v1.4.0.pre.20181220a..v1.4.0
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66516 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:02 PM Revision cd416f81 (git): * 2018-12-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66515 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * gc.c (gc_mark_ptr): this check was introduced by accidentaly
(this is why message is "...", crazy simple) for debugging.
However, this check is useful because if there is T_NONE
object here, we can't know which object points to i... -
- * array.c (rb_ary_splice): do not use RARRAY_PTR() here because it can cause
GC because of rb_ary_detransient(). Here ary can contain T_NONE object
because of increasing capacity and not initialized yet.
error log: http://ci.rvm.j... -
- On a side note, perhaps we should add Float() to this document:
https://ruby-doc.org/core-2.5.3/Float.html
I understand that this is not part of class Float itself; but it uses
the same name (just distinguishes with the () for met... -
02:07 PM Bug #15426 (Closed): BigDecimal: "1.2.3".to_d が 0.0 になる
- bigdecimal 1.4.0.pre.20181220a で修正しました。
-
01:15 PM Revision 8a80a33b (git): Add RDoc section to NEWS
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66512 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66511 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:01 PM Bug #15453: Ruby 2.5 on Darwin appears to return different result
- Ah, thank you very much for the explanation Yusuke. I should have examined the documentation more closely.
-
- Nice try to resolve your problem with Ruby. I think that this issue fits ruby-talk mailing list.
https://www.ruby-lang.org/en/community/mailing-lists/
Best of luck on your venture. Thank you. -
- Your program is actually not deterministic. The result of `Array#sort_by!` may differ depending upon the platform. See the rdoc:
```
* The result is not guaranteed to be stable. When the comparison of two
* elements returns... -
- Hi everyone,
I'm not sure if this is the right place to report, but I hit a shocking result recently. I was developing on my OSX machine on ruby 2.5.1 and also on a linux x64 machine and noticed I was getting different results for a t... -
- It seems to be all green now. Thank you for your help.
-
08:52 AM Bug #15430: test_fork_while_parent_locked is failing status on Ruby CI
- > So reopening this. If it's just a bad check, please consider
> eliminating the check or skipping the test itself to avoid
> false-positive alarms.
OK, I rewrote the test to surgically trigger the condition
r66508. Feel free to ... -
- Applied in changeset trunk|r66508.
----------
test/ruby/test_thread.rb (test_fork_while_parent_locked): rewrite to avoid OOM
Instead of using a torture test, trigger the condition for the old
segfault in [Bug #15383] exactly.
[ruby-co... -
- As of r66497 or r66498, some Linux environments are getting:
~~~
1) Failure:
TestThread#test_fork_while_parent_locked [/home/hsbt/chkbuild/tmp/build/20181222T213003Z/ruby/test/ruby/test_thread.rb:1278]:
lower `nr' if SIGKILL beca... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66510 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66509 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:42 AM Revision 37bba27b (git): test/ruby/test_thread.rb (test_fork_while_parent_locked): rewrite to avoid OOM
- Instead of using a torture test, trigger the condition for the old
segfault in [Bug #15383] exactly.
[ruby-core:90676] [Bug #15430]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66508 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:00 AM Revision e5d63426 (git): Import CSV 3.0.2
- This includes performance improvement especially writing. Writing is
about 2 times faster.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66507 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66506 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:44 AM Bug #15454 (Closed): Add documentation for Struct#to_h with block
- Thanks for the patch.
-
02:03 AM Bug #15454 (Closed): Add documentation for Struct#to_h with block
- There is no docs about `Struct#to_h` with block.
Patch attached. -
- Good catch. Thanks!
- 03:43 AM Revision 97775478 (git): Struct#to_h: Add doc for block form.
- Patch by Shuji Kobayashi [doc] [ci skip] [#15454]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66505 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- With travis_wait, we may not need -j3 for test-all anymore, but still we
need to avoid hanging on building Ruby somehow.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66504 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- We're hitting `Expected |200 - 351| (151) to be <= 150.` in several places:
https://rubyci.org/logs/rubyci.s3.amazonaws.com/osx1012/ruby-trunk/log/20181215T094505Z.fail.html.gz
https://travis-ci.org/ruby/ruby/jobs/471483171
git-svn-id: ... -
- because travis_wait is not found via setarch
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66502 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Using -v somehow makes test-all on osx stable. Let me check if travis_wait
solves the issue or not.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66501 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- detected by coverity scan
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66500 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It fixed the issues of RubyGems 3.0.0.
https://blog.rubygems.org/2018/12/23/3.0.1-released.html
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66499 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/22/2018
-
- Applied in changeset trunk|r66498.
----------
{complex,object,rational}.c: document exception: false
From: Victor Shepelev <zverok.offline@gmail.com>
[ruby-core:90673] [Bug #15452] -
- > I understand it is pretty late, but I hope this patch could be merged before 2.6 release.
It's a race against the x-mas clock! \o/ -
07:46 PM Bug #15452 (Closed): Document exception: false for Integer() and others
- Just noticed that after #12732 there is no docs about new `exception:` option.
The patch fixes this.
I understand it is pretty late, but I hope this patch could be merged before 2.6 release.
PS: I'll provide a patch for BigDecimal... - 10:39 PM Revision 9b9fe826 (git): {complex,object,rational}.c: document exception: false
- From: Victor Shepelev <zverok.offline@gmail.com>
[ruby-core:90673] [Bug #15452]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66498 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:05 PM Revision c7dafeb2 (git): * 2018-12-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66497 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:05 PM Revision 1e30df6f (git): ostruct.rb: Accept block for to_h [#15451].
- Patch by Shuji Kobayashi.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66496 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- `Struct#to_h` がブロックを受け付けるようになったので、`OpenStruct#to_h`
も同様にしてはどうでしょうか。
パッチを添付します。 -
11:41 AM Feature #14183: "Real" keyword argument
- I'm not sure if this was discussed but one more thing to consider is hash destructuring using keywords. As far as I understand there's a use case I rely on which is going to be broken by the proposed changes. Specifically, things like
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66495 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- takashikkbn@gmail.com wrote:
> As of r66490, the test on some CIs is still failing for different reasons.
> > Expected "#<Process::Status: pid 515 SIGKILL (signal 9)>" to be empty.
OK, I lowered thread counts in r66494.
Btw, c... -
- Applied in changeset trunk|r66494.
----------
test/ruby/test_thread.rb (test_fork_while_parent_locked): reduce threads
Reduce thread counts unconditionally for some CI systems with
low limits.. And Solaris apparently lacks RLIMIT_NPRO... -
- As of r66490, the test on some CIs is still failing for different reasons.
> Expected "#<Process::Status: pid 515 SIGKILL (signal 9)>" to be empty.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian8/ruby-trunk/log/20181222T063... - 08:08 AM Revision db68ccc2 (git): test/ruby/test_thread.rb (test_fork_while_parent_locked): reduce threads
- Reduce thread counts unconditionally for some CI systems with
low limits.. And Solaris apparently lacks RLIMIT_NPROC, so we
can't detect resource limits and scale the test appropriately.
[ruby-core:90670] [Bug #15430]
git-svn-id: svn+... -
- * eval_error.c (show_cause): get rid of infinite recursion on
circular causes. [Bug #15447]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66493 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66492 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66491 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:42 AM Feature #15450 (Rejected): to be deleted
-
- https://github.com/ruby/ruby/commit/3efcb74036af32cbcc889d06d8c6c546289e89f4#r31762996
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66490 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:41 AM Revision 0fd53f51 (git): thread_sync.c (rb_mutex_t): eliminate fork_gen
- The true bug fork_gen was hiding was rb_mutex_abandon_locking_mutex
failing to unconditionally clear the waitq of mutexes it was
waiting on. So we fix rb_mutex_abandon_locking_mutex, instead,
and eliminate rb_mutex_cleanup_keeping_mutex...
12/21/2018
- 11:32 PM Revision 5072f037 (git): test/ruby/test_thread.rb: reduce thread count to avoid SIGKILL
- Perhaps this error report is down to resource limits on a VM:
http://rubyci.s3.amazonaws.com/centos7/ruby-trunk/log/20181221T230003Z.fail.html.gz
But rb_mutex_t.fork_gen is still redundant, I think.
git-svn-id: svn+ssh://ci.ruby-lang.... -
- Fwiw, I think the bug is in rb_mutex_abandon_locking_mutex,
it needs to clear the waitq unconditionally; but not touch
mutex->th or mutex->next_mutex:
https://80x24.org/spew/20181221223422.9219-1-e@80x24.org/raw
And as a result,... -
- Applied in changeset trunk|r66477.
----------
thread_sync.c (rb_mutex_cleanup_keeping_mutexes): update fork_gen
... when clearing waitq. Otherwise, we risk redundantly clearing
valid waiters in future calls to `mutex_ptr`.
Note: I am ... - 09:44 PM Revision 6f91160f (git): test/ruby/test_thread.rb: add diagnosis code for [Bug #15430]
- I can't find stderr in the test-all output of the CI machine,
so maybe the assertion will show what's going on.
http://rubyci.s3.amazonaws.com/centos7/ruby-trunk/log/20181221T170003Z.log.html.gz#test-all
git-svn-id: svn+ssh://ci.ruby-l... -
- Stefan, I've incorporated both of your suggestions. Thanks.
-
11:40 AM Feature #15446: Add a method `String#each_match` to the Ruby core
- Regarding the name – I'd prefer `String#each_match`.
And it should accept an optional block which yields the matches and (as opposed to `gsub`) returns the receiver (i.e. no substitution):
> each_match(pattern) { |match| block } →... -
- The suggested idea by Cary seems fine to me. We have to ask
matz what he thinks about the proposed idea + name choice and
functionality.
I would suggest, however had, to, if necessary, deprecate at
a later time or decouple it from ... -
- This looks like a good idea. Actually, I might suggest that we even go further: We introduce a new method and depreciate (and ultimately remove) the functionality of producing an enumerator by gsub.
(I wouldn't mind keeping producing ... -
- `String#each_match` would have two forms:
*each_match(pattern) { |match| block } → str*
*each_match(pattern) → an_enumerator*
The latter would be identical to the form *gsub(pattern) → enumerator* of [String#gsub](http://ruby-doc.... -
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66486 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66485 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Even building ruby seems to hang for unknown reasons.
https://travis-ci.org/ruby/ruby/jobs/471021727
Travis's osx environment is too fragile. Avoid anything dangerous.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66484 b2dd03c8-39... - 03:07 PM Revision 3a2c6a86 (git): * 2018-12-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66483 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- osx build has failed too often. we don't know why.
To know which test hangs forever, we might want to have hard timeout for
all test case (like 9min, slightly less than no-output timeout) in test-all.
But it's a little hard to implement... - 02:33 PM Revision 982bbc11 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66481 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The tests are really fragile with --jit-wait and it doesn't have interface
to modify this timeout at all.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66480 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- to investigate
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable11s/ruby-trunk/log/20181221T092505Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66479 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:58 PM Bug #15449: Range#=== is not using cover in Ruby 2.6
- Sorry, `Range#===` is called `Range#cover?` in Ruby 2.6.
see: https://bugs.ruby-lang.org/issues/14575 -
01:55 PM Bug #15449: Range#=== is not using cover in Ruby 2.6
- That isn't new, that is since 1.9 as #cover? was added
-
01:35 PM Bug #15449: Range#=== is not using cover in Ruby 2.6
- If that the case, this should be clarified in NEWS, because it sounds as it was changed for all cases...
-
- According to [code](https://github.com/ruby/ruby/blob/trunk/range.c#L1287), it first tries to use `range_include_internal`, which has [special handling for strings](https://github.com/ruby/ruby/blob/trunk/range.c#L1330).
Justificatio... -
- ```
irb(main):105:0> ('A'..'Z').cover? 'ANA'
=> true
irb(main):106:0> ('A'..'Z') === 'ANA'
=> false
```
Is this expected? Should `===` use cover according to NEWS in Ruby 2.6?
```
> ruby -v
ruby 2.6.0dev (2018-12-20 trun... - 01:05 PM Revision 7bef465e (git): range.c: reject ArithmeticSequence in rb_range_values
- Reject ArithmeticSequence in rb_range_values so that methods like
Array#[] raises TypeError for ArithmeticSequence as an index.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66478 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:32 PM Revision fa5601e7 (git): thread_sync.c (rb_mutex_cleanup_keeping_mutexes): update fork_gen
- ... when clearing waitq. Otherwise, we risk redundantly clearing
valid waiters in future calls to `mutex_ptr`.
Note: I am not sure if this fixes [Bug #15430], and even if it
did, fork_gen is a belt-and-suspenders redundancy for [Bug #15... - 12:32 PM Revision 2a742d5f (git): thread_sync.c (rb_mutex_abandon_keeping_mutexes): remove unnecessary check
- rb_mutex_abandon_all functions fine when passed a NULL value,
so let the compiler deal with the complexity of the branch
instead of the person reading the code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66476 b2dd03c8-39d4-4d8f-... -
- ```console
$ ./miniruby -e '
begin
raise "foo"
rescue => e1
begin
raise "bar"
rescue => e2
raise e1, cause: e2
end
end
'
Traceback (most recent call last):
Traceback (most recent call last):
Traceback (most ... -
- Applied in changeset trunk|r66475.
----------
eval_error.c (show_cause): check if cause is an Exception or not
Fixes [Bug #15447] -
- ```
$ ./miniruby -e 'raise "foo", cause: 1'
Traceback (most recent call last):
Traceback (most recent call last):
Traceback (most recent call last):
...
``` -
- Fixes [Bug #15447]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66475 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I believe this is fixed by Feature #15287
Thanks @ko1 -
- I seem to remember from the book (http://exceptionalruby.com/) by Avdi Grimm that in general, methods that have the same name as classes are more tolerant than other constructors. If I remember correctly, and this is by design, then we s...
-
- Since ruby 1.8, Ruby occurs a syntax error for ".<digit>" floating literal.
But Float() method accepts such form now.
I propose to reject ".<digit>" form even in Float() method. -
- Applied in changeset trunk|r66474.
----------
enumerator.c: Fix airth_seq_each for Rational
Fix the wrong uses of rb_int_ge in arith_seq_each.
[ruby-core:90648] [Bug #15444] - 12:03 AM Revision 09b3d38c (git): enumerator.c: Fix airth_seq_each for Rational
- Fix the wrong uses of rb_int_ge in arith_seq_each.
[ruby-core:90648] [Bug #15444]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66474 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/20/2018
- 11:29 PM Revision ccdba542 (git): Import bigdecimal-1.4.0.pre.20181220a
- * https://github.com/ruby/bigdecimal/compare/v1.4.0.pre.20181214a..v1.4.0.pre.20181220a
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66473 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
08:45 PM Bug #15444 (Closed): finite Ranges over Rationals are not iterable
- Under 2.5.3, finite ranges over rational values are iterable, given a valid step size:
~~~
((1/10r)..(1/2r)).step(1/10r).to_a
# => [(1/10), (1/5), (3/10), (2/5), (1/2)]
~~~
Under 2.6.0, this is not the case (StopIteration is rai... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66472 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66471 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:17 PM Revision b430aa3a (git): * 2018-12-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66470 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Fix GH-2052]
From: Jon Burgess <jkburges@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66469 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- "ruby -v" probably provides more information than the in-ruby
constant RUBY_VERSION alone does. -
- I have just downloaded trunk again and it seems to work now... Maybe there was some related changes or maybe I didn't have the current version and I though I had
Anyway, it seems fixed, sorry for the mess -
- Please use the latest revision of Ruby 2.6.
```
~ > ruby -v
ruby 2.6.0dev (2018-12-20 trunk 66456) +JIT [x86_64-darwin18]
~ > irb
>> [1,3,5,7,9].union([2,3,4,5,6])
=> [1, 3, 5, 7, 9, 2, 4, 6]
``` -
- @ana06 what is your build day or revision number?
because this methods where added with #14097 3 months ago -
- Using `irb` with using current Ruby trunk version:
```
irb(main):008:0> RUBY_VERSION
=> "2.6.0"
irb(main):009:0> [1,3,5,7,9].union([2,3,4,5,6])
Traceback (most recent call last):
2: from /usr/local/bin/irb:11:in `<main>'
... -
- It sound reasonable ;) this can be closed then
-
- Not a bug but a spec of `Hash#slice`. Consider the case where the keys are a range:
{ (1..) => :a, (2..) => :b, (3..) => :c }.slice(2..) #=> {2..=>:b}
Note that this behavior is not specific to endless range:
{ 1 => :a,... -
- `Hash#slice` takes an array of keys via *keys
each parameter is checked as a key in the Hash
```ruby
{ 1 => :a, 2 => :b, 3 => :c }.slice(2, 3) #=> { 2 => :b, 3 => :c }
{ 1 => :a, 2 => :b, 3 => :c }.slice([2, 3]) #=> {} [2,3]... -
- `{ 1 => :a, 2 => :b, 3 => :c }.slice(2..)` returns `{}`. I had expected that it retuns `{2=>:b, 3=>:c}` instead.
-
- 確認していただいてありがとうございます。
\# 順番がいろいろ前後して回答します。
> 以下、その他のコメントです。
> ...
なるほどー。オブジェクトに対する間接参照が減るということですね (これは
doc/extention.rdoc に載っていると嬉しいのではと思って調べて見たところ、#9894
で提案があったみたいですね)。
修正したパッチを添付します。
> (2) Infinity じゃなくて、いっそ NegativeInfin... -
- （コードのご提案時には、アイディア（アルゴリズム）を書いて頂けるとありがたいです）
パッチを見たところ、Flonum 生成時に、範囲外で heap から生成する直前に `isinf()` でチェックして、inf であれば、事前に allocate した inf オブジェクトを返す、と理解しました。
```C
if (isinf(d)) {
return d < 0 ? rb_float_negative_infinity : rb_float... -
01:24 PM Feature #15438: Threads can't switch faster than TIME_QUANTUM_(NSEC|USEC|MSEC)
- This is the implementation of option (4) on 2.5.3 (since that's what I am using). If it has a chance to be accepted, I will forward-port it to 2.6.
-
- It wrongly used all linenos of ISeq#trace_points which includes not only
line events but also call, return, and other events. So, the result
included some linenos that can not be covered at all by line coverage.
git-svn-id: svn+ssh://c... -
09:55 AM Revision 1d13610d (git): [DOC] Update CI build status badges [ci skip]
- copy from README.md
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66467 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I think I didn't have current trunk version. It seems to work no. Sorry
-
- You can check the availability of readline by this command line:
```
ruby -rreadline -ep
``` -
- The keyboard line editing behaviors are based on GNU Readline. Please install GNU Readline before you build Ruby.
For example, if you're using Ubuntu 18.10, run `sudo apt install libreadline-dev` and re-build Ruby. -
- When trying to press the UP, DOWN, LEFT and RIGHT keys in Ruby 2.6 strange characters are printed instead of moving (or showing the last executed instruction). This works properly for me in Ruby 2.5.
```
irb(main):004:0> ^[[A^[[A^[[B... -
- @shevegen I had the package install.
I have just downloaded trunk again and it seems to work now... Maybe there was some related changes or maybe I didn't have the current version and I though I had
Anyway, it seems fixed -
- > But I cant reproduce it atm...
OK, I need a break and get some sleep (but I realize 2.6 release is
is very soon).
I can reproduce [Bug #15383] with "rb_mutex_t.fork_gen" field
removed, but fork_gen shouldn't be necessary in mu... -
- > It still exists. https://rubyci.org/logs/rubyci.s3.amazonaws.com/centos7/ruby-trunk/log/20181218T230003Z.fail.html.gz
:< I am now thinking the r66230 for [Bug #15383] is
unnecessary and [Bug #15383] is a bug somewhere else.
Bu... -
- > > https://bugs.ruby-lang.org/issues/15383
> r66230 should fix it in trunk and should be backported
No, actually. r66230 hides an existing problem in the fix
for https://bugs.ruby-lang.org/issues/14578
...
Still working on th... -
- Applied in changeset trunk|r66466.
----------
hide iseq operand object for duphash. [Bug #15440]
* compile.c (compile_array): hide source Hash object.
* hash.c (rb_hash_resurrect): introduced to dup Hash object
using rb_cHash. -
06:24 AM Bug #15440 (Closed): Freeze hash literals embedded in duphash instructions
- Previously, these hash literals were not frozen, and thus could be
modified by ObjectSpace, resulting in undesired behavior. Example
(run with --disable-gems):
~~~ ruby
require 'objspace'
def a(b={0=>1,1=>4,2=>17})
b
end
... -
- * compile.c (compile_array): hide source Hash object.
* hash.c (rb_hash_resurrect): introduced to dup Hash object
using rb_cHash.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66466 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66465 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Previously, these hash literals were not frozen, and thus could be
modified by ObjectSpace, resulting in undesired behavior. Example:
```ruby
require 'objspace'
def a(b={0=>1,1=>4,2=>17})
b
end
p a
ObjectSpace.each_object(Hash) do ... -
- Applied in changeset trunk|r66463.
----------
parse.y: ignore constant name captures
* parse.y (reg_named_capture_assign_iter): ignore non-local name
captures, including non-ASCII constant names.
[ruby-dev:50719] [Bug #15437] -
- * parse.y (reg_named_capture_assign_iter): ignore non-local name
captures, including non-ASCII constant names.
[ruby-dev:50719] [Bug #15437]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66463 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- After playing around with the RC2 release, I think it's pretty good.
The only thing I'd like to see, is the use of Node instances even for cases where Array is currently used. Rather than Node.type, use explicit classes.
In additio... -
- After discussion, we decided that:
- Doing this in the GC is probably a bad idea.
- Ruby's general model for resource management is explicit, e.g. `f = File.open; f.close` or `File.open do |f| ... end`. The same model should apply to... -
- While it's not possible unless we invoke functionality from the GC, if/when we merge https://bugs.ruby-lang.org/issues/10344 it should become simple to do the following
```
while fiber.alive?
fiber.raise(Exception, "Time to die"... - 04:03 AM Revision 766f9b4a (git): Really ensure loading REXML in tests
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66462 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Bug #13423]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66461 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * tool/rbinstall.rb (load_gemspec): do not hide syntax errors in
a gemspec file. check if the result instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66460 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Time object's zone generated by Time.getlocal returns a strange value in Ruby 2.6
```
$ ruby -v -e 'p Time.new.utc.getlocal(0).zone; p Time.new.utc.getlocal(0).utc?
ruby 2.6.0dev (2018-12-17 trunk 66427) [x86_64-linux]
"UTC"
fal... - 03:08 AM Revision 3ea72d25 (git): Ensure loading REXML
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66459 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:49 AM Revision 0d1abb90 (git): rexml: upgrade to 3.1.8
- See https://github.com/ruby/rexml/blob/master/NEWS.md for change summary.
Changes for spec/ has been reported: https://github.com/ruby/spec/pull/639
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66458 b2dd03c8-39d4-4d8f-98ff-823fe... -
- We will experiment and aim to merge this into 2.7
-
12:16 AM Bug #14542 (Third Party's Issue): syswrite spuriously empties the given string
- 12:07 AM Revision 0b38221d (git): thread_pthread.c (ubf_timer_disarm): ignore EINVAL iff timer is dead
- The following race may happen if ubf_timer_destroy calls
timer_delete before ubf_timer_disarm gets called from
a different thread. Consider the following timelines:
ubf_timer_destroy | ubf_timer_disarm
----------...
12/19/2018
-
- Thread#priority can be set to negative values, which when looking at the code is meant to reduce the time allocated to the thread. However, as far as I could understand in the codebase, the quantum of time is definitely hard-coded to 100...
-
- Could someone close this report ? It's been solved as 'not a bug in Ruby'
-
08:30 PM Bug #15437 (Closed): 正規表現の名前付きキャプチャでASCII以外の大文字で定義したクラスが上書きされる
- ASCIIの大文字で定義したクラスは正規表現の名前付きキャプチャで上書きされませんが、ASCII以外の大文字で定義したクラスは上書きされてしまうようです。
これは意図的ですか？
```ruby
# rewrite_constant_by_named_capture.rb
class C
end
/(?<C>C)/ =~ "C"
p C
class 𝐂
end
/(?<𝐂>𝐂)/ =~ "𝐂"
p 𝐂
C.new
𝐂.... -
- ffi could be found here as source package: ftp://sourceware.org/pub/libffi/libffi-3.2.1.tar.gz
That one also provides ffi.h; I assume opensuse has this also packaged up somewhere, possibly
a -dev/-devel package or something.
I don... -
- ana06 (Ana Maria Martinez Gomez) wrote:
> The following tests fail when running `check make` (after `make`) in my openSUSE Tumbleweed using current Ruby trunk version:
> ...
This failure also occurs in OpenBSD. It appears to be relate... -
- The following tests fail when running `check make` (after `make`) in my openSUSE Tumbleweed using current Ruby trunk version:
```
[ 1080/19451] OpenSSL::TestEC#test_ec_point_mul = 0.00 s
... - 07:01 PM Revision cb3393ad (git): * 2018-12-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66456 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:01 PM Revision 4760b6b5 (git): * gems/bundled_gems: Upgrade the did_you_mean gem to 1.3.0
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66455 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- me@julik.nl wrote:
> It has been... a very long time. Nobu, is there something else I can do?
>
> https://bugs.ruby-lang.org/issues/11266#change-74992
Committed as r66452. Sorry for the delays, I wasn't webrick
maintainer at the... -
- Applied in changeset trunk|r66452.
----------
webrick: add the ability to override res, req creation
So that a customized HTTPServer subclass can use it's own
Request/Response classes.
To apply the override, make a subclass of WEBrick... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66454 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66453 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- From [developer's meeting log](https://docs.google.com/document/d/1q22gVRNbCIYOQw2djH4UPmT0gxVoBKvjvs0MqX5ILcU/pub):
> 2.7 or later
> ...
The last Matz's notice makes a lot of sense for me, so I withdraw my petition for `self`-less o... - 11:08 AM Revision 4038d013 (git): webrick: add the ability to override res, req creation
- So that a customized HTTPServer subclass can use it's own
Request/Response classes.
To apply the override, make a subclass of WEBrick::HTTPServer
and override the
`create_request_and_response(with_webrick_config)` method. The
method sho... -
- Hello Greg,
Many thanks for this fix. I think it's good to have one or two ci instances somewhere to not cache these files, but we should try to reduce the actual downloads as much as possible to reduce the load on the Unicode Consort... -
02:41 AM Bug #15434 (Closed): Fix up for r66448 - add option to deal with Unicode beta data files
- Appveyor build failed, Travis passed. I believe Travis is caching files, Appveyor is not.
See attached patch.
Thanks & Happy Holidays, Greg -
- Float の Infinity はしばしば使われると思うのですが、Flonum が有効でも即値に
ならないので、演算の結果や C から DBL2NUM で返却される場合などに毎回オブ
ジェクトが生成されます。
Ruby リポジトリーで、Infinity オブジェクトが生成されると明確に分かる場所を簡
単に調べた限りでは20数箇所ありました。
~~~
$ grep 'DBL2NUM.*HUGE_VAL' $(git ls-files | awk '/... -
- Don't mind, one-line comment may be overlooked easily.
I'll paste the content not only a link, next time. -
- https://blog.rubygems.org/2018/12/19/3.0.0-released.html
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66451 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66450 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The option --unicode-beta for tool/downloader.rb introduced in
r66448 must not be passed as an option to actual download machinery.
Thanks to MSP-Greg (Greg L.) for bug report and patch.
This closes issue #15434.
git-svn-id: svn+ssh://c... -
- @normalperson
It still exists. https://rubyci.org/logs/rubyci.s3.amazonaws.com/centos7/ruby-trunk/log/20181218T230003Z.fail.html.gz -
- Eric Wong wrote:
> ko1 brought up a good point: this may interact badly with
> 3rd-party libraries which use thread-local storage via
> pthread_getspecific/pthread_setspecific (or compiler
> extensions).
> So, we might need to d... -
- Thank you, ko1 and nobu :)
-
- Unicode uses file names with explicit versions for beta publication.
This commit introduces a variable on the makefile level to distinguish
between beta and regular versions of file names.
common.mk: Define new variable UNICODE_BETA, us...
12/18/2018
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66447 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Are you sure that .call had the same meaning as to_proc?
I vaguely remember the old pickaxe having mentioned .call a
lot, but I can not recall it having mentioned to_proc much
at all. It has been quite some years since I last had a ... -
07:35 PM Bug #15390: Error installing nokogiri on ruby-2.6.0-rc1
- Thank you Nobuyoshi!
As you know, I indeed was overlooking something, specifically your comment and link on note #2 when you correctly changed the Status to "Third Party's Issue." I saw the workaround in note #1 and the confirmation ... -
- Thank you for your report.
This issue was from Ruby 2.0 :p
-
- Applied in changeset trunk|r66436.
----------
should use defined_class.
* vm_insnhelper.c (vm_call_method_each_type): we should use me->defined_class
instead of me->owner because me->owner doesn't has correct ancestors list.
[Bug #... - 06:25 PM Revision a57acb73 (git): thread_pthread.c (ubf_timer_destroy): more careful state transition
- We must not call timer_destroy while another thread is
calling timer_settime to arm the timer.
cf. http://ci.rvm.jp/results/trunk-iseq_binary@silicon-docker/1541578
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66446 b2dd03c8-39d4-... -
- ```
I've hit this with parallel tests on a bare trunk on all my Debian stable
machines, not sure why, yet:
1)
OpenStruct#method_missing when passed additional arguments raises a NoMethodErro
r ERROR
NameError: undefined local var... -
05:14 PM Feature #15393: Add compilation flags to freeze Array and Hash literals - > I would like to add VM compilation options to freeze array and hash literals. For example:
My two samples:
~~~ ruby
#!/usr/local/bin/ruby -w
def frequency(text)
def prepare_string(text)
text.gsub!(",", "") ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66445 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66444 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:11 PM Revision 7b6f2e2c (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66443 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66442 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:06 PM Revision 011bee2d (git): * 2018-12-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66441 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66440 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r66439.
----------
Enable refinements on symbol-proc in ruby-level methods
* vm_args.c (refine_sym_proc_call): resolve refinements when the
proc is invoked, instead of resolving at making the proc, to
ena... -
- * vm_args.c (refine_sym_proc_call): resolve refinements when the
proc is invoked, instead of resolving at making the proc, to
enable refinements on symbol-proc in ruby-level methods
* vm.c (vm_cref_dup): clear cached symbol-procs wh... -
- I like the idea from one point of view - **convenience**. A bit
similar to changes such as require 'pp' being available by default;
of course it is not the same as the proposal here, since the
proposal here refers to a syntax change, ... -
- It has been already proposed at #10528.
-
04:14 AM Misc #15431 (Open): Hashes and arrays should not require commas to seperate values when using new lines
- Ruby should not require commas for hash and array values if using new lines. I think the syntax would look cleaner without.
**Example**
~~~
myHash = {
:key => “value”,
:anotherKey => “another value”
}
~~~
**Could be**
~~~
... -
- r66438 should fix it. Sorry for the bugs :x
-
- Applied in changeset trunk|r66438.
----------
thread_sync.c (mutex_ptr): only reinitalize waitqueue at fork
Mutexes need to remain locked after forking.
This fixes "[BUG] invalid keeping_mutexes: Attempt to unlock a
mutex which is loc... -
- r66438 should fix it. Ugh, I clearly shouldn't be allowed near
a keyboard anymore :< -
- Applied in changeset trunk|r66438.
----------
thread_sync.c (mutex_ptr): only reinitalize waitqueue at fork
Mutexes need to remain locked after forking.
This fixes "[BUG] invalid keeping_mutexes: Attempt to unlock a
mutex which is loc... -
- Thanks. Maybe related to [Bug #15430]. Will investigate in coming days.
-
- After r66230, TestThread#test_fork_while_parent_locked is failing status on Ruby CI.
See
* CentOS 7 https://rubyci.org/logs/rubyci.s3.amazonaws.com/centos7/ruby-trunk/log/20181217T230002Z.fail.html.gz
* Amazon Lunux 2 https://ruby... - 09:21 AM Revision 1df9c2bc (git): thread_sync.c (mutex_ptr): only reinitalize waitqueue at fork
- Mutexes need to remain locked after forking.
This fixes "[BUG] invalid keeping_mutexes: Attempt to unlock a
mutex which is locked by another thread" and should
fix test_fork_while_parent_locked failures in CI
[ruby-core:90581] [Bug #15... -
- Float の NaN のみを含む配列比較のテストが以下にあります。
~~~ ruby
## spec/ruby/core/array/equal_value_spec.rb:47
# As per bug #1720
it "returns false for [NaN] == [NaN]" do
[nan_value].should_not == [nan_value]
end
~~~
しかし、これは #1720 で未定義動作とすると... - 08:33 AM Revision 47127762 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66437 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_insnhelper.c (vm_call_method_each_type): we should use me->defined_class
instead of me->owner because me->owner doesn't has correct ancestors list.
[Bug #15427]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66436 b2dd03c8-... - 08:11 AM Revision 84b49707 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66435 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66434 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66433 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Merged in r66432, thanks!
-
- 05:09 AM Revision ab364fb5 (git): Import ipaddr 1.2.2
- - Enable frozen_string_literal and do a bit of code cleanup
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66432 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:09 AM Revision 78dc3da2 (git): Pathname#relative_path_from uses is_a?
- I reconsidered because simpler code would have better maintainablity.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66431 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66430 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- こんなところでしょうか。
```diff
diff --git i/ext/bigdecimal/bigdecimal.c w/ext/bigdecimal/bigdecimal.c
index 64d7f20078..052fdc57b9 100644
--- i/ext/bigdecimal/bigdecimal.c
+++ w/ext/bigdecimal/bigdecimal.c
@@ -4271,7 +4271,7 @@ VpAlloc(siz...