Activity
From 08/12/2017 to 08/18/2017
08/18/2017
-
10:36 PM Feature #13828 (Closed): Win32ole extension should support licensed COM servers
- Current implementation doesn't support licensed COM servers. I've added keyword argument `:license` which when used switches to using `IClassFactory2::CreateInstanceLic` instead of `CoCreateInstance`.
Default behaviour was not touched... -
12:44 PM Revision e3c42f53 (git): vm_insnhelper.c: vm_cfp_consistent_p
- * vm_insnhelper.c (vm_cfp_consistent_p): extracted the conditions
for cfp consistency.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59619 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- * vm_insnhelper.c (rb_threadptr_stack_overflow): rb_fatal is not
available during GC. raise the preallocated fatal error.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59618 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:59 AM Feature #13827 (Closed): Improve performance of `Base64.urlsafe_encode64`
- Improve performance of `Base64.urlsafe_encode64` by avoiding unnecessary memory allocations. This may seem insignificant, but for the web service I am working on this patch makes noticeable improvement.
### Benchmark
~~~ ruby
requ... -
10:01 AM Feature #13812: Refinements で定義した to_s を String interpolation が呼んでくれない
- そうですね。
先に答えを出しておくと、この場合のto_sは(そのコンテキストでの呼び出しと解釈できるので)refinementの対象になったほうが良いように思います。
Matz.
-
09:13 AM Feature #13812: Refinements で定義した to_s を String interpolation が呼んでくれない
- shugo さん
> Refinements導入時の議論で暗黙のメソッド呼び出しには影響しないようにするという判断が
> ...
なるほど。
> 仕様変更の議論は英語でやった方がよいですかね。
英語で新規にチケットを起票した方が良いでしょうか？
それともこのチケットの Title と Description を編集して英語に書き換えた方がいいですか？
-
08:18 AM Feature #13812: Refinements で定義した to_s を String interpolation が呼んでくれない
- 匿名ユーザー wrote:
> 既出だったらすみません。bugs.ruby-lang.org でも検索したんですが
> ...
Refinements導入時の議論で暗黙のメソッド呼び出しには影響しないようにするという判断が
ありましたが、その後一部の暗黙のメソッド呼び出しには影響するようになったので
string interpolationでも使えるようにしてもよいかもしれません。
最終的にはまつもとさんの判断になると思いますが、仕様変更の議論は英語でやっ... -
- Applied in changeset trunk|r59617.
----------
test/net/imap/test_imap.rb: Use Addrinfo.tcp in case localhost is ::1.
[ruby-dev:50208] [Bug #13825] -
- IMAPTest#test_starttls hangs.
See http://ci.rvm.jp/results/trunk@P895/4443 for details.
-
- [ruby-dev:50208] [Bug #13825]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59617 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- williamn (William Newbery) wrote:
> shevegen (Robert A. Heiler) wrote:
> ...
`??` is a string literal, and `//` is a regexp literal.
> ```ruby
> ...
Why not keyword arguments?
08/17/2017
-
- * method.h (rb_method_definition_t): rb_method_type_t should be
unsigned as it needs 5bits at least for signed extension.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59616 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:34 PM Revision 7b15bd95 (git): * 2017-08-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59615 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:34 PM Revision d067b263 (git): Add optimization for creating zerofill string
- ```
require 'benchmark'
n = 1 * 1024 * 1024 * 1024
Benchmark.bmbm do |x|
x.report("*") { 0.chr * n }
x.report("ljust") { String.new(capacity: n).ljust(n, "\0") }
end
```
Before
```% ./ruby test.rb
Rehearsal ------------------------... -
03:08 PM Bug #13794: Infinite loop of sched_yield
- The patch above does not work because native_reset_timer_thread runs after fork in the parent. Attached an alternative patch that runs in gvl_atfork and appears not to run in the parent. Again I do not believe this is necessarily the cor...
-
- I am now testing the following patch:
~~~
diff --git a/thread_pthread.c b/thread_pthread.c
index 4aa2d620a2..fe99524a54 100644
--- a/thread_pthread.c
+++ b/thread_pthread.c
@@ -1685,6 +1685,7 @@ native_stop_timer_thread(void)
s... -
- Applied in changeset trunk|r59613.
----------
vm_method.c: alias warning at refined method
* vm_method.c (rb_method_entry_make): suppress a warning at
refined method which will not be redefined.
[ruby-core:82385] [Bug #13817] -
- It's a ruby's bug.
"old <<" means a refined method, but it is not redefined actually.
```ruby
class C
def t; :t; end
def f; :f; end
end
module M
refine C do
alias foo t
end
end
class C
alias foo f
end
... -
- * vm_method.c (rb_method_entry_make): suppress a warning at
refined method which will not be redefined.
[ruby-core:82385] [Bug #13817]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59613 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * method.h (rb_method_definition_t): define type as an enum for
debugging.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59612 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parser_number_literal_suffix): keep token after numeric
suffix to show the value in an error message.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59611 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:31 PM Revision e60c38cb (git): * 2017-08-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59610 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:31 PM Revision 50df0467 (git): Use `*` instead of `**` in .editorconfig
- It seems `**` is same as `*` when no `/` exist.
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59609 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:28 AM Feature #9450: Allow overriding SSLContext options in Net::HTTP
- Being able to exclude versions of TLS and/or add additional option flags (without monkey patching) would indeed be quite useful, especially in the cases where TLS 1.0 needs to be excluded for compliance reasons. Hopefully this issue will...
-
03:47 AM Misc #13819 (Closed): removing issues... [p *local vars]
- OK, closing as per request.
-
- Andreas, it's easy to say "might be improved", but without the concrete design, it's worth nothing for us.
We designed for reasons, with the balance of features. Please submit the proposal, if you come up with the new idea.
Matz. -
12:01 AM Feature #13820: Add a nil coalescing operator
- williamn (William Newbery) wrote:
>
> ...
Not in perl ;)
>
> ...
Yes, short-circuit is handy. It's why I was a proponent of `&.`. Maybe it's okay to add `//` even if it's only used sometimes.
08/16/2017
-
11:45 PM Feature #13820: Add a nil coalescing operator
- shevegen (Robert A. Heiler) wrote:
> By the way, did you actually propose an actual syntax? The two '?'?
Not really personally set on any given syntax, just `??` and `//` are familiar to me from other programming. Although actually f... -
- In perl I find `$x // $y` useful vs `$x || $y` because sometimes you want to accept `""` and `0` as values.
In ruby the only 'defined' falsey value is `false`, so I'm not sure how useful this feature is here.
If you're pulling opti... -
12:44 PM Feature #13820: Add a nil coalescing operator
- I am not sure that using a special-purpose operator would make a lot of sense.
I myself use nil primarily as means to indicate a default, "non-set" value. The
moment it is set to a boolean, be it false or true, is for me an indicatio... -
- It would be nice if Ruby had an operator that only considered `nil` as false, like the null coalescing operators or "Logical Defined-Or operator" (Perl) found in some other languages. Ive seen things like `//` and `//=`m `??` and `??=`, ...
-
- opti (Andreas Opti) wrote:
> >If you want the same behavior, you need to use parentheses:
> ...
Most people wouldn't write it in the first place.
You *could*, if you really, really wanted to do a multiple assignment **and** capture ... -
09:34 PM Bug #13815 (Open): p args
- >If you want the same behavior, you need to use parentheses:
> ...
# ok, but also with ((...)) [most people] would assume its meaning is (x, y=x+1, y+1)...
*Other example:
p(x+=1,x+=1) # ok
p (x+=1,x+=1) # error
p ((x,y)=[x+1,... -
- output [time1,time2] of daysaving-changes of given year
I assume the result does not depend on timezone,
only the output will be in default timezone.
-
- ok - thanks for the number!
Now [whoever] can delete this issue.
-
- You mean #13815? Seems not deleted to me.
-
- Hi
Its not nice to remove issues, I invested much time to test it, also with different Ruby-versions,
so please at least tell me (maybe via Mail), why you deleted that issue.
After having put it in the buglist, I deleted all my files ... -
06:20 PM Feature #11210: IPAddr has no public method to get the current subnet mask
- @knu: Could you review the PR and decide whether to merge it?
-
05:19 PM Feature #13821 (Assigned): Allow fibers to be resumed across threads
- Given a Fiber created in ThreadA, Ruby 2.4.1 (and earlier releases) raise a FiberError if the fiber is resumed in ThreadB or any other thread other than the one that created the original Fiber.
Sample code attached to demonstrate prob... -
09:46 AM Bug #13808 (Closed): lib/ipaddr.gemspec includes `git ls-files -z`
- Applied in changeset trunk|r59608.
----------
Extract files variables of ipaddr.gemspec for non git environment.
[Bug #13808][ruby-core:82358] -
- [Bug #13808][ruby-core:82358]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59608 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59607.
----------
Added gemspec of digest library.
standalone repository is https://github.com/ruby/digest
[Misc #13771][ruby-core:82179] -
- standalone repository is https://github.com/ruby/digest
[Misc #13771][ruby-core:82179]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59607 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:22 AM Feature #5481: Gemifying Ruby standard library
- I like the idea that you could "update your standard library", for example, you are using Ruby 2.5.2, but want the standard library of 2.6.1. (as long as every gem in 2.6.1 is compatible with your old version of Ruby), which would be pos...
-
- > zenspider
Thanks for your offer. meta-gem idea is useful for update default gems.
Could you transfer ownership of `ruby` namespace to me? -
02:38 AM Feature #5481: Gemifying Ruby standard library
- Hi hi... if you all want a meta-gem that you can version along with your releases and have it point to all the originally bundled gems, I am happy to transfer the `ruby` gem over to you. I was trying to get this ball rolling a long time ...
-
- Applied in changeset trunk|r59606.
----------
vm_insnhelper.c: cfp error at stack overflow
* vm_insnhelper.c (threadptr_stack_overflow): set stack overflow
flag until handling execptions, to get rid of cfp consistency
error when ex... -
- * vm_insnhelper.c (threadptr_stack_overflow): set stack overflow
flag until handling execptions, to get rid of cfp consistency
error when exec tag was rewound. [ruby-core:80618] [Bug #13412]
git-svn-id: svn+ssh://ci.ruby-lang.org/r... -
- I think that this is a pretty big undertaking, irrelevant of pros or cons
to it (which surely exist).
Bundler is popular, there is no doubt about this even though I myself do not
use it - at https://rubygems.org/stats bundler is ran...
08/15/2017
-
- I confirmed to fix `TestDir_M17N#test_filename_extutf8_invalid` and `TestDir_M17N#test_glob_encoding` by r59602.
-
- Applied in changeset trunk|r59602.
----------
High Sierra's APFS cannot use invalid filenames [Bug #13816] -
- I found fail results of `make test-all` with High Sierra Beta 6 and APFS.
```
~/D/r/trunk > mk test-all
Run options: "--ruby=./miniruby -I../../github.com/ruby/ruby/lib -I. -I.ext/common ../../github.com/ruby/ruby/tool/runruby.rb -... -
11:44 PM Bug #13817: test/unit breaks Hash
- Great!
-
03:19 PM Bug #13817: test/unit breaks Hash
- Bug reported at https://github.com/k-tsj/power_assert/issues/19
-
- It's not caused by test-unit. It's caused by power_assert.
Please report it to https://github.com/k-tsj/power_assert/issues/new with the following script:
```ruby
#!/usr/bin/env ruby
$VERBOSE = true
require 'power_assert/enable_... -
- Consider the following program:
~~~ruby
#!/usr/bin/env ruby
BEGIN {$VERBOSE = true}
require 'test/unit'
class Hash
STDERR.puts method_defined?(:<<)
alias << merge!
STDERR.puts method_defined?(:<<)
end
~~~
In older Ru... -
- revert unexpected changes
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59605 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59604 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:33 PM Revision d441144b (git): * 2017-08-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59603 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59602 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:35 PM Feature #12282: Hash#dig! for repeated applications of Hash#fetch
- How about this name?
~~~
places.deep_fetch(:countries, :canada, :ontario)
~~~
I've encountered the case which I did "places.fetch(:countries).fetch(:canada).fetch(:ontario)" multiple times. I want this method. -
02:00 PM Bug #13412: Infinite recursion with define_method may cause silent SEGV or cfp consistency error
- I reproduced this bug with 2.2.7, 2.3.4 and 2.4.1.
~~~
docker run ruby:2.2.7-alpine ruby -e 'define_method(:foo) { foo }; loop { 1.times { 1.times { begin; foo; rescue Exception; nil; end } } }'
docker run ruby:2.3.4-alpine ruby -e ... -
01:54 PM Bug #13818 (Closed): Licence issue with use of Onigmo rather than Oniguruma library files
- I am concerned about the current content of the https://github.com/ruby/ruby/blob/trunk/LEGAL file which implies that Ruby is using Oniguruma when in fact the forked Onigmo is what is in place - the licence of both are BSD (AFAICT) but t...
-
- * parse.y (singleton): literal nodes are always value expressions,
no check is necessary.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59601 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:12 PM Revision a70804da (git): Remove not exist arguments from comments of insns
- is_local argument was introduced on r11639 and removed on r11813.
* insns.def (getinstancevariable, setinstancevariable): Remove a not
exist argument.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59600 b2dd03c8-39d4-4d8f-98ff-82... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59599 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- > Can you also check the value of timer_thread_pipe.owner_process?
~~~
(gdb) print timer_thread_pipe.writing
$1 = 1
(gdb) print timer_thread_pipe.owner_process
$2 = 0
(gdb) info threads
Id Target Id Frame
2 ... -
- I send a pull request to upstream: https://github.com/ruby/ipaddr/pull/1
-
- Applied in changeset trunk|r59598.
----------
ftp.rb: fix example format [ci skip]
* lib/uri/ftp.rb: [DOC] fix format of example URLs. patched by
aycabta (Code Ahss) at [ruby-core:82379]. [Bug #13814] -
- * lib/uri/ftp.rb: [DOC] fix format of example URLs. patched by
aycabta (Code Ahss) at [ruby-core:82379]. [Bug #13814]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59598 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59597.
----------
ripper.rb: fix License format [ci skip]
* ext/ripper/lib/ripper.rb: [DOC] fix format of the License
description and the author. patched by aycabta (Code Ahss) at
[ruby-core:82376]. [B... -
- * ext/ripper/lib/ripper.rb: [DOC] fix format of the License
description and the author. patched by aycabta (Code Ahss) at
[ruby-core:82376]. [Bug #13813]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59597 b2dd03c8-39d4-4d8f-9... -
- * compile.c (compile_retry): extract from iseq_compile_each.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59596 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (compile_redo): extract from iseq_compile_each.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59595 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (compile_next): extract from iseq_compile_each.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59594 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/14/2017
-
- * compile.c (compile_break): extract from iseq_compile_each.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59593 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:11 PM Bug #13815 (Rejected): p args
- opti (Andreas Opti) wrote:
> x=y=0 # outside defined vars!
> ...
This makes sense once you understand how ruby parses the p method call:
~~~ ruby
3.times { p((x),(y = x+1),(y+1)) }
~~~
If you want the same behavior, you need t... -
- x=y=0 # outside defined vars!
3.times { x,y = x+1,y+1 } # as expected: x==3
3.times { p(x,y = x+1,y+1) } # NOT as expected: x not changed!
# x,y are the same vars as above. p shoudn't have any effect on scope
-
- x=y=0 # outside defined vars!
3.times {|i| x,y=x+1,y+1 } # as expected: x==3
3.times {|i| p(x,y=x+1,y+1) } # NOT as expected: x not changed!
# x,y are the same vars as above. p shoudn't have any effect on scope
-
05:37 PM Misc #13814 (Closed): URI::FTP documentation for RDoc is broken
- This is related to #13813.
In lib/uri/ftp.rb, documentation for #path below:
```ruby
# Returns the path from an FTP URI.
#
# RFC 1738 specifically states that the path for an FTP URI does not
# include the / whi... -
05:30 PM Bug #13810: Inconsistency between Date and Time.strftime("%v")
- Ruby's `Time.strftime` method (where `%v` is equivalent to `%e-%^b-%4Y`) is compatible with VMS time format, and `Date.strftime` and `DateTime.strftime` (where it is equivalent to `%e-%b-%Y`) are not, according to section 27.1.1 Absolute...
-
- At r31672, date changed it but no description or rationale.
> * ext/date/date_strftime(date_strftime_with_tmx): "%v" means "%e-%b-%Y".
Does anybody have any pointers? -
- Dir.children(dir) behaving as Dir.entries(dir) - ['.', '..'] would be nice.
I have wished many times Dir would have such a method, and the ./.. are almost never useful. - 04:04 PM Revision 12693e24 (git): * 2017-08-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59592 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:04 PM Revision fda03715 (git): fix documentation of REXML::Formatters::Default (id_hack -> ie_hack) [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59591 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- In ext/ripper/lib/ripper.rb, license section of documentation for RDoc below:
```ruby
# == License
#
# Ruby License.
#
# Minero Aoki
# aam... -
- * compile.c (compile_loop): extract from iseq_compile_each.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59590 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59589 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:26 PM Revision aeb7f8a9 (git): * 2017-08-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59588 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/objspace/object_tracing.c (allocation_sourceline): Fix
a class of a returned value. allocation_sourceline returns
an integer.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59587 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- 谷道さん
引き続き、メーリングリストで議論していただいて構いません。
Refinements については shugomaeda さんが担当となっているため、assign を明確にする意図でメールの内容を issue チケットとしてこちらの tracker に登録しておきました。
-
- https://github.com/nobu/ruby/tree/feature/refine-tostring
-
10:51 AM Feature #13812: Refinements で定義した to_s を String interpolation が呼んでくれない - あ、もしかしてバグでした？英語で ruby-core に投げた方が良かったかな。
ruby-lang.org のメーリスに投げるの初めてで、慣習がよく分かってないです、すみません。
--
谷道 創（Tsukuru Tanimichi）
https://ttanimichi.com/ -
- 10:01 AM Feature #13812 (Closed): Refinements で定義した to_s を String interpolation が呼んでくれない
- はじめまして。谷道と申します。
既出だったらすみません。bugs.ruby-lang.org でも検索したんですが
それっぽいチケットが見当たらなかったので確認させてください。
Refinements で定義した to_s を String interpolation が呼んでくれないのですが、これって仕様なんですかね？
String literal の評価が using B しているスコープの外で行われる、ということでしょうか。
```
$ r... -
- And a typo in `"a\u0300".each_chars.to_a.size #=> 2`,
should be `"a\u0300".each_char.to_a.size #=> 2` -
- Great to see this implemented!
One tiny thing I've noticed:
- For non-Unicode strings, `\X` will still match "\r\n" as a single grapheme. This should probably also be the case with `String#each_grapheme` - or the difference should be... -
- nobu (Nobuyoshi Nakada) wrote:
> naruse (Yui NARUSE) wrote:
> ...
Ah, it should be chars; thanks!
08/13/2017
-
10:52 PM Feature #13805: Make refinement scoping to be like that of constants
- jeremyevans0 (Jeremy Evans) wrote:
> You probably want to read the very long issue that introduced refinements (#4085), which contains the reasoning.
I thought there'd be one of these long discussions floating around, thanks for the ... -
09:45 PM Bug #13811 (Closed): Ruby 2.4.1 fails to compile inside qemu armhf - signal 11 (Segmentation fault)
- I'm using this Dockerfile to compile: https://github.com/docker-library/ruby/blob/ecbfdeb2b71e155222b1d3df0a33685247f00616/2.4/alpine3.6/Dockerfile, except with FROM resin/armhf-alpine (https://hub.docker.com/r/resin/armhf-alpine/) which...
-
- This seems odd. Each function matches its documentation, but the document and implementation of `Date.strftime("%v")` differs from the documentation and implementations of `Time.strftime("%v")` and `DateTime.strftime("%v")`.
```
ruby... -
- Applied in changeset trunk|r59585.
----------
parse.y: set used flag in gettable
* parse.y (dvar_defined_ref, dvar_defined): rename macros. only
gettable uses the former. assignable should not set LVAR_USED
flag.
* parse.y (gett... -
12:42 PM Bug #13809 (Closed): Unused variable warning does not occur when a method with the same name was called
- ## problem
~~~ ruby
a = 1
a()
~~~
`a` is unused, but `ruby -cw` does not add warning for this code.
~~~
$ ruby -cw test.rb
Syntax OK
~~~
## Cause
The parser changes mode by lvar definition. At that time, pars... -
- * spec/mspec/lib/mspec/utils/script.rb (entries): skip empty
directories so that at least one file would run.
Merged https://github.com/ruby/spec/issues/459
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59586 b2dd03c8-39d4-4d8f-9... -
- * parse.y (dvar_defined_ref, dvar_defined): rename macros. only
gettable uses the former. assignable should not set LVAR_USED
flag.
* parse.y (gettable_gen): set used flag on local/dynamic variables
instead of setting in lexer. ... - 12:14 PM Revision 2bbc3052 (git): REXML: Fix a bug that unexpected methods can be called as a XPath function
- [HackerOne:249295]
Reported by Andrea Jegher. Thanks!!!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59584 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/stringio/stringio.c (strio_read): suppress an
implicit-fallthrough warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59583 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/stringio/stringio.c (strio_gets): should return string with
the external encoding, at empty chomped result .
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59582 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/stringio/stringio.c (strio_gets): should return string with
the external encoding, at empty result.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59581 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- naruse (Yui NARUSE) wrote:
> ```diff
> ...
Why codepoints?
08/12/2017
- 05:41 PM Revision c5f66a37 (git): * 2017-08-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59580 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59579 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ```diff
diff --git a/NEWS b/NEWS
index 4bfca9240c..1e66e94879 100644
--- a/NEWS
+++ b/NEWS
@@ -94,6 +94,7 @@ with all sufficient information, see the ChangeLog file or Redmine
* String#delete_prefix! is added to remove prefix de... -
04:03 PM Feature #13795: Hash#select return type does not match Hash#find_all
- > In the worst case, ruby 3.x may accept backwards-incompatible changes so either way
> ...
I fully agree that changing Hash#select and #reject (or even #find_all) should not be a 2.x change! -
- > > Also, as a side note, it seems that Hash#select and #reject really are the only two methods that behave this way. And even inside Hash, methods like #collect, #collect_concat, #drop, #drop_while, #grep, #max, #max_by, #min, #min_by...
-
02:53 PM Feature #13795: Hash#select return type does not match Hash#find_all
- Changing the behavior of Hash#select/reject broke a lot of files, some in [very strange ways](https://travis-ci.org/ruby/ruby/builds/263508096?utm_source=github_status&utm_medium=notification).
This makes me think that such a change w... -
- On 2017/08/11 01:12, david.n.arnold@gmail.com wrote:
> Also, as a side note, it seems that Hash#select and #reject really are the only two methods that behave this way. And even inside Hash, methods like #collect, #collect_concat, #... -
- > Ruby has been not backwards-compatible in several releases, so I don't see that as
> ...
It all depends on matz, whether he agrees with the assessment or whether he does not.
I won't comment on the proposal and discussion as such, th... -
- It seems useless without method chain, i.e., variable `a` is too simple as an example.
That is, this is a variant of `yield_self`.
```ruby
foo.bar.zot.yield_self {|a| a.some_condition ? a : b}
```
or
```ruby
foo.bar.zot.ve... -
- I don't see any improvement. The new way that would be possible with the `verify` method is longer and more complicated than the simple and straightforward `a.some_condition ? a : b`.
-
- I have no particular pro or con opinion about your proposal, but I just
want to say that the last variant is not very pretty.
The lonely guy operator staring at the dot before him is pressed hard
against the wall behind him there, t... -
- `git ls-files -z` in gemspec may occur error.
see https://bugs.ruby-lang.org/issues/13423 and/or https://bugs.ruby-lang.org/issues/12736 -
-
- Yes, works as the code specifies, not a bug, so misfiled.
I anyone wants to test via copy/paste into IRB, here is a slightly reformatted variant:
```ruby
y = 1
loop do
y += 1
next unless y % 2==0
puts y
break if y >... -
- I do not think that issue #4085 necessarily has to be the "one and only one true refinement", in
particular if we keep in mind that towards ruby 3.x, even syntax changes could happen if they
may make sense (and matz would approve).
... -
- Applied in changeset trunk|r59578.
----------
stringio.c: encoding at EOF
* ext/stringio/stringio.c (strio_read): should return string with
the external encoding, at EOF too.
[ruby-core:82349] [Bug #13806] -
- * ext/stringio/stringio.c (strio_read): should return string with
the external encoding, at EOF too.
[ruby-core:82349] [Bug #13806]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59578 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:34 AM Revision 201d0e7e (git): * 2017-08-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59577 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/stringio/test_stringio.rb (test_read): add assertions
of return value of read with a buffer string.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59576 b2dd03c8-39d4-4d8f-98ff-823fe69b080e