Activity
From 08/19/2017 to 08/25/2017
08/25/2017
-
11:44 PM Feature #13839: String Interpolation Statements
- It might be better to compare this to Erubi, the current default ERB template processor in Rails and Tilt. While this approach is fast for small strings, it's actually slower for large strings (probably due to the use of `+=` instead of...
-
10:34 PM Feature #13839 (Rejected): String Interpolation Statements - Hello!
Here is a KISS implementation of a template engine in Ruby:
~~~ ruby
class Template
attr_reader :input
def initialize(input)
@input = input
end
def output
"output = %\0" + @input.gsub("{%", "\0... - 03:47 PM Revision c150c787 (git): * 2017-08-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59659 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:47 PM Revision 11d419ad (git): `$IGNORECASE` is no longer effective. [ci skip]
- * lib/English.rb: [DOC] `$IGNORECASE` is no longer effective.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59658 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:01 PM Bug #13757: TestBacktrace#test_caller_lev segaults on PPC
- BTW, very likely unrelated, but I noticed, that on PCC64 (BE), the C level backtrace is not correctly collected. It looks like:
~~~
-- C level backtrace information -------------------------------------------
[0x4ef7a734]
[0x4ef7a8... -
- Ok, so I did my homework :) It started with r59047 and it is issue for ppc64/ppc64le. No other Fedora architectures are affected. Since this release, the test suite always get stuck at TestBacktrace#test_caller_lev. Later, since r59159, ...
-
08:13 AM Revision 20c5f607 (git): csv.rb: optimize CSV::Table#to_a and #to_csv
- * lib/csv.rb (CSV::Table#to_a, #to_csv): use Array#push instead of
Array#concat for performance improvement. This performance improvement is
proposed by zdennis <zach.dennis@gmail.com>. The patch is from
Mau Magnaguagno <maumagnagu... -
03:41 AM Revision c0baa381 (git): compile.c: unreachable chunk
- * compile.c (iseq_peephole_optimize): remove unreachable chunk
which appeared by useless jump elimination.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59656 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (iseq_peephole_optimize): eliminate useless if/unless
just before jump.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59655 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:37 AM Revision 5ccf7b06 (git): * 2017-08-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59654 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (iseq_peephole_optimize): moved comments inside proper
blocks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59653 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:16 AM Feature #13801: Implement case equality test for Set#===
- Here's a counterexample with Array:
~~~ ruby
[1, 2, 3] === 2 #=> false
~~~
Array#=== doesn't look inside the array. I expect Set to act almost like Array, so it would be weird if Set#=== looked inside the container but Array#=== ... -
- Turns out that `open(temp_file, 'a')` works with the original open, but fails after loading open-uri.
This is because the instances of Tempfile respond to `to_path`, just like instances of File or Pathname. So `open(temp_file, 'a')` a... -
- It makes many conflicts with the current syntax.
I don't think it is easy to resolve. -
01:04 AM Feature #13667: Add Coverage.running? to quickly check if Coverage is enabled.
- I also think `running?` is better. And I feel `#test_coverage_running?` is good enough :)
-
12:56 AM Feature #13667: Add Coverage.running? to quickly check if Coverage is enabled.
- Sorry for the late reply. I'm positive for this proposal.
There is the same request #13838, which reminds me of this ticket. That issue proposes `Coverage.enabled?`. I'm unsure, but `running?` seems a bit better to me because the s... -
- Sorry I overlooked the issue :)
-
- I think this is a duplicate of #13667. Let us discuss this issue in that ticket. Thank you!
-
- ## Description
I want to detect current status of Coverage, which is enabled or not.
Now we can detect status only trying `Coverage.peek_result` or `Coverage.result` and catch RuntimeError.
Attached patch enable us to detect status ...
08/24/2017
-
- This ES6 syntax for hash literals looks strange to me. I have never seen it before today, but I have not written JavaScript for a few years, and I am not using Ruby for web development.
Two things puzzle me:
1. What is the key in `... -
03:55 AM Feature #11105: ES6-like hash literals
- This syntax is now widely known and popular in the JavaScript/ES world. It is frequently used in everyday code and we've grown used to it.
-
07:40 AM Feature #8781: Use require_relative() instead of require() if possible
- Martin Dürst wrote back then:
> On the other hand, 'require' has a tighter coupling to the file
> ...
Both have a similar requirement - you need to pass in the name of
the file at question.
Both also require some information to t... -
- * compile.c (iseq_set_sequence): show failed instructions at
adjuststack mismatch.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59652 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:26 AM Revision 20c29411 (git): * 2017-08-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59651 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59650 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/23/2017
-
04:47 PM Bug #13837: Class attributes get overshadowed by local variables
- shevegen (Robert A. Heiler) wrote:
> Even the old pickaxe mentions that ruby may behave slightly unexpected
> ...
I still can't consider this correct behavior. Aren't the multi-line and the single-line ways of writing `if` supposed to ... -
- I think hanmac already gave the correct answer so there is no point in me adding
much to it. :)
Note that you could specifically point ruby to call the getter method in the
line hanmac pointed out, rather than using:
bar = 0... -
12:27 PM Bug #13837: Class attributes get overshadowed by local variables
- ruby does parse the lines before exceute them.
so when ruby does read this:
~~~ ruby
bar = 0 if bar.nil?
~~~
it finds that you assign a local variable bar in this contect.
now it does always use the local variable instead of me... -
- ~~~ ruby
irb(main):001:0> RUBY_VERSION
=> "2.4.1"
irb(main):002:0> class Foo
irb(main):003:1> attr_accessor :bar
irb(main):004:1> def initialize
irb(main):005:2> self.bar = 1
irb(main):006:2> end
irb(main):007:1> def ... -
- Applied in changeset trunk|r59649.
----------
gc.c: restore cfp at finalizer
* gc.c (run_finalizer): restore cfp for the case an exception
raised in a finalizer. [ruby-core:82432] [Bug #13832] -
- * gc.c (run_finalizer): restore cfp for the case an exception
raised in a finalizer. [ruby-core:82432] [Bug #13832]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59649 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59648 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * gc.c (run_finalizer): revert r59155 partially. finalizing loop
should continue even after an exception is rescued.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59647 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59644.
----------
parse.y: primary should not be 0
* parse.y (primary): should not be 0, since it can be a receiver.
[ruby-core:82447] [Bug #13836] - 02:23 AM Revision e96ba1d6 (git): * 2017-08-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59646 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:23 AM Revision e553df86 (git): remove debug code.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59645 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:09 AM Bug #13794: Infinite loop of sched_yield
- charlie@atech.media wrote:
> File sched_yield_1.patch added
> The patch above does not work because
> native_reset_timer_thread runs after fork in the parent.
> Attached an alternative patch that runs in gvl_atfork and
> appears ...
08/22/2017
-
09:35 PM Bug #13835: Using 'open-uri' with 'tempfile' causes an exception
- shevegen (Robert A. Heiler) wrote:
> Indeed, sounds like a bug; at the least it is somewhat surprising behaviour to me. Not
> ...
Hm, as I remember, the first argument to `open` should be a URl or a path, not a `Tempfile` instance, rig... -
- Indeed, sounds like a bug; at the least it is somewhat surprising behaviour to me. Not
that I think I would have ever found the above behaviour, I always used open-uri with
a remote URL so far. :) -
08:18 AM Bug #13835 (Closed): Using 'open-uri' with 'tempfile' causes an exception
- Hi there,
try this in your current ruby env:
~~~ ruby
require 'tempfile'
require 'open-uri'
temp_file = Tempfile.new
open(temp_file, 'a')
~~~
Get this:
~~~
/Users/~/.rvm/rubies/ruby-2.4.1/lib/ruby/2.4.0/tempfile.rb:14... -
- * parse.y (primary): should not be 0, since it can be a receiver.
[ruby-core:82447] [Bug #13836]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59644 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:36 PM Bug #13836 (Closed): Null pointer dereference in defined_expr0()
- After some fuzz testing I found a crashing test case.
To reproduce: miniruby ruby_null_ptr_defined_expr0
Context:
~~~
ruby_null_ptr_defined_expr0: [BUG] Segmentation fault at 0x0000000000000000
ruby 2.5.0dev (2017-08-03) [x86_... -
- So far, I think the test never reaches this [1] line for some reason. Or if it reaches it, it is not executed properly. Then the temporary directory is cleaned up and the test suite starts to fail.
[1]: https://github.com/rubygems/rub... -
- I think the github "ticket" is not as useful as the issue track here; I may mistakingly remember
but I think that some of the ruby core team said so. Where github may help of course are
patches and pull requests attached to.
The er... -
- I also opened RubyGems ticket:
https://github.com/rubygems/rubygems/issues/1991 -
- From time to time, RubyGems test suite changes working directory, which breaks rest of Ruby tests suite. It all starts like this:
~~~
[ 7096/17125] TestGemRemoteFetcher#test_do_not_allow_invalid_client_cert_auth_connection = 0.01 sLe... -
08:47 AM Bug #13832: cfp consistency error occurred in vm_call_cfunc on non-optimized ruby
- This is my configure options:
```
~/src/github.com/ruby/ruby/configure \
--prefix=$(echo ~/.rbenv/versions/trunk-o0) \
--with-opt-dir=$(brew --prefix) \
--with-dbm-dir=$(brew --prefix qdbm) \
--with-dbm-type=qdbm \
--w... -
- I can reproduce this bug with r59639.
-
- Seems something weird, r58053 is for 2.4.1 at 2017-03-22.
And I can't reproduce it with r59639.
Try checkout and `make up` again. -
06:57 AM Bug #11126 (Closed): CSV field converters doesn't attempt to convert nil value.
- Applied in changeset trunk|r59643.
----------
Fixed regression to convert blank value at r45497.
[Bug #11126][ruby-core:69088] -
- [Bug #11126][ruby-core:69088]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59643 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59642.
----------
Gracefully handle CSV IO when file descriptor closed.
[Bug #10504][ruby-core:66240] -
- [Bug #10504][ruby-core:66240]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59642 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59641.
----------
Fixed equality method fails when given the object that doesn't support table method.
[Bug #12422][ruby-core:75707] -
- [Bug #12422][ruby-core:75707]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59641 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59640.
----------
Fixed to write_headers option behavior when given no rows.
[Bug #9988][ruby-core:63375] -
- [Bug #9988][ruby-core:63375]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59640 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59639.
----------
Escape skip_lines string before convert to Regexp.
It ignored all of lines when given Regexp special characters.
[Feature #9147][ruby-core:58549] -
- It ignored all of lines when given Regexp special characters.
[Feature #9147][ruby-core:58549]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59639 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59638 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59637 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59636 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * template/insns.inc.tmpl (ASSERT_VM_INSTRUCTION_SIZE): static
assertion for VM instruction info tables.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59635 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * signal.c (check_stack_overflow): raise fatal when the last tag
is in danger zone.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59634 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59633 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:41 AM Revision 59d8fefa (git): * 2017-08-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59632 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * cont.c: introduce `struct cont_saved_vm_stack` which was part of
`struct rb_context_struct`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59631 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/21/2017
-
05:50 PM Bug #13833 (Closed): String#scanf("%a") incorrectly requires a sign on the (binary) exponent
- ~~~
>> Float("0x1p9")
=> 512.0
> ...
=> 512.0
>> "0x1p+9".scanf("%a")
=> [512.0]
> ...
=> [0.0] # Oops
>> RUBY_VERSION
=> "2.4.1"
~~~
In scanf.rb, there are three regexps that say the equivalent o... -
- * gc.c: enable PREVENT_STACK_OVERFLOW.
* vm.c (invoke_iseq_block_from_c): prevent stack overflow.
* vm_eval.c (stack_check): raise preallocated exception instance.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59630 b2dd03c8-39d4-... -
- * iseq.c (rb_iseq_disasm_insn): Remove a meaningless
local variable assignment. `insn` is never changed
in this function, so a result of `insn_op_types(insn)`
is also never changed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... - 06:46 AM Revision aaac3f8c (git): * 2017-08-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59628 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_core.h (ruby_special_exceptions): rename sysstack_gc as
stackfatal.
* eval.c (Init_eval): modified the message for stackfatal error as
"critical region".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59627 b2dd03c8-39d4-4d... -
06:00 AM Bug #13831: error when try to install
- MSP-Greg (Greg L) wrote:
> I'm not that familiar with encoding issues, but I believe CP720 is an older code page.
Yes indeed. CP720 is the DOS encoding for Arabic.
> ...
This should be `chcp 1256`. The command is "change code page... -
01:20 AM Bug #13831: error when try to install
- I'm not that familiar with encoding issues, but I believe CP720 is an older code page. IF you enter `cp 1252` in the console, then `gem install sass`, does the gem install?
Regardless, given the nature of your question, the best plac... -
- The following script occurs `[BUG] vm_call_cfunc: cfp consistency error` on ruby that is compiled with `-O0`.
```console
$ cat test.rb
def callback
p :callback
@non_existing_ivar
end
ObjectSpace.define_finalizer(Object.new... -
01:01 AM Feature #13828: Win32ole extension should support licensed COM servers
- nobu (Nobuyoshi Nakada) wrote:
> * use `rb_scan_args` and `rb_get_kwargs`
bug reported in #13830 was resolved, so now I can use `rb_scan_args` and `rb_get_kwargs`. Updated version attached.
08/20/2017
-
05:01 PM Bug #13831 (Closed): error when try to install
- ruby 2.4.1p111 (2017-03-22 revision 58053) [x64-mingw32]
C:\Users\K>gem install sass
C:/Ruby24-x64/lib/ruby/2.4.0/win32/registry.rb:72:in `find': unknown encoding name - CP720 (ArgumentError)
from C:/Ruby24-x64/lib/ruby/2.4.... -
- * class.c (rb_scan_args), include/ruby/ruby.h (rb_scan_args_set):
return non-keywords elements only in the last hash when keyword
arguments are extracted from it, as well as methods defined in
ruby level. [ruby-core:82427] [Bug #1...
08/19/2017
-
- Applied in changeset trunk|r59624.
----------
ruby.h: fix rb_scan_args_trail_idx
* include/ruby/ruby.h (rb_scan_args_trail_idx): fix the case both
of optional and rest arguments are defined.
[ruby-core:82427] [Bug #13830]
* includ... -
- Oh and in case it's relevant, here is table of how it behaves under `-O3`.
rb_scan_args|Function call |Result |
============|=======================|==================================|
... -
- I think I've found bug in `rb_scan_args` function. This is my testing script:
require_relative 'test'
Test.test "server", "host", "a", "b", license: "lic"
And this is implementation of my module:
#include <ruby.h>... - 11:39 PM Revision 9191d9e7 (git): * 2017-08-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59625 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/ruby.h (rb_scan_args_trail_idx): fix the case both
of optional and rest arguments are defined.
[ruby-core:82427] [Bug #13830]
* include/ruby/ruby.h (rb_scan_args_n_trail): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.or... -
10:02 AM Revision 9657a6c2 (git): gems/bundled_gems: Update to power_assert 1.1.0
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59623 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- nobu (Nobuyoshi Nakada) wrote:
> * adjust indents
Fixed
> ...
Do you mean via ":" in `rb_scan_args`? I tried that at first actually, but had some troubles getting it work (here is what happened: https://gist.github.com/anonymous/7... -
- * adjust indents
* use `rb_scan_args` and `rb_get_kwargs`
* don't mix a declaration with code -
- `$0` and `Process.setproctitle` ignore `\0` and the after.
Is it intentional?
```
$ ruby -e '$0 = "foo\0bar"; system("ps", "#$$"); Process.setproctitle("bar\0foo"); system("ps", "#$$")'
PID TT STAT TIME COMMAND
34931 s00... -
- What are `time1` and `time2`?
If `time1` is the time when DST starts at and `time2` is the time when it ends at, then `time1 > `time2` in the Southern Hemisphere?
And what will return in non-DST timezones? -
- * class.c (rb_keyword_error_new): get rid of an intermediate
string and check if keys are symbols.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59622 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:45 AM Revision 4179fada (git): * 2017-08-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59621 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59620 b2dd03c8-39d4-4d8f-98ff-823fe69b080e