Project

General

Profile

Activity

From 07/05/2017 to 07/11/2017

07/11/2017

08:22 PM Bug #13737: "can't modify frozen String" when installing bundled gems
ko1@atdot.net wrote:
> Not sure why but r59310 will fix it (at least on my
> environment). To complete it i think we need to dig into
> rubygems deeply....

It seems Psych is correct to be tainting keys with YAML.load.
Perhaps the...
normalperson (Eric Wong)
08:51 AM Bug #13737: "can't modify frozen String" when installing bundled gems
ko1 (Koichi Sasada) wrote:
> Not sure why but r59310 will fix it (at least on my environment). To complete it i think we need to dig into rubygems deeply....
I got virtually the same error message on cygwin (with context just in case...
duerst (Martin Dürst)
07:51 AM Bug #13737: "can't modify frozen String" when installing bundled gems
ko1@atdot.net wrote:
> Not sure why but r59310 will fix it (at least on my
> ...
Thank you. I think there may also be an old bug at early
initializtion when rb_cString == 0 causing unfrozen string keys
form hash_aset instead of hash...
normalperson (Eric Wong)
07:45 AM Bug #13737: "can't modify frozen String" when installing bundled gems
Not sure why but r59310 will fix it (at least on my environment). To complete it i think we need to dig into rubygems deeply....
ko1 (Koichi Sasada)
06:55 AM Bug #13737 (Closed): "can't modify frozen String" when installing bundled gems
After committed r59304, mswin CI often (but not always) reports errors when installing bundled gems.
For example, http://mswinci.japaneast.cloudapp.azure.com/vc12-x64/ruby-trunk/log/20170710T020413Z.fail.html.gz
I've not investigated...
usa (Usaku NAKAMURA)
02:43 PM Feature #13726: PATCH: Windows builds - fractional second file times
While running tests today on `ruby 2.5.0dev (2017-07-11 trunk 59311) [x64-mingw32]`, I had an error in [spec/rubyspec/core/file/utime_spec](https://github.com/ruby/ruby/blob/561c253512eb83dba822d50ccc95a90187ab945e/spec/rubyspec/core/fil... MSP-Greg (Greg L)
07:42 AM Revision 561c2535 (git): * 2017-07-11
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59311 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
07:42 AM Revision 5168fb54 (git): tainted string should be tainted.
* hash.c (hash_aset_str): create frozen string for tainted objects.
(should not use fsting table on this case).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59310 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
05:11 AM Bug #5497: Math.log10(10_000) error on HP-UX/PA
Please try more precision.
The default precision doesn't seem enough.
```c
#include <math.h>
#include <stdio.h>
int main(void) {
printf("%.19f\n", log10(10000));
return 0;
}
```
nobu (Nobuyoshi Nakada)
03:34 AM Feature #12733: Bundle bundler to ruby core
I added `test-bundler` task to my experimental branch.
https://github.com/ruby/ruby/pull/1536/commits/5aa6d9a4340f8e6a54c9411e56c835c7f026abe3
It install rspec under the $(srcdir)/.bundle directory and use it by bundler test.
Bu...
hsbt (Hiroshi SHIBATA)

07/10/2017

05:02 PM Bug #13730: Parallel ext configuration has broken `make install` for static-linked-ext builds
Can confirm this fixes it for me - thanks! mistydemeo (Misty De Meo)
11:42 AM Revision d2dd18ed (git): compile.c: simplify defined_expr0
* compile.c (defined_expr0): exapnd defined_expr macro.
* compile.c (defined_expr0): reduce duplicate code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59309 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
07:41 AM Bug #13736: ruby -00 should be the same as setting $/=""
```diff
diff --git i/ruby.c w/ruby.c
index b2b2c690ff..4497331d48 100644
--- i/ruby.c
+++ w/ruby.c
@@ -1162,7 +1162,7 @@ proc_options(long argc, char **argv, ruby_cmdline_options_t *opt, int envopt)
if (v > 0377)
rb_rs =...
nobu (Nobuyoshi Nakada)
06:29 AM Bug #13736 (Assigned): ruby -00 should be the same as setting $/=""
I agree that it's a bug because ruby.1 states `-00 turns Ruby into paragraph mode.`
I'm uncertain the reason though, this behavior has been there since 0.95 at least, but 0.49 behaved same as perl.
nobu (Nobuyoshi Nakada)
05:08 AM Bug #13736: ruby -00 should be the same as setting $/=""
Please see Stackoverflow https://stackoverflow.com/q/44999907/298607 for a better / more complete description. dawg (Andrew Dumke)
05:06 AM Bug #13736 (Closed): ruby -00 should be the same as setting $/=""
Suppose you have blocks of text separated by 2 or more \n. A typical text file with records defined by a black line.
Given:
```
$ cat lines
f1, r1
f2, r1 then 2 \n:
f1, r2 then 3 \n:
f1,r3
f2,r3 then 4 \n:
f1, r...
dawg (Andrew Dumke)
07:37 AM Revision 5ed1d88e (git): test_rubyoptions.rb: assert -00
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59308 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
06:57 AM Bug #13284 (Closed): IA64 ruby 2.4 miniruby segfault
Applied in changeset trunk|r59307.
----------
a64: fix crash on register stack mark/sweep pass
* thread_pthread.c: move 'register_stack_start' earlier.
[ruby-core:79928] [Bug #13284] [Fix GH-1625]
Author: Sergei Trofimovich <slyf...
takano32 (Mitsuhiro TAKANO)
06:57 AM Revision 7aa74a0d (git): a64: fix crash on register stack mark/sweep pass
* thread_pthread.c: move 'register_stack_start' earlier.
[ruby-core:79928] [Bug #13284] [Fix GH-1625]
Author: Sergei Trofimovich <slyfox@gentoo.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59307 b2dd03c8-39d4-4d8f-98ff-...
takano32 (Mitsuhiro TAKANO)
02:24 AM Feature #13712: String#start_with? with regexp
Shyouhei Urabe) wrote:
> +1 for start_with? but I have no practical usage of end_with? so a bit negative about
> ...
I do not know if the use case frequency is the same. Perhaps you are right that anchoring
or .start_with? is more f...
shevegen (Robert A. Heiler)
01:18 AM Bug #13735 (Closed): Initialization-error of sortedset
When we use multithreading environment, sortedset-initialization always fails.
Reproducible programs and the logs are below.
~~~ ruby
$ cat sortedset-test.rb
require "set"
def func1
set = SortedSet.new([2, 1, 5, 6, 4, 5, ...
junjihashimoto (Junji Hashimoto)
12:41 AM Revision f1fe99b1 (git): hash.c: prefer value cast to pointer cast
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59306 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)

07/09/2017

11:04 PM Feature #13725 (Closed): [PATCH] Hash#[]= deduplicates string keys if (and only if) fstring exists
Applied in changeset trunk|r59304.
----------
Hash#[]= deduplicates string keys if (and only if) fstring exists
In typical applications, hash entries are read after being
written to. Blindly writing to hashes which are never read
make...
Anonymous
11:04 PM Revision 9d1d30c9 (git): * 2017-07-10
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59305 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:04 PM Revision e205304a (git): Hash#[]= deduplicates string keys if (and only if) fstring exists
In typical applications, hash entries are read after being
written to. Blindly writing to hashes which are never read
makes little sense. So, for any hash which is read from, an
fstring entry for the key should already exist for the key...
Eric Wong
08:46 PM Bug #11384: multi-threaded autoload sometimes fails
ruby_2_4 r59303 merged revision(s) 58696. nagachika (Tomoyuki Chikanaga)
08:46 PM Revision 5e645629 (git): merge revision(s) 58696: [Backport #11384]
autoload: always wait on loading thread
We cannot assume autoload_provided/rb_feature_provided returning
TRUE means it is safe to proceed without waiting. Another
thread may call rb_provide_feature before settin...
nagachika (Tomoyuki Chikanaga)
08:24 PM Bug #12670: Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
ruby_2_4 r59302 merged revision(s) 56558,59116,59136. nagachika (Tomoyuki Chikanaga)
08:24 PM Revision e15f61a0 (git): merge revision(s) 56558,59116,59136: [Backport #12670]
* gc.c (heap_page_resurrect): do not return tomb_pages when
page->freelist == NULL.
[Bug #12670]
test for [Bug #12670]
heap corruption by deferred free.
gc.c: expand sorted pages
* g...
nagachika (Tomoyuki Chikanaga)
08:06 PM Bug #5339: ERB generates extra newlines on Windows
ruby_2_4 r59301 merged revision(s) 58825,58826. nagachika (Tomoyuki Chikanaga)
08:06 PM Revision 420151cf (git): merge revision(s) 58825,58826: [Backport #5339]
erb.rb: Allow explicit trimming carriage return
when trim_mode is "-", for Windows environments.
[ruby-core:39625] [Bug #5339]
erb.rb: Allow trimming CR in all trim_modes
to unify a behavior with r58823...
nagachika (Tomoyuki Chikanaga)
08:04 PM Bug #11464: ERB trimming doesn't trim carriage returns
ruby_2_4 r59300 merged revision(s) 58823. nagachika (Tomoyuki Chikanaga)
08:04 PM Revision 05215d0d (git): merge revision(s) 58823: [Backport #11464]
erb.rb: Allow trimming carriage return
when trim_mode is "<>", for Windows environments.
[Bug #11464]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59300 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nagachika (Tomoyuki Chikanaga)
08:02 PM Bug #8916: rb_sprintf への精度指定が正しく機能していない
ruby_2_4 r59299 merged revision(s) 58210. nagachika (Tomoyuki Chikanaga)
08:02 PM Revision f5b84007 (git): merge revision(s) 58210: [Backport #8916]
vsnprintf.c: prefix with precision
* vsnprintf.c (BSD_vfprintf): sign and hex-prefix should not be
counted in precision. [ruby-dev:47714] [Bug #8916]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@5929...
nagachika (Tomoyuki Chikanaga)
07:51 PM Bug #13545: Ruby built by clang 4.0.0 parses Float literal wrongly
ruby_2_4 r59298 merged revision(s) 58796. nagachika (Tomoyuki Chikanaga)
07:51 PM Revision c54593ed (git): merge revision(s) 58796: [Backport #13545]
Merge latest dtoa.c [Bug #13545]
Apply some part of http://www.netlib.org/fp/dtoa.c with my eyes...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59298 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nagachika (Tomoyuki Chikanaga)
07:49 PM Bug #13432: set_trace_funcにproc->is_from_method = TRUEのオブジェクトを渡し、SystemStackErrorを発生させるとRubyVMが停止する
ruby_2_4 r59297 merged revision(s) 58334,58346,58349. nagachika (Tomoyuki Chikanaga)
07:49 PM Bug #13425: Tracer.onにした状態でSystemStackErrorを発生させるとSegmentation fault
ruby_2_4 r59297 merged revision(s) 58334,58346,58349. nagachika (Tomoyuki Chikanaga)
07:49 PM Revision 5528c18d (git): merge revision(s) 58334,58346,58349: [Backport #13425] [Backport #13432]
thread.c: disable VM events when stack overflow
* thread.c (ruby_thread_stack_overflow): disable VM events when
stack overflow occurred; it causes another stack overflow again
in making backtrace object, and ...
nagachika (Tomoyuki Chikanaga)
07:47 PM Bug #13369: TracePoint gives incorrect `return_value` after rescuing error when using `return`
ruby_2_4 r59296 merged revision(s) 58262,5826. nagachika (Tomoyuki Chikanaga)
07:47 PM Revision 79787c18 (git): merge revision(s) 58262,5826: [Backport #13369]
fix TracePoint#return_value with non-local exits
* vm.c: get return_value from imemo_throw_data object (THROW_DATA_VAL()).
imemo_throw_data (TAG_BREAK) contains returned value.
However, imemo_throw_data (TAG_...
nagachika (Tomoyuki Chikanaga)
07:36 PM Bug #13638: please backport r59030
ruby_2_4 r59295 merged revision(s) 59030,59031. nagachika (Tomoyuki Chikanaga)
07:36 PM Revision 11fdbadd (git): merge revision(s) 59030,59031: [Backport #13638]
thread.c: avoid busy looping on rb_thread_fd_close
We no longer use it this function, but extensions do, and
we need to ensure it continues to work for them.
* thread.c (rb_thread_fd_close): schedule other threa...
nagachika (Tomoyuki Chikanaga)
07:28 PM Bug #13573: Compilation on Mac OS X 10.5.8 fails because of missing _fgetattrlist
ruby_2_4 r59294 merged revision(s) 57248. nagachika (Tomoyuki Chikanaga)
07:27 PM Revision d679034a (git): merge revision(s) 57248: [Backport #13573]
dir.c: getattrlist on OSX 10.5
* dir.c (is_case_sensitive): use getattrlist() if fgetattrlist()
is unavailable, on OSX 10.5. [ruby-core:68829] [Bug #11054]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_...
nagachika (Tomoyuki Chikanaga)
07:02 PM Bug #13554: Running system with different gid fails on Linux if host has group with lots of members
ruby_2_4 r59293 merged revision(s) 58658. nagachika (Tomoyuki Chikanaga)
07:02 PM Revision 4c33806f (git): merge revision(s) 58658: [Backport #13554]
process.c: temporary string for buffer
* process.c (obj2uid, obj2gid): use temporary string as the buffer
instead of `rb_alloc_tmp_buffer`, which is `NODE_ALLOCA` since
r51492. [ruby-core:81084] [Bug #13554]...
nagachika (Tomoyuki Chikanaga)
02:00 PM Feature #12733: Bundle bundler to ruby core
The upstream version of minitest 4.7.5 supported spec syntax. It does not probably support all the RSpec features, but might be worth of considering ... vo.x (Vit Ondruch)
05:14 AM Feature #13625: BigDecimal short form / shorthand
Let me mark this begin a feature request. shyouhei (Shyouhei Urabe)
04:49 AM Bug #13709 (Closed): Problem compiling https://cache.ruby-lang.org/pub/ruby/snapshot.tar.gz - symlinks point to non-existing .gem files during "make install" step
Applied in changeset trunk|r59292.
----------
downloader.rb: get rid of symlinks in dist files
* tool/downloader.rb: download to the target file directly if
CACHE_SAVE=no, to get rid of symlinks in dist files.
[ruby-core:81887] [Bu...
nobu (Nobuyoshi Nakada)
04:49 AM Revision b3917087 (git): downloader.rb: get rid of symlinks in dist files
* tool/downloader.rb: download to the target file directly if
CACHE_SAVE=no, to get rid of symlinks in dist files.
[ruby-core:81887] [Bug #13709]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59292 b2dd03c8-39d4-4d8f-98ff-823fe6...
nobu (Nobuyoshi Nakada)
04:20 AM Revision 90d65afc (git): make-snapshot: generate ChangeLog iff not exist
* tool/make-snapshot (package): ChangeLog had existed in pre-2.4
revisions, but not doc/ChangeLog-YYYY. fix for 2..3.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59291 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:17 AM Bug #13734 (Closed): Broken snapshot script for Ruby 2.4
Applied in changeset trunk|r59289.
----------
make-snapshot: touch-unicode-files for 2.4
* tool/make-snapshot (package): fallback touch-unicode-files for
2.4, which has been introduced to reduce downloads on CI.
[ruby-core:81972] [...
nobu (Nobuyoshi Nakada)
02:27 AM Bug #13734 (Closed): Broken snapshot script for Ruby 2.4
`tool/make-snapshot` in trunk is broken now.
I got following error at some days ago.
```
generating known_errors.inc
known_errors.inc updated
generating vm_call_iseq_optimized.inc
file2lastrev.rb: does not seem to be under a vc...
hsbt (Hiroshi SHIBATA)
04:17 AM Revision ac9219e0 (git): * 2017-07-09
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59290 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:17 AM Revision d0677cdb (git): make-snapshot: touch-unicode-files for 2.4
* tool/make-snapshot (package): fallback touch-unicode-files for
2.4, which has been introduced to reduce downloads on CI.
[ruby-core:81972] [Bug #13734]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59289 b2dd03c8-39d4-4d8f-98f...
nobu (Nobuyoshi Nakada)
01:48 AM Bug #13723: Change to use RubyVM for syntax check in test suite breaks suite for non-MRI
I missed the name, `syntax_check` instead of `check_syntax` :( nobu (Nobuyoshi Nakada)

07/08/2017

12:32 PM Bug #13730 (Closed): Parallel ext configuration has broken `make install` for static-linked-ext builds
Applied in changeset trunk|r59288.
----------
* template/exts.mk.tmpl: extract SUBMAKEOPTS from sub exts.mk files too. [Bug #13730]
nobu (Nobuyoshi Nakada)
12:31 PM Revision 2abf6a34 (git): * template/exts.mk.tmpl: extract SUBMAKEOPTS from sub exts.mk files too. [Bug #13730]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59288 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
09:39 AM Feature #13733 (Open): Dump the delegator instead of the delegated object
I would like to let Delegator dump itself instead of the delegated object.
Let's consider the following scenario.
~~~
require "delegate"
class Foo < Delegator
def initialize(the_obj)
@the_obj = the_obj
end
def _...
huynhquancam (Cam Huynh)
08:20 AM Feature #13732 (Closed): Precise Time.now on Windows
Windows 上での Time.now の精度を調べてみたところ、システムの
タイマー精度(1ミリ秒以上15.6ミリ秒以下。通常は15.6ミリ秒)と同じに
なっていました。
試験内容と結果は以下のURLを参照
https://github.com/MSP-Greg/ruby_on_windows/issues/1#issuecomment-313660247
Time.now は内部では GetSystemTimeAsFileTime を使って現在時...
kubo (Takehiro Kubo)
06:15 AM Feature #13731 (Closed): inode for Windows on ReFS
#11216 でWindowsでのinodeの代用としてBY_HANDLE_FILE_INFORMATION構造体の
メンバ、nFileIndexHigh/Lowを使っていますが、ReFS ではこの値ではユニークに
なりません。ReFSでは64ビットではなくて、128ビットでユニークな番号になります。
In https://msdn.microsoft.com/en-us/library/windows/desktop/aa363788(v=vs.85).as...
kubo (Takehiro Kubo)
05:47 AM Feature #13726: PATCH: Windows builds - fractional second file times
01-time-subsec.patch changes declarations in include/ruby/win32.h.
IMO, it could be in ruby 2.5.x but could not be backported to ruby 2.4.x because of ABI incompatibility.
It also deletes meaningless TZ checking I pointed at #13702.
kubo (Takehiro Kubo)
04:51 AM Bug #13723: Change to use RubyVM for syntax check in test suite breaks suite for non-MRI
Thank you nobu! headius (Charles Nutter)
02:22 AM Bug #13723 (Closed): Change to use RubyVM for syntax check in test suite breaks suite for non-MRI
Applied in changeset trunk|r59287.
----------
assertions.rb: syntax_check for other impl
* test/lib/test/unit/assertions.rb (syntax_check): use eval
instead of RubyVM::InstructionSequence.compile so that other
implementations can s...
nobu (Nobuyoshi Nakada)
03:28 AM Bug #11779: Module#using does not make sense as a method
nobu (Nobuyoshi Nakada) wrote:
> Seems that your "dynamic" and "lexical" words differ from ours.
I was using "dynamic" to mean that its dynamically "bound" (applies) to the default definee at the point of invocation, not the lexicall...
bughit (bug hit)
02:10 AM Bug #11779: Module#using does not make sense as a method
Seems that your "dynamic" and "lexical" words differ from ours. nobu (Nobuyoshi Nakada)
02:22 AM Revision 1d6c1d20 (git): assertions.rb: syntax_check for other impl
* test/lib/test/unit/assertions.rb (syntax_check): use eval
instead of RubyVM::InstructionSequence.compile so that other
implementations can share the tests.
[ruby-core:81935] [Bug #13723]
git-svn-id: svn+ssh://ci.ruby-lang.org/ru...
nobu (Nobuyoshi Nakada)
02:21 AM Bug #13632: Not processable interrupt queue for a thread after it's notified that FD is closed in some other thread.
ruby_2_4 r59286 merged revision(s) 58284,58812,59028. nagachika (Tomoyuki Chikanaga)
02:21 AM Revision 27251312 (git): merge revision(s) 58284,58812,59028: [Backport #13632]
vm_core.h: ruby_error_stream_closed
* vm_core.h (ruby_special_exceptions): renamed
ruby_error_closed_stream as ruby_error_stream_closed, like the
message.
speed up IO#close with many threads
...
nagachika (Tomoyuki Chikanaga)
02:05 AM Revision 41bdfc53 (git): .travis.yml: update dist to trusty
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59285 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
01:20 AM Bug #13720: appveyor.yml nmake arguments - not *nix style
`-l` is undocumented, just `nmake` sets `MAKEFLAGS=l` when `/nologo` option is given. nobu (Nobuyoshi Nakada)

07/07/2017

09:58 PM Bug #13730 (Closed): Parallel ext configuration has broken `make install` for static-linked-ext builds
r57401 introduced parallel ext configuration, which has broken `make install` when configuring Ruby using the `--with-static-linked-ext` option. Specifically, it looks like miniruby fails to require the `stringio` extension at install-ti... mistydemeo (Misty De Meo)
07:19 PM Bug #13723: Change to use RubyVM for syntax check in test suite breaks suite for non-MRI
nobu (Nobuyoshi Nakada) wrote:
> In some cases, `RubyVM::InstructionSequence.compile` and `eval` fail in different manor.
Ok, but I still need a way to run the tests. The original code used `eval`...is there a reason it needed to cha...
headius (Charles Nutter)
12:08 PM Bug #13723: Change to use RubyVM for syntax check in test suite breaks suite for non-MRI
In some cases, `RubyVM::InstructionSequence.compile` and `eval` fail in different manor.
```ruby
RubyVM::InstructionSequence.compile("break") #=> Invalid break
eval("break") #=> Can't escape from eval with break
```
nobu (Nobuyoshi Nakada)
05:59 PM Revision 129a0711 (git): NEWS: note [Feature #13517] is Linux-only (no side-effects on _*nonblock)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59284 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eric Wong
05:41 PM Revision 61a8b4c1 (git): NEWS: entry for WEBRick SNI support [Feature #13729]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59283 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eric Wong
05:09 PM Feature #13729 (Closed): PATCH: Add Server Name Indication (SNI) support to WEBrick
Applied in changeset trunk|r59281.
----------
webrick: add Server Name Indication (SNI)
* lib/webrick/https.rb: servername_cb implementation.
* lib/webrick/ssl.rb: abstract servername_cb.
* test/webrick/test_https.rb: test.
[ruby-dev...
Anonymous
09:49 AM Feature #13729 (Closed): PATCH: Add Server Name Indication (SNI) support to WEBrick
WEBrick に Server Name Indication (SNI) サポートを追加するパッチです。
よくWEBrickで簡易サーバを立てているのですが、SNIでバーチャルホストを立てたかった(けどできなかった)のでパッチを書きました。
`WEBrick::HTTPServer` が元々持っているバーチャルホストの仕組みに乗っかっています。
一応テストも入っています。
Google Chrome + Let's Encryptの証明書(SANでは...
Tietew (Toru Iwase)
05:09 PM Revision c82bed63 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59282 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
05:09 PM Revision 08bdbef5 (git): webrick: add Server Name Indication (SNI)
* lib/webrick/https.rb: servername_cb implementation.
* lib/webrick/ssl.rb: abstract servername_cb.
* test/webrick/test_https.rb: test.
[ruby-dev:50165] [Feature #13729]
Author: Tietew <tietew@gmail.com>
git-svn-id: svn+ssh://ci.rub...
Eric Wong
05:07 PM Bug #11779: Module#using does not make sense as a method
matz (Yukihiro Matsumoto) wrote:
> Providing a feature by a method does not imply dynamic scoping, for example, Module#private etc. work in lexical scope.
I didn't think about Module#private too deeply at the time, but recently was p...
bughit (bug hit)
04:53 PM Revision 4d3d6f68 (git): * 2017-07-08
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59280 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:53 PM Revision aff529a5 (git): webrick: become maintainer
<CAK6HhsrshX7s3qai4usbXknTQnA4GoRThJcQ_Ea=WgTG2Gu0QA@mail.gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59279 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
02:35 PM Feature #13726: PATCH: Windows builds - fractional second file times
I was mistaken about Time.now resolution in windows.
What I believe does occur is that when windows natively writes file times, it seems to write them with 100 µs resolution, and truncated.
But, Ruby can write with higher resolutio...
MSP-Greg (Greg L)
02:27 AM Feature #13726 (Closed): PATCH: Windows builds - fractional second file times
At present, I believe Windows builds have integer seconds resolution on File times.
Attached are three patches that seem to correct the issue. The numbered patches are best applied in order.
The c source patches were created by kub...
MSP-Greg (Greg L)
02:28 PM Bug #13720: appveyor.yml nmake arguments - not *nix style
nobu (Nobuyoshi Nakada) wrote:
> What version is your nmake, and what was the exact error message?
> ...
I think I've tried VS2015 and VS2017, settled on VS2015. I don't recall the message. I was mistaken in my assumption about `-`.
...
MSP-Greg (Greg L)
02:00 PM Bug #13720: appveyor.yml nmake arguments - not *nix style
What version is your nmake, and what was the exact error message?
At least, versions since VC98 through VS2017 have never failed.
nobu (Nobuyoshi Nakada)
01:34 PM Bug #13728: How to design websites?
Looks like spam-account. shevegen (Robert A. Heiler)
09:45 AM Bug #13728 (Rejected): How to design websites?
I want to learn web design but don’t have the money to do a course right now. What web site can I go onto to start learning how to design web sites? What would be the best course to learn web design? Please share innovative ideas here or... georgelhays (George L Hays)
12:25 PM Revision d984da66 (git): Run single downloader
* common.mk (update-unicode-property-files, update-unicode-files):
download in single process for each targets, not for each files
in parallel, to get rid of conflicts.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59278 b2dd03c...
nobu (Nobuyoshi Nakada)
09:52 AM Bug #13724 (Assigned): make install does not install bundled gems
hsbt (Hiroshi SHIBATA)
09:52 AM Bug #13724: make install does not install bundled gems
installation of bundled gems requires `make update-gems` and `make extract-gems`.
We should add above instructions to README.md.
hsbt (Hiroshi SHIBATA)
07:51 AM Bug #13727: Not able to set program_name for new Syslog::Logger
melentievm@gmail.com wrote:
> Hi!
>
> Every instance of syslog logger uses same program_name as first initialized one, because they all share single instance of Syslog (https://github.com/ruby/ruby/blob/trunk/ext/syslog/lib/syslog/l...
normalperson (Eric Wong)
07:20 AM Bug #13727 (Closed): Not able to set program_name for new Syslog::Logger
Hi!
Every instance of syslog logger uses same program_name as first initialized one, because they all share single instance of Syslog (https://github.com/ruby/ruby/blob/trunk/ext/syslog/lib/syslog/logger.rb#L195)
~~~ ruby
logger1 ...
printercu (Max Melentiev)
06:00 AM Bug #13413: --with-static-linked-ext doesn't install extension files on `make install`
ruby_2_3 r59277 merged revision(s) 57446. usa (Usaku NAKAMURA)
05:39 AM Bug #13413: --with-static-linked-ext doesn't install extension files on `make install`
> 2.4: DONTNEED
Thank you for marking this for backport! The backport is needed for 2.4 as well.
mistydemeo (Misty De Meo)
04:47 AM Bug #13413 (Closed): --with-static-linked-ext doesn't install extension files on `make install`
nobu (Nobuyoshi Nakada)
01:05 AM Bug #13413: --with-static-linked-ext doesn't install extension files on `make install`
After some research, I discovered that this has since been fixed in trunk. It was fixed by r57446 (git b3dbeb6e90f). I can't test if this fixes the trunk build, which fails for what may or may not be unrelated reasons, but backporting th... mistydemeo (Misty De Meo)
12:35 AM Bug #13413: --with-static-linked-ext doesn't install extension files on `make install`
Found the commit that's responsible - r51756 (50226fb61cb10c5be9e2745e7b1a29228987a4ee in the github mirror).
This does adjust the logic surrounding the `STATIC_LIB` target and whether or not to add `install-rb`. At a glance, making t...
mistydemeo (Misty De Meo)
06:00 AM Revision e1f73c32 (git): merge revision(s) 57446: [Backport #13413]
mkmf.rb: fix script installation
* lib/mkmf.rb (MakeMakefile): fix condition to install script
files.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59277 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
02:14 AM Revision c6134214 (git): * 2017-07-07
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59276 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
02:14 AM Revision b88e0ceb (git): * tool/redmine-backporter.rb (show): just report and ignore if a feature ticket
is specified instead of aborting.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59275 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
02:03 AM Revision 651990fa (git): This backport of r58812 is necessary to ease backporting r59028,
which fixes a real bug.
* thread.c (struct waiting_fd): declare
(rb_thread_io_blocking_region): use on-stack list waiter
(rb_notify_fd_close): walk vm->waiting_fds instead
(call_without_gvl): remove old field setting
(th_init): ...
U.Nakamura
12:21 AM Feature #13725: [PATCH] Hash#[]= deduplicates string keys if (and only if) fstring exists
I forget to mention, this might make the proposed [Feature #13721]
("net/imap: dedupe attr keys in Net::IMAP::FetchData")
obsolete: https://bugs.ruby-lang.org/issues/13721

Along with the necessity to make similar changes down the l...
normalperson (Eric Wong)
12:08 AM Feature #13725 (Closed): [PATCH] Hash#[]= deduplicates string keys if (and only if) fstring exists
Hash#[]= deduplicates string keys if (and only if) fstring exists
In typical applications, hash entries are read after being
written to. Blindly writing to hashes which are never read
makes little sense. So, for any hash which is r...
normalperson (Eric Wong)

07/06/2017

07:10 PM Bug #13723: Change to use RubyVM for syntax check in test suite breaks suite for non-MRI
I have the following patch that uses eval when RubyVM::InstructionSequence is not available.
```diff
diff --git a/test/lib/test/unit/assertions.rb b/test/lib/test/unit/assertions.rb
index a01871f05c..b110855f45 100644
--- a/test/li...
headius (Charles Nutter)
06:46 PM Bug #13723 (Closed): Change to use RubyVM for syntax check in test suite breaks suite for non-MRI
In revision 57158 (6b5f9277 on github) nobu modified the syntax checks in test/lib/test/unit/assertions.rb to use MRI-specific features.
https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/57158
Specifically, instea...
headius (Charles Nutter)
07:06 PM Bug #13724: make install does not install bundled gems
At first sight it seems the standard Homebrew ruby formula does not install bundled gems either due to this:
https://github.com/Homebrew/homebrew-core/blob/a71cdcd43814c8692718eca61bf67ef0b61cdf9e/Formula/ruby.rb#L75-L76
Eregon (Benoit Daloze)
07:03 PM Bug #13724 (Closed): make install does not install bundled gems
I believe the usual way to build C (autoconf) software is
autoconf
./configure --prefix=...
make
make install
However, such a sequence does not download nor install bundled gems.
One needs to "make up" before "m...
Eregon (Benoit Daloze)
06:54 PM Bug #13670: [BUG] Bus Error at 0xefce7b (armv7l) (ruby 2.3.4p301)
mrohnstock (Mathias Rohnstock) wrote:
> On using the library bootsnap the error occurred (see attachment). The developer of the library suggested to report this directly to the ruby-devs, as it looks like a bug in core. Related issue on...
WarheadsSE (Jason Plum)
06:49 PM Feature #12733: Bundle bundler to ruby core
hsbt (Hiroshi SHIBATA) wrote:
> We can choose some strategy.
> ...
I think isolation environment is the best strategy (or the only reasonable).
Rewriting tests is not an option for upstream development and is very time-consuming/err...
Eregon (Benoit Daloze)
08:59 AM Feature #12733: Bundle bundler to ruby core
>I am not sure what is needed for this, but I would like to help figure out what would be needed.
I hope to promote bundler to default gems on standard libraries.
Requirements of default gems is following things:
* Works with cr...
hsbt (Hiroshi SHIBATA)
03:15 PM Bug #13718: openssl: Reading PEM/DER from an IO object fails on mswin Ruby
rhenium (Kazuki Yamaguchi) wrote:
> This is a separate doc issue. I'll will fix them.
Thank you. Having looked over a great deal of the test code, I feel that the net test code could benefit from shared code and constants for the ct...
MSP-Greg (Greg L)
04:06 AM Bug #13718 (Third Party's Issue): openssl: Reading PEM/DER from an IO object fails on mswin Ruby
MSP-Greg (Greg L) wrote:
> When running test-all, I had silent SEGV failures on the net tests - test_ftp.rb, test_imap.rb, and test_smtp.rb. All three currently use the following code for some tests:
https://github.com/ruby/openssl/...
rhenium (Kazuki Yamaguchi)
11:55 AM Bug #13722: OptionParser::DecimalInteger can be converted as Octal
Thank you, it's obviously a bug. nobu (Nobuyoshi Nakada)
11:49 AM Bug #13722 (Closed): OptionParser::DecimalInteger can be converted as Octal
Applied in changeset trunk|r59273.
----------
Fix DecimalInteger converting to octal bug
Previously if the input started with a '0' then it will be converted
as octal even though it has been specified as a decimal. This commit
forces t...
nobu (Nobuyoshi Nakada)
11:10 AM Bug #13722: OptionParser::DecimalInteger can be converted as Octal
From optparse.rb:
```
OptionParser comes with a few ready-to-use kinds of type
# coercion. They are:
#
# - Date -- Anything accepted by +Date.parse+
# - DateTime -- Anything accepted by +DateTime.parse+
# - Time -- Anything ac...
wmccumstie (William McCumstie)
10:56 AM Bug #13722: OptionParser::DecimalInteger can be converted as Octal
I don't believe it would be intended behaviour. At very least it would be strange to specifically specify a Decimal only to have it converted as Octal.
Looking into to the unit tests (test/optparse/test_acceptable.rb:115), I would hav...
wmccumstie (William McCumstie)
10:48 AM Bug #13722: OptionParser::DecimalInteger can be converted as Octal
shyouhei (Shyouhei Urabe) wrote:
> I wonder if this is a bug or an intended behaviour.
I would argue that this is a bug. The test here -- https://github.com/ruby/ruby/blob/trunk/test/optparse/test_acceptable.rb#L115 -- also doesn't f...
mjtko (Mark Titorenko)
10:19 AM Bug #13722: OptionParser::DecimalInteger can be converted as Octal
I wonder if this is a bug or an intended behaviour. shyouhei (Shyouhei Urabe)
10:10 AM Bug #13722: OptionParser::DecimalInteger can be converted as Octal
A PR containing a bug fix can be found at:
https://github.com/ruby/ruby/pull/1665
wmccumstie (William McCumstie)
09:59 AM Bug #13722 (Closed): OptionParser::DecimalInteger can be converted as Octal
OptionParser::DecimalInteger will convert in octal format for input values that start with a '0'. In the attached script, an input of '035' will be converted to 29.
Script Output:
```
$: ./ruby-op-octal-bug.rb
Input: 035
Parsed...
wmccumstie (William McCumstie)
11:49 AM Revision 8ddf0263 (git): Fix DecimalInteger converting to octal bug
Previously if the input started with a '0' then it will be converted
as octal even though it has been specified as a decimal. This commit
forces the number to be interpreted as a decimal.
[ruby-core:81927] [Bug #13722] [Fix GH-1665]
Aut...
nobu (Nobuyoshi Nakada)
09:14 AM Feature #13721 (Rejected): [PATCH] net/imap: dedupe attr keys in Net::IMAP::FetchData
Since attr hash keys are frequently reused, it makes sense to
deduplicate them up front.
This saves one allocation per-attr, per-message. When running
imap.fetch(1..-1, 'UID') on a mailbox with 30000 messages;
this saves 30000 all...
normalperson (Eric Wong)
07:21 AM Revision 06a3a10a (git): string.c: preserve coderange in String#setbyte
Fix a wrong jump so replacing a byte in an ASCII-only string with an
ASCII character won't clear the coderange.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59272 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
rhenium (Kazuki Yamaguchi)
07:21 AM Revision 2c8cec96 (git): string.c: remove dead code in str_fill_term()
The length of a string never exceeds the capacity.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59271 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
rhenium (Kazuki Yamaguchi)
04:12 AM Revision 1798deb2 (git): * 2017-07-06
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59270 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:12 AM Revision d9d8ca0b (git): lexer.rb: ignore dedented space
* ext/ripper/lib/ripper/lexer.rb (on_heredoc_dedent): replace an
empty string content because of dedentation with :on_ignored_sp.
an empty token makes the sorted order unstable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@5926...
nobu (Nobuyoshi Nakada)
01:54 AM Bug #13720: appveyor.yml nmake arguments - not *nix style
nobu (Nobuyoshi Nakada) wrote:
> Actually it does.
I had an error message on at least one of my nmake log files about bad argument; wonder if it's version dependent. I changed all params to `/` style, but next mswin build I'll swap ...
MSP-Greg (Greg L)
01:40 AM Bug #13720: appveyor.yml nmake arguments - not *nix style
Actually it does. nobu (Nobuyoshi Nakada)

07/05/2017

08:11 PM Bug #13720 (Rejected): appveyor.yml nmake arguments - not *nix style
See [lines 45-53](https://github.com/ruby/ruby/blob/650e7580601327fab48eccde794cee2d467214af/appveyor.yml#L45-L53). I don't believe nmake accepts *nix style arguments. Hence, remove `-l` from nmake lines.
Didn't see a need to have a ...
MSP-Greg (Greg L)
07:03 PM Feature #13719 (Open): [PATCH] net/http: allow existing socket arg for Net::HTTP.start
~~~
This allows Net::HTTP users to use Unix domain sockets
or any other type of stream socket, including TCP.
Several HTTP servers (e.g. nginx and puma) support
listening on local Unix sockets instead of TCP.
* lib/net/http.rb (HT...
normalperson (Eric Wong)
04:49 PM Bug #13718 (Third Party's Issue): openssl: Reading PEM/DER from an IO object fails on mswin Ruby
I recently decided to locally build/test mswin based on VS2015/140. The current Ruby Appveyor testing is done using VS2013/120. I did so since using Appveyor on my Ruby fork was wasteful and time consuming, especially if the problem wa... MSP-Greg (Greg L)
03:21 PM Bug #10856: Splat with empty keyword args gives unexpected results
https://github.com/ruby/ruby/compare/trunk...nobu:bug/10856-splat-hash nobu (Nobuyoshi Nakada)
11:44 AM Feature #13712: String#start_with? with regexp
phluid61 (Matthew Kerwin) wrote:
> That could depend on whether `$&`, `$1`, `$2`, etc. are set. I assumed @nobu was only asking about `$~` because allocating a whole MatchData object is heavier than just allocating some strings.
$&,...
Eregon (Benoit Daloze)
10:11 AM Feature #13712: String#start_with? with regexp
Eregon (Benoit Daloze) wrote:
>
> ...
That could depend on whether `$&`, `$1`, `$2`, etc. are set. I assumed @nobu was only asking about `$~` because allocating a whole MatchData object is heavier than just allocating some strings.
phluid61 (Matthew Kerwin)
09:35 AM Feature #13712: String#start_with? with regexp
nobu (Nobuyoshi Nakada) wrote:
> Will you need `$~` after `start_with?(re)`?
It might be quite useful when parsing, to avoid doing a second match just to get captures.
Eregon (Benoit Daloze)
06:01 AM Feature #13712: String#start_with? with regexp
nobu (Nobuyoshi Nakada) wrote:
> Will you need `$~` after `start_with?(re)`?
Personally, I don't see that I'll ever need it. If people do want it, they can lodge a feature request in future?
phluid61 (Matthew Kerwin)
05:27 AM Feature #13712: String#start_with? with regexp
Will you need `$~` after `start_with?(re)`? nobu (Nobuyoshi Nakada)
03:50 AM Feature #13712: String#start_with? with regexp
shyouhei (Shyouhei Urabe) wrote:
> +1 for start_with? but I have no practical usage of end_with? so a bit negative about that part. Do people really need regexp version of .end_with?
In addition, even if we don't have a direct use c...
duerst (Martin Dürst)
02:46 AM Feature #13712: String#start_with? with regexp
phluid61 (Matthew Kerwin) wrote:
> I've used regexen at different times to match final punctuation (e.g. `/\?[!.]*/`) and trailing whitespace (e.g. `/\s/`). I think it's more readable having `str.end_with? /pattern/` instead of `str =~...
shyouhei (Shyouhei Urabe)
02:33 AM Feature #13712: String#start_with? with regexp
shyouhei (Shyouhei Urabe) wrote:
> +1 for start_with? but I have no practical usage of end_with? so a bit negative about that part. Do people really need regexp version of .end_with?
I've used regexen at different times to match fin...
phluid61 (Matthew Kerwin)
12:30 AM Feature #13712: String#start_with? with regexp
+1 for start_with? but I have no practical usage of end_with? so a bit negative about that part. Do people really need regexp version of .end_with? shyouhei (Shyouhei Urabe)
10:51 AM Bug #13717 (Closed): Calling lambda with keyword arguments inconsistent behavior
Context: I am running a callback hook that can have multiple arguments (or none) and multiple keywords (or none).
The idea is to run this and just pass on the params:
~~~
hook.call(*args, **kw_args)
~~~
But I've encountered an...
hakunin (Michal Hantl)
09:05 AM Revision 650e7580 (git): un.rb: use OpenSSL::PKey.read instead of OpenSSL::PKey::RSA.new
Also, error out if --ssl-private-key option is not given, since
specifying only the certificate makes no sense. [Feature #13714]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59268 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
rhenium (Kazuki Yamaguchi)
07:06 AM Revision 739782e3 (git): * ext/openssl/ossl_cipher.c: remove the encryption key initialization
from Cipher#initialize. This is effectively a revert of r32723
("Avoid possible SEGV from AES encryption/decryption", 2011-07-28).
the patch is derived from https://github.com/ruby/openssl/commit/8108e0a6db133f3375608303fdd2083eb5115...
U.Nakamura
06:56 AM Bug #13716 (Closed): Unexpected or undocumented (or maybe both) behaviour when mixing String#scan with named captures
Is this intentional?
```
[1] pry(main)> "1q2w3e4r".scan(/(\w\d)(foo){0}/)
=> [["q2", nil], ["w3", nil], ["e4", nil]]
[2] pry(main)> "1q2w3e4r".scan(/(\w\d)(?<foo>foo){0}/)
=> [[nil], [nil], [nil]]
```
The only difference is th...
shyouhei (Shyouhei Urabe)
06:32 AM Revision af683bd1 (git): debug.c: add FMODE constants
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59266 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
06:27 AM Feature #13714 (Closed): Add https support to "httpd" function inside of "un.rb"
Applied in changeset trunk|r59265.
----------
un.rb: support https
* lib/un.rb: add https support. based on the patch by Flavio
Castelli <flavio@castelli.name> in [ruby-core:81901].
[Feature #13714]
nobu (Nobuyoshi Nakada)
06:27 AM Revision 2c59dd61 (git): un.rb: support https
* lib/un.rb: add https support. based on the patch by Flavio
Castelli <flavio@castelli.name> in [ruby-core:81901].
[Feature #13714]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:49 AM Bug #13711 (Rejected): Unexpected behavior of bit_length method on negative integers
No further action needed. duerst (Martin Dürst)
 

Also available in: Atom