Activity
From 07/12/2017 to 07/18/2017
07/18/2017
-
04:47 PM Bug #13753: Segfault when calling `Random::DEFAULT.rand` in forked child
- The attached patch fixes the issue by re-initialising the random instance such that calls to `Random::DEFAULT.rand` after forking will succeed.
This now gives the same after-fork behaviour as `Random.rand`. Incidentally, there is a c... -
- Hi,
The following causes a segfault on 2.3.4, 2.4.1 and current (`ruby 2.5.0dev (2017-07-18 trunk 59362) [x86_64-linux]`)
~~~ ruby
puts "before fork: #{Random::DEFAULT.rand(42)}"
fork do
puts "child: #{Random::DEFAULT.rand(4... -
12:43 PM Bug #13699: Multiple maps over lazy enumerator yielding multiple values in 2.4.x causes crash
- ruby_2_4 r59363 merged revision(s) 59056.
-
- ruby_2_4 r59363 merged revision(s) 59056.
-
- enumerator.c: fix nested maps
* enumerator.c (lazy_map_proc, lazy_grep_iter_proc): marks values
returned by blocks are not packed in the case of nested maps, so
that the result will be same as non-lazy versio... -
12:37 PM Feature #13726 (Assigned): PATCH: Windows builds - fractional second file times
-
-
- 2.5でやりましょう。
-
- Ok, I'll backport this later.
-
11:28 AM Revision 13155d4d (git): Copy openssl library finder for ext/digest from OpenSSL extention.
- * ext/digest/digest_conf.rb: Support to search variaous filenames of
OpenSSL/LibreSSL libraries.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59362 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:18 AM Bug #13647 (Feedback): Some weird behaviour with keyword arguments
- I couldn't reproduce it with hashie-3.5.6, from 2.0.0 through trunk.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59361 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_string.rb (test_uplus_minus): prefer more
descriptive asssertions than assert_equal.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59360 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:52 AM Revision 86e266bb (git): string: preserve taint flag with String#-@ (uminus)
- * string.c (tainted_fstr_update): move up
(rb_fstring): support registering tainted strings
(register_fstring_tainted): extract from rb_fstring_existing0
(rb_tainted_fstring_existing): use register_fstring_tainted instead
git-svn-... -
- Applied in changeset trunk|r59358.
----------
vm_eval.c: rb_lambda_call
* enum.c (enum_collect): make the block arity same as the given
block. [Bug #13391]
* internal.h (vm_ifunc): store arity instead of unused id.
* proc.c (rb_vm... -
- * enum.c (enum_collect): make the block arity same as the given
block. [Bug #13391]
* internal.h (vm_ifunc): store arity instead of unused id.
* proc.c (rb_vm_block_min_max_arity): return ifunc arity.
* vm_eval.c (rb_lambda_call): ... -
- * proc.c (rb_block_min_max_arity): new function to get arity range
from the current block.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59357 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:21 AM Revision 6607266e (git): test/ruby/test_string.rb: ensure we do not have tainted strings
- Trying to figure out [ruby-core:82092]
cf. https://gist.github.com/e2c899c453f3f66e7934095c32505486
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59356 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:27 AM Bug #13752 (Closed): Can't observe sibling refinements
- Sorry in advance if already reported elsewhere, but is this intentional?
```ruby
class Foo
using Module.new {
refine Foo do
def foo
puts "foo"
end
end
}
using Module.new {
refine Foo d... - 04:30 AM Revision 4f473905 (git): newhash insn reuses existing keys
- This gives the newhash VM instruction the same string reuse
capabilities as rb_hash_aset.
* st.c (str_key): new wrapper function to call rb_fstring_existing
(rb_hash_bulk_insert): use str_key
* test/ruby/test_optimization.rb (test_has... -
02:30 AM Bug #13737 (Closed): "can't modify frozen String" when installing bundled gems - Applied in changeset trunk|r59354.
----------
hash: keep fstrings of tainted strings for string keys
The same hash keys may be loaded from tainted data sources
frequently (e.g. parsing headers from socket or loading
YAML data from a fi... - 02:29 AM Revision d04c085b (git): hash: keep fstrings of tainted strings for string keys
- The same hash keys may be loaded from tainted data sources
frequently (e.g. parsing headers from socket or loading
YAML data from a file). If a non-tainted fstring already
exists (because the application expects the hash key),
cache and... - 02:10 AM Feature #13740 (Closed): [PATCH] doc/extension.rdoc: start entries for threading and IO
- Applied in changeset trunk|r59353.
----------
doc/extension.rdoc: start documenting threading and IO APIs
This will hopefully be useful for folks writing C extensions.
* doc/extension.rdoc: start documenting threading and IO APIs
[r... - 02:10 AM Revision ed831a6c (git): doc/extension.rdoc: start documenting threading and IO APIs
- This will hopefully be useful for folks writing C extensions.
* doc/extension.rdoc: start documenting threading and IO APIs
[ruby-core:82016] [Feature #13740]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59353 b2dd03c8-39d4-4d8f... - 01:59 AM Feature #13729 (Closed): PATCH: Add Server Name Indication (SNI) support to WEBrick
- Applied in changeset trunk|r59351.
----------
webrick: fix SNI support
* lib/webrick/https.rb: check ssl context of virtual host.
* lib/webrick/ssl.rb: ensure to return ssl context.
* test/webrick/test_https.rb: test returned cert is c... -
- 01:59 AM Revision a7b7d403 (git): * 2017-07-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59352 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:59 AM Revision a6c13d08 (git): webrick: fix SNI support
- * lib/webrick/https.rb: check ssl context of virtual host.
* lib/webrick/ssl.rb: ensure to return ssl context.
* test/webrick/test_https.rb: test returned cert is correct.
[Feature #13729][ruby-dev:50173]
Author: Tietew <tietew@gmail....
07/17/2017
-
07:51 PM Feature #13751 (Rejected): Suppert SSHFP resource records in rubysl-resolv
- Hi,
not sure if this is the correct place to report this. rubysl-resolv does not yet support SSHFP resource records. Proposed patch is here:
https://github.com/rubysl/rubysl-resolv/pull/1
Cheers,
-- Guido -
04:11 PM Bug #13660: rb_str_hash_m discards bits from the hash
- I think the case where half the bits are lost could become a potential security issue.
Essentially all strings which have the same first half will collide in a Hash, and that's likely trivial to generate
(the same prefix/suffix of the ... -
03:39 PM Feature #13732: Precise Time.now on Windows
- Thanks @kubo! Your patch looks good. Finally precise timestamps on Windows! The 1/64 granularity was annoying. I tested your patch successfully on Windows-10 64 bit. Time.now returns reliable usec precision as expected.
-
12:59 PM Bug #13745: How to download latest build package for Windows 32/64?
- larskanis (Lars Kanis) wrote:
> The most common binary package for Windows is the RubyInstaller. Stable releases are provided in the download section of https://rubyinstaller.org . Daily development snapshots can be downloaded as build ... -
06:39 AM Feature #13750: Improve String#casecmp? and Symbol#casecmp? performance with ASCII string
- Because String#casecmp? duplicates object at `rb_str_downcase()` every time, so String#casecmp? is slower than String#casecmp?
-
- I think String#casecmp and String#casecmp? are similar methods. But they have different performance with ASCII strings.
It seems that String#casecmp handles ASCII string only, but it is faster than String#casecmp?.
This patch uses ... -
04:22 AM Bug #13632: Not processable interrupt queue for a thread after it's notified that FD is closed in some other thread.
- I created a gem with a temporary workaround for versions 2.2.7, 2.3.4 and 2.4.1 to help folks until versions with backports are released:
https://rubygems.org/gems/stopgap_13632 -
- 2.2.5 is outdated, could you try 2.2.7 (or 2.3, 2.4, trunk if possible)?
-
- * defs/gmake.mk (extract-gems): should wait for update-gems to
finish when doing both.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59350 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parser_yyerror): strip newline in error source which
will not be printed, when lex_p has passed it.
* parse.y (parser_tokadd_utf8): unterminated Unicode escape even
after invalid Unicode escape.
* parse.y (parser_parse_s... -
12:04 AM Bug #13549: MinGW / Windows encoding - Two issues
- Since I posted this, nobu (thank you) authored a few commits that improved the windows encoding issues (not necessarily related to this issue). Since then I do not recall many encoding related failures, and a few patches I have for such...
07/16/2017
-
- * parse.y (literal_flush): rename from numeric_literal_flush, as
it is not just for numerics now.
* parse.y (parser_tokadd_codepoint): show invalid character
position, but not the start of Unicode escape.
git-svn-id: svn+ssh://ci.r... -
- Re-addressing this with a current build, the same issue exists. As mentioned previously, this issue will only exhibit itself when used with a MinGW build that uses the MSYS2/MinGW `readline` package. `readline` has been problematic in ...
-
- Decided to re-run this test, as it's been a while. I've been applying the patch before my normal test runs, so I haven't checked for its (continued) failure for a while. Given that my test results have been consistent across all test s...
-
05:55 PM Bug #13749 (Closed): Encountered a bug in the Ruby interpreter or extension libraries.
- Hi,
I am using a Mac OSX 10.6.8 (Snow Leopard).
I am trying to use vagrant along with virtual box.
I have ruby v.1.9.2 and jruby installed. However, after typing Vagrant into the command line I get the following error/crash (se... - 03:28 PM Revision 26888a8e (git): * 2017-07-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59347 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/lib/test/unit/assertions.rb (assert_pattern_list): make
frozen string literals modifiable as buffers.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59346 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59345 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r59344.
----------
parse.y: utf-8 codepoints
* parse.y (parser_tokadd_utf8): skip spaces in the current line,
without advancing the line, to get rid of dangling pointer.
[ruby-core:82029] [Bug #13742] -
- * parse.y (parser_tokadd_utf8): skip spaces in the current line,
without advancing the line, to get rid of dangling pointer.
[ruby-core:82029] [Bug #13742]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59344 b2dd03c8-39d4-4d8f-9... - 11:35 AM Revision f01f98f0 (git): * 2017-07-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59343 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59342 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/15/2017
-
09:13 PM Bug #13501: Process.kill behaviour for negative pid is not documented and may be wrong
- What do you think about intercepting negative pid and also using it to set `negative`, so that behaviour is consistent on ruby side and `killpg` is used when needed?
-
- We looked at this issue at yesterday's developer meeting and agreed that the acceptance of negative pid shall be documented.
But killing other process is ultimately dome by the platform. It seems not possible to completely remove pla... -
- Just updated to gcc 7.1.0, and built trunk `ruby 2.5.0dev (2017-07-15 trunk 59341) [x64-mingw32]` with Lars' patch, and **all tests results were as expected**.
Build/test logs are at Bintray - [z_logs_2017-07-15_59341.7z](https://dl.b... -
- FIXNUMs are expected to fit into a long type, but the test in MUL_OVERFLOW_FIXNUM_P() is about the VALUE type. Since long is smaller than VALUE on LLP64, the overflow is not detected. As an exemplary result "2**31" evaluates to "-2147483...
-
-
- * parse.y (parser_read_escape, parser_tok_hex): refine error
messages. point from the backslash up to the invalid char.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59341 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:24 AM Revision a7452a8f (git): test_lexer.rb: require ripper directly
- * test/ripper/test_lexer.rb: This file does not use
DummyParser, so requiring ripper directly instead of
requiring dummyparser.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59340 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:35 AM Revision 3cfbd610 (git): * 2017-07-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59339 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:35 AM Revision 40dad62c (git): Fix warning: shadowing outer local variable - a
- [ci skip][Fix GH-1628]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59338 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
-
- We looked at this issue at yesterday's developer meeting and none of attendees remembered there has been any plans to have this feature. It seems to be a doc issue. Please delete this part.
-
- We looked at this issue at yesterday's developer meeting.
The attendees agree that current behaviour is intentional. Because creating Bignums every time is too slow for this experiential hot spot, we want to avoid such thing and stic...
07/14/2017
-
05:17 PM Bug #13745: How to download latest build package for Windows 32/64?
- Do also note that there is a *nix "subsystem" on Win10 since a while. I tried it and you can currently run ubuntu there or a ubuntu-like system.
This is of course not 100% the same as an .exe but my point is that you can actually use... -
- The most common binary package for Windows is the RubyInstaller. Stable releases are provided in the download section of https://rubyinstaller.org . Daily development snapshots can be downloaded as build artefacts from appveyor: https://...
-
07:02 AM Bug #13745 (Closed): How to download latest build package for Windows 32/64?
- As far as Ruby CI and CRuby development, we don't provide binary package.
It just build and trash away the package built in the instruction.
I don't know RubyInstaller CI and it is not handled here. -
- This is my first question, it look like not much for the dev group.
I need to download latest build package for Windows 32/64 but not able to find out. I see Ruby has 2 ci/ build server.
+ Ruby CI
+ RubyInstaller CI
I try to ac... -
- As many of you know, I have been building MinGW for quite a while, and posting results at [Ruby MinGW Test Results](https://msp-greg.github.io/file.mingw_test-all.html).
I recently added a 64-bit build to [BinTray](https://dl.bintray.... -
- * ext/zlib/zlib.c (rb_gzfile_total_out): cast to long not to
result in an unsigned long to normalized to Fixnum on LLP64
platforms. [ruby-core:81488]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59337 b2dd03c8-39d4-4d8f-98ff-8... -
- Applied in changeset trunk|r59336.
----------
io.c: textmode if newline decorator
* io.c (validate_enc_binmode): newline decorator implies text mode
now. [ruby-core:80270] [Bug #13350] -
-
08:25 AM Bug #13350: File.read :newline option not respected on Linux
- It seems to be a nice idea to turn text-mode on with `newline` option.
Matz.
-
- * io.c (validate_enc_binmode): newline decorator implies text mode
now. [ruby-core:80270] [Bug #13350]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59336 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (ripper.c): pass the build directory path for id.h
which may be generated there.
* ext/ripper/depend (ripper.y): search the top build directory and
the top source directory.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/t... -
- I created a ticket in upstream: https://github.com/k-takata/Onigmo/issues/92
-
09:41 AM Revision 677751e1 (git): hash.c: fix possible crash in Hash#transform_keys!
- Fix up r59328. It is possible that the given block abuses
ObjectSpace.each_object to shrink the temporary array.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59334 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
-
- Now we have Exception#cause.
Therefore it should be
```ruby
begin
raise 'foo'
ensure
raise 'bar'
end
``` -
- I understand the principle. But I think it's a programmer's fault to modify the string.
I don't think it's worth prohibiting (and making implementation more complex).
Matz.
-
- Applied in changeset trunk|r59333.
----------
Zlib::GzipReader#pos underflows after calling #ungetbyte or #ungetc at start of file [Bug #13616]
patched by Andrew Haines <andrew@haines.org.nz> [ruby-core:81488] -
- patched by Andrew Haines <andrew@haines.org.nz> [ruby-core:81488]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59333 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:17 AM Bug #13593 (Feedback): Addrinfo#== behaves oddly
- It is difficult compare Addrinfo objects precisely if not impossible.
Using Addrinfo#inspect as addrinfo_eql.diff is fragile.
Addrinfo is basically struct addrinfo which contains struct sockaddr.
Byte-to-byte comparison may not wo... -
-
-
- As far as I understand this is Wine's issue.
Wine should have the registry key. -
08:46 AM Feature #13676 (Closed): to_s method is not overriden for Set
- Applied in changeset trunk|r59332.
----------
Alias Set#to_s to #inspect [ruby-core:81753] [Feature #13676] -
- Makes sense. I'll add to_s as an alias to inspect.
- 08:46 AM Revision d893c123 (git): Alias Set#to_s to #inspect [ruby-core:81753] [Feature #13676]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59332 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:46 AM Revision cb1d634d (git): Make tests for Set#inspect more straightforward
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59331 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- >ko1
Please review https://github.com/ruby/ruby/compare/trunk...nobu:bug/13391-map-arity
-
- We continues to discuss #13391
-
- @shugo Could you review this patch?
-
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59330 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- 確かに頑張ってGNU makeを指定すると言う方向性もなくはないのですが、基本的にはCRuby添付のlibffiはlibffiパッケージが提供されていない環境、
具体的にはWindowsのVisual C++環境を想定してのものなので、Rubyインストール前にlibffiをインストールして頂けますか。
Solarisではパッケージで提供されているはずです。
なお、configureに--without-fiddleを指定してそもそもfiddleをビルドしないと... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59329 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:44 AM Feature #13583 (Closed): Adding `Hash#transform_keys` method
- Applied in changeset trunk|r59328.
----------
hash.c: Add Hash#transform_keys and Hash#transform_keys!
* hash.c (transform_keys_i, rb_hash_transform_keys): Add Hash#transform_keys.
[Feature #13583] [ruby-core:81290]
* hash.c (rb_has... -
- Looks good to me.
Matz.
- 06:44 AM Revision 14051117 (git): hash.c: Add Hash#transform_keys and Hash#transform_keys!
- * hash.c (transform_keys_i, rb_hash_transform_keys): Add Hash#transform_keys.
[Feature #13583] [ruby-core:81290]
* hash.c (rb_hash_transform_keys_bang): Add Hash#transform_keys!.
[Feature #13583] [ruby-core:81290]
* test/ruby/test_... -
- This API is pretty simple but only works on Linux. I am not positive to add platform-specific features to the language core. I'd rather recommend considering making it a gem.
Matz.
-
- I feel this is too Linux and environment specific.
For example, it depends /proc/fd.
I think that it is better to provide linkat(2) directly.
(Extend File.link or add File.linkat.) -
- normalperson (Eric Wong) wrote:
> However, `PATH_MAX` (4096 on Linux) is excessive use of stack.
> ...
```c
static const char self_fd[] = "/proc/self/fd/%d";
char from_path[sizeof(self_fd) - 2 + DECIMAL_SIZE_OF_BITS(sizeof(int))];
``` -
06:38 AM Bug #13746 (Closed): windows-pr gemのRuby 2.4 32bit版でのSEGV
- windows-pr gemのCI対象にRuby 2.4 32/64bit版の両方を加えてAppVeyorにてCIを走らせたところ、SEGVが発生しました。
このSEGVはRuby 2.4の64bit版（ruby 2.4.1p111 (2017-03-22 revision 58053) [x64-mingw32]）では発生しません。
windows-prのリポジトリは https://github.com/cosmo0920/windows-pr です。
g... -
- * Rely on encoding tags to determine if string should be dumped as binary.
https://github.com/ruby/psych/commit/8949a47b8cee31e03e21608406ba116adcf74054
* Specify "frozen_string_literal: true".
* Support to binary release for min... -
06:12 AM Feature #13666 (Closed): Development: Writing test code for new features/bug fixes can be done as specs under spec/rubyspec instead of tests under test/
- We discussed this this issue at today's Ruby Committer meeting.
We agreed that the new setup makes it easier to write specs. It is no longer necessary to also write tests for MRI.
We noted that different developers may be more or l... -
- Looks good to me.
Matz.
-
05:44 AM Feature #13729: PATCH: Add Server Name Indication (SNI) support to WEBrick
- ごめんなさい。前回送ったパッチですが、不完全でした。正しくContextを返していませんでした。
テスト時に大ぽかしてSAN証明書を参照していたため、見誤っていました。
そこの修正と、正しい証明書が提示されたことを確認するテストを追加したパッチを追加します。
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59326 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * process.c (rlimit_type_by_sym): prohibit null bytes in key
names. [ruby-core:82033] [Bug #13744]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59325 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/13/2017
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59324 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:32 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- ko1@atdot.net wrote:
> sorry for long absent about this topic. it is hard task (hard
> to start writing up because of problem difficulties and my
> English skil ;p ) to summarize about this topic.
No problem, thank you for summari... -
08:37 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- sorry for long absent about this topic. it is hard task (hard to start writing up because of problem difficulties and my English skil ;p ) to summarize about this topic.
I try to write step by step.
----
# Discussion at last dev... -
- reclosing to trigger backport request
-
- fixed in r59322, will need backports
- 08:47 PM Bug #13744 (Closed): Spawn doesn't work with options of symbol keys generated dynamically
- Applied in changeset trunk|r59322.
----------
process.c: handle dynamic :rlimit_* symbols in spawn execopts
* process.c (rb_execarg_addopt_rlimit): hoist out of rb_execarg_addopt
(rlimit_type_by_sym): new wrapper for dynamic symbol
... -
- satoryu.1981@gmail.com wrote:
> But spawn fails when generating symbol from a String:
>
> ~~~
> $ ruby -e 'spawn("ls", "rlimit_cpu".to_sym => 100)'
> -e:1:in `spawn': wrong exec option symbol: rlimit_cpu (ArgumentError)
> ... -
01:14 PM Bug #13744: Spawn doesn't work with options of symbol keys generated dynamically
hm on my windows machine:
~~~
ruby -e 'spawn("ls", :rlimit_cpu => 100)'
~~~
causes a syntax error
PS:
i did install ruby in my mingw (ruby 2.3.3p222), there i get similar problem like yours:
~~~
$ ruby -e 'spawn("ls", :...-
- Very interesting behaviour. I would have assumed for both to behave the same in the above case.
-
11:44 AM Bug #13744 (Closed): Spawn doesn't work with options of symbol keys generated dynamically
- spawn works when giving options whose key is symbol literal:
~~~
$ ruby -e 'spawn("ls", :rlimit_cpu => 100)'
~~~
But spawn fails when generating symbol from a String:
~~~
$ ruby -e 'spawn("ls", "rlimit_cpu".to_sym => 100)'
... -
- glass.saga@gmail.com wrote:
> Feature #13743: Support linking of files opened with O_TMPFILE
> https://bugs.ruby-lang.org/issues/13743
I like this feature.
> patch.diff (2.44 KB)
> ```diff
> + if (!NIL_P(tmp) && f... -
- Extension of `File.link`, but not `File#link`?
-
11:18 AM Feature #13743 (Rejected): Support linking of files opened with O_TMPFILE
- This patch enables linking of files opened with O_TMPFILE into file system.
Users can make a temporary file persistent as named file.
```ruby
File.open(".", IO::WRONLY|IO::TMPFILE) do |f|
f.write("content")
f.chmod(0600)
Fi... - 08:47 PM Revision 24e4a877 (git): * 2017-07-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59323 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:47 PM Revision 5c4db58b (git): process.c: handle dynamic :rlimit_* symbols in spawn execopts
- * process.c (rb_execarg_addopt_rlimit): hoist out of rb_execarg_addopt
(rlimit_type_by_sym): new wrapper for dynamic symbol
(rb_execarg_addopt): check for dsym via rlimit_type_by_sym
* test/ruby/test_process.rb (test_execopts_rlimit)... -
- I think atomicity is important. If the kernel doesn't support atomic exchange, File.exchange should raise NotImplementedError and users can handle it properly.
```ruby
begin
File.exchange("hoge", "fuga")
rescue NotImplementedErro... -
10:20 AM Bug #13742 (Closed): SIGSEGV in parser_yyerror()
- After some fuzz testing I found a crashing test case.
To reproduce: miniruby ruby_sigsegv_parser_yyerror
Valgrind Context:
```
==20061== Memcheck, a memory error detector
==20061== Copyright (C) 2002-2017, and GNU GPL'd, by Ju... -
- tests of fiddle already used customized assertions of ruby core.
* test/fiddle/helper.rb: Use Test::Unit::TestCase for base class of
testcase.
* test/fiddle/test_*.rb: Use assert_raise instead of assert_raises.
Remove needle... -
- ko1@atdot.net wrote:
> > VALUE rb_vm_call0_body(rb_thread_t *th, struct rb_calling_info *calling,
>
> You don't need to expose `vm_call0_body()` because ` vm_eval.c` and ` vm_insnhelper.c` are included in `vm.c`.
Ah, thanks. I j... -
- > VALUE rb_vm_call0_body(rb_thread_t *th, struct rb_calling_info *calling,
You don't need to expose `vm_call0_body()` because ` vm_eval.c` and ` vm_insnhelper.c` are included in `vm.c`.
```
if (RB_TYPE_P(recv, T_SYMBOL)) {
v... -
- ko1@atdot.net wrote:
> I wrote the following sentences in hastily so sorry if it has
> English grammar problems.
<snip> no problem.
> normalperson (Eric Wong) wrote:
> > Yes, that would be great. However, we will take ... -
- I wrote the following sentences in hastily so sorry if it has English grammar problems.
normalperson (Eric Wong) wrote:
> Sorry, I wasn't sure what you wanted the last time this came up.
> ...
Yes. and I understand.
> Yes, that... -
- * parse.y (parser_compile_error): flush debug output before
compile error message, to keep the order.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59320 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ko1@atdot.net wrote:
> Thank you for survey.
No problem :)
> normalperson (Eric Wong) wrote:
> > > I think we don't need to prepare frozen string table for tainted string because most of people don't use tainted strings. We nee... -
- Thank you for survey.
normalperson (Eric Wong) wrote:
> > I think we don't need to prepare frozen string table for tainted string because most of people don't use tainted strings. We need to measure the counts of that before commit ... -
- ko1@atdot.net wrote:
> Sorry for late response
> (because of my health problem and so on...)
No problem, I hope you feel better, soon. Thank you for any
response you give :)
> I think we don't need to prepare frozen string tab... -
- Sorry for late response
(because of my health problem and so on...)
I think we don't need to prepare frozen string table for tainted string because most of people don't use tainted strings. We need to measure the counts of that befor... -
- ko1@atdot.net wrote:
> > void *rb_thread_call_without_gvl(void *(*func)(void *), void *data1, rb_unblock_function_t *ubf, void *data2) ::
>
> You need to mention that `func` is not allowed to call any
> `rb_` functions (there are ... -
- > void *rb_thread_call_without_gvl(void *(*func)(void *), void *data1, rb_unblock_function_t *ubf, void *data2) ::
You need to mention that `func` is not allowed to call any `rb_` functions (there are exceptions but it should be used ... -
- shevegen@gmail.com wrote:
> Looks ok to me - at the least I could not spot grammatical
> errors or typo glancing through it 1-2 times. I have of course
> no idea about threads themselves really so perhaps someone
> should also look ... -
- Looks ok to me - at the least I could not spot grammatical errors or typos glancing through it 1-2 times. I have of course no idea about threads themselves really so perhaps someone should also look through who actually knows that stuff ...
-
- > It would be great if #write could take an array, and if possible, call writev.
That's would be nice.
```
File.open("test", "w") do |f|
f.write("foo", "bar", "baz") # use writev(2) if possible
end
``` -
03:17 AM Bug #13741 (Closed): A documentation bug of IO#putc
- The documentation of IO#putc says:
```
* call-seq:
* ios.putc(obj) -> obj
*
* If <i>obj</i> is
07/12/2017
-
- Eric Wong <normalperson@yhbt.net> wrote:
> nobu@ruby-lang.org wrote:
> > Or should `fstring_cmp` consider also tainted flags?
>
> I considered doing that, but it may not be optimal since I want
> to share heap allocations with the... -
- nobu@ruby-lang.org wrote:
> Or should `fstring_cmp` consider also tainted flags?
I considered doing that, but it may not be optimal since I want
to share heap allocations with the non-tainted version via
rb_str_dup. -
- Or should `fstring_cmp` consider also tainted flags?
-
- Eric Wong <normalperson@yhbt.net> wrote:
> ko1@atdot.net wrote:
> ...
Maybe the following works (barely tested, but I have to go...)
```diff
---
hash.c | 23 +----------
internal.h | ... -
- Some of it derived from existing documentation in thread.c,
and some of it original. It seems extension.rdoc is getting
large, so maybe it is better broken up into separate manpages
(section "3ruby", maybe?)
Anybody care to revi... - 06:31 PM Revision d15cc7a6 (git): doc/extension.rdoc: update wikipedia link to HTTPS
- Avoid the latency for HTTP -> HTTPS redirect
* doc/extension.rdoc: update wikipedia link to HTTPS
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59319 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:02 PM Revision 98f0a528 (git): * 2017-07-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59318 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59317 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_4 r59316 merged revision(s) 59312.
-
- バックポート管理用チケットです。
-
- optparse.rb: get rid of eval
* lib/optparse.rb: try Float() and Integer() instead of eval,
which does too much things.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59316 b2dd03c8-39d4-4d8f-98ff-823fe6... -
01:38 PM Bug #13727: Not able to set program_name for new Syslog::Logger
- Thank you!
Sorry, I haven't noticed this documentation. -
- karanamsandhya (Karanam Sandhya) wrote:
> getting Encoding::UndefinedConversionError ("\xFF" from ASCII-8BIT to UTF-8): this error while uploding the image.
There's definitely no error in Ruby itself, in the encoding "ASCII-8BIT", on... -
10:00 AM Bug #13738 (Third Party's Issue): Active Scaffold image upload using CarrierWave gem
- Did you see https://github.com/carrierwaveuploader/carrierwave/issues/1404?
As far as I can see from your description, it's unlikely to be a bug in Ruby-side. Please confirm the issue and then could you report it to carrierwave or Rails? -
07:45 AM Bug #13738 (Third Party's Issue): Active Scaffold image upload using CarrierWave gem
- getting Encoding::UndefinedConversionError ("\xFF" from ASCII-8BIT to UTF-8): this error while uploding the image. and image params are like this:
"photo"=>#<ActionDispatch::Http::UploadedFile:0x007fbcc2925c80 @tempfile=#<Tempfile:/tm... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59315 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * gc.c (RGENGC_DEBUG_ENABLED): restrict runtime ruby_rgengc_debug
level up to -RGENGC_DEBUG, to reduce runtime branches in inner
loops.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59314 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:49 AM Revision 5235446a (git): * 2017-07-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59313 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/optparse.rb: try Float() and Integer() instead of eval,
which does too much things.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59312 b2dd03c8-39d4-4d8f-98ff-823fe69b080e