Activity
From 07/25/2014 to 07/31/2014
07/31/2014
-
11:31 PM Bug #10102: [PATCH] dir.c: [DOC] Document that Dir.exists? is deprecated
- I think the reasoning given here makes sense and is consistent.
matz explained that the question that should be asked is "object, do you exist" (singular, specific to the object at hand) rather than the english sentence question "does... -
06:22 AM Bug #10102 (Closed): [PATCH] dir.c: [DOC] Document that Dir.exists? is deprecated
- I noticed Dir.exists? was undocumented, so I thought Dir.exists? should be marked as deprecated just like File.exists? is marked as deprecated. If its unneeded, feel free to ignore this patch.
Thanks for your guide zzak :D
http://doc... - 10:36 PM Revision 4514516b (git): * 2014-08-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47022 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:36 PM Revision bf3d294a (git): * ext/bigdecimal/bigdecimal.c: [DOC] Add description of
- `BigDecimal.new` exceptions. Patched by @joker1007 and
@prathamesh-sonpatki [Fixes GH-690]
https://github.com/ruby/ruby/pull/690
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47021 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:56 PM Bug #10086: [PATCH] Remove exponents calculation from mathn.rb
- @Nobuyoshi Nakada さん
コメントありがとうございます.
> alias / quo の変更は不要に見えますが
個人的にaliasを貼る時は（特にoperatorに対して）symbolの方が可読性が高まり好ましいと考えています.
すみませんこの様な個人的な趣向を入れ込むは避けるべきだったでしょうか.
少なくともパッチは分けるべきだったでしょうか.
> ...
はい. 文脈から察するに'多様な除法' を意図された言葉だと... -
02:09 AM Bug #10086 (Feedback): [PATCH] Remove exponents calculation from mathn.rb
- `**`の削除は(`alias / quo` の変更は不要に見えますが)いいと思います。
最後のパッチで"multiple division"から"multiple"という単語が消されていますが、これはいらないのでしょうか。 -
05:45 PM Bug #10104 (Rejected): Fileutils cp_r fails on sockets or fifes even if File.mknod and File.mkfifo are defined
- Briefly, our code uses cp_r to copy a directory structure whose contents seem to occasionally have a Unix domain socket. This raises an exception, which seems reasonable enough. We consulted the code to see if there was a workaround, and...
-
04:21 PM Bug #10103: Unable to refine class with CONSTANT
- I would like to also mention that this impacts class_variables as well
~~~
module Foobar
@@baz = "boom"
refine String do
@@foo = "bar"
def foobar
@@foo
end
def bazical
... -
03:44 PM Bug #10103 (Closed): Unable to refine class with CONSTANT
- When refining a class (such as `String` in the following example) it is impossible to assign a constant. The constant will get attached to the module containing the refinement instead of the refined class. When inside of a `refine` bloc...
-
04:00 PM Feature #10090: Display of program name in process listing under AIX
- +1 on fixing this.
Is it possible AIX is missing some headers supplied on other systems? -
01:37 PM Bug #9937: Segfault in the TracePoint API
- Hi, I'll be fixing this inside byebug. I don't think the assumption that TracePoint API events will always provide a method_id is correct, so I'll be checking for nil values.
I guess this can be closed. -
02:38 AM Bug #9937 (Assigned): Segfault in the TracePoint API
- Thank you for your report.
ko1 san, could you handle this issue? -
01:31 PM Feature #6613: VT_RECORD, IRecordInfo Support in WIN32OLE
- Sorry for waiting too long. I had implemented VT_RECORD / IRecordInterface features.
Try WIN32OLE_RECORD class in ruby-trunk (2.2.0dev revision 47020 or later). -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47020 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:15 PM Feature #6265: Remove 'useless' 'concatenation' syntax
- I said "useless" in the sense that you can achieve the same using "+" and it makes it easy to introduce common bugs in case you forget a comma between two strings when calling a method and this has happened already in real code, includin...
-
- I'm against it, it's not "useless" to me.
-
- Release Manager of 2.2.0 is naruse san.
-
- WIN32OLE_RECORD#ole_instance_variable_set and
WIN32OLE_RECORD#ole_instance_variable_get
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47019 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * symbol.h (RSYMBOL): move macros for Symbol from internal.h.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47018 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47017 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:52 AM Revision 4a2cf2fe (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47016 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47015 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Joseph, thank you for your report.
But I think current behavior on trunk is correct as described in #3803.
> BigDecimal.new("0.51").round(0, BigDecimal::ROUND_HALF_DOWN).to_s("F")
=> "1.0"
> BigDecimal.new("0.51").rou... -
01:08 AM Bug #9353 (Closed): Struct setter methods now return the struct object rather than the value
-
12:53 AM Bug #10101 (Closed): Zlib::GzipReader produce different outputs for different methods applied
- The methods `read`, `readbyte` and `each_byte` are producing different outputs. Comparing with the unziped file, only the result of readbyte is correct according to the size but comparing byte per byte with the original file sometimes gi...
07/30/2014
-
- Backported into `ruby_2_1` branch at r47014.
-
- * compile.c (rb_iseq_compile_node): put start label of block after
trace (b_call).
[Bug #9964]
* test/ruby/test_settracefunc.rb: add a test.
added assert_consistent_call_return() method check call/r... -
04:48 PM Bug #10019: segmentation fault/buffer overrun in pack.c (encodes)
- Well the reproducibility issue appears to be a toolset problem. If I build with -O2 the code works fine. I think ultimately the optimizations (O3) for gcc 4.7.2 at least with the mingw toolset are causing the issue here for windows. I...
-
04:41 PM Bug #10100 (Closed): Document usage of RB_GC_GUARD in README.EXT
- I see more and more extensions and ruby code using this and yet it is undocumented. Eric posted this - http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/60741 and if it can be added to README.EXT it would be pretty awesome.
-
- Backported into `ruby_2_1` branch at r47013.
-
- * vm.c (invoke_block_from_c): move call/return event timing for
bmethod. It can invoke inconsistent call event if this call raises
argument error.
[Bug #9959]
* vm_insnhelper.c (vm_call_bmethod_body... -
- Backported into `ruby_2_1` branch at r47012.
-
- * vm_core.h: add VM_FRAME_MAGIC_RESCUE to recognize normal block or
rescue clause.
* vm.c (vm_exec): use VM_FRAME_MAGIC_RESCUE on at rescue/ensure.
* test/ruby/test_settracefunc.rb: should not invoke b_return ... - 04:18 PM Revision b1b779fa (git): * 2014-07-31
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47011 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/mkmf.rb (have_framework): try without -ObjC option first as
MacPorts GCCs do not support it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47010 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- r46419 and r46429 were backported into `ruby_2_1` branch at r47009.
-
- * vm_trace.c: clear and restore recursive checking thread local data
to avoid unexpected throw from TracePoint.
[Bug #9940]
* test/ruby/test_settracefunc.rb: add a test.
* thread.c: adde
* ... -
02:31 PM Revision e3230f15 (git): * sprintf.c (rb_str_format): like r47006, get rid of
- function calls in RSTRING_PTR().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47008 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * signal.c (rb_f_kill, trap_signm): preserve argument encoding in
error messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47007 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * process.c (rlimit_resource_type, rlimit_resource_value): get rid
of function calls in RSTRING_PTR(), as it evaluates the argument
twice.
* re.c (match_backref_number): ditto.
* signal.c (esignal_init, rb_f_kill, trap_signm): ditt... -
- get rid of inadvertent dynamic symbol pin-down.
* re.c (match_backref_number): ditto.
* signal.c (esignal_init, rb_f_kill, trap_signm): ditto.
* transcode.c (econv_opts): ditto.
* vm_trace.c (symbol2event_flag): ditto.
git-svn-id: s... -
12:56 PM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
- Matt U wrote:
> - Since Ruby has only the one `String` class for text and data, I think it does make sense to keep this method on the `String` class.
I agree with you!
> ...
Then that encoding will be ignored has to be mentioned i... -
02:07 AM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
- Nobuyoshi Nakada wrote:
> `rb_tsafe_eql()` doesn't need to be `VALUE`, `int` is OK.
> ...
I'll get these done. Your benchmark code demonstrated this pretty well so (if it's ok with you) I'll use that as a starting point.
cremno phob... -
- * thread.c (rb_thread_variable_set): get rid of inadvertent dynamic
symbol pin-down.
* vm_method.c (obj_respond_to): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47004 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (rb_to_symbol): new function to convert an object to a
symbol.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47003 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * thread.c (threadptr_local_aset): fix indent, remove unnecessary
braces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47002 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- by reference when invoke OLE methods at first.
* ext/win32ole/win32ole.c (olerecord_set_ivar): release
IRecordInfo interface before setting another IRecordInfo interface.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47001 b2dd... -
- Use homebrew's openssl instead of OpenSSL.framework.
- 06:24 AM Revision f29dae35 (git): * 2014-07-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47000 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:24 AM Revision 2cb8ee94 (git): * gc.c: remove unused macros.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46999 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/29/2014
-
08:21 PM Feature #10059 (Feedback): [PATCH and SUGGEST] 代数構造を記述する時にメタプログラミングは非常に非常に強力ですが
-
- Your code is very artifactual and the patch of comment #2 reduce a performance of normal case. So, until someone provide a real usecase, I don't take it.
-
- I don't like the proposed method name.
`tsafe`? It should be `timingsafe`. Saving some keystrokes isn't worth it to have a less obvious name. Even C programmers chose a longer name!
I'm also not happy about `eql?` either. Then peop... -
- `rb_tsafe_eql()` doesn't need to be `VALUE`, `int` is OK.
Tests for timing-safeness are desirable, but it would be fragile by noise. -
- What's your thoughts on this new patch?
At the moment I'm using OSX and Linux, unable to test `timingsafe_memcmp()` and `consttime_memequal()`. -
- Agree to extract a function, I meant it by "provide timing-safe binary compare function".
But the name `*_memcmp` doesn't look nice, as it looks like returning the same result as `memcmp`.
The order on this comparison won't make sense,... -
- Nobuyoshi Nakada wrote:
> According to [notes on timingsafe_memcmp](http://www.tedunangst.com/flak/post/notes-on-timingsafe-memcmp),
> ...
Wow, thank you for such detailed and valuable feedback (and an awesome patch!)
What do you th... -
- According to [notes on timingsafe_memcmp](http://www.tedunangst.com/flak/post/notes-on-timingsafe-memcmp),
OpenBSD has [`timingsafe_memcmp()`](http://openbsd.cs.toronto.edu/cgi-bin/cvsweb/src/lib/libc/string/timingsafe_memcmp.c), and Ne... -
- Seems correct.
I made a benchmark for it:
~~~ruby
# bm-tsafe_eql.rb: [Feature #10098]
require 'benchmark'
a = "x"*1024_000
b = a+"y"
c = "y"+a
a << "x"
n = (ARGV.shift || 100000).to_i
Benchmark.bm(15) {|bm|
bm.report("... -
- Nobuyoshi Nakada wrote:
> `slow` is not the main concern here, IMHO.
> ...
Cleaned up (hopefully correctly) and moved to `String#tsafe_eql?`. Any ideas for a better name?
-
- Matt U wrote:
> How about moving this to a method on `String` - e.g. `String#slow_eql?` or `String::timing_safe_eql?`? I'm terrible at naming things :)
`slow` is not the main concern here, IMHO.
The latter is more descriptive, but s... -
- Thanks for the feedback!
Nobuyoshi Nakada wrote:
> * Indent style mismatch
> ...
Will fix - sorry, this is my first contribution!
> * Why HMAC only? Other digests don't need it?
Good point, I thought since HMAC is for both re... -
- * Indent style mismatch
* Should try to convert the argument with `StringValue()`
* Why HMAC only? Other digests don't need it?
* Probably we should provide timing-safe binary compare function? -
03:15 PM Bug #10099 (Rejected): Compiling Ruby 2.1.2 with OpenSSL "recipe for target 'openssl_missing.o' failed"
- Hi,
I compile Ruby 2.1.2 from source but "get recipe for target 'openssl_missing.o' failed". I don't understand why it's using openssl_missing as my copy of OpenSSL works and is passed to `configure`. Any help with this would be much ... -
- instance variable if the variable is nil.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46998 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- divide functionality of folerecord_method_missing into
olerecord_ivar_set and olerecord_ivar_get.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46997 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (compile_data_alloc): cast to suppress a warning by
apple gcc-4.2. it doesn't cause an error but a warning in spite
of -Werror=shorten-64-to-32 option, for some reason.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@... -
07:55 AM Bug #10019: segmentation fault/buffer overrun in pack.c (encodes)
- Nobuyoshi Nakada wrote:
> I couldn't reproduce it with that code, can you?
I can't, and I explained that the output of OpenSSL::HMAC.digest is way too short to fill or overflow buff[] in encodes(). It was added to make it possible f... -
- * misc/ruby-additional.el (ruby-encode-unicode): change key
binding to get rid of conflict with uncomment-region.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46995 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * misc/ruby-additional.el (ruby-encode-unicode): use marker
instead of offset to track insertion.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46994 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:18 AM Bug #9712 (Assigned): Dir.entries replace Unicode character with questionmarks
- In that case, we need to ask for a backport of r42058; this must be done by usa the maintainer of 2.0 series.
Thank you for the report. -
- * marshal.c (w_symbol): fix symlink index. register the given
symbols, not its name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- In Java it doesn't but I only borrowed Java's name, while keeping the concept of Ruby modules. Ruby modules do search classes in the parent modules and I wanted package to simply make it easier to use nested modules in Ruby.
07/28/2014
-
- It doesn't seem that `package A::B::C` searches constants from `A` and `A::B`.
-
- Not all reasons, but important ones in my opinion specially as you get big namespaces and nesting level.
I didn't want to mix everything in a single request, but since you're asking for more reasons/motivation let me also state what e... -
- Tomas Hoger wrote:
> Hence the minimal reproducer should be:
> ...
I couldn't reproduce it with that code, can you?
-
- Will Wood wrote:
> Here's the issue. In the loop (len >= 3) you check to see if there's enough room in buff. Unfortunately if len < 3 we don't flush the buffer and then write additional bytes onto the end without checking.
The chec... -
- I took a look at it yesterday. Here's the issue. In the loop (len >= 3) you check to see if there's enough room in buff. Unfortunately if len < 3 we don't flush the buffer and then write additional bytes onto
the end without checking... - 08:36 PM Revision fbc3f55b (git): * 2014-07-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46992 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * marshal.c (r_symreal): fix instance variable load odrder, its
name must be read before its value. the order of function call
arguments is not stable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46991 b2dd03c8-39d4-4d8f-98ff... -
- Modified misleading error message - new patch attached.
-
- I could be totally wrong, but it seems the standard library doesn't provide a reliable way of comparing hashes in constant-time.
* The docs for `OpenSSL::HMAC` encourage the use of `Digest#to_s` (see: http://ruby-doc.org/stdlib-2.1.0/... -
02:32 PM Bug #10013: [CSV] Yielding all elements from a row
- First of all sorry for the late answer Andrew.
Checking arity was one thing I was considering. You're right that the arity of the block might not match the number of items, but that works fine with arrays.
~~~ruby
foo = [[1, 2], [... -
- What do you mean by introducing a mode to make a hash indifferent? You mean another method changing how the Hash works, just like compare_by_identity? Or do you mean some Ruby command-line flag option? I wouldn't like the latter but mayb...
-
- Was this rejected because the i suffix was already taken or because the idea of using suffixes would be confusing? Should I try another suffix in another ticket?
I don't think compare_by_identity does what I want. It seems to behave s... -
- Hi Boris,
there's indeed no urgency in asking for such a feature but I don't think it's a required reason for a feature request, is it?
But thanks for the suggested implementation, really useful. -
- * bignum.c (Init_Bignum): [DOC] Bignum::GMP_VERSION.
* complex.c (Init_Complex): [DOC] ignore an internal class.
* dir.c (Init_Dir): [DOC] File::FNM_SYSCASE.
* file.c (rb_file_exists_p): [DOC] File.exists? is deprecated.
* object.c (... -
- setter of member of WIN32OLE_RECORD object.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46989 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * encoding.c (rb_enc_get_index): deal with symbols instead of IDs
to get rid of inadvertent pin-downs.
* enum.c (chunk_ii): ditto.
* enumerator.c (append_method): ditto.
* iseq.c (iseq_load): ditto.
* marshal.c (w_symbol, r_symlink... -
08:02 AM Bug #9712: Dir.entries replace Unicode character with questionmarks
- As mentioned the documentation for version 2.0 is missing this. SketchUp 2014 embedded Ruby 2.0 and developers usually refer to the documentation for the version embedded. Any chance to see that documentation updated? It's causing a bit ...
-
- I've forgotten the test file, "test/ruby/enc/test_windows_1252.rb", and added it now.
What tests are needed? -
- * common.mk (clean-platform): use $(NULL) as portabile null device
name instead of hard coded /dev/null for the portability.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46987 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:32 AM Feature #10084: Add Unicode String Normalization to String class
- copying notes from 2014/7/26 developer's meeting (Google docs):
Proposed method names by Matz: unicode_normalize or normalize_kd,... (not too short)
How to deal with non-Unicode encodings: Matz: raise Exception
Other than UTF-8: UTF... -
-
- Yukihiro Matsumoto wrote:
> I can accept `#itself`. I want to see it isn't conflict with existing methods.
It's hard to imagine other functionality from that name for me.
The best way to tell if it will break something should be im... -
02:30 AM Feature #10095: Object#as
- What about unifying this feature with this feature: https://bugs.ruby-lang.org/issues/6373? Let the block be optional; when there is one, it returns what this thread originally expected, and when there is no block, it returns the receive...
07/27/2014
-
- I think the current documentation explains this well, so closing.
```
/*
* call-seq:
* Dir.entries( dirname ) -> array
* Dir.entries( dirname, encoding: enc ) -> array
*
* Returns an array containin... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46986 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r46985.
----------
* vm_eval.c: [DOC] [Bug #9551] Improve clarity of Kernel::catch
documentation, patch by Jesse Sielaff. -
- documentation, patch by Jesse Sielaff.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46985 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Its been 5 months without any feedback, so I'm closing this.
If you have any specific questions about how to contribute, please feel free to reply or email the list ruby-core@ruby-lang.org or email me personally at zzak@ruby-lang.org
... -
- Applied in changeset r46984.
----------
* lib/uri/common.rb: [DOC] [Bug #9563] Recommend using URI.escape
before parsing a uri to avoid invalid characters. Reported by
Evgeniy Serykh. -
- before parsing a uri to avoid invalid characters. Reported by
Evgeniy Serykh.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46984 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- We've added an rdoc file to the source tree that lists the current keywords of ruby, you can access it a couple of ways, such as:
$ ri ruby:keywords
or from irb:
help "ruby:keywords"
-
- I'm marking this as closed as we are working on it outside of redmine, and has no effect on trunk or other ruby version development.
Stay tuned! -
- Applied in changeset r46983.
----------
Fix ticket number from r46982, should be [Bug #10049] -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46983 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- and will output at least 4 digits as the year. Reported by Yury
Trofimenko [Bug #8941]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46982 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/win32ole/win32ole.c (ole_rec2variant): cast to suppress a
format warning on x86_64-cygwin.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46981 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46980 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r46979.
----------
* lib/uri/common.rb: [DOC] [Bug #10075] Clarify how URI.join arguments
are handled by RFC3986, originall reported by John Feminella. -
- are handled by RFC3986, originall reported by John Feminella.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46979 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r46978.
----------
* file.c: [DOC] Clarify how File.file? handles symbolic links. Also
cleaned up the rdoc style for this method, more to follow.
Originally reported by Michael Renner [Bug #10067] -
- cleaned up the rdoc style for this method, more to follow.
Originally reported by Michael Renner [Bug #10067]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46978 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r46977.
----------
* time.c: [DOC] Remove dead link and old bug report, which hasn't been
reproduced in a few years. Reported by Federico Builes [Bug #10071] -
- reproduced in a few years. Reported by Federico Builes [Bug #10071]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46977 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- they may change in the implementation without notice. Patched by
@robin850 [Fixes GH-682] https://github.com/ruby/ruby/pull/682
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46976 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:37 PM Revision 3a4ac27f (git): * 2014-07-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46975 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Patched by @vipulnsward https://github.com/ruby/ruby/pull/665
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46974 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- As far as I tried, using `when` can't parse well.
-
04:12 PM Feature #6739: One-line rescue statement should support specifying an exception class
- ~~~ruby
do_something rescue SomeError with puts "SomeError occured"
~~~ -
01:39 PM Bug #10054: Net::HTTPGenericRequest sets host even if it was set before by user
- Yui NARUSE wrote:
> Why don't you use http_proxy?
I need this only for some requests (imagine database that stores URLs, headers and request bodies) so adding http_proxy makes code more difficult. -
11:04 AM Revision 448c8700 (git): * lib/cgi/core.rb: remove unused variables.
- * lib/erb.rb: ditto.
* lib/mkmf.rb: ditto.
* lib/net/http/response.rb: ditto.
* lib/optparse/version.rb: ditto.
* lib/prime.rb: ditto.
* lib/racc/parser.rb: ditto.
* lib/rexml/document.rb: ditto.
* lib/rexml/dtd/dtd.rb: ditto.
* lib/rexm... -
10:49 AM Bug #10093: SecureRandom.uuid is not valid v4 and/or RFC 4122
- Valid UUID should match `/[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}/i`
-
- Ya, it seems that all wrong UUID are ended with 'g', here is another one:
0e6cf5ef-0afd-4854-8130-ac6144ddd70g
-
- Nobuyoshi Nakada wrote:
> Is this correct?
> ...
Thanks a lot for this very quick work!
Unfortunately, it's not correct. I haven't checked everything, but at least cp1252_get_case_fold_codes_by_str doesn't deal with the special case... -
- Is this correct?
https://github.com/nobu/ruby/compare/windows-1252 -
- * symbol.c (register_symid_direct, unregister_sym): extract to
wrap global_symbols tables.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46972 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * symbol.c (lookup_str_id, lookup_str_sym, lookup_id_str): return
the result ID, Symbol, and string directly instead of returning
via a pointer.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46971 b2dd03c8-39d4-4d8f-98ff-823fe69...
07/26/2014
-
- Which revision did you try?
-
06:04 PM Feature #8546: super errors in UnboundMethods
- Nobuyoshi Nakada wrote:
> Fixed in 2.1.
I tried the above sample code in 2.1.2 and the error has changed from a TypeError to a NoMethodError: "NoMethodError: super: no superclass method `hello' for #<O:0x007fb799046c50>"
Is th... -
- Fixes documenting-ruby/ruby#37
https://github.com/documenting-ruby/ruby/pull/37
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46970 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I found that Ocaml has a function "revapply".
```ocaml
revapply x f (* it means f(x) *)
```
How about "rap" (shorter name of revapply)?
Similar to "tap" :)
(bike shed)
-
09:37 AM Feature #10095: Object#as
- Here's some of the candidates I thought up in today's dev meeting:
- `into`
- `turn`
- `map1`
- `apply`
-
- I would like to propose the name `chain`.
```ruby
[1, 2, 3, 4].select(&:odd?).chain{|x| {total: x.count, data: x}}
```
As I looked in the related threads, it looks like there is a consensus that what this method would do is metho... -
06:53 AM Feature #10095 (Closed): Object#as
- We've had so many times of feature requests for a method similar to `Object#tap` that doesn't return self but returns the given block's execution result (e.g. #7388, #6684, #6721 ).
I'm talking about something like this in Ruby of cou... -
- * lib/shell/system-command.rb: ditto.
* lib/tmpdir.rb: ditto.
* lib/uri/generic.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Could you show the site to reproduce on my Mavericks?
-
- 05:12 PM Revision 9b932528 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46968 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * sample/weakref.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * sample/delegate.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46966 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- Why `size` in bytes and `length` in chars, not vice versa?
-
03:54 PM Feature #9650: String#size versus String#length - -1, #size is good enough.
-
- Thanks, I'll see if I can clean up any misunderstandings here
-
- I will try to improve the explanation
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46965 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:33 PM Feature #6452: Allow extend to override class methods
- Rodrigo Rosenfeld Rosas wrote:
> Would Module.preextend be a good name for that? It would indicate it's similar to prepend but applied to extend...
Does this do what you want to do?
class Object
def preextend m
singleton_c... -
-
- knu: do you have any thoughts on this one?
- 04:22 PM Feature #6739: One-line rescue statement should support specifying an exception class
- How about introducing shorter "resc" keyword for error-specific inline rescue?
~~~ruby
do_messy_job resc TypeError: 42, NameError: 43
~~~
Tbh, inline `rescue` always leaves me with a feeling that I'm doing something underhanded. ... -
- Applied in changeset r46964.
----------
proc.c: method_super_method
* proc.c (method_super_method): new method Method#super_method,
which returns a method object of the method to be called by
`super` in the receiver method object.
... -
08:24 AM Feature #9781 (Open): Feature Proposal: Method#super_method
-
- OK, accepted.
The name should be 'super_method', since 'super' make me feel invocation of a mehtod in super class.
The 'super_method' should return nil when there's no method in superclasses.
Matz.
-
- * proc.c (method_super_method): new method Method#super_method,
which returns a method object of the method to be called by
`super` in the receiver method object.
[ruby-core:62202] [Feature #9781]
git-svn-id: svn+ssh://ci.ruby-lan... - 04:13 PM Revision 042a162a (git): * 2014-07-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46963 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * eval_error.c (rb_print_undef, rb_print_undef_str): quote unprintable
names.
* eval_error.c (rb_print_inaccessible): ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46962 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * eval_error.c (rb_print_inaccessible): exract from mnew_from_me()
in proc.c
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46961 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Why don't you use http_proxy?
- 03:28 PM Feature #9620: Rename "curry" to "schönfinkelize"
- Uh oh, that Pegasus computer looks so beautiful, http://upload.wikimedia.org/wikipedia/commons/e/ee/Pegasus_computer.jpg
- 03:22 PM Feature #9620: Rename "curry" to "schönfinkelize"
- Who in the Heaven is Christopher Strachey?
-
- Rodrigo Rosenfeld Rosas wrote:
> Great, from the test it seems to allow interpolation. Could you please confirm I understood it correctly?
Yes, it is allowed inside double quotes, but not single quotes.
Other terminators (e.g., `%(.... -
- I am not against the idea, but I want to make sure that key will be symbol, since some may expect
```ruby
{"foo bar": 12}
```
to be a hash with string key, especially who is familiar with JSON.
Matz.
-
- * compile.c (compile_data_alloc): check allocation size and
integer overflow.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46960 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- By chance I had a look at enc/iso_8859_1.c and found
~~~C
ENC_REPLICATE("Windows-1252", "ISO-8859-1")
~~~
on line 288. But this does not work for case folding:
~~~ruby
# http://en.wikipedia.org/wiki/Windows-1252
s1 = "\u0160".... -
- I want default case conversion should be Unicode aware (when encoding is Unicode).
The previous behavior can be done by `str.downcase(:ascii)`.
Non unicode encoding (e.g. Latin-1) can support non ASCII case conversion, but not mandat... -
08:28 AM Revision 39fd13bc (git): * ext/objspace/objspace_dump.c (dump_append): avoid fflush.
- because dump_append_string_value() iterates over each chars,
fflush()-ing here effectively issues system calls on every single
bytes exist in a ruby process.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46959 b... -
- I got Matz's approval.
- 07:57 AM Revision 36b476cd (git): struct iseq_compile_data_storage: 16 bytes (from 32) overhead
- This reduces the iseq_compile_data_storage header from 32 to 16
bytes on 64-bit systems.
pos and size fields cannot exceed 32-bit sizes due to stack size
limits. Using a flexible array for the buffer also saves us 8
bytes of pointer ov... -
07:52 AM Feature #10096 (Rejected): [PATCH] use khash for fstring and id_str tables
- frozen_strings and global_symbols.id_str hashes are two of the bigger
hashes in Ruby. They are needlessly ordered and incurs malloc overhead
in every st_table_entry.
Use an unordered open-addressing table which incurs no additional... - 07:30 AM Revision a9c7629e (git): rb_iseq_t: reduce to (280 bytes from 288 bytes) on 64-bit
- iseq_size and line_info_size may be 32-bit.
4GB instruction sequences should be big enough for anyone.
Other existing line info counters are 32-bit, and nobody
should need all that.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@469... -
r46952
-
- Moved to #10095
-
- We've had numbers of feature requests for a method similar to Object#tap that doesn't return self but returns the given block's execution result (e.g. #7388, #6684, #6721 ).
I'm talking about something like this in Ruby of course:
Ob... -
- First of all, I don't think `normalize` is the best name.
I propose `unicode_normalize` instead, since this normalization is sort of unicode specific.
We still need to define the detail.
It should raise an exception for non Unicod... -
- * ext/rbconfig/sizeof/depend: remove garbage dollar mark.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46956 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- FYI here's an already existing implementation by Seki-san: https://gist.github.com/seki/6449467
Gemified version is here: https://github.com/takkanm/erb_with_hash -
- I like the idea, but I have one concern.
The binding also has information about the receiver (which defaults to top-level self).
I am not sure whether it's critical or not.
I hope Seki will address this.
Matz.
-
- I think it is easy to implement, but not clear what is "self" on ERB evaluation context.
If you provide binding, self will be binding's self.
-
- 'g' at the end?
-
04:56 AM Bug #10093: SecureRandom.uuid is not valid v4 and/or RFC 4122
- Why is it not a valid UUID?
-
- SecureRandom.uuid sometimes generates some value like this:
e7be09bb-e939-43db-9c20-dfad9c27fd3g
And it's not a valid UUID. This problem occurred randomly for me, I don't know how to reproduce :( -
- Thank you for your report.
I'll check it (best effort. I ask my boss about priority).
-
- I am not sure about the motivation behind this proposal.
Are the following all reasons you have:
* Reduce module .. end lines
* Reduce indentations
If so, the change is too big for small gain.
I am not (yet) against the packag... -
- Suffix `i` is used for complex (imaginary) numbers. It's bit confusing.
Maybe what you want can be gained by shorter/nicer name for Hash#compare_by_identity.
Matz.
-
- Note that we alrady have Hash#compare_by_identity.
Matz.
-
- Hi,
I have to reject this issue, since this will introduce a huge incompatibility. Even I don't have right to break thousands of programs that use both symbols and strings in keys.
Another idea is introducing mode to make a hash i... -
- * ext/rbconfig/sizeof/depend: revert r46924, VPATH prefix, to fix
build error on old FreeBSD. NMAKE must die.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46955 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
07/25/2014
-
10:13 PM Feature #10042: Deprecate postfix rescue syntax for removal in 3.0
- On 26/07/2014, naruse@airemix.jp <naruse@airemix.jp> wrote:
> Issue #10042 has been updated by Yui NARUSE.
>
>
> I sometimes use postfix rescue, and often want a new syntax to specify
> exceptions to rescue.
>
This was a featur... -
- I sometimes use postfix rescue, and often want a new syntax to specify exceptions to rescue.
- 09:47 PM Revision 6358bae3 (git): struct parse_params: trivial packing
- * parse.y (struct parse_params): shrink to 320 to 304 bytes on 64-bit
Some elements may be removed/resized as well, but not as important
as reducing more-frequently allocated structures.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... - 09:36 PM Revision 36c1e06c (git): ChangeLog: add references [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:34 PM Revision 48a2b96d (git): introduce ZALLOC{,_N} to replace ALLOC{,_N}+MEMZERO use
- Using calloc where possible reduces code and binary sizes.
* include/ruby/ruby.h (ZALLOC, ZALLOC_N): implement
(Data_Make_Struct, TypedData_Make_Struct):
ZALLOC replaces ALLOC+memset
* compile.c (iseq_seq_sequence): ZALLOC_N replace... - 08:57 PM Revision 5c094d38 (git): * 2014-07-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:57 PM Revision 098c9a32 (git): symbol.c (dsymbol_check): remove unneeded semi-colon
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46950 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Thomas Enebo wrote:
> ko1, when you say native tools, do you mean things like valgrind? Can you elaborate a bit (curious since I am doing some stuff with Java Heap dumps atm)?
I wrote a tool to detect which memory part is shared w... -
06:30 PM Feature #10038: Extend ObjectSpace.dump to expose buffer addresses for String and Array
- Oh! I should also note I know dump_all is marked as experimental and implementation-specific in the documents so I am not saying you are not trying to mark things. I am just hoping we all can agree on a standard for this.
Also, I am ... -
- ko1, when you say native tools, do you mean things like valgrind? Can you elaborate a bit (curious since I am doing some stuff with Java Heap dumps atm)?
I am neutral on this because it feels like an extension to help with your imp... -
-
-
- Try recent versions.
-
04:42 AM Bug #10091 (Closed): ruby-1.9.3-p0 Error
- Hi,
I am Arun. I have installed ruby-1.9.3-p0. I'm getting below error. How can I solve this problem?
```
-- Control frame information -----------------------------------------------
c:0007 p:---- s:0019 b:0019 l:000018 d:000018 ... -
- Great, from the test it seems to allow interpolation. Could you please confirm I understood it correctly?
-
- Updated with the test in [Feature #4935]: https://github.com/ruby/ruby/pull/684
-
- You should compare `singleton_methods(false)`.
-
10:55 AM Bug #10092 (Rejected): singleton_method behaves inconsistent with singleton_methods on modules, extending self
- Let’s consider the following code:
~~~ruby
module M
extend self
def m_i
puts "m_i"
end
def m
puts "include? = [#{singleton_methods.include?(:m_i)}]"
puts "call = [#{singleton_method(:m_i).call}]" rescue p... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46949 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:59 AM Feature #5478: Add syntax to import Set into core
- It has not been mentioned in this thread yet that in Python it is done like this:
```python
empty_set = set() # => set([])
some_set = {1, 1, 2, 2, 3, 4} # => set([1, 2, 3, 4])
```
Python [has no literal for the e... -
- ふとパッチを見たのですが、これって rdoc で生成されるドキュメントはどうなるのでしょうか。
-
- "UTF-8" is invalid encoding name in Emacs, use "utf-8" instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46948 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/rubygems/util.rb (Gem.silent_system): use keyword options to
redirect outputs instead of reopening global IOs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46947 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/rubygems/specification.rb (build_extensions): close
redirection FDs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46946 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/rubygems/util.rb (silent_system): close duplicated IOs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46945 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/rubygems/remote_fetcher.rb (request): close connections.
* lib/rubygems/request.rb (close): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/rubygems/test_gem_remote_fetcher.rb (start_server):
shutdown remote servers.
* test/rubygems/test_gem_remote_fetcher.rb (start_ssl_server):
ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46943 b2dd03c8-39d4-4d8f-98... -
- * lib/rubygems/user_interaction.rb (Gem::StreamUI#close): clean up
IOs.
* test/rubygems/test_gem_silent_ui.rb (TestGemSilentUI#teardown):
fix leaked FDs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46942 b2dd03c8-39d4-4d8f-98... -
- * test/lib/leakchecker.rb (LeakChecker#find_threads): temporary
measure for unrestartable WEBrick::Utils::TimeoutHandler::Thread.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46941 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/test/unit.rb (deal): temporary measure for mixing
output from the tests of minitest in parallel test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46940 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- to objspace::rgengc::parent_object (VALUE).
Use Qfalse or RVALUE pointer instead of FALSE and TRUE.
* gc.c (gc_marks_body): should clear parent_object just before
gc_mark_roots() because there are no parents objects
for root object... -
- OLD objects on RGENGC_AGE2_PROMOTION.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46938 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46937 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:19 AM Revision c3cbfa41 (git): ChangeLog: reference GitHub pull request
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46936 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:17 AM Revision 73ac899b (git): * ext/socket/socket.c (sock_gethostname): Use NI_MAXHOST to support
- hostnames longer than 64 characters if the system supports it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46935 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (defined_expr): make the condition if the receiver
is explicit or implicit cleaner. [fix GH-681]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46934 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:21 AM Bug #10027: make at windows , err : _rb_file_expand_path_internal already defined in file. obj
- Nobuyoshi Nakada wrote:
> It's a different story.
> ...
I think ruby can use the way like golang ,
just run src/all.bat , then everything is ok .