Activity
From 07/18/2014 to 07/24/2014
07/24/2014
-
08:42 PM Feature #10017: Add `Hash#fetch_values`
- Andrew Vit wrote:
> Please consider the name `fetch_at` carefully: it seems easily confused with `fetch` (1 key), and the name doesn't hint that it's for multiple keys. (`values_at` is plural, so it gives a good clue.) Maybe `fetch_valu... -
06:54 PM Revision e7ce17cf (git): * doc/keywords.rdoc: [DOC] Describe each keyword.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46933 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:17 PM Feature #10090: Display of program name in process listing under AIX
- I'm using the config.h created by executing the unmodified configure script from the source tarball.
~~~
./configure --disable-install-rdoc
~~~
Here's the definition from the resulting config.h:
~~~
#define SPT_TYPE SPT_REUSE... -
03:36 PM Feature #10090 (Feedback): Display of program name in process listing under AIX
- On AIX, `SPT_REUSEARGV` should be used, as same as linux.
How is `SPT_TYPE` defined in your config.h file? -
01:54 PM Feature #10090 (Third Party's Issue): Display of program name in process listing under AIX
- On AIX, the process listing (displayed with the `ps` command) for a program using Ruby 2.1.2 (or Ruby 1.9.3) shows only the Ruby interpreter path.
However, on other platforms (Linux, OS X), the process listing (for the same Ruby progr... - 03:28 PM Revision 3d998c9a (git): * 2014-07-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46932 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:28 PM Revision be7c04e1 (git): parse.y: dynamic const assign_error in ripper
- * parse.y (mlhs_node): dynamic constant assignment in massign
should cause assign_error, like as single assign and backref
assignment in massign.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46931 b2dd03c8-39d4-4d8f-98ff-823fe6... -
03:28 PM Revision 418c46f2 (git): parse.y: move common code
- * parse.y (arg, primary): move common code shared with ripper.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46930 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:51 PM Revision 6d877a93 (git): * ext/win32ole/win32ole.c (Init_win32ole): add WIN32OLE_RECORD#initialize
- method.
* ext/win32ole/win32ole.c (ole_val2variant): convert WIN32OLE_RECORD
object to VT_RECORD variant.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46929 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:14 PM Bug #10089 (Closed): build failure since r46924
- Applied in changeset r46928.
----------
* ext/rbconfig/sizeof/depend (sizes.c): fix build failure since r46924.
[Bug #10089] [ruby-dev:48446] -
11:48 AM Bug #10089 (Closed): build failure since r46924
- r46924 以降、ビルドに失敗しています。
http://chkbuild002.hsbt.org/chkbuild/ruby-trunk/log/20140724T020014Z.fail.html.gz
Travis-CI のログ: http://travis-ci.org/ruby/ruby/builds/30708589
-
12:14 PM Revision 6af209e4 (git): * ext/rbconfig/sizeof/depend (sizes.c): fix build failure since r46924.
- [Bug #10089] [ruby-dev:48446]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46928 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:51 AM Bug #9898: Keyword argument oddities
- Backported into `ruby_2_1` at r46619.
-
11:45 AM Bug #9955 (Assigned): issue building dll on mingw, library not found
-
11:38 AM Bug #10036 (Closed): Time.parse raises NoMethodError: undefined method `<' for nil:NilClass when called with out of range arguments and a negative offset
- It seems fixed at r46872. https://github.com/ruby/ruby/pull/667
-
11:33 AM Feature #9952 (Assigned): Optimize object allocations in CSV::Row
-
11:13 AM Revision c90cd20c (git): * gc.c: fix major GC flags.
- * add GPR_FLAG_MAJOR_BY_FORCE, which indicates
major GC by METHOD, CAPI and so on (see GC_BY).
* remove GPR_FLAG_MAJOR_BY_RESCAN because not used.
* remove GPR_FLAG_MAJOR_BY_STRESS, use FORCE instead.
* test/ruby/test_gc.rb: catc... -
08:22 AM Revision 4cd04711 (git): parse.y: remove garbage
- * parse.y (assoc): remove garbage semicolon added by r35489.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46926 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:13 AM Bug #10088: Bus Error on Sparc Solaris since r46884
- Thank you for the catch and explanation!
I mistakenly believed it was safe with 32-bit types :x -
07:04 AM Bug #10088 (Closed): Bus Error on Sparc Solaris since r46884
- Applied in changeset r46925.
----------
* include/ruby/io.h (struct rb_io_buffer_t): PACKED_STRUCT should not
be used for platform-specific optimization. PACKED_STRUCT_UNALIGNED
should be used. [ruby-core:63988] [Bug #10088] -
06:58 AM Bug #10088 (Closed): Bus Error on Sparc Solaris since r46884
- Since r46884, bus error occurred on Sparc64.
PACKED_STRUCT_UNALIGNED generally should always be used, and PACKED_STRUCT generally should never be used unless it is really needed.
I think existence of both PACKED_STRUCT and PACKED_S... -
07:03 AM Revision 834eb1a8 (git): * include/ruby/io.h (struct rb_io_buffer_t): PACKED_STRUCT should not
- be used for platform-specific optimization. PACKED_STRUCT_UNALIGNED
should be used. [ruby-core:63988] [Bug #10088]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46925 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:58 AM Feature #10084: Add Unicode String Normalization to String class
- Nobuyoshi Nakada wrote:
> What will happen for a non-unicode string, raising an exception?
This is a very good question. I'm okay with whatever Matz and the community think is best.
There are many potential approaches. In general,... -
12:59 AM Revision 92705750 (git): rbconfig/sizeof: VPATH prefix
- * ext/rbconfig/sizeof/depend (sizes.c): prefix with nmake-style
VPATH to use the distributed source in out-of-place builds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46924 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/23/2014
- 07:45 PM Revision 09821335 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46923 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:45 PM Revision 8fded5ba (git): * lib/benchmark.rb: split executable code into sample directory.
- * sample/benchmark.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46922 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:44 PM Revision 7d8175a2 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46921 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:44 PM Revision a7f672a1 (git): * lib/tempfile.rb: split executable code into sample directory.
- * sample/tempfile.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46920 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:31 PM Revision 31f2d1d7 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46919 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:31 PM Revision d2864212 (git): * 2014-07-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46918 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:31 PM Revision e32e0a2d (git): * lib/pstore.rb: split executable code into sample directory.
- * sample/pstore.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46917 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:20 PM Feature #10042: Deprecate postfix rescue syntax for removal in 3.0
- Hi, I'm against it :-)
Nobody is forced to use it, and for short scripts it can be quite useful.
For example to fetch some websites, if they exist:
```ruby
require 'open-uri'
urls = …
urls.each do |url|
open(url) do
#save... -
05:22 PM Feature #9997: Specifying non volatile registers for increase performence in ppc64
- ping... anyone to review this patch?
-
05:16 PM Feature #10087 (Closed): [PATCH] Specifying "target_cpu" for structure packing in ppc64
- r46915
-
05:11 PM Feature #10087 (Closed): [PATCH] Specifying "target_cpu" for structure packing in ppc64
- This change adds new "target_cpu" for structure packing in ppc64.
~~~
- [x86*|i?86|x64], [packed_struct_unaligned='PACKED_STRUCT(x)'])
+ [x86*|i?86|x64|powerpc64*|ppc64*], [packed_struct_unaligned='PACKED_STRUCT(x)'])
~~~
Note: ... -
02:53 PM Bug #9767: test-all parallel fails if a test is skipped after raise
- Backported into `ruby_2_1` branch at r46916.
-
02:53 PM Revision 3eb0620c (git): merge revision(s) r45953,r45961: [Backport #9767]
- * lib/test/unit/parallel.rb: fix test-all parallel failure if a test
is skipped after raise.
DL::TestFunc#test_sinf is skipped after raise on mingw ruby.
But it causes Mashal.load failure due to undefined cl... -
02:50 PM Feature #10081 (Closed): [PATCH] Specifying MACRO for increase performence in ppc64
- Applied in changeset r46915.
----------
UNALIGNED_WORD_ACCESS on ppc64
* include/ruby/defines.h, siphash.c, st.c (UNALIGNED_WORD_ACCESS):
add PowerPC64 too, which is capable to access unaligned words.
patched by Gustavo Frederico T... -
12:52 PM Feature #10081: [PATCH] Specifying MACRO for increase performence in ppc64
- Thank you.
Possibly, can `PACKED_STRUCT_UNALIGNED` also work on PowerPC64? -
11:28 AM Feature #10081: [PATCH] Specifying MACRO for increase performence in ppc64
- Nobuyoshi Nakada wrote:
> PowerPC64 can unaligned access?
Yes, I have tested in my IBM POWER 7+ (rev 2.1) -
01:36 AM Feature #10081: [PATCH] Specifying MACRO for increase performence in ppc64
- PowerPC64 can unaligned access?
-
02:50 PM Revision 63360be4 (git): UNALIGNED_WORD_ACCESS on ppc64
- * include/ruby/defines.h, siphash.c, st.c (UNALIGNED_WORD_ACCESS):
add PowerPC64 too, which is capable to access unaligned words.
patched by Gustavo Frederico Temple Pedrosa in [ruby-core:63937].
[Feature #10081]
* regint.h (PLATFO... -
02:50 PM Revision 6528ad09 (git): defines.h: PACKED_STRUCT_UNALIGNED
- * include/ruby/defines.h (PACKED_STRUCT_UNALIGNED): move from
configure.in for universal binary.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46914 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:50 PM Revision 3f21aa5d (git): configure.in: missing comma
- * configure.in (posix_fadvise): fix missing comma separating
blocks. [ruby-core:62968] [Bug #9914]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46913 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:49 PM Revision fa2937a1 (git): merge revision(s) r45034,r45037:
- * test/socket/test_addrinfo.rb: remove unused variables.
* test/socket/test_nonblock.rb: ditto.
* test/socket/test_socket.rb: ditto.
* test/socket/test_unix.rb: ditto.
* test/testunit/test_parallel.rb:... -
02:45 PM Bug #10045: SegFault in BigDecimal in 2.1.2p95
- I've been unable to replicate the segfault on demand.
Because I've been unable to create the segfault on demand I am unwilling to remove the BigDecimal-1.2.5 gem - we started using it specifically to avoid another segfault a few month... -
02:06 PM Bug #9618: Pathname#cleanpath creates mixed path separators
- Backported into `ruby_2_1` branch at r46911.
-
02:05 PM Revision 5807ff68 (git): merge revision(s) r45827: [Backport #9618]
- * ext/pathname/lib/pathname.rb (cleanpath_aggressive): make all
separators File::SEPARATOR from File::ALT_SEPARATOR.
Reported by Daniel Rikowski.
Fixed by Nobuyoshi Nakada. [Bug #9618]
* ext/pathna... -
02:04 PM Bug #9571: "Error: TestFileUtils#test_rmdir: Errno::EEXIST: File exists @ dir_s_rmdir - data" on Solaris
- Backported into `ruby_2_1` branch at r46910.
-
02:03 PM Revision b22467da (git): merge revision(s) r45720: [Backport #9571]
- * lib/fileutils.rb (rmdir): rescue Errno::EEXIST in addition to
ENOTEMPTY (and ENOENT), because SUSv3 describes that "If the
directory is not an empty directory, rmdir() shall fail and set
errno to [EEXIST] ... -
01:44 PM Bug #9544: Ruby resolver not using autoport
- Backported into `ruby_2_1` branch at r46909.
-
01:44 PM Revision 61754d1a (git): merge revision(s) r45144: [Backport #9544]
- * lib/resolv.rb (bind_random_port): Rescue EPERM for FreeBSD which
security.mac.portacl.port_high is changed.
See mac_portacl(4) for details.
Reported by Jakub Szafranski. [ruby-core:60917] [Bug #9544]
gi... -
01:44 PM Feature #10084: Add Unicode String Normalization to String class
- What will happen for a non-unicode string, raising an exception?
-
10:04 AM Feature #10084 (Closed): Add Unicode String Normalization to String class
- Unicode string normalization is a frequent operation when comparing or normalizing strings.
This should be available directly on the String class.
The proposed syntax is:
'string'.normalize # normalize 'string' accordin... -
01:29 PM Revision a5b229be (git): merge revision(s) r46899,r46903,r46904:
- split assertions into algorithms
CentOS 7 seems finish MD5 support
http://chkbuild005.hsbt.org/chkbuild/ruby-trunk/log/20140722T140010Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@46908 b2... -
12:45 PM Feature #10082: [PATCH] add ZALLOC* macros to reduce ALLOC + MEMZERO calls
- Tadashi Saito wrote:
> (My only concern is that zlib uses "zalloc" as its API, but we will
> ...
How about `0ALLOC()`? ;) -
10:58 AM Feature #10082: [PATCH] add ZALLOC* macros to reduce ALLOC + MEMZERO calls
- > I considered ZALLOC_N == CALLOC, but the arguments are reversed
> ...
I agree with your concern. ZALLOC may be better.
(My only concern is that zlib uses "zalloc" as its API, but we will
not have to worry about it:
https://githu... -
07:22 AM Feature #10082: [PATCH] add ZALLOC* macros to reduce ALLOC + MEMZERO calls
- tad.a.digger@gmail.com wrote:
> The basic policy of patch feels great, but why don't you name CALLOC?
>
> I feel CALLOC is more straitforward because calloc(3) is in the standard and
> ZALLOC(_N) already uses calloc().
I conside... -
06:32 AM Feature #10082: [PATCH] add ZALLOC* macros to reduce ALLOC + MEMZERO calls
- The basic policy of patch feels great, but why don't you name CALLOC?
I feel CALLOC is more straitforward because calloc(3) is in the standard and
ZALLOC(_N) already uses calloc(). -
06:00 AM Feature #10082: [PATCH] add ZALLOC* macros to reduce ALLOC + MEMZERO calls
- LGTM.
Matz.
-
12:00 PM Bug #10086: [PATCH] Remove exponents calculation from mathn.rb
- There are my PATCHES.
PATCHです. -
11:57 AM Bug #10086 (Closed): [PATCH] Remove exponents calculation from mathn.rb
- #English
When we override `:**`, we make it alias as `:power!` (mathn.rb:L73, L102)
Like this.
```
alias power! ** unless method_defined? :power!
```
If user have define `:power!`, this `:power!` is called unintentionally.(... -
11:04 AM Feature #10085 (Closed): Add non-ASCII case conversion to String#upcase/downcase/swapcase/capitalize
- Case conversion functions are currently limited to ASCII characters. When used with formal languages, that may be appropriate, but it is often not appropriate for applications.
In order to avoid backwards-compatibility problems and to... -
07:20 AM Revision 2e8ce889 (git): time.c: unnecessary encoding
- * time.c (time_zone_name): remove unnecessary encoding and
conversion if it is 7bit-ascii only.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:20 AM Revision 87c8901d (git): test_time.rb: encoding of Time#zone
- * test/ruby/test_time.rb (assert_zone_encoding): encoding of
Time#zone is not locale, but the default internal.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46906 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:23 AM Revision 98a2dfe7 (git): minitest/unit.rb: flush messages
- * test/lib/minitest/unit.rb (MiniTest::Unit#_run_suite): flush
messages after each tests.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46905 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:38 AM Feature #10083 (Rejected): String.to_i unexpected behavior
- You can use `Integer("String")` instead.
-
02:15 AM Feature #10083 (Rejected): String.to_i unexpected behavior
- Hi
There's the issue:
~~~ruby
"String".to_i => 0
~~~
This must be NIL or at least error, but no 0, because the string is not a number, also:
~~~ruby
"10String".to_i => 10
~~~
Is not 10, because "10String" is not a ... -
05:37 AM Revision 981ab867 (git): test_x509req.rb: fix for RHEL7
- * test/openssl/test_x509req.rb (test_sign_and_verify_rsa_md5): fix
exception to be rescued.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:19 AM Bug #4527 (Closed): [PATCH] IO#close releases GVL if possible
- Eric Wong wrote:
> naruse@airemix.jp wrote:
> ...
Sure, thanks for explanation. -
02:33 AM Bug #4527: [PATCH] IO#close releases GVL if possible
- naruse@airemix.jp wrote:
> A patch proposed Eric in [ruby-core:35610] is not merged yet.
Won't apply after r43373 (which is way more important).
I don't think the current close(tmpfd) needs to release GVL in the
new code path it... -
02:18 AM Bug #4527: [PATCH] IO#close releases GVL if possible
- A patch proposed Eric in [ruby-core:35610] is not merged yet.
-
02:17 AM Bug #4527 (Assigned): [PATCH] IO#close releases GVL if possible
-
02:35 AM Revision 3b48a96c (git): RHEL7 disables MD5
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46903 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:25 AM Bug #10019: segmentation fault/buffer overrun in pack.c (encodes)
- I agree the argument should be short. I'm working on it, but it's definitely strange. If I take the buffer and allocate it off the heap it's fine. Maybe it's a build
issue with RubyInstaller? Anyway, I'll poke around with and get ba...
07/22/2014
-
10:48 PM Revision e08773bc (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46902 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:33 PM Bug #10080 (Rejected): Functions marked as "static inline" are not inlined by gcc
-
06:48 PM Bug #10080: Functions marked as "static inline" are not inlined by gcc
- Eric Wong wrote:
> gustavo.pedrosa@eldorado.org.br wrote:
> ...
I don't have permissions to close, can you close for me, please?
Thank you very much, indeed. -
06:30 PM Bug #10080: Functions marked as "static inline" are not inlined by gcc
- gustavo.pedrosa@eldorado.org.br wrote:
> So, can I close this issue?
Sure. -
06:15 PM Bug #10080: Functions marked as "static inline" are not inlined by gcc
- Eric Wong wrote:
> I don't think removing "inline" is necessary, either. It is a hint
> ...
Yes, you are right.
So, can I close this issue? -
05:51 PM Bug #10080: Functions marked as "static inline" are not inlined by gcc
- I don't think removing "inline" is necessary, either. It is a hint
to the compiler (and as evidenced, your compiler is capable of
ignoring it). Different compilers may still inline it and produce
faster code. -
05:02 PM Bug #10080: Functions marked as "static inline" are not inlined by gcc
- (2014/07/23 1:31), gustavo.pedrosa@eldorado.org.br wrote:
> Do you think it would be interesting to remove
> the inline keyword in such cases?
Why remove them?
--
// SASADA Koichi at atdot dot net -
04:31 PM Bug #10080: Functions marked as "static inline" are not inlined by gcc
- Eric Wong wrote:
> Can you show a performance difference with always_inline on those
> ...
Sorry, yes, you are right. There is a small performance penalty when
every function marked as inline is, in fact, inlined. There are other
iss... -
10:31 PM Feature #10082 (Closed): [PATCH] add ZALLOC* macros to reduce ALLOC + MEMZERO calls
- This reduces code and binary sizes.
ZALLOC macros are accessible via public API for exts
OK to add this API? It should simplify some code and reduce typos.
-
07:06 PM Revision 86b38466 (git): * lib/drb/extserv.rb: remove duplicate code with sample direcotry.
- contributed from @vipulnsward. [fix GH-679]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46901 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:40 PM Feature #10081 (Closed): [PATCH] Specifying MACRO for increase performence in ppc64
- To increase performance on ppc64 machines, the MACRO "powerpc64" were specified for the architecture, just like for x86_64 machines.
I've executed some benchmarks, see below:
~~~
Benchmark Before (milliseconds) After... -
05:29 PM Feature #2567: Net::HTTP does not handle encoding correctly
- I've just hit this problem again.
I've read all comments and it seems like I see 3 different opinions:
1) Content type is unrealiable so clients of Net::HTTP should force the encoding to whatever they want whenever they want to use the... - 04:02 PM Revision acd7bd07 (git): * 2014-07-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46900 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:02 PM Revision 594eee85 (git): split assertions into algorithms
- CentOS 7 seems finish MD5 support
http://chkbuild005.hsbt.org/chkbuild/ruby-trunk/log/20140722T140010Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46899 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:29 AM Bug #9933: segmentation fault when running 'gem' (ruby 2.1.2p95)
- Hello, Gaurav. Thank you for your report.
It seems that a segmentation fault occurs in psych.
Could you try with trunk? I want to know it is an existing bug or already fixed in trunk.
Thanks. -
05:22 AM Revision 98b24010 (git): string.c: simplify
- * string.c (rb_str_count): move code for the first argument
outside loop for the rest, as it is executed only once.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46898 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:33 AM Revision d2d9257c (git): string.c: raise at invalid byte sequence
- * string.c (rb_str_count): raise at invalid byte sequence argument
even if single-byte optimization is effective.
[ruby-dev:48442] [Bug #10078]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46897 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
03:56 AM Bug #10078 (Closed): String#count() returns wrong count under specific conditions
- Applied in changeset r46896.
----------
string.c: fix wrong single-byte optimization
* string.c (rb_str_count): fix wrong single-byte optimization.
7bit ascii can be a trailing byte in Shift_JIS.
[ruby-dev:48442] [Bug #10078] -
03:56 AM Revision 1a95e46c (git): string.c: fix wrong single-byte optimization
- * string.c (rb_str_count): fix wrong single-byte optimization.
7bit ascii can be a trailing byte in Shift_JIS.
[ruby-dev:48442] [Bug #10078]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46896 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/21/2014
-
11:53 PM Bug #10075: URI#join needs documentation of its behavior
- On Mon, Jul 21, 2014 at 10:40 AM, <jxf+ruby@jxf.me> wrote:
> Here's my thoughts on this: every other Ruby method I can think of named
> `#join` works by concatenating its arguments together with a separator
> (possibly with some ad... -
02:40 PM Bug #10075: URI#join needs documentation of its behavior
- Eric Hodel wrote:
> I have changed this to a doc bug, the behavior does not surprise me, I expect it to behave as it does.
Here's my thoughts on this: every other Ruby method I can think of named `#join` works by concatenating its ar... -
05:02 PM Bug #10080: Functions marked as "static inline" are not inlined by gcc
- Can you show a performance difference with always_inline on those
functions?
Inlining is not always faster, it bloats the code and eats cache.
Perhaps GCC is avoiding that bloat. -
04:50 PM Bug #10080 (Rejected): Functions marked as "static inline" are not inlined by gcc
- Since GCC 4.8.3, some static inline functions (such as rb_call0) are not
inlined in the generated machine code. This happens in both x86-64 and ppc64
platforms and it can be verified by using the following commands:
~~~
(in ppc64)
... -
04:56 PM Bug #10079 (Closed): Warnings in definition of macro 'PACKED_STRUCT' - Applied in changeset r46894.
----------
rb_io_buffer_t: fix packing on gcc
* include/ruby/io.h (rb_io_buffer_t): fix packing on gcc
r46892 caused packing to be a no-op on gcc (4.7.2-5, Debian)
[Bug #10079][ruby-core:63912] -
04:19 PM Bug #10079 (Closed): Warnings in definition of macro 'PACKED_STRUCT'
- After the commit db433dc39d07449184a908d417919e3de8b70405, the building shows many warnings like below:
~~~
compiling pty.c
In file included from pty.c:1:0:
../.././include/ruby/io.h:54:30: warning: 'packed' attribute ignored [-Wat... - 04:56 PM Revision 30f008a8 (git): * 2014-07-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46895 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:56 PM Revision 8cb5f8be (git): rb_io_buffer_t: fix packing on gcc
- * include/ruby/io.h (rb_io_buffer_t): fix packing on gcc
r46892 caused packing to be a no-op on gcc (4.7.2-5, Debian)
[Bug #10079][ruby-core:63912]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46894 b2dd03c8-39d4-4d8f-98ff-823f... -
04:10 PM Bug #10078 (Closed): String#count() returns wrong count under specific conditions
- 以下の条件の場合、String#countが誤った文字数を返します。
* 文字コードがWindows-31J (文字コード体系が違うせいか、UTF_8, ISO2022_JP, EUC_JPでは再現せず)
* countの引数が1バイト文字一つのみ
* Stringにcountに指定された文字と一致する文字コードが含まれる。
異常な例: 和は0x9861, aは0x61
~~~
>ruby -ve "puts 'a-和'.count('a')"
... -
01:23 PM Feature #8257: Exception#cause to carry originating exception along with new one
- (2014/07/21 1:50), headius@headius.com wrote:
> I agree with Benoit that the cause exception should be reflected in the error output, as on the JVM. What are the objections?
What happen on exception from deep backtrace, occurred by ... -
01:11 PM Feature #10038: Extend ObjectSpace.dump to expose buffer addresses for String and Array
- (2014/07/17 23:52), headius@headius.com wrote:
> I would still prefer an MRI-specific namespace for features only MRI can implement. JRuby and Rubinius have both been a good citizens, keeping our impl-specific APIs hidden. MRI should d... -
12:13 PM Revision 1fe71722 (git): Makefile.sub: no PACKED_STRUCT on old VC
- * win32/Makefile.sub (PACKED_STRUCT): __pragma extension is
available since VC9.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46893 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:36 AM Bug #10019: segmentation fault/buffer overrun in pack.c (encodes)
- Will Wood wrote:
> d:/ruby-2.1.2-i386-mingw32/lib/ruby/gems/2.1.0/gems/aws-sdk-1.48.1/lib/aws/core/signers/s3.rb:59:in `signature'
https://github.com/aws/aws-sdk-ruby/blob/e243394/lib/aws/core/signers/s3.rb#l59
~~~ruby
signatur... -
07:04 AM Revision db433dc3 (git): ruby/io.h: fix rb_io_buffer_t
- * include/ruby/io.h (rb_io_buffer_t): fix usage of PACKED_STRUCT().
it must surround the whole declaration on VC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46892 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:55 AM Revision 9d3890ab (git): optparse.rb: getopts message improvement
- * lib/optparse.rb (getopts): print default values and descriptions
in the help message. [fix GH-676]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46891 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:29 AM Revision fb8f66cf (git): test/rake: fix tests under test-all
- * test/rake/test_rake_application.rb (test_display_exception_details):
`RbConfig::CONFIG["prefix"]` can be the root directory, under
test-all.
* test/rake/test_rake_test_task.rb (test_run_code_rake_default_gem):
`-I` may be insert... -
03:42 AM Feature #10040: `%d` and `%t` shorthands for `Date.new(*args)` and `Time.new(*args)`
- `Time.[]` is better?
~~~ruby
class Class
alias [] new
end
Time[2014, 7, 20, 12, 42, 24]
~~~ -
02:55 AM Feature #10077 (Closed): [PATCH] Implement Matrix#row_merge and Matrix#column_merge
- Merge matrices horizontally and vertically.
It is useful and important when we handle linear equations, statistics and so on.
```
Matrix[[1, 2], [3, 4]].row_merge(Matrix[[5], [6]])
=> 1 2 5
3 4 6
Matrix[[1, 2], [3...
07/20/2014
-
11:36 PM Bug #10075: URI#join needs documentation of its behavior
- Eric Hodel wrote:
> I have changed this to a doc bug, the behavior does not surprise me, I expect it to behave as it does.
It surprised me. The operation it performs appears to be "resolve relative" [1], but, like OP, from the name a... -
10:24 PM Bug #10075: URI#join needs documentation of its behavior
- I have changed this to a doc bug, the behavior does not surprise me, I expect it to behave as it does.
-
10:54 PM Feature #10065: Make `gem env` command output valid YAML
- Eric Hodel wrote:
> I don't understand the value of loading the output of `gem env` as YAML when you can query the fields directly from RubyGems itself.
In "Ruby-only" or "Ruby-dominant" environments I agree that there is little valu... -
10:10 PM Feature #10065: Make `gem env` command output valid YAML
- I don't understand the value of loading the output of `gem env` as YAML when you can query the fields directly from RubyGems itself.
With the exception of subcommands of `gem env` such as `gem env path` and `gem env home` the output o... - 10:43 PM Revision 8591da82 (git): * 2014-07-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46889 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:42 PM Revision 195f56ab (git): * test/ruby/test_module.rb: Bump up timeout in
- test_prepend_visibility_inherited for slow or heavily-loaded
systems or slower-launching impls.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46888 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:20 PM Feature #8257: Exception#cause to carry originating exception along with new one
- I agree with Benoit that the cause exception should be reflected in the error output, as on the JVM. What are the objections?
I do *not* believe this should show up in #backtrace since I have no idea how it would be formatted. This al... -
07:29 PM Bug #9975 (Assigned): irb で Hash を 1.9 記法で記述したときに、キーがキーワードだと syntax error
-
07:28 PM Bug #10013 (Assigned): [CSV] Yielding all elements from a row
-
07:11 PM Feature #10068 (Assigned): [PATCH] Implement monadic operator for Vector
-
07:11 PM Feature #10069 (Assigned): [PATCH] Implement monadic operator for Matrix
-
07:11 PM Feature #10070 (Assigned): [PATCH] About comments, fix typo and add info.
- Deleted.
-
07:29 AM Feature #10070: [PATCH] About comments, fix typo and add info.
- Sorry... There isn't trashbox icon.
-
01:03 AM Feature #10070: [PATCH] About comments, fix typo and add info.
- There isn't a trashbox icon between the size and your name, after the link?
-
07:10 PM Feature #10072 (Assigned): [PATCH] Implement Vector.basis
-
07:09 PM Feature #10073 (Assigned): [PATCH] Implement Laplace expansion for matrix.
-
07:09 PM Feature #10074 (Assigned): [PATCH] generalize Vector#cross_product
-
06:55 PM Feature #10040: `%d` and `%t` shorthands for `Date.new(*args)` and `Time.new(*args)`
- It reads nicely, but these literals could only build Time constants without variables/interpolation, which are rarely needed (in my own experience).
I do use Time with constant values in test scenarios, but outside of that very rarel... -
01:10 AM Feature #10040: `%d` and `%t` shorthands for `Date.new(*args)` and `Time.new(*args)`
- Isn't `2014_07_18T10_20_30` better than it?
-
01:27 PM Bug #10062: Segfault involving Queue
- Hello fred, thank you for your reporting.
At first, could you try to reproduce it with 2.1-head and trunk?
-
01:01 PM Bug #10027: make at windows , err : _rb_file_expand_path_internal already defined in file. obj
- It's a different story.
You need to install those libraries by yourself on Windows. -
07:38 AM Bug #10027: make at windows , err : _rb_file_expand_path_internal already defined in file. obj
- but many libs not found at windows . For example: zlib , readline ...
-
07:25 AM Bug #10027: make at windows , err : _rb_file_expand_path_internal already defined in file. obj
- successed after install vs6sp6 :
```
ruby 2.1.2p95 (2014-05-08 revision 45877) [i386-mswin32]
```
thanks -
12:28 PM Revision 975dcbbc (git): vm_core.h: fix comment
- * vm_core.h (rb_proc_t): fix comment. safe_level is upto 3 now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46887 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:39 AM Bug #10049: RDoc bug for time format
- Jared Beck wrote:
> I don't see it at ruby-doc.org, either. Check out lib/time.rb:420 (https://github.com/ruby/ruby/blob/f75b676cc4f5411c4c1aa8cc9cb48d5dd665af6f/lib/time.rb#L420)
My bug report is about the documentation. It is abou... -
07:10 AM Bug #10049: RDoc bug for time format
>
> ...
I don't see it at ruby-doc.org, either. Check out lib/time.rb:420 (https://github.com/ruby/ruby/blob/f75b676cc4f5411c4c1aa8cc9cb48d5dd665af6f/lib/time.rb#L420)- 05:34 AM Revision 44c32c22 (git): rb_proc_t: reduce to 64 bytes from 72 on 64-bit
- * vm_core.h (rb_proc_t): reduce to 64 bytes from 72 on 64-bit
This allows rb_proc_t to fit inside a single cache line on x86-64
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46886 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:51 AM Revision 0a2c4b4c (git): rb_econv_t: reduce to 184 bytes from 200 on 64-bit
- * transcode.c (rb_econv_t): reduce to 184 bytes from 200 on 64-bit
This allows rb_econv_t to fit inside of three cache lines on x86-64.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46885 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:19 AM Feature #10050 (Closed): [PATCH 0/2] reduce rb_io_t to 192 bytes (from 216) on 64-bit - Applied in changeset r46883.
----------
rb_io_t: shrink from 216 to 200 bytes on 64-bit
* include/ruby/io.h (rb_io_t): shrink to 200 bytes from 216 on 64-bit
This puts us within 8 bytes of being three cache lines instead of
four li... - 04:19 AM Revision eeb05e8c (git): rb_io_buffer_t: pack structure
- * include/ruby/io.h (rb_io_buffer_t): pack structure
Reduces rb_io_t from 200 to 192 bytes, allowing rb_io_t to
occupy one less cache line.
[Feature #10050]
n.b. this leaves a 4-byte hole after the `cbuf' field which may
be used f... - 04:18 AM Revision 910d081d (git): rb_io_t: shrink from 216 to 200 bytes on 64-bit
- * include/ruby/io.h (rb_io_t): shrink to 200 bytes from 216 on 64-bit
This puts us within 8 bytes of being three cache lines instead of
four lines on x86-64. This breaks the ABI.
[Feature #10050]
git-svn-id: svn+ssh://ci.ruby-lan... -
04:18 AM Feature #10034 (Closed): [PATCH] (struct re_pattern_buffer): reduce by cache line - Applied in changeset r46881.
----------
re_pattern_buffer: shrink from 464 to 448 bytes on 64-bit
* include/ruby/oniguruma.h (struct re_pattern_buffer): shrink to 448
bytes from 464 bytes on 64-bit. This breaks the ABI.
[Feature #... - 04:18 AM Revision cc9e233e (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46882 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:18 AM Revision f36315a5 (git): re_pattern_buffer: shrink from 464 to 448 bytes on 64-bit
- * include/ruby/oniguruma.h (struct re_pattern_buffer): shrink to 448
bytes from 464 bytes on 64-bit. This breaks the ABI.
[Feature #10034]
Reducing struct re_pattern_buffer from 464 to 448 bytes allows it to fit
into neatly into se... -
02:56 AM Bug #9931: irb: Really weird behavior for x = "#{x\"}" (ex: irb(main:009:-4))
- PS: Check out the pitchfork book's (2009 edition) chapter on strings, especially the part about interpolation on p. 110. http://pragprog.com/book/ruby/programming-ruby
-
02:52 AM Bug #9931: irb: Really weird behavior for x = "#{x\"}" (ex: irb(main:009:-4))
- Interesting. Let's try to figure it out!
## The irb prompt
The prompt has two numbers. The first is obviously a line number, but what is the second number?
irb(main):001:0> "#{
irb(main):002:0> end
irb(main):003... -
12:13 AM Revision fcf08015 (git): thread.c: use RUBY_VM_CHECK_INTS
- * thread.c (rb_thread_schedule): use dedicated macro
RUBY_VM_CHECK_INTS().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46880 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/19/2014
-
11:50 PM Bug #10061 (Closed): Segmentation fault
-
08:25 PM Bug #10061: Segmentation fault - Nobuyoshi Nakada wrote:
> It's a machine stack overflow, and should be fixed already.
> ...
ruby 2.2.0dev (2014-07-20 trunk 46879) [x86_64-linux]
Segmentation fault is fixed.
~~~
bug.rb:3:in `puts': stack level too deep (SystemS... -
11:48 PM Bug #10019 (Feedback): segmentation fault/buffer overrun in pack.c (encodes)
- Will Wood wrote:
> After pulling the latest code, your fix still causes a seg fault. IMO you're still overrunning the buffer.
> ...
Can't you show the argument to `encode64`?
-
04:33 PM Bug #10019: segmentation fault/buffer overrun in pack.c (encodes)
- After pulling the latest code, your fix still causes a seg fault. IMO you're still overrunning the buffer.
~~~
d:/ruby-2.1.2-i386-mingw32/lib/ruby/2.1.0/base64.rb:38: [BUG] Segmentation fault
ruby 2.1.2p176 (2014-07-19 revision 4686... -
09:08 PM Feature #10069: [PATCH] Implement monadic operator for Matrix
- Yukihiro Matsumoto wrote:
> unary operator has nothing related to inject though.
It's kind of my mistake, sorry to confuse you.
I think it not seldom happens that we want do this(term monadic). And this is based on custom in math... -
11:16 AM Feature #10069: [PATCH] Implement monadic operator for Matrix
- As #10068, I like the idea, but unary operator has nothing related to inject though.
Matz.
-
02:08 AM Feature #10069 (Closed): [PATCH] Implement monadic operator for Matrix
- Before
```
m = Matrix[[1,2,3], [4,5,6]]
+ m
NoMethodError: undefined method `+@' for Matrix[[1, 2, 3], [4, 5, 6]]:Matrix
- m
NoMethodError: undefined method `-@' for Matrix[[1, 2, 3], [4, 5, 6]]:Matrix
```
After
```
... -
07:20 PM Feature #10058: [PATCH] Fix some coding styles
- Marc-Andre Lafortune wrote:
> Yes, ideally. If they can be discussed separately, they should be separate issues.
> ...
I see, I try this next time.
Thank you for your committing my patches. -
09:44 AM Feature #10058: [PATCH] Fix some coding styles
- gogo tanaka wrote:
> Sorry, I'm not familiar with how to use redmine. so you mean I need to make new 2 features?
Yes, ideally. If they can be discussed separately, they should be separate issues.
No need for this issue, it's alrea... -
08:01 AM Feature #10058: [PATCH] Fix some coding styles
- @ Mr. Marc-Andre Lafortune
> Even though it can be a pain, please split unrelated patches in different requests.
Sorry, I'm not familiar with how to use redmine. so you mean I need to make new 2 features?
(About unify_product_op... -
04:15 PM Feature #10070: [PATCH] About comments, fix typo and add info.
- oh.... I'm embarrassed now... thank you for teaching that!
How can I delete this patch from Feature?
gogo. -
03:50 PM Feature #10070: [PATCH] About comments, fix typo and add info.
- "iff" is "if and only if", not a typo.
-
07:11 AM Feature #10070 (Closed): [PATCH] About comments, fix typo and add info.
- When I read codes, I notice some mistakes about comments.
It have nothing to do with ruby's performance.
If you don't mind that or are busy, you can ignore my patches.
gogo. -
04:10 PM Revision 2f1ce283 (git): * ext/openssl/ossl.c: use encryptor instead of encrypter in doc.
- contributed from @vipulnsward. [fix GH-663]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46879 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:01 PM Feature #10072: [PATCH] Implement Vector.basis
- ```
We can build standard euclidean space easily with this method.
[Vector.basis(3, 0), Vector.basis(3, 1), Vector.basis(3, 2)]
=> [Vector[1, 0, 0], Vector[0, 1, 0], Vector[1, 0, 1]]
```
This patch is needed in https://bugs.... -
07:39 AM Feature #10072 (Closed): [PATCH] Implement Vector.basis
- Standard basis vectors are really important in linear algebra.
And we usually need this when we use matrix or vector. (base conversion, principal component analysis...
This is why I implemented.
But I recognize Ruby should be no... -
04:00 PM Revision eb95f194 (git): * ext/thread/thread.c: added nodoc attribute into
- 'ConditionVariable#marshal_dump' by @vipulnsward
[fix GH-672]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:39 PM Feature #10073: [PATCH] Implement Laplace expansion for matrix.
- ```
For all n * n matrix m, k <- {1, 2, ..., n}.
m.laplace_expansion(k-1, :row) == m.laplace_expansion(k-1, :column) == m.det
It is important when we think about values contains not Scalar, like that.
Matrix[[Vector[1, 0], ... -
07:41 AM Feature #10073 (Closed): [PATCH] Implement Laplace expansion for matrix.
- Laplace expansion has really important mathematical property.
We can handle many thing with this (determinant, cross product)
So I'm confident that this method is necessary.
But I recognize Ruby should be not for mathematician b... -
03:32 PM Bug #10039 (Closed): "a+" mode for File.open doesn’t work
- Applied in changeset r46876.
----------
io.c: fix rdoc of append mode
* io.c (rb_io_initialize): [DOC] fix rdoc of append mode. it does
not move the pointer at open. [ruby-core:63747] [Bug #10039] -
03:32 PM Bug #10039: "a+" mode for File.open doesn’t work
- Append mode doesn't move the pointer at open.
It moves it to the end at each `write(2)`.
-
05:06 AM Bug #10039: "a+" mode for File.open doesn’t work
- Writing with `a+` mode appears to work fine, but the `pos` cursor is not updated until the first IO operation.
echo -en "test1\ntest2\n" > test
irb
irb(main):001:0> f = File.open('test', 'a+')
=> #<File:test>
... - 03:32 PM Revision d177879f (git): * 2014-07-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46877 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:32 PM Revision c73c34e2 (git): io.c: fix rdoc of append mode
- * io.c (rb_io_initialize): [DOC] fix rdoc of append mode. it does
not move the pointer at open. [ruby-core:63747] [Bug #10039]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:22 PM Feature #10074: [PATCH] generalize Vector#cross_product
Before
```
Vector[1, 0, 0].cross_product Vector[0, 1, 0]
=> Vector[0, 0, 1]
Vector[1, 2].cross_product
=> ArgumentError: wrong number of arguments (0 for 1)
Vector[3, 5, 2, 1].cross_product(Vector[4, 3, 1, 8], Vector[2,...-
07:47 AM Feature #10074 (Closed): [PATCH] generalize Vector#cross_product
- Usually We use cross_product in only 3 dimensions.
Sometimes we want to handle cross_product in n-dimensions.
But I recognize Ruby should be not for mathematician but rubyist.
Ruby doesn't need too academic method.
So If you ... -
02:22 PM Bug #10049: RDoc bug for time format
- > However, the documentation for Time.strptime says, simply:
> ...
Actually, I cannot find such description. I searched in these docs:
* Ruby 1.9.3 Time (http://ruby-doc.org/stdlib-1.9.3/libdoc/date/rdoc/Time.html)
* Ruby 1.9.3 Date... -
08:26 AM Bug #10049: RDoc bug for time format
- Tsuyoshi Sawada wrote:
> > However, the documentation for Time.strptime says, simply:
> ...
No, it doesn't mean that there must be a third digit, it means that the century is always explicit, never implied. This includes absence. For e... -
08:13 AM Bug #10049: RDoc bug for time format
- > However, the documentation for Time.strptime says, simply:
> ...
I don't understand how you interpreted the phrase "with century". In order to express a year with century, there has to be the third digit (hundreds), which means there ... -
04:04 AM Bug #10049: RDoc bug for time format
- The cited line of documentation:
%Y - Year with century (can be negative, 4 digits at least)
was taken from `strftime` (time.c:4395). Therefore, the phrase "4 digits at least" refers to output.
However, the documentation fo... -
02:01 PM Bug #10076: 2nd thread can't get mutex even though 1st thread released it (race)
- Thread fairness issue?
Checking interrupts seems to help it, but not sure.
~~~diff
diff --git a/thread.c b/thread.c
index 682e05f..6f67df6 100644
--- a/thread.c
+++ b/thread.c
@@ -4528,11 +4528,15 @@ rb_mutex_synchronize(VALUE m... -
01:29 PM Bug #10076: 2nd thread can't get mutex even though 1st thread released it (race)
- Attaching source code with reproduced problem.
-
01:26 PM Bug #10076 (Closed): 2nd thread can't get mutex even though 1st thread released it (race)
- ~~~ruby
require 'thread'
m = Mutex.new
Thread.abort_on_exception = true
Thread.new {
loop {
m.synchronize {
puts 'got mutex in thread'
sleep 0.1
}
}
}
loop {
m.synchronize {
puts 'got mut... -
11:15 AM Feature #10068: [PATCH] Implement monadic operator for Vector
- I am not sure the term monadic is a proper one, but I like the idea.
Matz.
-
02:01 AM Feature #10068: [PATCH] Implement monadic operator for Vector
- I'm sorry my report looks ugly... I fix it. ↓
Before
```
v = Vector[1, 2, 3]
+ v
=> NoMethodError: undefined method `+@' for Vector[1, 2, 3]:Vector
- v
=> NoMethodError: undefined method `-@' for Vector[1, 2, 3]:Vector
`... -
01:57 AM Feature #10068 (Closed): [PATCH] Implement monadic operator for Vector
Before
```
v = Vector[1, 2, 3]
+ v
=> NoMethodError: undefined method `+@' for Vector[1, 2, 3]:Vector
- v
=> NoMethodError: undefined method `-@' for Vector[1, 2, 3]:Vector
```
After
```
v = Vector[1, 2, 3]
+ v
...-
11:11 AM Feature #10064 (Feedback): &:symbol in when clause
- The original idea includes dispatch based on type (Symbol), which is not a good idea in general.
The one proposed by ko1 is slightly better, yet I still don't love it.
Matz.
-
02:41 AM Feature #10064: &:symbol in when clause
- just idea.
```ruby
class Symbol
def ~@
self.to_proc
end
end
case 0
when ~:zero?
p :zero
end
```
-
10:14 AM Bug #10067: File.file? misleading semantics & documentation for symbolic links
- Nobuyoshi Nakada wrote:
> Citing from [POSIX manpage test(1)](http://www.unix.com/man-page/POSIX/1/test/)
> ...
Oh my, just double-checked, Python and Perl have implemented the same behaviour as test(1), along with Ruby.
The big d... -
04:45 AM Bug #10067: File.file? misleading semantics & documentation for symbolic links
- Citing from [POSIX manpage test(1)](http://www.unix.com/man-page/POSIX/1/test/)
> With the exception of the `-h pathname` and `-L pathname` primaries,
> ...
-
04:23 AM Bug #10067: File.file? misleading semantics & documentation for symbolic links
- I can confirm that `test -f` and `File.file?` seem to have the same return values in this example:
ln -s link file
ruby -e 'puts File.file?("link")'
false
test -f link; echo $?
1
touch file
ruby -e 'p... -
08:07 AM Revision f5a43f4a (git): compile.c: FCALL flag on AREF
- * compile.c (iseq_compile_each): set FCALL flag on AREF call at
private aref op_assign. [ruby-core:63817] [Bug #10060]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:01 AM Bug #10075 (Closed): URI#join needs documentation of its behavior
- The [documentation](http://www.ruby-doc.org/stdlib-2.1.2/libdoc/uri/rdoc/URI.html#method-c-join) for `URI.join` says:
> "Joins URIs."
Let's look at what a similar `join` method [documentation](http://www.ruby-doc.org/core-2.1.2/Fil... -
07:33 AM Bug #10071 (Closed): Documentation for time.c contains broken links
- The documentation for `compat_common_month_table` in time.c:1326 contains a link to http://use.perl.org/articles/08/02/07/197204.shtml, which 404s. I tried to search for the original article (http://use.perl.org/use.perl.org/search1e49-2...
-
04:22 AM Revision ef809762 (git): * string.c: [DOC] teach rdoc symbol.c.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46874 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:41 AM Bug #10060 (Closed): private attr_accessor and NoMethodError
- Applied in changeset r46873.
----------
compile.c: private reader in op_assign
* compile.c (iseq_compile_each): allow to access private attribute
reader in op_assign. [ruby-core:63817] [Bug #10060] -
03:40 AM Revision bc45eed1 (git): compile.c: private reader in op_assign
- * compile.c (iseq_compile_each): allow to access private attribute
reader in op_assign. [ruby-core:63817] [Bug #10060]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:56 AM Revision f75b676c (git): Fix `Time.parse` for out of range arguments with an offset
- * lib/time.rb (Time#apply_offset): Guards against a `nil` return
value from `Time.month_days` when offsetting date. Out of range
values are then caught when `Time.utc` is called (as usual).
Previously a `nil` return value from `Ti... -
12:06 AM Feature #10065: Make `gem env` command output valid YAML
- I just realized that the current output is actually valid Markdown (at least Github Flavored Markdown). The proposed patch does not change that at all. It just makes the output valid (Github Flavored) Markdown *and* valid YAML!
The...
07/18/2014
-
11:45 PM Bug #10067: File.file? misleading semantics & documentation for symbolic links
- It's same as `test(1)` command.
-
11:17 PM Bug #10067 (Closed): File.file? misleading semantics & documentation for symbolic links
- The documentation for ``File.file?`` states:
"Returns true if the named file exists and is a regular file."
When trying that out I get the following results:
~~~
% /usr/bin/stat link
File: `link' -> `file'
Size: 4 ... -
11:40 PM Bug #10066 (Rejected): File.expand_path performs poor validation of absolute path
- It's a valid path, and `File.expand_path()` doesn't reject non-existent pathes.
-
10:02 PM Bug #10066 (Rejected): File.expand_path performs poor validation of absolute path
- With `File.expand_path()`, if one of the arguments is of the form "~/.*", then it will search for the environment variable `$HOME`. If this is set to:
~~~sh
export HOME="/home/peter"
~~~
Then searching for `File.expand_path '~/.ba... -
11:35 PM Bug #10053: OpenSSL: incorrect return value check of EGD functions
- The Entropy Gathering Daemon was last updated twelve years ago.
Ruby should deprecate the use of egd functions and provide configuration options to use LibreSSL in place of OpenSSL, just like how the Editline Library can be used in pl... -
11:01 PM Feature #10065: Make `gem env` command output valid YAML
- It doesn't *need* to be YAML, but does it need *not* to be YAML? It is sooooo close already why not make it YAML? Besides, much of the info in the `GEM CONFIGURATION` section (where the only non-YAML syntax exists) comes from YAML file...
-
10:03 PM Feature #10065 (Feedback): Make `gem env` command output valid YAML
- Why does it need to be YAML?
I don't think it was ever intended to be YAML and with your change it will be too clumsy to be useful. -
06:25 PM Feature #10065 (Feedback): Make `gem env` command output valid YAML
- The output of `gem environment` is close to being valid YAML, but the `GEM CONFIGURATION` section uses `key => value` instead of `key: value` so the output cannot be parsed by YAML. The attached patch changes just one line to make the o...
- 09:20 PM Revision 595d057e (git): * 2014-07-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46871 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:20 PM Revision cf55e34e (git): * refactoring
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46870 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:11 PM Bug #10062: Segfault involving Queue
- The condition has been tagged as 'segfault' on all three projects. Since I will attempt to find a workaround, be sure to pull those tags, as well as 'devready' branches on rubyneat and rubyneat_examples
-
12:08 PM Bug #10062 (Closed): Segfault involving Queue
- Pushing an object onto a `Queue` instantiation causes a segfault. This was seen on Ruby versions 2.1.1 and 2.1.2
In the interests of being able to completely reproduce the environment in which this happens, I have included detailed in... -
07:20 PM Bug #10063: [ruby_2_1] test-all abort due to undefined marshal_dump from test_queue.rb
- May be something in my environment as `make test-all` runs fine on one of my other 64-bit Ubuntu Server boxes.
-
03:50 PM Bug #10063 (Rejected): [ruby_2_1] test-all abort due to undefined marshal_dump from test_queue.rb
- ~~~
uname -a
Linux ubusvr64 3.13.0-32-generic #57-Ubuntu SMP Tue Jul 15 03:51:08 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
git st
## ruby_2_1...origin/ruby_2_1
git log -1 --oneline
c7391a0 merge revision(s) r44516,r46159,r46196: ... -
05:42 PM Feature #10064 (Feedback): &:symbol in when clause
- Now we can put Proc objects in a when clause as this code.
~~~
require 'prime'
def test(n)
print "#{n} is "
case n
when :zero?.to_proc
puts 'zero'
when :even?.to_proc
puts 'an even number'
when :prime?.to_... -
05:18 PM Bug #10060: private attr_accessor and NoMethodError
- ~~~diff
diff --git i/compile.c w/compile.c
index 637e112..556efc2 100644
--- i/compile.c
+++ w/compile.c
@@ -4178,8 +4178,8 @@ iseq_compile_each(rb_iseq_t *iseq, LINK_ANCHOR *ret, NODE * node, int poped)
asgnflag = COMPILE_REC... -
04:52 PM Bug #10060: private attr_accessor and NoMethodError
- Not a bug, there is no such thing as a private accessor
-
09:08 AM Bug #10060 (Closed): private attr_accessor and NoMethodError - ~~~ruby
class Bug
def initialize
self.n = 1 # ok
end
def t1
self.n = n + 1 # ok
self.n += 1 # in `t1': private method `n' called for #<Bug:0x000000019ae1a0 @n=2> (NoMethodError)
end
def t2
n # ok
... -
05:16 PM Bug #9902: Regexp#[] ignores after NUL byte in named capture index
- backported into `ruby_2_1` branch at r46869.
-
05:13 PM Feature #10057: [PATCH] Add tests for Matrix class.
- @ Hiroshi SHIBATA さん
ファイルの削除や進捗、ステータスのハンドリングありがとうございます.
Thank you for your some supports.
@ Mr. Marc-Andre Lafortune
I don't know that ... ! it's great! Thank you for your kindness!!! -
09:57 AM Feature #10057: [PATCH] Add tests for Matrix class.
- Gogo Tanaka san,
Thanks for these additional tests.
Please note that the vast majority of tests of the Matrix library are in RubySpec: https://github.com/rubysl/rubysl-matrix
I hope you'll find them extensive, having for instanc... -
08:48 AM Feature #10057 (Closed): [PATCH] Add tests for Matrix class.
- Applied in changeset r46861.
----------
* test/matrix/test_matrix.rb: Add tests for Matrix class.
[Feature #10057][ruby-core:63809] -
08:18 AM Feature #10057: [PATCH] Add tests for Matrix class.
- @ Hiroshi SHIBATA さん
I split patch "reorder_Matrix#real_and_Matrix_imaginary.patch" to https://bugs.ruby-lang.org/issues/10058
How can I delete patch from feature ?
承知致しました.
7つのPATCHの内、"reorder_Matrix#real_and_Matrix_imagina... -
05:54 AM Feature #10057: [PATCH] Add tests for Matrix class.
- Please split new feature and tests into another issue.
-
05:49 AM Feature #10057 (Closed): [PATCH] Add tests for Matrix class.
- I send 7 patches.
In one of patches (reorder_Matrix#real_and_Matrix_imaginary.patch), I just reorder methods.
I think Matrix#real should be upon Matrix#imaginary(From what I see complex.c)
In the others(6 patches), I add tests ... -
05:01 PM Misc #10032: Matrix classについて
- Marc-Andre Lafortune wrote:
> Finally, my personal goal is that PRs are dealt as early as convenient, but definitely before a major release. Please realize that there is no real way to accelerate this cycle for new features.
OK, I g... -
10:35 AM Misc #10032: Matrix classについて
- gogo tanaka wrote:
> I think only Mr. Marc-Andre Lafortune can review my PR, and this is why it take time to review.
I find it ironic that you feel it took me much time to review your patch, when it took you the same time to make the... -
01:50 AM Misc #10032: Matrix classについて
- @ Shota Fukumori
> But please remember that almost of us are volunteer. I think you already know as you did, write a code, not only criticizing.
はい、多いに同意致します. ただ毎回、同じ方がレビュワーで、レビューに時間を要していたので(すみません結果的には僕がGithubを使っていたせいでした)
問題ではない... -
01:13 AM Misc #10032: Matrix classについて
- >But I think Whether I use github or redmine, It's not problem.
github の pull request へのレビューが行われないことは、公式の issue tracker ではないので
私は問題とは思っていません。
一方で、redmine に継続的にパッチを送っているにもかかわらず、何も行動がない、という状況が
もしあるのであれば、問題だと思っています。解決したいです。 -
12:29 AM Misc #10032: Matrix classについて
- Translating from Japanese...
gogo tanaka wrote:
> > And I'm afraid that nobody but you can maintain matrix..
> ...
-> I'm afraid for losing maintainers.
> > Nobody but you haven't maintained EigenvalueDecomposition class, and it... -
04:46 PM Revision f8048f78 (git): merge revision(s) r46344: [Backport #9902]
- * re.c (match_aref): should not ignore name after NUL byte.
[ruby-dev:48275] [Bug #9902]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@46869 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:33 PM Feature #10058: [PATCH] Fix some coding styles
- > Naohisa Goto: Good point about __send__, I imagine it is to avoid classes that redefined send? In any case, I revised the uses of send in the Matrix lib and they are all to call our own private methods, so I think it's fine like this.
... -
10:14 AM Feature #10058: [PATCH] Fix some coding styles
- Naohisa Goto: Good point about `__send__`, I imagine it is to avoid classes that redefined `send`? In any case, I revised the uses of `send` in the Matrix lib and they are all to call our own private methods, so I think it's fine like this.
-
10:12 AM Feature #10058: [PATCH] Fix some coding styles
- Even though it can be a pain, please split unrelated patches in different requests.
1) Unify && vs and:
Thanks, this is good.
2) I reorder methods. I think Matrix#real should be upon Matrix#imaginary
Methods are sorted alphab... -
09:40 AM Feature #10058: [PATCH] Fix some coding styles
- > There are both && and and. So, I Unify with &&
Be careful that "&&" and "and" have different operator precedence, and they can not always be simply replaceable.
&& と and は演算の優先順位が異なるので、単純に置換できない場合もあるのは要注意です。
http://qiita.com/... -
09:06 AM Feature #10058: [PATCH] Fix some coding styles
- > There are both send :xxx and send(:xxx) expressions. So, I Unify with send(:xxx)
I think "send" should be replaced with "__send__", because the Japanese version of reference manual for Object#send says that libraries should use "__s... -
08:13 AM Feature #10058 (Closed): [PATCH] Fix some coding styles
- When I read codes, I notice some issues about coding style.
If you don't mind that, you can ignore my patches. It's just coding style problem.
コードを読んでいる中でコーディングスタイルに関して気になる事があったのでPATCHを投げますが、
こちら(redmine, rubyコミュニティ)のコーディングスタイルに... -
02:24 PM Revision a6ba688d (git): array.c: array may be modified in the block
- * array.c (rb_ary_any_p): the array may be modified in the yielded
block, do not access directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:40 PM Revision d89c7635 (git): * ext/win32ole/win32ole.c (folevariant_initialize): WIN32OLE_VARIANT
- does not support VT_RECORD. VT_RECORD should be supported in
WIN32OLE_RECORD.
* test/win32ole/test_win32ole_variant.rb (test_s_new_vt_record_exc):
ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46867 b2dd03c8-39d4-4d8f-9... -
01:16 PM Revision d738e3e1 (git): optimized any? methods
- * array.c (rb_ary_any_p), hash.c (rb_hash_any_p): optimized
versions. these are bit faster than optimization in
Enumerable#any?.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46866 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:16 PM Revision e23d1736 (git): revert r46859 and r46860
- revert "enum.c: optimize any? object allocations for Array and Hash"
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:15 PM Bug #8507: Keyword splat does not convert arg to Hash
- It's #9776.
-
10:18 AM Bug #8507: Keyword splat does not convert arg to Hash
- Stephen Celis wrote:
> - **kwargs are mutable
> ...
I believe this is a bug. Matz, could you confirm?
-
11:54 AM Bug #10061 (Feedback): Segmentation fault
- It's a machine stack overflow, and should be fixed already.
Try recent versions. -
09:19 AM Bug #10061 (Closed): Segmentation fault - ~~~
array = []
100000.times { array = [array] }
puts array
~~~
~~~
bug.rb:4: [BUG] Segmentation fault at 0x007fffaa0e0ff8
ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-linux]
-- Control frame information -------------------... -
10:56 AM Revision 7ebb63f0 (git): * ext/win32ole/win32ole.c (folevariant_initialize): remove unnecessary
- code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46864 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:11 AM Revision 84eba0de (git): * lib/matrix/eigenvalue_decomposition: Style fix
- Patch by Gogo Tanaka [#10058]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:04 AM Revision b0eda568 (git): * lib/matrix.rb: Avoid using `and`.
- Patch by gogo tanaka [#10058]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:48 AM Revision b7941452 (git): * test/matrix/test_matrix.rb: Add tests for Matrix class.
- [Feature #10057][ruby-core:63809]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:30 AM Feature #10059 (Feedback): [PATCH and SUGGEST] 代数構造を記述する時にメタプログラミングは非常に非常に強力ですが
- タイトルに書きました通り、代数構造を記述する時にメタプログラミングは非常に非常に強力で
保守性や可読性を著しく推し上げます. 著しくです. これは代数的な性質(演算子の対称性、可逆性など)を記述出来る事に起因します.
しかし議論を呼びそうなのと取り分け優先度が高い訳でないので、提案レベルで簡単なPATCHを投げさせて頂きます. お手透きの時にでも目をお通し下さい. -
02:18 AM Revision ff4dad97 (git): ChangeLog: fix GH reference
- * ChangeLog: fix Github reference in r46859. [fix GH-671]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46860 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:10 AM Revision 0d0fc551 (git): enum.c: optimize any? object allocations for Array and Hash
- * enum.c (enum_any): optimize object allocations for Array and
Hash when `each` is not redefined, always false if empty and the
case without a block. [fix GH-617]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46859 b2dd03c8-39d... -
01:53 AM Revision c317e978 (git): vm_core.h: redefined_flag in rb_vm_t
- * vm_core.h (struct rb_vm_struct): move redefined_flag from
ruby_vm_redefined_flag.
* vm_core.h (BASIC_OP_UNREDEFINED_P): move from vm_insnhelper.h.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46858 b2dd03c8-39d4-4d8f-98ff-823f... -
01:47 AM Revision ce4cfec8 (git): configure.in: with-destdir
- * configure.in: add --with-destdir option which sets default
destination directory to install.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46857 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:29 AM Feature #10056 (Assigned): [PATCH 0/1]Add #adjugate method to matrix class
-
01:21 AM Feature #10056 (Closed): [PATCH 0/1]Add #adjugate method to matrix class
- Add Matrix#adjugate to make a matrix adjugate.
Adjugate is really important operator to handle matrix (especially Exploring Data with ruby)
```ruby:
# Property
* Any n-th matrix `m`(object of Matrix class) Satisfy the followin... -
01:16 AM Revision 2de10af7 (git): * lib/fileutils.rb: added missing options of FileUtils.touch by @Domon.
- [fix GH-669]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46856 b2dd03c8-39d4-4d8f-98ff-823fe69b080e