Project

General

Profile

Actions

Bug #17182

closed

Refinements behavior is broken

Bug #17182: Refinements behavior is broken

Added by osyo (manga osyo) about 5 years ago. Updated about 5 years ago.

Status:
Closed
Target version:
-
ruby -v:
ruby 3.0.0dev (2020-09-13T03:35:37Z master d7b279e79f) [x86_64-linux]
[ruby-core:100070]

Description

Calling the methods defined by Refinements via super from a singleton method breaks the behavior.

class X def hoge ["X#hoge"] end end using Module.new { refine X do def hoge ["refine #hoge"] + super end end } x = X.new def x.hoge ["x.hoge"] + super end # Refinements method is not called p x.hoge # 2.7.1 => ["x.hoge", "refine #hoge", "X#hoge"] OK: Expected behavior # 3.0.0 => ["x.hoge", "X#hoge"] NG: Behavior is broken. # Method#super_method refers to a Refinements method p x.method(:hoge).super_method.call # 2.7.1 => ["refine #hoge", "X#hoge"] # 3.0.0 => ["refine #hoge", "X#hoge"] 

This is broken by a fix for [Bug #17007].
commit: https://github.com/ruby/ruby/commit/eeef16e190cdabc2ba474622720f8e3df7bac43b

Is this the intended change?

Actions

Also available in: PDF Atom