tests: intel_adsp/smoke: cast to signed ints before abs() #98808
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
xt-clang complains about the clock ratio difference is unsigned when being fed to abs(), though GCC does not. So type cast that to signed integer before feeding to abs(). Clock ratio could be big enough to overflow signed 32-bit integer. So we first cast it to be a signed 64-bit integer before substraction. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
|
zephyrbot added platform: Intel ADSP zephyrbot requested review from andyross, ceolin, kv2019i, lgirdwood, lyakh, marcinszkudlinski, nashif, softwarecki and tmleman 
tmleman approved these changes Nov 4, 2025
softwarecki approved these changes Nov 4, 2025
Member
| Should this go to 4.3? If so, please set the milestone and reference a bug report. |
Member Author
| Should be okay. It is not a blocker at this point. I can wait a bit. |
nashif approved these changes Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
xt-clang complains about the clock ratio difference is unsigned when being fed to abs(), though GCC does not. So type cast that to signed integer before feeding to abs(). Clock ratio could be big enough to overflow signed 32-bit integer. So we first cast it to be a signed 64-bit integer before substraction.