settings: Add function for saving (unchanged) single item/subtree #98567
+1,482 −22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @rmsaad can you check if this would work for your application if settings_mgmt was updated to used this? |
rmsaad reviewed Oct 30, 2025
subsys/settings/src/settings_store.c Outdated
| #ifdef CONFIG_SETTINGS_SAVE_SINGLE_SUBTREE_WITHOUT_CHANGE | ||
| int settings_save_subtree_or_single_without_modification(const char *name, | ||
| bool save_if_subtree, | ||
| bool save_if_single_setting); |
There was a problem hiding this comment.
the function definition shouldn’t have a semicolon at the end.
subsys/settings/src/settings_store.c Outdated
| { | ||
| int rc; | ||
| int value_size; | ||
| uint8_t read_buffer[CONFIG_CONFIG_SETTINGS_SAVE_SINGLE_SUBTREE_WITHOUT_CHANGE_VALUE_SIZE]; |
| @nordicjm These changes will work for my application, thanks. |
nordicjm force-pushed the settingssavesingle branch from 276bb6e to 87aacc7 Compare Adds a function that allows saving of a single setting item without changing the value, or saving a subtree of settings, to the storage backend Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds a test for the newly introduced settings_save_subtree_or_single_without_modification() settings function which allows saving a single value or subtree to NVM without modifying the values Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Enables the Kconfig for the newly introduced settings_save_subtree_or_single_without_modification() settings function so that it is tested in CI Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds functionality that allows saving a single setting to NVM using the newly added function in the settings subsystem. This also replaces calling the subtree save function if it the underlying Kconfig is enabled to reduce code paths in settings mgmt Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Expands the test to check thr functionality of the newly adding save subtree/save single setting Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
nordicjm force-pushed the settingssavesingle branch from 87aacc7 to 0eef69e Compare 
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds a function that allows saving of a single setting item without changing the value, or saving a subtree of settings, to the storage backend