- Notifications
You must be signed in to change notification settings - Fork 8.1k
sample: echo_server: specify the USB network device #96342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hello @tzy0002088, and thank you very much for your first pull request to the Zephyr project! |
aae634a
to 1eb4957
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objection with the change, but please follow Pull Request guidelines, specifically:
- Pull Request needs description,
- Commit's sign-off entry must match commit author's name.
Plus the compliance issue with line length needs fixing.
90d7d99
to 9097400
Compare } | ||
| ||
(void)net_config_init_app(NULL, "Initializing network"); | ||
(void)net_config_init_app(DEVICE_DT_GET(DT_NODELABEL(cdc_ncm_eth0)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One enhancement for the future PR could be to make the label configurable so that user could set "cdc_ncm_eth0" or similar via kconfig option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is better to be able to configure rather than hard-code
Please fix the compliance error. It now says
|
9097400
to 110f8e5
Compare When there are multiple network cards in the system, usb.c will select the first network card as the USB network card device, which will cause problems. Signed-off-by: tangzhenye <zytang@linkedsemi.com>
110f8e5
to 18323c5
Compare |
Specify the usb_ncm device in net_config_init_app to avoid issues when multiple network interfaces are present.