subsys: display: cfb: Fix tile drawing processing #96332
+57 −25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Since there is no way to run this test with `harness: display` configuration, we will change it so that execution can be controlled by specifying a fixture. This method has already been proven with `tests/drivers/display/display_read_write`. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Make it allow to run the tests on `native_sim/native/64` platform. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi force-pushed the fix_cfb_tiled_tests branch from 64a034f to 1352d36 Compare soburi changed the title 
zephyrbot requested review from JarmouniA, VynDragon, danieldegrasse and jfischer-no There are several issues to be fixed. - cfb.c: draw_char_htmono It appears that some parts of the process have been ported from `draw_char_vtmono`, but the loop is different, causing the calculations to be incorrect. - cfb.c: cfb_framebuffer_finalize The inversion condition is "XOR-ish". The original that before de9dd98 is correct. - cfb:c cfb_invert_area - utils.c display_pixel The implementation for HTILED was not. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi force-pushed the fix_cfb_tiled_tests branch from 1352d36 to 701ba87 Compare 
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There is a bug in the CFB tile drawing process, so we will fix it.
We will also modify testcase.yaml to make it easier to perform testing using twister.
Fix #92860
But still fail circle drawing tests.
#96313 is required to be merged prior.