Skip to content

support renames for dq joins #26897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

support renames for dq joins #26897

wants to merge 6 commits into from

Conversation

nfrmtk
Copy link
Collaborator

@nfrmtk nfrmtk commented Oct 15, 2025 •
edited
Loading

closes: #25784
closes: #26780
...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

todo: check if benchmarks work, and try to add data validation to ydb/core/kqp/ut/join/kqp_block_hash_join_ut.cpp
...
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

🟢 2025-10-16 10:37:03 UTC The validation of the Pull Request description is successful.
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

⚪ 2025-10-15 10:39:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4b53b5d has started.
⚪ 2025-10-15 10:40:06 UTC Artifacts will be uploaded here
⚪ 2025-10-15 10:43:52 UTC ya make is running...
🔴 2025-10-15 10:54:18 UTC Build failed, see the logs. Also see fail summary
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

⚪ 2025-10-15 10:40:35 UTC Pre-commit check linux-x86_64-release-asan for 4b53b5d has started.
⚪ 2025-10-15 10:40:49 UTC Artifacts will be uploaded here
⚪ 2025-10-15 10:44:22 UTC ya make is running...
🔴 2025-10-15 10:50:33 UTC Build failed, see the logs. Also see fail summary
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

⚪ 2025-10-15 13:41:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 777f45f has started.
⚪ 2025-10-15 13:41:23 UTC Artifacts will be uploaded here
⚪ 2025-10-15 13:45:02 UTC ya make is running...
⚫ 2025-10-15 13:46:43 UTC Check cancelled
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

⚪ 2025-10-15 13:41:26 UTC Pre-commit check linux-x86_64-release-asan for 777f45f has started.
⚪ 2025-10-15 13:41:40 UTC Artifacts will be uploaded here
⚪ 2025-10-15 13:45:25 UTC ya make is running...
⚫ 2025-10-15 13:46:45 UTC Check cancelled
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

⚪ 2025-10-15 13:48:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for e85c9c9 has started.
⚪ 2025-10-15 13:48:31 UTC Artifacts will be uploaded here
⚪ 2025-10-15 13:52:11 UTC ya make is running...
⚫ 2025-10-15 14:02:57 UTC Check cancelled
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

⚪ 2025-10-15 13:48:17 UTC Pre-commit check linux-x86_64-release-asan for e85c9c9 has started.
⚪ 2025-10-15 13:48:32 UTC Artifacts will be uploaded here
⚪ 2025-10-15 13:52:18 UTC ya make is running...
⚫ 2025-10-15 14:02:55 UTC Check cancelled
@nfrmtk nfrmtk marked this pull request as ready for review October 15, 2025 13:55
@nfrmtk nfrmtk requested review from a team as code owners October 15, 2025 13:55
nfrmtk
nfrmtk commented Oct 15, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

⚪ 2025-10-15 14:04:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3be1a7e has started.
⚪ 2025-10-15 14:04:39 UTC Artifacts will be uploaded here
⚪ 2025-10-15 14:08:17 UTC ya make is running...
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

⚪ 2025-10-15 14:06:14 UTC Pre-commit check linux-x86_64-release-asan for 3be1a7e has started.
⚪ 2025-10-15 14:06:41 UTC Artifacts will be uploaded here
⚪ 2025-10-15 14:11:04 UTC ya make is running...
🟡 2025-10-15 16:16:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15833 15331 0 183 297 22

🟢 2025-10-15 16:16:27 UTC Build successful.
🟢 2025-10-15 16:16:51 UTC ydbd size 3.8 GiB changed* by -908.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 66bdeb5 merge: 3be1a7e diff diff %
ydbd size 4 033 140 016 Bytes 4 032 209 728 Bytes -908.5 KiB -0.023%
ydbd stripped size 1 497 880 352 Bytes 1 497 441 760 Bytes -428.3 KiB -0.029%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@nfrmtk nfrmtk added the rebase-and-check Rebase PR with the current base branch and check label Oct 15, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

⚪ 2025-10-15 17:10:16 UTC Pre-commit check linux-x86_64-release-asan for c4275e0 has started.
⚪ 2025-10-15 17:10:40 UTC Artifacts will be uploaded here
⚪ 2025-10-15 17:15:05 UTC ya make is running...
🟡 2025-10-15 19:18:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15837 15281 0 257 277 22

🟢 2025-10-15 19:18:48 UTC Build successful.
🟢 2025-10-15 19:19:11 UTC ydbd size 3.8 GiB changed* by -937.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 37977bb merge: c4275e0 diff diff %
ydbd size 4 033 053 144 Bytes 4 032 092 992 Bytes -937.6 KiB -0.024%
ydbd stripped size 1 497 928 672 Bytes 1 497 478 048 Bytes -440.1 KiB -0.030%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

⚪ 2025-10-15 17:12:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for c4275e0 has started.
⚪ 2025-10-15 17:12:54 UTC Artifacts will be uploaded here
⚪ 2025-10-15 17:16:32 UTC ya make is running...
🟡 2025-10-15 18:47:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38998 36214 0 9 2745 30

⚪ 2025-10-15 18:48:05 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-15 19:09:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
788 (only retried tests) 758 0 4 1 25

⚪ 2025-10-15 19:09:44 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-10-15 19:26:12 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
614 (only retried tests) 590 0 2 1 21

🟢 2025-10-15 19:26:15 UTC Build successful.
🟢 2025-10-15 19:26:33 UTC ydbd size 2.3 GiB changed* by -580.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 37977bb merge: c4275e0 diff diff %
ydbd size 2 424 051 952 Bytes 2 423 457 440 Bytes -580.6 KiB -0.025%
ydbd stripped size 516 042 088 Bytes 515 867 944 Bytes -170.1 KiB -0.034%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2025 •
edited
Loading

⚪ 2025-10-16 08:45:50 UTC Pre-commit check linux-x86_64-release-asan for b5e8c8a has started.
⚪ 2025-10-16 08:46:04 UTC Artifacts will be uploaded here
⚪ 2025-10-16 08:49:47 UTC ya make is running...
🟢 2025-10-16 11:38:50 UTC ydbd size 3.8 GiB changed* by -911.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 07e73d4 merge: b5e8c8a diff diff %
ydbd size 4 033 060 184 Bytes 4 032 126 784 Bytes -911.5 KiB -0.023%
ydbd stripped size 1 497 931 968 Bytes 1 497 494 560 Bytes -427.2 KiB -0.029%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-10-16 11:38:52 UTC Check cancelled
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2025 •
edited
Loading

⚪ 2025-10-16 08:47:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for b5e8c8a has started.
⚪ 2025-10-16 08:48:09 UTC Artifacts will be uploaded here
⚪ 2025-10-16 08:51:52 UTC ya make is running...
@nfrmtk nfrmtk mentioned this pull request Oct 16, 2025
Draft
@nfrmtk nfrmtk added the rebase-and-check Rebase PR with the current base branch and check label Oct 16, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 16, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2025 •
edited
Loading

⚪ 2025-10-16 11:41:10 UTC Pre-commit check linux-x86_64-release-asan for f0c67e1 has started.
⚪ 2025-10-16 11:41:23 UTC Artifacts will be uploaded here
⚪ 2025-10-16 11:44:57 UTC ya make is running...
🟡 2025-10-16 13:55:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15842 15339 0 220 269 14

🟢 2025-10-16 13:55:33 UTC Build successful.
🟢 2025-10-16 13:55:54 UTC ydbd size 3.8 GiB changed* by -930.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c38cbce merge: f0c67e1 diff diff %
ydbd size 4 033 290 984 Bytes 4 032 338 200 Bytes -930.5 KiB -0.024%
ydbd stripped size 1 498 016 480 Bytes 1 497 569 312 Bytes -436.7 KiB -0.030%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2025 •
edited
Loading

⚪ 2025-10-16 11:42:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for f0c67e1 has started.
⚪ 2025-10-16 11:42:57 UTC Artifacts will be uploaded here
⚪ 2025-10-16 11:46:34 UTC ya make is running...
🟡 2025-10-16 13:27:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39005 36226 0 12 2744 23

⚪ 2025-10-16 13:27:15 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-16 13:50:29 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
933 (only retried tests) 913 0 0 0 20

🟢 2025-10-16 13:50:32 UTC Build successful.
🟢 2025-10-16 13:50:48 UTC ydbd size 2.3 GiB changed* by -575.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ed73f44 merge: f0c67e1 diff diff %
ydbd size 2 424 183 328 Bytes 2 423 594 048 Bytes -575.5 KiB -0.024%
ydbd stripped size 516 068 552 Bytes 515 895 816 Bytes -168.7 KiB -0.033%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-for-changelog

1 participant

@nfrmtk