[READY] Optimize completion item extra data #1775
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The ycmd protocol says that the client side cares only about extra_data[ 'resolve' ], so we need not serialize the LSP item as well. Unfortunately, the standard library json has no useful mechanism for skipping certain dict keys. Instead, we implement a custom type that behaves like a dict, but stores the LSP item on the side.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The ycmd protocol says that the client side cares only about extra_data[ 'resolve' ], so we need not serialize the LSP item as well.
Unfortunately, the standard library json has no useful mechanism for skipping certain dict keys. Instead, we implement a custom type that behaves like a dict, but stores the LSP item on the side.
This change is