Skip to content

Conversation

@adrians5j
Copy link
Member

@adrians5j adrians5j commented Oct 13, 2025

With this PR, we're trying to make @webiny/admin-ui package not be dependent on @webiny/app.

We do this by making the @webiny/admin-ui code not directly use the SimpleLink component. Instead, we let the user supply it via the new AdminUiProvider. For example (https://github.com/webiny/webiny-js/blob/5be8971f45f42acc7d74afae087ce909789e8775/packages/app-admin/src/base/providers/UiProviders.tsx):

import React from "react"; import { createProvider, SimpleLink } from "@webiny/app"; import { AdminUiProvider } from "@webiny/admin-ui"; interface UiProvidersProps { children: React.ReactNode; } export const createUiProviders = () => { return createProvider(Component => { return function UiProviders({ children }: UiProvidersProps) { return ( <AdminUiProvider linkComponent={SimpleLink}> <Component>{children}</Component> </AdminUiProvider> ); }; }); };

Note

If not supplied, @webiny/admin-ui has its own default implementation of the Link component (basic a tag).

With this change, @webiny/app package is no longer a dependency of @webiny/admin-ui.

@adrians5j adrians5j changed the title wip Admin UI - Configurable Link Component Oct 13, 2025
@adrians5j adrians5j marked this pull request as draft October 13, 2025 07:59
@Pavel910 Pavel910 added this to the 5.44.0 milestone Oct 13, 2025
@adrians5j adrians5j marked this pull request as ready for review October 13, 2025 14:59
@adrians5j adrians5j merged commit 680d8ad into next Oct 15, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants