Skip to content

Conversation

@TiEul
Copy link

@TiEul TiEul commented May 11, 2020

This change allows for different strings to be used for each language on
the search placeholder.

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

#2382

@TiEul TiEul changed the title Fix #2382: Allow search placeholder localization Feat: Allow search placeholder localization (fix #2382) May 11, 2020
This change allows for different strings to be used for each language on the search placeholder.
@TiEul TiEul changed the title Feat: Allow search placeholder localization (fix #2382) feat: Add localizable search placeholder (fix #2382) May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants