feat: introduce `-error` versions of configs that have all rules configured to error #2796

G-Rath · 2025-07-15T00:59:33Z

I'm happy to take alternative names for the environment and local config variables

Resolves #2774

changeset-bot · 2025-07-15T00:59:36Z

🦋 Changeset detected

Latest commit: 215633d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-vue	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

G-Rath · 2025-07-31T20:24:12Z

@waynzh would it be possible to get a review or even just a yay/nay on if you're open to this?

FloEdelmann · 2025-08-01T08:57:23Z

I'm unsure whether an environment variable is the correct approach to this. Maybe it would be better to duplicate the configs with an -error variant for each one?

G-Rath · 2025-08-06T20:22:08Z

I'm personally not fussed so if you're happy having double the amount of configs I'm fine to do it that way too - I just figured the env variable was a nice way of leveraging the fact that going forward you have to use a JS file for the ESLint config (meaning its always possible to ensure that the property on process.env is always set when ESLint is running) without doing a breaking change

FloEdelmann · 2025-08-07T06:56:47Z

@ota-meshi @waynzh What do you think?

ota-meshi · 2025-08-08T02:54:04Z

I've been thinking about this for a few days, and my personal opinion is that I'm against adding new shareable configs or making major changes to them.
It's impossible to satisfy everyone's preferences, so I think it's better for users to create their own configs.
I think this is also related to #1951 (comment).
However, if @FloEdelmann and @waynzh both think this config change is a good idea, there's no problem with accepting it.

@ota-meshi @waynzh What do you think?

I'm not a fan of using environment variables.

waynzh · 2025-08-08T03:28:07Z

For the IDE DX issue, you can address it by configuring the IDE-ESLint integration like this:

"eslint.rules.customizations": [ { "rule": "*", "severity": "error" } // { "rule": "vue/*", "severity": "error" } ]

I'm not a big fan of controlling this via environment variables either.
One thing worth noting is that there's already a (though not very active) discussion in the ESLint core (eslint/eslint#14679) about adding severity settings into ESLint config. If implemented, this would allow severity to be configured through a single field, removing the need for each plugin to provide separate sharable configs for different severity levels.

G-Rath · 2025-08-08T03:45:25Z

For the IDE DX issue, you can address it by configuring the IDE-ESLint integration like this:

That only works for VSCode

I'm not a big fan of controlling this via environment variables either.

Sounds like folks are against that, so I'll switch to generating new configs

G-Rath · 2025-08-08T04:33:37Z

@FloEdelmann @waynzh @ota-meshi I've updated the implementation to generate dedicated configs instead of using an env variable

Revert "feat: support using `error` instead of `warn` for rules in config" This reverts commit efb2832. Revert "feat: regenerate configs" This reverts commit a379d77. Revert "feat: only define variable if it is needed" This reverts commit be3db8d. Revert "feat: regenerate rules" This reverts commit 98888a6. Revert "docs: add note to user guide" This reverts commit 3dd94e3. Revert "fix: avoid unneeded blank line" This reverts commit d7990e9.

FloEdelmann

Sorry for the late review. I still like the idea of more strict configs, so this mostly looks good to me 🙂

I have a few code and docs remarks though.

docs/user-guide/index.md

tools/update-lib-configs.js

.changeset/brown-eels-care.md

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

FloEdelmann

Thanks, looks good to me now 🙂

.changeset/brown-eels-care.md

Copilot

Pull request overview

This PR introduces -error variants of existing ESLint config presets to provide users with stricter configurations where all rules report as errors instead of warnings. This resolves issue #2774 by giving users an alternative to manually overriding warning severities.

Key Changes:

Modified config generator scripts to automatically create -error versions of warn-based configs
Generated 8 new config files (4 legacy + 4 flat) for strongly-recommended-error and recommended-error variants (Vue 2 & 3)
Updated documentation to describe the new config options

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
tools/update-lib-flat-configs.js	Modified generator to create `-error` flat config variants with `alwaysError` parameter
tools/update-lib-configs.js	Modified generator to create `-error` legacy config variants with `alwaysError` parameter
lib/configs/vue3-strongly-recommended-error.js	Generated legacy config extending vue3-essential with strongly-recommended rules as errors
lib/configs/vue3-recommended-error.js	Generated legacy config extending vue3-strongly-recommended-error with recommended rules as errors
lib/configs/vue2-strongly-recommended-error.js	Generated legacy config extending vue2-essential with strongly-recommended rules as errors
lib/configs/vue2-recommended-error.js	Generated legacy config extending vue2-strongly-recommended-error with recommended rules as errors
lib/configs/flat/vue3-strongly-recommended-error.js	Generated flat config extending vue3-essential with strongly-recommended rules as errors
lib/configs/flat/vue3-recommended-error.js	Generated flat config extending vue3-strongly-recommended-error with recommended rules as errors
lib/configs/flat/vue2-strongly-recommended-error.js	Generated flat config extending vue2-essential with strongly-recommended rules as errors
lib/configs/flat/vue2-recommended-error.js	Generated flat config extending vue2-strongly-recommended-error with recommended rules as errors
docs/user-guide/index.md	Added documentation entries for all new `-error` config variants with usage descriptions
.changeset/brown-eels-care.md	Added changeset describing the new feature as a minor version bump

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tools/update-lib-configs.js

docs/user-guide/index.md

.changeset/brown-eels-care.md

FloEdelmann · 2025-12-17T09:43:44Z

@G-Rath can you please have a look at Copilot's suggestions? Some of them seem to make sense. Feel free to just comment on and resolve the invalid ones.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

docs/user-guide/index.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

G-Rath · 2025-12-17T18:26:59Z

@FloEdelmann should be all good to go now

G-Rath force-pushed the support-erroring branch 4 times, most recently from 1d9181a to c26aeb9 Compare July 31, 2025 20:11

G-Rath force-pushed the support-erroring branch 2 times, most recently from a2795d8 to 3825a40 Compare August 8, 2025 04:31

G-Rath changed the title ~~feat: support having all rules in config report at error instead of warn using env variable~~ feat: introduce -error versions of configs that have all rules configured to error Aug 8, 2025

G-Rath added 10 commits December 6, 2025 11:49

feat: support using error instead of warn for rules in config

ee9f8a0

feat: regenerate configs

4dcb8ff

feat: only define variable if it is needed

b5a434e

feat: regenerate rules

644d23b

docs: add note to user guide

6d92929

fix: avoid unneeded blank line

50fec87

chore: add changeset entry

6f57445

feat: generate new error-based configs

b835cda

docs: update documentation

e77678a

G-Rath force-pushed the support-erroring branch from 168cf66 to e77678a Compare December 5, 2025 22:49

FloEdelmann requested changes Dec 12, 2025

View reviewed changes

docs/user-guide/index.md Show resolved Hide resolved

tools/update-lib-configs.js Outdated Show resolved Hide resolved

.changeset/brown-eels-care.md Outdated Show resolved Hide resolved

G-Rath added 2 commits December 13, 2025 05:51

Merge branch 'vuejs:master' into support-erroring

9c56a40

docs: update section about flat config

3e9fb11

G-Rath and others added 2 commits December 12, 2025 17:11

refactor: reuse existing list

c510184

docs: update changelog entry

6a09005

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

G-Rath requested a review from FloEdelmann December 12, 2025 17:12

FloEdelmann approved these changes Dec 14, 2025

View reviewed changes

.changeset/brown-eels-care.md Outdated Show resolved Hide resolved

Make changeset wording consistent

fe755cf

FloEdelmann requested review from Copilot, ota-meshi and waynzh December 14, 2025 16:07

Copilot started reviewing on behalf of FloEdelmann December 14, 2025 16:07 View session

Copilot AI reviewed Dec 14, 2025

View reviewed changes

G-Rath and others added 4 commits December 18, 2025 06:55

docs: update changeset

f0ea448

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

docs: update descriptions of new configs

d554daa

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: ensure flat configs have unique names

231123d

fix: actually export configs

ebb4b6d

G-Rath requested a review from Copilot December 17, 2025 18:12

Copilot started reviewing on behalf of G-Rath December 17, 2025 18:12 View session

Copilot AI reviewed Dec 17, 2025

View reviewed changes

docs/user-guide/index.md Outdated Show resolved Hide resolved

docs: add full stop

d0e13cc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

G-Rath requested a review from Copilot December 17, 2025 18:22

Copilot started reviewing on behalf of G-Rath December 17, 2025 18:22 View session

Copilot AI reviewed Dec 17, 2025

View reviewed changes

FloEdelmann added 3 commits December 17, 2025 20:07

Simplify changeset wording a bit

29be2c9

Clarify config docs wording

056ba16

Add back missing word

215633d

FloEdelmann approved these changes Dec 17, 2025

View reviewed changes

Uh oh!

feat: introduce -error versions of configs that have all rules configured to error #2796

Are you sure you want to change the base?

feat: introduce -error versions of configs that have all rules configured to error #2796

Uh oh!

Conversation

G-Rath commented Jul 15, 2025

changeset-bot bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

G-Rath commented Jul 31, 2025

FloEdelmann commented Aug 1, 2025

G-Rath commented Aug 6, 2025

FloEdelmann commented Aug 7, 2025

ota-meshi commented Aug 8, 2025

waynzh commented Aug 8, 2025

G-Rath commented Aug 8, 2025

G-Rath commented Aug 8, 2025

FloEdelmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

FloEdelmann left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FloEdelmann commented Dec 17, 2025

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

G-Rath commented Dec 17, 2025

Labels

4 participants

feat: introduce `-error` versions of configs that have all rules configured to error #2796

feat: introduce `-error` versions of configs that have all rules configured to error #2796

changeset-bot bot commented Jul 15, 2025 •

edited

Loading