Enable Gradle configuration cache in project template #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the generateGdIgnoreFilesTask to be compatible with Gradle Configuration Cache by moving project and build directory access to configuration-time providers instead of execution-time access.
- Replaces execution-time project property access with configuration-time providers
- Moves plugin existence check from
doFirsttoonlyIfcondition - Uses Gradle's layout providers for directory access instead of direct property access
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kt/plugins/godot-gradle-plugin/src/main/kotlin/godot/gradle/tasks/generateGdIgnoreFilesTask.kt Show resolved Hide resolved
CedNaru approved these changes Sep 23, 2025
| @DSteve595 the new preprocessor version is now deployed ( |
chippmann approved these changes Oct 19, 2025
DSteve595 changed the title CedNaru approved these changes Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
With this and the changes in utopia-rise/kotlin-preprocessors#4, Gradle Configuration Cache can be enabled for downstream projects, which should give a nice speed boost since the same task is run over and over again during development.
This does not yet enable the config cache in the template project. Need to bring in that kotlin-preprocessors change first.Done!