Skip to content

Conversation

@natecorkish
Copy link
Contributor

@natecorkish natecorkish commented Mar 2, 2021

Currently the steps don't show how to install the plugin to a custom oh-my-zsh installation folder

Type of changes

Changed from cd to the folder to cloning directly in to the custom/default folder.

  • A helper script
  • A link to an external resource like a blog post or video
  • Text cleanups/updates

Checklist:

  • All new and existing tests pass.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an ok exception)
  • Scripts are marked executable
  • Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have added a credit line to README.md for the script
  • If there was no author credit in a script added in this PR, I have added one.
  • I have confirmed that the link(s) in my PR are valid.
  • I have read the CONTRIBUTING document.

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit b60b486 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@unixorn unixorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure how I missed seeing this PR for so long, sorry. Thanks for the contribution, I use zgenom myself so the oh-my-zsh instructions were stale.

@unixorn unixorn merged commit d4cd27e into unixorn:master Apr 25, 2021
@natecorkish natecorkish deleted the patch-1 branch May 11, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants