Skip to content

Conversation

@Amorymeltzer
Copy link
Contributor

@Amorymeltzer Amorymeltzer commented Sep 20, 2019

There are 20 uses of #/bin/sh that are fine per PULL_REQUEST_TEMPLATE.md


Not sure if this is strictly desired post-facto, but this should make all current scripts comply with Contributing.md. Done with a couple of seds, one for bash and one for perl.

Type of changes

  • A helper script
  • A link to an external resource like a blog post or video
  • Text cleanups/updates

Checklist:

  • All new and existing tests pass.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an ok exception)\
  • Scripts are marked executable
  • I have added a credit line to README.md for the script
  • If there was no author credit in a script added in this PR, I have added one.
  • I have confirmed that the link(s) in my PR are valid.
  • I have read the CONTRIBUTING document.

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.
There are 20 uses of #/bin/sh that are fine per PULL_REQUEST_TEMPLATE.md
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 497d19d and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@unixorn unixorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up those scripts.

LGTM

@unixorn unixorn merged commit 91ecbc2 into unixorn:master Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants