Draft: Initial merged cells support in get_cells() #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This adds new columns `n_rows` and `n_cols` to the result of `get_cells()/range_read_cells()`. API response with the merged cell ranges is parsed in `get_merged_ranges()` and then left-joined by starting location into the cell table.
tzakharko changed the title get_cells()get_cells() 
| I assume you've got a test sheet or two lying around with some merged cells that you are developing against.... can you share with "anyone with a link"? And share the ID here? Then I could experience this for myself. I can't really work on this feature right now, so to advance things, I have to be able to make intelligent comments with a modest amount of time/psychic energy. |
| Absolutely! Here a simple example sheet And the output
If you can just have a quick look and tell me whether you are ok with the general direction, I'd be happy to also add tests, documentation, missing checks etc. I kept it minimal on purpose for now. Thanks for your time! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Initial implementation for #289
This adds new columns
n_rowsandn_colsto the result ofget_cells()/range_read_cells(). API response with the merged cell ranges is parsed inget_merged_ranges()and then left-joined by starting location into the cell table.No updates to documentation, tests, or range formatting yet. Could also use error handling when implementing the join.