Gatsby 2.0 #5
Merged
Gatsby 2.0 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Migrate to Gatsby 2.0
| Oh wow, this is awesome! If I remember correctly, I introduced gatsby-next because of this issue with React's context API: #1 I guess this stays fixed then. Did you experience any bugs there? Otherwise I merge this. Thanks for your efforts! Helps a lot! 💯 |
I was told in this issue that it was no longer necessary in v2. I personally didn't experience any issues but it might something worth confirming on your end before merging. Happy to help! |
| Thanks again! |
rwieruch reviewed Aug 7, 2018
| "version": "1.0.0", | ||
| "author": "Robin Wieruch <wrobin@gmx.net>", | ||
| "dependencies": { | ||
| "bluebird": "^3.5.1", |
There was a problem hiding this comment.
@ckj do you know where Bluebird is used in the application?
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR:
firebase.auth()would cause the build to failnpm run format