Skip to content

Conversation

@bzhr
Copy link

@bzhr bzhr commented Apr 30, 2018

  • All user management routes are pushed under /app/ and /app/ is defined as client side route in gatsby-node.js, so that the web site can build.

  • gatsby-plugin-react-next allows for use of context API.

  • Project is restructured such that in pages /app/ is a gateway to the client side part, while the client side pages like: SignIn, Home and Account are moved to /componenets.

@rwieruch
Copy link
Member

Nice! 🚀 Only issue is that the branch cannot be merged. Did you add your changes on top of the recent master branch?

@bzhr
Copy link
Author

bzhr commented Apr 30, 2018

Yes, I forked the repo and then created the auth branch out of the master branch.

@rwieruch
Copy link
Member

rwieruch commented May 1, 2018

Okay. I was wondering because there are still recent changes from my account in the PR. Either you can create a PR with a new fork or I need to address the conflicts in this PR at some point :D

@rwieruch
Copy link
Member

rwieruch commented Jun 1, 2018

This PR #3 should have fixed the issue.

@rwieruch rwieruch closed this Jun 1, 2018
rwieruch added a commit that referenced this pull request Dec 5, 2018
React 16.3: Using new Context API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants