fix: Attach policies to IAM user (not role) #595
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Replace aws_iam_role_policy_attachment with aws_iam_user_policy_attachment and switch the attribute from `role` to `user`. This ensures `var.policies` are correctly attached to the created IAM user and prevents apply errors.
emuesuenu changed the title emuesuenu changed the title 
| This was corrected in #594 |
| I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Replace the incorrect resource type aws_iam_role_policy_attachment with aws_iam_user_policy_attachment.
Update arguments accordingly (role -> user) so attachments target the created IAM user (aws_iam_user.this[0].name).
No changes to input variables: var.policies remains a map and the for_each logic is unchanged.
Motivation and Context
The previous implementation attempted to attach policies using the role attachment resource for an IAM user, which is invalid.
Breaking Changes
Resource address change: from aws_iam_role_policy_attachment.additional to aws_iam_user_policy_attachment.additional.
Terraform will plan to replace these attachment resources on the next apply (destroy old, create new).
Impact: Brief re‑creation of policy attachments during apply. No persistent permission loss is expected.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projects