fix: Wrong content for oidc_fully_qualified_audiences in iam-assumable-role-with-oidc #301
Conversation
corneliusgdahling changed the title corneliusgdahling changed the title corneliusgdahling changed the title 
| | ||
| content { | ||
| test = "StringLike" | ||
| test = "StringEquals" |
There was a problem hiding this comment.
I think this is better suited to be a variable if we need to change it - see
| } | ||
| | ||
| ##################################### | ||
| # IAM assumable role with audience |
There was a problem hiding this comment.
This example doesn't match the changes being made
corneliusgdahling force-pushed the fix-wrong-content-for-audience branch 4 times, most recently from 09c9ce4 to 2ab2a49 Compare 
| based on your example - is this change needed or are you looking for https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/modules/iam-github-oidc-role ? |
| This PR has been automatically marked as stale because it has been open 30 days |
Kind of. That would only work for GitHub, while making this change would allow it to work with others such as CircleCI |
…nerating StringLike
Example of how to use GH actions
corneliusgdahling force-pushed the fix-wrong-content-for-audience branch from 96e3d5e to 9b88a9c Compare | This PR has been automatically marked as stale because it has been open 30 days |
I have long since created my own module with this implementation, but still see the value in this. What do you think @bryantbiggs ? |
| This PR has been automatically marked as stale because it has been open 30 days |
| This PR was automatically closed because of stale in 10 days |
| I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
2 participants
Fix: fully qualified audiences should generate StringEquals but is generating StringLike
Description
There is a bug that causes oidc_fully_qualified_audiences to create StringLike condition instead of StringEquals condition. This is simply because the content is created with StringLike instead of StringEquals
Motivation and Context
Solves bug
Breaking Changes
I don't know
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request