fix: Remove non-functional container_definition_defaults #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
antonbabenko approved these changes Jul 11, 2025
Member
antonbabenko left a comment
antonbabenko left a comment There was a problem hiding this comment.
Looks simpler 🤞 I agree, that variable types in terraform are not intuitive even with features like optional, nullable, etc.
antonbabenko pushed a commit that referenced this pull request Jul 11, 2025
## [6.0.4](v6.0.3...v6.0.4) (2025-07-11) ### Bug Fixes * Remove non-functional `container_definition_defaults` ([#312](#312)) ([dcc5ae5](dcc5ae5))
Member
| This PR is included in version 6.0.4 🎉 |
3 tasks
dispel-derekberger pushed a commit to dispel/terraform-aws-ecs that referenced this pull request Jul 16, 2025
…-aws-modules#312) * fix: Remove non-functional `container_definition_defaults` * docs: Update UPGRADE guide to alert users migrating
dispel-derekberger pushed a commit to dispel/terraform-aws-ecs that referenced this pull request Jul 16, 2025
## [6.0.4](terraform-aws-modules/terraform-aws-ecs@v6.0.3...v6.0.4) (2025-07-11) ### Bug Fixes * Remove non-functional `container_definition_defaults` ([terraform-aws-modules#312](terraform-aws-modules#312)) ([dcc5ae5](terraform-aws-modules@dcc5ae5))
Member Author
| relates to hashicorp/terraform-provider-aws#17988 |
| I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
container_definition_defaults. Due to the way variable optional attributes work, a value provided as a default attribute will always succeed this additional, fallback value which renders it useless nowMotivation and Context
cloudwatch_log_group_retention_in_daysincontainer_definition_defaultsnever honoured; per-container default 14 always wins #305Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request