- Notifications
You must be signed in to change notification settings - Fork 117
Add GPU driver/toolkit/sdk links in readme #295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up on this!
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov, @kangyizhang, @nkreeger, and @nsthorat)
README.md, line 16 at r1 (raw file):
- Windows GPU (Win 7 or higher and Cuda 10.0 w/ CUDNN v7) ([see installation instructions](https://www.tensorflow.org/install/gpu#windows_setup)) For GPU support, current tfjs-node-gpu package requires the following NVIDIA® software installed on your system:
s/current/EXACT_VERSION/ so it will be correct even if we forget to update the README in a while. It is almost a sign for us to keep the readme up-to-date.
README.md, line 16 at r1 (raw file):
- Windows GPU (Win 7 or higher and Cuda 10.0 w/ CUDNN v7) ([see installation instructions](https://www.tensorflow.org/install/gpu#windows_setup)) For GPU support, current tfjs-node-gpu package requires the following NVIDIA® software installed on your system:
It might be clearer to make a simple 2 columns table:
Name | Version
Driver | >410.x
CUDA | 10.0
SDK | >7.4.1
etc
README.md, line 18 at r1 (raw file):
For GPU support, current tfjs-node-gpu package requires the following NVIDIA® software installed on your system: - [NVIDIA® GPU drivers](https://www.nvidia.com/Download/index.aspx?lang=en-us) —CUDA 10.0 requires 410.x or higher. - [CUDA® Toolkit](https://developer.nvidia.com/cuda-toolkit-archive) —TensorFlow supports CUDA 10.0
can you link to the 10.0 toolkit directly?
README.md, line 20 at r1 (raw file):
- [CUDA® Toolkit](https://developer.nvidia.com/cuda-toolkit-archive) —TensorFlow supports CUDA 10.0 - [CUPTI](https://docs.nvidia.com/cuda/cupti/) ships with the CUDA Toolkit. - [cuDNN SDK](https://developer.nvidia.com/cudnn) (>= 7.4.1)
same here, is there a link to the 7.4.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov, @kangyizhang, @nkreeger, and @nsthorat)
README.md, line 16 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
It might be clearer to make a simple 2 columns table:
Name | Version
Driver | >410.x
CUDA | 10.0
SDK | >7.4.1
etc
btw use the markdown syntax for table , my comment is just quasi code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov, @nkreeger, and @nsthorat)
README.md, line 16 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
s/current/EXACT_VERSION/ so it will be correct even if we forget to update the README in a while. It is almost a sign for us to keep the readme up-to-date.
Done
README.md, line 16 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
btw use the markdown syntax for table , my comment is just quasi code
Done
README.md, line 18 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
can you link to the 10.0 toolkit directly?
Added link to 10.0 toolkit directly. GPU driver requires user to select their gpu model and version number so there is no direct link.
README.md, line 20 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
same here, is there a link to the 7.4.1?
Added link to download page of the latest version. There is no direct link because it requires user to select the operating system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @kangyizhang, @nkreeger, and @nsthorat)
README.md, line 20 at r1 (raw file):
Previously, kangyizhang (Kangyi Zhang) wrote…
Added link to download page of the latest version. There is no direct link because it requires user to select the operating system.
Yeah some of these require a login with Nvidia too.
README.md, line 16 at r2 (raw file):
version
nit: drop this word.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @kangyizhang, @nkreeger, and @nsthorat)
README.md, line 16 at r2 (raw file):
Previously, nkreeger (Nick Kreeger) wrote…
version
nit: drop this word.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Reviewed 1 of 1 files at r3.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @nkreeger and @nsthorat)
This change is