Skip to content
This repository was archived by the owner on Sep 17, 2022. It is now read-only.

Conversation

annxingyuan
Copy link
Contributor

@annxingyuan annxingyuan commented Aug 6, 2019

This change is Reviewable

@annxingyuan annxingyuan changed the title Add fused kernel Add fused conv2d and fused prelu activation. Aug 6, 2019
@annxingyuan annxingyuan self-assigned this Aug 6, 2019
Copy link

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @nkreeger, and @nsthorat)


src/nodejs_kernel_backend.ts, line 351 at r1 (raw file):

 activation?: Activation, preluActivationWeights?: Tensor): Tensor4D { let result = this.conv2d(x, filter, convInfo); if (bias) {

bias != null


src/nodejs_kernel_backend.ts, line 355 at r1 (raw file):

 } if (activation) {

activation != null

Copy link
Contributor Author

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @nkreeger)


src/nodejs_kernel_backend.ts, line 351 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

bias != null

Done


src/nodejs_kernel_backend.ts, line 355 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

activation != null

Done

@annxingyuan annxingyuan merged commit 98913bb into master Aug 7, 2019
@annxingyuan annxingyuan deleted the add_fused_kernel branch August 7, 2019 11:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3 participants