This repository was archived by the owner on Sep 17, 2022. It is now read-only.
Fallback to compile addon from source silently when pre-compiled addon is not available #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
With pre-compile addon, it's likely that we miss uploading the addon for one or two platforms when publishing npm package. The package could build native addon from source when the addon is not available on GCP, but we should not print out error message which confuses user.
node-pre-gyp provides an option
node-pre-gyp install --fallback-to-buildwhich silently fallback to compile addon from source when it fails to download from GCP.This change is